[GitHub] [hbase] comnetwork commented on a change in pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to bran

2020-07-09 Thread GitBox
comnetwork commented on a change in pull request #2034: URL: https://github.com/apache/hbase/pull/2034#discussion_r452620948 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncProtobufLogWriter.java ## @@ -231,4 +231,9 @@ protected long

[GitHub] [hbase] comnetwork commented on a change in pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to bran

2020-07-09 Thread GitBox
comnetwork commented on a change in pull request #2034: URL: https://github.com/apache/hbase/pull/2034#discussion_r452620566 ## File path: hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java ## @@ -91,7 +93,11 @@ private void

[GitHub] [hbase] comnetwork commented on a change in pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to bran

2020-07-09 Thread GitBox
comnetwork commented on a change in pull request #2034: URL: https://github.com/apache/hbase/pull/2034#discussion_r452620566 ## File path: hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java ## @@ -91,7 +93,11 @@ private void

[GitHub] [hbase] saintstack commented on pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default

2020-07-09 Thread GitBox
saintstack commented on pull request #2037: URL: https://github.com/apache/hbase/pull/2037#issuecomment-656476438 Looks like tests passed: 13:23:36 | +1 | unit | 180m 33s | hbase-server in the patch passed. Couldn't push the update to here.

[GitHub] [hbase] Apache9 commented on a change in pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-

2020-07-09 Thread GitBox
Apache9 commented on a change in pull request #2034: URL: https://github.com/apache/hbase/pull/2034#discussion_r452602900 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java ## @@ -85,6 +90,12 @@ public void sync(boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2035: HBASE-24663 Add procedure process time statistics UI

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2035: URL: https://github.com/apache/hbase/pull/2035#issuecomment-656451857 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on pull request #2012: HBASE-24670 KeyPrefix related split policies should exends SteppingSp…

2020-07-09 Thread GitBox
bsglz commented on pull request #2012: URL: https://github.com/apache/hbase/pull/2012#issuecomment-656449251 @wchevreuil @virajjasani Ping. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] bsglz commented on a change in pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-09 Thread GitBox
bsglz commented on a change in pull request #2011: URL: https://github.com/apache/hbase/pull/2011#discussion_r452592457 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java ## @@ -68,22 +76,14 @@ protected void

[GitHub] [hbase] bsglz commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp

2020-07-09 Thread GitBox
bsglz commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-656448394 @virajjasani Please take a look, thanks. This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2034: URL: https://github.com/apache/hbase/pull/2034#issuecomment-656446206 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] WenFeiYi commented on a change in pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-09 Thread GitBox
WenFeiYi commented on a change in pull request #1962: URL: https://github.com/apache/hbase/pull/1962#discussion_r452583441 ## File path: hbase-hadoop-compat/src/test/java/org/apache/hadoop/metrics2/impl/TestMutableRangeHistogram.java ## @@ -0,0 +1,90 @@ +/** + * Licensed to

[jira] [Resolved] (HBASE-24489) Rewrite TestClusterRestartFailover.test since namespace table is gone on on master

2020-07-09 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24489. Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed Pushed to master. Thanks [~Ddupg] 

[GitHub] [hbase] infraio merged pull request #2025: HBASE-24489 Rewrite TestClusterRestartFailover.test since namespace t…

2020-07-09 Thread GitBox
infraio merged pull request #2025: URL: https://github.com/apache/hbase/pull/2025 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (HBASE-22738) Fallback to default group to choose RS when there are no RS in current group

2020-07-09 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-22738. Fix Version/s: 2.4.0 3.0.0-alpha-1 Resolution: Fixed Pushed to

[GitHub] [hbase] infraio merged pull request #2039: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-07-09 Thread GitBox
infraio merged pull request #2039: URL: https://github.com/apache/hbase/pull/2039 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] infraio commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-07-09 Thread GitBox
infraio commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-656437001 > If I make a change only in MasterQuotaManager, other classes that call QuotaUtil.deleteNamespaceQuota() will not get the fix. Which class will call this? Clear all

[GitHub] [hbase] Apache-HBase commented on pull request #1094: HBASE-23744 - FastPathBalancedQueueRpcExecutor should enforce queue l…

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #1094: URL: https://github.com/apache/hbase/pull/1094#issuecomment-656436347 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] infraio commented on a change in pull request #2035: HBASE-24663 Add procedure process time statistics UI

2020-07-09 Thread GitBox
infraio commented on a change in pull request #2035: URL: https://github.com/apache/hbase/pull/2035#discussion_r452579208 ## File path: hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/Histogram.java ## @@ -54,5 +54,4 @@ */ @InterfaceAudience.Private

[GitHub] [hbase] Apache-HBase commented on pull request #1094: HBASE-23744 - FastPathBalancedQueueRpcExecutor should enforce queue l…

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #1094: URL: https://github.com/apache/hbase/pull/1094#issuecomment-656434538 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2034: URL: https://github.com/apache/hbase/pull/2034#issuecomment-656430497 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-656415583 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-656414934 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-656413915 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1986: HBASE-24581 Skip compaction request/check for replica regions at the …

2020-07-09 Thread GitBox
ndimiduk commented on a change in pull request #1986: URL: https://github.com/apache/hbase/pull/1986#discussion_r452557659 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionReplicaSplit.java ## @@ -109,11 +112,16 @@ public void

[jira] [Created] (HBASE-24708) Flaky Test TestRegionReplicas#testVerifySecondaryAbilityToReadWithOnFiles

2020-07-09 Thread Huaxiang Sun (Jira)
Huaxiang Sun created HBASE-24708: Summary: Flaky Test TestRegionReplicas#testVerifySecondaryAbilityToReadWithOnFiles Key: HBASE-24708 URL: https://issues.apache.org/jira/browse/HBASE-24708 Project:

[GitHub] [hbase] ndimiduk commented on pull request #2015: HBASE-24568 do-release need not wait for tag

2020-07-09 Thread GitBox
ndimiduk commented on pull request #2015: URL: https://github.com/apache/hbase/pull/2015#issuecomment-656405446 Bump. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HBASE-24632) Enable procedure-based log splitting as default in hbase3

2020-07-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154996#comment-17154996 ] Michael Stack commented on HBASE-24632: --- This one-liner has gotten kinda big:    * We were

[GitHub] [hbase] saintstack commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-09 Thread GitBox
saintstack commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-656402513 We weren't handling corrupt WALs This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] ndimiduk commented on a change in pull request #2003: HBASE-24633 Remove data locality and StoreFileCostFunction for replic…

2020-07-09 Thread GitBox
ndimiduk commented on a change in pull request #2003: URL: https://github.com/apache/hbase/pull/2003#discussion_r452546679 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancerRegionReplica.java ## @@ -168,6 +205,23 @@

[GitHub] [hbase] Apache-HBase commented on pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2034: URL: https://github.com/apache/hbase/pull/2034#issuecomment-656400659 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1094: HBASE-23744 - FastPathBalancedQueueRpcExecutor should enforce queue l…

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #1094: URL: https://github.com/apache/hbase/pull/1094#issuecomment-656397498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase-native-client] bharathv commented on a change in pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-07-09 Thread GitBox
bharathv commented on a change in pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#discussion_r452536952 ## File path: CMakeLists.txt ## @@ -117,23 +124,22 @@ endif()

[GitHub] [hbase-native-client] bharathv commented on pull request #10: HBASE-24642: Apache Yetus test-patch and Jenkins integration.

2020-07-09 Thread GitBox
bharathv commented on pull request #10: URL: https://github.com/apache/hbase-native-client/pull/10#issuecomment-656392463 @phrocker No worries. How about we get this patch in before #6? That validates both the patches. Tests that the precommit is running well and also tests your patch in

[GitHub] [hbase] ndimiduk commented on a change in pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch

2020-07-09 Thread GitBox
ndimiduk commented on a change in pull request #2034: URL: https://github.com/apache/hbase/pull/2034#discussion_r452529869 ## File path: hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java ## @@ -91,7 +93,11 @@ private void

[GitHub] [hbase] gjacoby126 commented on a change in pull request #1094: HBASE-23744 - FastPathBalancedQueueRpcExecutor should enforce queue l…

2020-07-09 Thread GitBox
gjacoby126 commented on a change in pull request #1094: URL: https://github.com/apache/hbase/pull/1094#discussion_r452527315 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java ## @@ -559,6 +561,25 @@ public void

[GitHub] [hbase] clarax commented on a change in pull request #2003: HBASE-24633 Remove data locality and StoreFileCostFunction for replic…

2020-07-09 Thread GitBox
clarax commented on a change in pull request #2003: URL: https://github.com/apache/hbase/pull/2003#discussion_r452498200 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancerRegionReplica.java ## @@ -168,6 +205,23 @@

[GitHub] [hbase] Apache-HBase commented on pull request #2043: HBASE-24675: On Master restart all servers are assigned to default rs…

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2043: URL: https://github.com/apache/hbase/pull/2043#issuecomment-656352241 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2043: HBASE-24675: On Master restart all servers are assigned to default rs…

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2043: URL: https://github.com/apache/hbase/pull/2043#issuecomment-656352141 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2043: HBASE-24675: On Master restart all servers are assigned to default rs…

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2043: URL: https://github.com/apache/hbase/pull/2043#issuecomment-656350654 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24633) Remove data locality and StoreFileCostFunction for replica regions out of balancer's cost calculation

2020-07-09 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154924#comment-17154924 ] Clara Xiong commented on HBASE-24633: -

[GitHub] [hbase-native-client] phrocker commented on a change in pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-07-09 Thread GitBox
phrocker commented on a change in pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#discussion_r452478797 ## File path: CMakeLists.txt ## @@ -117,23 +124,22 @@ endif()

[GitHub] [hbase-native-client] phrocker commented on a change in pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-07-09 Thread GitBox
phrocker commented on a change in pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#discussion_r452478797 ## File path: CMakeLists.txt ## @@ -117,23 +124,22 @@ endif()

[jira] [Commented] (HBASE-24676) Meta region assignment is blocked when all RS in meta table group are restarted.

2020-07-09 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154918#comment-17154918 ] Mohammad Arshad commented on HBASE-24676: - can we back port HBASE-22820 to branch-2 ? will it

[jira] [Commented] (HBASE-24676) Meta region assignment is blocked when all RS in meta table group are restarted.

2020-07-09 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154915#comment-17154915 ] Mohammad Arshad commented on HBASE-24676: - Default rsgroup can be updated only in memory, no

[GitHub] [hbase-native-client] phrocker commented on pull request #10: HBASE-24642: Apache Yetus test-patch and Jenkins integration.

2020-07-09 Thread GitBox
phrocker commented on pull request #10: URL: https://github.com/apache/hbase-native-client/pull/10#issuecomment-656340176 @bharathv I will take a look. sorry for the delay. This is an automated message from the Apache Git

[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-07-09 Thread GitBox
phrocker commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-656339614 > > > Had a chance to apply your patch locally and try it out, running into this weird linker issue. > > > >

[jira] [Commented] (HBASE-24676) Meta region assignment is blocked when all RS in meta table group are restarted.

2020-07-09 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154912#comment-17154912 ] Mohammad Arshad commented on HBASE-24676: - When default rsgroup server is stopped or started,

[GitHub] [hbase] Apache-HBase commented on pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2037: URL: https://github.com/apache/hbase/pull/2037#issuecomment-656333211 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] arshadmohammad opened a new pull request #2043: HBASE-24675: On Master restart all servers are assigned to default rs…

2020-07-09 Thread GitBox
arshadmohammad opened a new pull request #2043: URL: https://github.com/apache/hbase/pull/2043 …group. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] clarax commented on a change in pull request #1986: HBASE-24581 Skip compaction request/check for replica regions at the …

2020-07-09 Thread GitBox
clarax commented on a change in pull request #1986: URL: https://github.com/apache/hbase/pull/1986#discussion_r452463759 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionReplicaSplit.java ## @@ -109,11 +112,16 @@ public void

[jira] [Created] (HBASE-24707) Fix Empty region in meta with read replica

2020-07-09 Thread Huaxiang Sun (Jira)
Huaxiang Sun created HBASE-24707: Summary: Fix Empty region in meta with read replica Key: HBASE-24707 URL: https://issues.apache.org/jira/browse/HBASE-24707 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2037: URL: https://github.com/apache/hbase/pull/2037#issuecomment-656256994 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24687) MobFileCleanerChore uses a new Connection for each table each time it runs

2020-07-09 Thread Junhong Xu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154750#comment-17154750 ] Junhong Xu commented on HBASE-24687: I think the problem here is not about connections, we should

[GitHub] [hbase] Apache-HBase commented on pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2037: URL: https://github.com/apache/hbase/pull/2037#issuecomment-656253288 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2042: HBASE-24704 Make the Table Schema easier to view even there are multi…

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2042: URL: https://github.com/apache/hbase/pull/2042#issuecomment-656251929 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2042: HBASE-24704 Make the Table Schema easier to view even there are multi…

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2042: URL: https://github.com/apache/hbase/pull/2042#issuecomment-656248355 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on a change in pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default

2020-07-09 Thread GitBox
saintstack commented on a change in pull request #2037: URL: https://github.com/apache/hbase/pull/2037#discussion_r452357330 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java ## @@ -128,14 +124,8 @@ public class CanaryTool implements Tool,

[jira] [Updated] (HBASE-24706) When merging a non-empty region with empty regions, skip the reference creation to avoid compaction.

2020-07-09 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-24706: - Description: Note here while I remember, for the case, there is snapshot, hfiles need to be

[GitHub] [hbase] saintstack commented on a change in pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default

2020-07-09 Thread GitBox
saintstack commented on a change in pull request #2037: URL: https://github.com/apache/hbase/pull/2037#discussion_r452354554 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java ## @@ -128,14 +124,8 @@ public class CanaryTool implements Tool,

[jira] [Updated] (HBASE-24698) Turn OFF Canary WebUI as default

2020-07-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24698: -- Fix Version/s: 2.4.0 2.3.1 3.0.0-alpha-1 > Turn OFF

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-07-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154723#comment-17154723 ] Michael Stack commented on HBASE-11288: --- {quote}We have discussed this a lot in the design doc but

[jira] [Created] (HBASE-24706) When merging a non-empty region with empty regions, skip the reference creation to avoid compaction.

2020-07-09 Thread Huaxiang Sun (Jira)
Huaxiang Sun created HBASE-24706: Summary: When merging a non-empty region with empty regions, skip the reference creation to avoid compaction. Key: HBASE-24706 URL:

[jira] [Created] (HBASE-24705) MetaFixer#fixHoles() does not include the case for read replicas (i.e, replica regions are not created)

2020-07-09 Thread Huaxiang Sun (Jira)
Huaxiang Sun created HBASE-24705: Summary: MetaFixer#fixHoles() does not include the case for read replicas (i.e, replica regions are not created) Key: HBASE-24705 URL:

[GitHub] [hbase] d-c-manning commented on a change in pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-09 Thread GitBox
d-c-manning commented on a change in pull request #1962: URL: https://github.com/apache/hbase/pull/1962#discussion_r452331427 ## File path: hbase-hadoop-compat/src/test/java/org/apache/hadoop/metrics2/impl/TestMutableRangeHistogram.java ## @@ -0,0 +1,90 @@ +/** + * Licensed

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-07-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154675#comment-17154675 ] Duo Zhang commented on HBASE-11288: --- After rethinking, I think you misuderstood me. It seems that you

[GitHub] [hbase] Apache9 commented on pull request #2009: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-09 Thread GitBox
Apache9 commented on pull request #2009: URL: https://github.com/apache/hbase/pull/2009#issuecomment-656193610 The only way to completely solve all the related problems is HBASE-15968, where we also consider MVCC so earlier modification will not effect later modifications. All other

[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-07-09 Thread GitBox
phrocker commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-656187689 > > Had a chance to apply your patch locally and try it out, running into this weird linker issue. > > >

[GitHub] [hbase] wchevreuil commented on pull request #2009: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-09 Thread GitBox
wchevreuil commented on pull request #2009: URL: https://github.com/apache/hbase/pull/2009#issuecomment-656179536 >So if users meet the problem, I will suggest them to go to HBASE-15968, but usually, they will just change their usage... Ok, had reverted it from master. > For

[GitHub] [hbase] Apache-HBase commented on pull request #2042: HBASE-24704 Make the Table Schema easier to view even there are multi…

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2042: URL: https://github.com/apache/hbase/pull/2042#issuecomment-656138841 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-21596) Delete for a specific cell version can bring back versions above VERSIONS limit

2020-07-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154575#comment-17154575 ] Hudson commented on HBASE-21596: Results for branch master [build #1781 on

[GitHub] [hbase] Apache-HBase commented on pull request #2042: HBASE-24704 Make the Table Schema easier to view even there are multi…

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2042: URL: https://github.com/apache/hbase/pull/2042#issuecomment-656135887 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #2009: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-09 Thread GitBox
Apache9 commented on pull request #2009: URL: https://github.com/apache/hbase/pull/2009#issuecomment-656134402 > Yeah, but it's the same current behaviour for manually deleted ones, right? No, for the scenario below they are not the same. For example, you have t1 > t2 > t3,

[GitHub] [hbase] Apache9 edited a comment on pull request #2009: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-09 Thread GitBox
Apache9 edited a comment on pull request #2009: URL: https://github.com/apache/hbase/pull/2009#issuecomment-656132049 > I guess both are solved by HBASE-15968 solution? Theoretically, HBASE-15968 can solve the problem. But HBASE-15968 itself is a PITA. The implementation is

[GitHub] [hbase] Apache9 commented on pull request #2009: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-09 Thread GitBox
Apache9 commented on pull request #2009: URL: https://github.com/apache/hbase/pull/2009#issuecomment-656132049 > Yeah, but it's the same current behaviour for manually deleted ones, right? I guess both are solved by HBASE-15968 solution? Theoretically, HBASE-15968 can solve the

[GitHub] [hbase] Apache-HBase commented on pull request #2042: HBASE-24704 Make the Table Schema easier to view even there are multi…

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2042: URL: https://github.com/apache/hbase/pull/2042#issuecomment-656130133 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] wchevreuil edited a comment on pull request #2009: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-09 Thread GitBox
wchevreuil edited a comment on pull request #2009: URL: https://github.com/apache/hbase/pull/2009#issuecomment-656080107 > Oh, the PR has already been merged... I can revert it back. This has been a recurring source of confusion and complains among our customer base, and having

[GitHub] [hbase] wchevreuil commented on pull request #2009: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-09 Thread GitBox
wchevreuil commented on pull request #2009: URL: https://github.com/apache/hbase/pull/2009#issuecomment-656080107 > Oh, the PR has already been merged... I can revert it back. This has been a recurring source of confusion and complains among our customer base, and having inconsistent

[GitHub] [hbase] wchevreuil commented on pull request #2036: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-09 Thread GitBox
wchevreuil commented on pull request #2036: URL: https://github.com/apache/hbase/pull/2036#issuecomment-656078169 > > And if you are talking about filter, the semantic for readVersions is the number of versions before filtering, not the version after fitlering. If you want to

[GitHub] [hbase] Apache-HBase commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-656075921 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2040: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2040: URL: https://github.com/apache/hbase/pull/2040#issuecomment-656056593 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] skochhar commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-07-09 Thread GitBox
skochhar commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-656055867 > > My change removes these QUOTA_FAMILY_USAGE column family for the tables when a namespace quota is deleted and allows the user to insert into the tables in the namespace

[GitHub] [hbase] Apache9 commented on pull request #2009: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-09 Thread GitBox
Apache9 commented on pull request #2009: URL: https://github.com/apache/hbase/pull/2009#issuecomment-656042766 Oh, the PR has already been merged... I skimmed the comments on jira and also the patch, so the approach here is when we delete a specific version, we will go through all

[GitHub] [hbase] Apache-HBase commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-656042400 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2008: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2008: URL: https://github.com/apache/hbase/pull/2008#issuecomment-656037498 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2040: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2040: URL: https://github.com/apache/hbase/pull/2040#issuecomment-656031166 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #2036: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-09 Thread GitBox
Apache9 commented on pull request #2036: URL: https://github.com/apache/hbase/pull/2036#issuecomment-656028134 > And if you are talking about filter, the semantic for readVersions is the number of versions before filtering, not the version after fitlering. If you want to limit the version

[GitHub] [hbase] Apache-HBase commented on pull request #2042: HBASE-24704 Make the Table Schema easier to view even there are multi…

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2042: URL: https://github.com/apache/hbase/pull/2042#issuecomment-656023814 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #2036: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-09 Thread GitBox
Apache9 commented on pull request #2036: URL: https://github.com/apache/hbase/pull/2036#issuecomment-656017629 And if you are talking about filter, the semantic for readVersions is the number of versions before filtering, not the version after fitlering. If you want to limit the version

[GitHub] [hbase] bsglz opened a new pull request #2042: HBASE-24704 Make the Table Schema easier to view even there are multi…

2020-07-09 Thread GitBox
bsglz opened a new pull request #2042: URL: https://github.com/apache/hbase/pull/2042 …ple families This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (HBASE-24704) Make the Table Schema easier to view even there are multiple families

2020-07-09 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24704: --- Summary: Make the Table Schema easier to view even there are multiple families (was: Make the

[jira] [Updated] (HBASE-24704) Make the Table Schema easier to view when there are multiple families

2020-07-09 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24704: --- Attachment: HBASE-24704-beforepatch.png HBASE-24704-afterpatch.png > Make the Table

[GitHub] [hbase] Apache9 commented on pull request #2036: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-09 Thread GitBox
Apache9 commented on pull request #2036: URL: https://github.com/apache/hbase/pull/2036#issuecomment-656012701 Not sure why I missed this one... Have you read https://issues.apache.org/jira/browse/HBASE-15968? Thanks.

[jira] [Created] (HBASE-24704) Make the Table Schema easier to view when there are multiple families

2020-07-09 Thread Zheng Wang (Jira)
Zheng Wang created HBASE-24704: -- Summary: Make the Table Schema easier to view when there are multiple families Key: HBASE-24704 URL: https://issues.apache.org/jira/browse/HBASE-24704 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-655999559 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-655990651 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1926: HBASE-24586 Add table level locality in table.jsp

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #1926: URL: https://github.com/apache/hbase/pull/1926#issuecomment-655983651 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2040: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2040: URL: https://github.com/apache/hbase/pull/2040#issuecomment-655968322 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-07-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154294#comment-17154294 ] Duo Zhang commented on HBASE-11288: --- Let me put up the problems and the solutions for the two

[GitHub] [hbase] Apache-HBase commented on pull request #2039: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2039: URL: https://github.com/apache/hbase/pull/2039#issuecomment-655962755 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2039: HBASE-22738 Fallback to default group to choose RS when there are no …

2020-07-09 Thread GitBox
Apache-HBase commented on pull request #2039: URL: https://github.com/apache/hbase/pull/2039#issuecomment-655956809 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   >