[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678043726 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
saintstack commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-678038915 Closing this PR. Will open a new one against this JIRA when I have a better story. This is an automated

[GitHub] [hbase] saintstack closed pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
saintstack closed pull request #2274: URL: https://github.com/apache/hbase/pull/2274 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on a change in pull request #2276: HBASE-24904 Speed up some unit tests

2020-08-20 Thread GitBox
saintstack commented on a change in pull request #2276: URL: https://github.com/apache/hbase/pull/2276#discussion_r474408817 ## File path: hbase-shell/src/test/ruby/hbase/admin_test.rb ## @@ -528,274 +528,5 @@ def teardown end end end - - # Simple

[GitHub] [hbase] infraio commented on a change in pull request #2265: HBASE-24892 config 'hbase.hregion.memstore.mslab.indexchunksize' not be used

2020-08-20 Thread GitBox
infraio commented on a change in pull request #2265: URL: https://github.com/apache/hbase/pull/2265#discussion_r474407633 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java ## @@ -52,8 +52,8 @@ String CHUNK_SIZE_KEY =

[GitHub] [hbase] saintstack commented on pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer

2020-08-20 Thread GitBox
saintstack commented on pull request #2286: URL: https://github.com/apache/hbase/pull/2286#issuecomment-678036735 `I just saw the code and found that maybe it can be optimized here. It saves 3 mins on my PC and 1 min in Test Results.` Thanks. Good.

[GitHub] [hbase] saintstack commented on a change in pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer

2020-08-20 Thread GitBox
saintstack commented on a change in pull request #2286: URL: https://github.com/apache/hbase/pull/2286#discussion_r474406789 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXConnectorServer.java ## @@ -56,39 +58,47 @@ private static Configuration

[GitHub] [hbase] infraio merged pull request #2285: HBASE-24912 Enlarge MemstoreFlusherChore/CompactionChecker period for…

2020-08-20 Thread GitBox
infraio merged pull request #2285: URL: https://github.com/apache/hbase/pull/2285 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] bsglz commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678032130 Digged more, and i think the failure in fact caused by timezone, let see the new build for verify. This is an

[GitHub] [hbase] infraio commented on pull request #2285: HBASE-24912 Enlarge MemstoreFlusherChore/CompactionChecker period for…

2020-08-20 Thread GitBox
infraio commented on pull request #2285: URL: https://github.com/apache/hbase/pull/2285#issuecomment-678031458 > @infraio There's a small typo in the commit message: "Enalrge" => "Enlarge" Fixed. This is an automated

[GitHub] [hbase] Apache-HBase commented on pull request #2077: HBASE-24684 Fetch ReplicationSink servers list from HMaster instead o…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2077: URL: https://github.com/apache/hbase/pull/2077#issuecomment-678030370 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-20 Thread GitBox
bharathv commented on a change in pull request #2284: URL: https://github.com/apache/hbase/pull/2284#discussion_r473434176 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java ## @@ -450,6 +451,45 @@ public static

[GitHub] [hbase] ddupg commented on pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer

2020-08-20 Thread GitBox
ddupg commented on pull request #2286: URL: https://github.com/apache/hbase/pull/2286#issuecomment-678026946 > Oh, want to say why you are making these changes? You having port clashes running tests? What is the difference in test time after these changes? I just saw the code and

[GitHub] [hbase] ddupg commented on a change in pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer

2020-08-20 Thread GitBox
ddupg commented on a change in pull request #2286: URL: https://github.com/apache/hbase/pull/2286#discussion_r474396182 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXConnectorServer.java ## @@ -56,39 +58,47 @@ private static Configuration conf =

[jira] [Assigned] (HBASE-24917) HBase RSGroup: Table region details under RS Groups are in the onder fromat like HBase 1.x

2020-08-20 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad reassigned HBASE-24917: --- Assignee: Mohammad Arshad > HBase RSGroup: Table region details under RS Groups

[jira] [Updated] (HBASE-24904) Speed up some unit tests

2020-08-20 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24904: --- Summary: Speed up some unit tests (was: HBASE-24904 Speed up

[jira] [Comment Edited] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-20 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181518#comment-17181518 ] Bo Cui edited comment on HBASE-24924 at 8/21/20, 3:03 AM: -- i think we can 

[jira] [Updated] (HBASE-24925) SCP reduce unnecessary get requests

2020-08-20 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24925: --- Component/s: MTTR > SCP reduce unnecessary get requests > --- > >

[jira] [Updated] (HBASE-24925) SCP reduce unnecessary get requests

2020-08-20 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24925: --- Affects Version/s: 3.0.0-alpha-1 2.2.3 > SCP reduce unnecessary get requests >

[jira] [Updated] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-20 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24924: --- Component/s: master > stuck InitMetaProcedure in finishActiveMasterInitialization >

[GitHub] [hbase] infraio merged pull request #2277: HBASE-24906 Enlarge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic

2020-08-20 Thread GitBox
infraio merged pull request #2277: URL: https://github.com/apache/hbase/pull/2277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (HBASE-24925) SCP reduce unnecessary get requests

2020-08-20 Thread Bo Cui (Jira)
Bo Cui created HBASE-24925: -- Summary: SCP reduce unnecessary get requests Key: HBASE-24925 URL: https://issues.apache.org/jira/browse/HBASE-24925 Project: HBase Issue Type: Improvement

[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678007032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678006758 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678005066 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-20 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181518#comment-17181518 ] Bo Cui edited comment on HBASE-24924 at 8/21/20, 2:28 AM: -- i think we should

[jira] [Updated] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-20 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24924: --- Description: if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, and meta znode

[jira] [Comment Edited] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-20 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181518#comment-17181518 ] Bo Cui edited comment on HBASE-24924 at 8/21/20, 2:09 AM: --

[GitHub] [hbase] ddupg commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-20 Thread GitBox
ddupg commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-677997250 > Thanks @ddupg. One quick question, will the new UT fail without changes in refreshSources()? Just want to make sure that the UT really does its job. +1 pending on your answer.

[GitHub] [hbase] bsglz commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677994326 Seems QA stuck in build#3, can you help to stop it? Thanks. @Apache9 This is an automated message from the Apache

[jira] [Commented] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-20 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181521#comment-17181521 ] Bo Cui commented on HBASE-24924: reproduction steps 1、start new hbase,master will create meta table and

[jira] [Assigned] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-20 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui reassigned HBASE-24924: -- Assignee: Bo Cui > stuck InitMetaProcedure in finishActiveMasterInitialization >

[jira] [Commented] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-20 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181518#comment-17181518 ] Bo Cui commented on HBASE-24924:

[jira] [Updated] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-20 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24924: --- Affects Version/s: 3.0.0-alpha-1 2.2.3 > stuck InitMetaProcedure in

[jira] [Updated] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-20 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24924: --- Description: if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, and meta znode

[jira] [Created] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization

2020-08-20 Thread Bo Cui (Jira)
Bo Cui created HBASE-24924: -- Summary: stuck InitMetaProcedure in finishActiveMasterInitialization Key: HBASE-24924 URL: https://issues.apache.org/jira/browse/HBASE-24924 Project: HBase Issue Type:

[GitHub] [hbase] ankitjain64 commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-20 Thread GitBox
ankitjain64 commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-677976677 > Is there any place this nice new facility is documented? Thanks. I have updated the PR description and also the JIRA about the enhancement that we want to bring as

[GitHub] [hbase] ankitjain64 commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-20 Thread GitBox
ankitjain64 commented on a change in pull request #2284: URL: https://github.com/apache/hbase/pull/2284#discussion_r474346612 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java ## @@ -450,6 +451,45 @@ public

[jira] [Created] (HBASE-24923) Running InitMetaProcedures are missed if Hmaster startup happens after Meta assign

2020-08-20 Thread Zach York (Jira)
Zach York created HBASE-24923: - Summary: Running InitMetaProcedures are missed if Hmaster startup happens after Meta assign Key: HBASE-24923 URL: https://issues.apache.org/jira/browse/HBASE-24923

[GitHub] [hbase] ankitjain64 commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-20 Thread GitBox
ankitjain64 commented on a change in pull request #2284: URL: https://github.com/apache/hbase/pull/2284#discussion_r474343617 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java ## @@ -60,6 +60,7 @@ public final

[jira] [Created] (HBASE-24922) InitMetaProcedure create Namespace is not Idempotent

2020-08-20 Thread Zach York (Jira)
Zach York created HBASE-24922: - Summary: InitMetaProcedure create Namespace is not Idempotent Key: HBASE-24922 URL: https://issues.apache.org/jira/browse/HBASE-24922 Project: HBase Issue Type:

[jira] [Updated] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.

2020-08-20 Thread Ankit Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated HBASE-24764: --- Description: Today, if a user needs to apply some common base peer configs to all the replication

[jira] [Updated] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.

2020-08-20 Thread Ankit Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated HBASE-24764: --- Description: Today, if a user needs to apply some common base peer configs to all the replication

[jira] [Updated] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.

2020-08-20 Thread Ankit Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated HBASE-24764: --- Summary: Add support of adding base peer configs via hbase-site.xml for all replication peers.

[GitHub] [hbase] z-york commented on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2020-08-20 Thread GitBox
z-york commented on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-677947479 I am currently -1 on the implementation pending answers to my questions. I have not been able to find any valid failure modes that will cause data loss or corrupting actions if

[GitHub] [hbase] Apache-HBase commented on pull request #2277: HBASE-24906 Enlarge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2277: URL: https://github.com/apache/hbase/pull/2277#issuecomment-677945395 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24920) A tool to rewrite corrupted HFiles

2020-08-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181487#comment-17181487 ] Michael Stack commented on HBASE-24920: --- Sounds like a good plan to me [~timoha] > A tool to

[GitHub] [hbase] saintstack commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-20 Thread GitBox
saintstack commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-677934075 Is there any place this nice new facility is documented? Thanks. This is an automated message from the Apache

[GitHub] [hbase] saintstack commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-20 Thread GitBox
saintstack commented on a change in pull request #2284: URL: https://github.com/apache/hbase/pull/2284#discussion_r474300228 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java ## @@ -60,6 +60,7 @@ public final

[GitHub] [hbase] saintstack commented on pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private

2020-08-20 Thread GitBox
saintstack commented on pull request #2289: URL: https://github.com/apache/hbase/pull/2289#issuecomment-677928202 @bharathv my fault... loaded but not committed. Thanks. This is an automated message from the Apache Git

[GitHub] [hbase] saintstack commented on pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer

2020-08-20 Thread GitBox
saintstack commented on pull request #2286: URL: https://github.com/apache/hbase/pull/2286#issuecomment-677927003 Oh, want to say why you are making these changes? You having port clashes running tests? What is the difference in test time after these changes?

[GitHub] [hbase] bharathv commented on pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private

2020-08-20 Thread GitBox
bharathv commented on pull request #2289: URL: https://github.com/apache/hbase/pull/2289#issuecomment-677927169 @saintstack Looks like the push didn't address the comments or is it just me? This is an automated message from

[GitHub] [hbase] saintstack commented on a change in pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer

2020-08-20 Thread GitBox
saintstack commented on a change in pull request #2286: URL: https://github.com/apache/hbase/pull/2286#discussion_r474293872 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXConnectorServer.java ## @@ -56,39 +58,47 @@ private static Configuration

[jira] [Commented] (HBASE-24920) A tool to rewrite corrupted HFiles

2020-08-20 Thread Andrey Elenskiy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181463#comment-17181463 ] Andrey Elenskiy commented on HBASE-24920: - I currently like that `hbase hfile` is read only and

[jira] [Resolved] (HBASE-24914) Remove duplicate code appearing continuously in method ReplicationPeerManager.updatePeerConfig

2020-08-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24914. --- Hadoop Flags: Reviewed Resolution: Fixed Merged PR. Thanks for the fix [~Ddupg] >

[GitHub] [hbase] saintstack merged pull request #2287: HBASE-24914 Remove duplicate code appearing continuously in method Re…

2020-08-20 Thread GitBox
saintstack merged pull request #2287: URL: https://github.com/apache/hbase/pull/2287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-20 Thread GitBox
saintstack commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-677921557 The patch looks fine. My question is same as @virajjasani `...should have some benefits.` Can you quantify at all?

[GitHub] [hbase] saintstack commented on a change in pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private

2020-08-20 Thread GitBox
saintstack commented on a change in pull request #2289: URL: https://github.com/apache/hbase/pull/2289#discussion_r474285921 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -69,7 +66,15 @@ */ @InterfaceAudience.Public public

[GitHub] [hbase] saintstack commented on pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private

2020-08-20 Thread GitBox
saintstack commented on pull request #2289: URL: https://github.com/apache/hbase/pull/2289#issuecomment-677918456 Push addresses @bharathv review This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] saintstack commented on a change in pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private

2020-08-20 Thread GitBox
saintstack commented on a change in pull request #2289: URL: https://github.com/apache/hbase/pull/2289#discussion_r474286032 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -69,7 +66,15 @@ */ @InterfaceAudience.Public public

[GitHub] [hbase] bharathv commented on a change in pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private

2020-08-20 Thread GitBox
bharathv commented on a change in pull request #2289: URL: https://github.com/apache/hbase/pull/2289#discussion_r474275214 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java ## @@ -69,7 +66,15 @@ */ @InterfaceAudience.Public public

[jira] [Commented] (HBASE-24920) A tool to rewrite corrupted HFiles

2020-08-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181449#comment-17181449 ] Michael Stack commented on HBASE-24920: --- Do you think it would be an option on

[GitHub] [hbase] Apache-HBase commented on pull request #2287: HBASE-24914 Remove duplicate code appearing continuously in method Re…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2287: URL: https://github.com/apache/hbase/pull/2287#issuecomment-677902114 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-24921) Add help output for shell "magic" commands

2020-08-20 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24921: Summary: Add help output for shell "magic" commands Key: HBASE-24921 URL: https://issues.apache.org/jira/browse/HBASE-24921 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2287: HBASE-24914 Remove duplicate code appearing continuously in method Re…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2287: URL: https://github.com/apache/hbase/pull/2287#issuecomment-677889878 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-24920) A tool to rewrite corrupted HFiles

2020-08-20 Thread Andrey Elenskiy (Jira)
Andrey Elenskiy created HBASE-24920: --- Summary: A tool to rewrite corrupted HFiles Key: HBASE-24920 URL: https://issues.apache.org/jira/browse/HBASE-24920 Project: HBase Issue Type:

[jira] [Created] (HBASE-24919) A tool to rewrite corrupted HFiles

2020-08-20 Thread Andrey Elenskiy (Jira)
Andrey Elenskiy created HBASE-24919: --- Summary: A tool to rewrite corrupted HFiles Key: HBASE-24919 URL: https://issues.apache.org/jira/browse/HBASE-24919 Project: HBase Issue Type:

[GitHub] [hbase] bitoffdev commented on a change in pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-20 Thread GitBox
bitoffdev commented on a change in pull request #2282: URL: https://github.com/apache/hbase/pull/2282#discussion_r474205155 ## File path: hbase-shell/src/main/ruby/shell/formatter.rb ## @@ -192,6 +199,56 @@ def footer(row_count = nil, is_stale = false) end end +

[GitHub] [hbase] bitoffdev commented on a change in pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-20 Thread GitBox
bitoffdev commented on a change in pull request #2282: URL: https://github.com/apache/hbase/pull/2282#discussion_r474204114 ## File path: hbase-shell/src/main/ruby/shell/commands/list_peers.rb ## @@ -38,10 +38,10 @@ def help def command peers =

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-677838306 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private

2020-08-20 Thread GitBox
saintstack commented on pull request #2289: URL: https://github.com/apache/hbase/pull/2289#issuecomment-677831251 This patch is same as last PR attached to HBASE-24896 only no claims it fixes HBASE-24896It is deprecation, annotation, and moving an inner-class out to be standalone

[GitHub] [hbase] saintstack opened a new pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private

2020-08-20 Thread GitBox
saintstack opened a new pull request #2289: URL: https://github.com/apache/hbase/pull/2289 Mark RegionInfo#UNDEFINED IA.Private and deprecated; it is for internal use only and likely to be removed in hbase4. Move MutableRegionInfo out of RegionInfoBuilder and have it as a

[jira] [Created] (HBASE-24918) Make RegionInfo#UNDEFINED IA.Private

2020-08-20 Thread Michael Stack (Jira)
Michael Stack created HBASE-24918: - Summary: Make RegionInfo#UNDEFINED IA.Private Key: HBASE-24918 URL: https://issues.apache.org/jira/browse/HBASE-24918 Project: HBase Issue Type: Sub-task

[jira] [Commented] (HBASE-24896) 'Stuck' in static initialization creating RegionInfo instance

2020-08-20 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181370#comment-17181370 ] Michael Stack commented on HBASE-24896: --- Update. Helpful back and forth on PR entertaining

[GitHub] [hbase] saintstack commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
saintstack commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677814307 Thats for the helpful pointer @bharathv and your input. Given the above discussion and my not wanting to waste valuable review resource, I think I need to reproduce this

[GitHub] [hbase] Apache-HBase commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-677806452 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24917) HBase RSGroup: Table region details under RS Groups are in the onder fromat like HBase 1.x

2020-08-20 Thread Ajeet Rai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24917: -- Description: HBase RSGroup: Table region details under RS Groups are in the older format like HBase

[jira] [Updated] (HBASE-24917) HBase RSGroup: Table region details under RS Groups are in the onder fromat like HBase 1.x

2020-08-20 Thread Ajeet Rai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24917: -- Description: HBase RSGroup: Table region details under RS Groups are in the older format like HBase

[jira] [Created] (HBASE-24917) HBase RSGroup: Table region details under RS Groups are in the onder fromat like HBase 1.x

2020-08-20 Thread Ajeet Rai (Jira)
Ajeet Rai created HBASE-24917: - Summary: HBase RSGroup: Table region details under RS Groups are in the onder fromat like HBase 1.x Key: HBASE-24917 URL: https://issues.apache.org/jira/browse/HBASE-24917

[GitHub] [hbase] Apache-HBase commented on pull request #2287: HBASE-24914 Remove duplicate code appearing continuously in method Re…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2287: URL: https://github.com/apache/hbase/pull/2287#issuecomment-677800330 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bharathv commented on a change in pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-20 Thread GitBox
bharathv commented on a change in pull request #2130: URL: https://github.com/apache/hbase/pull/2130#discussion_r474150302 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterAddressRefresher.java ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache

[jira] [Assigned] (HBASE-24916) HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start key is empty

2020-08-20 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad reassigned HBASE-24916: --- Assignee: Mohammad Arshad > HBCK2 Holes:Wrong region details in HBCK report ,if a

[jira] [Updated] (HBASE-24916) HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start key is empty

2020-08-20 Thread Ajeet Rai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24916: -- Description: HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in meta and

[jira] [Updated] (HBASE-24916) HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start key is empty

2020-08-20 Thread Ajeet Rai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24916: -- Description: HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in meta and

[jira] [Updated] (HBASE-24916) HBCK2 Holes:Wrong region detail in HBCK report ,if a region is missing in meta and start key is empty

2020-08-20 Thread Ajeet Rai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24916: -- Summary: HBCK2 Holes:Wrong region detail in HBCK report ,if a region is missing in meta and start

[jira] [Updated] (HBASE-24916) HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start key is empty

2020-08-20 Thread Ajeet Rai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24916: -- Description: HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in meta and

[jira] [Updated] (HBASE-24916) HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start key is empty

2020-08-20 Thread Ajeet Rai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24916: -- Summary: HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start

[jira] [Created] (HBASE-24916) HBCK2 Holes:Wrong region detail in HBCK report a start key of a region which is missing in meta is empty

2020-08-20 Thread Ajeet Rai (Jira)
Ajeet Rai created HBASE-24916: - Summary: HBCK2 Holes:Wrong region detail in HBCK report a start key of a region which is missing in meta is empty Key: HBASE-24916 URL:

[GitHub] [hbase] Apache-HBase commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677789166 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
bharathv commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677785949 > This approach looks sufficient breaking the possible static load tangle. I could add this to first patch -- deprecating and nulling UNDEFINED Wondering if this is

[GitHub] [hbase] Apache-HBase commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677785767 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-677783532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2277: HBASE-24906 Enlarge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2277: URL: https://github.com/apache/hbase/pull/2277#issuecomment-677783756 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2287: HBASE-24914 Remove duplicate code appearing continuously in method Re…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2287: URL: https://github.com/apache/hbase/pull/2287#issuecomment-677781976 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677780020 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-24867) Add 2.3.1 to the downloads page

2020-08-20 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24867. -- Resolution: Fixed > Add 2.3.1 to the downloads page > --- > >

[jira] [Updated] (HBASE-24867) Add 2.3.1 to the downloads page

2020-08-20 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24867: - Fix Version/s: 3.0.0-alpha-1 > Add 2.3.1 to the downloads page >

[GitHub] [hbase] Apache-HBase commented on pull request #2281: HBASE-24867 Add 2.3.1 to the downloads page

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2281: URL: https://github.com/apache/hbase/pull/2281#issuecomment-677768587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] saintstack commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
saintstack commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677767879 Added IA.Private and deprecation on UNDEFINED in RI per @Apache9 suggestion. This is an automated message from

[GitHub] [hbase] ndimiduk commented on pull request #2281: HBASE-24867 Add 2.3.1 to the downloads page

2020-08-20 Thread GitBox
ndimiduk commented on pull request #2281: URL: https://github.com/apache/hbase/pull/2281#issuecomment-677768088 thanks for the reviews! This is an automated message from the Apache Git Service. To respond to the message,

  1   2   >