[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678043726 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 7m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 40s | master passed | | +1 :green_heart: | checkstyle | 1m 34s | master passed | | +1 :green_heart: | spotbugs | 2m 48s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 41s | the patch passed | | -0 :warning: | checkstyle | 1m 10s | hbase-server: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 11s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 21s | The patch does not generate ASF License warnings. | | | | 45m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2272 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux b4f391b71bea 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 65d28da7c2 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…
saintstack commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-678038915 Closing this PR. Will open a new one against this JIRA when I have a better story. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack closed pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…
saintstack closed pull request #2274: URL: https://github.com/apache/hbase/pull/2274 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #2276: HBASE-24904 Speed up some unit tests
saintstack commented on a change in pull request #2276: URL: https://github.com/apache/hbase/pull/2276#discussion_r474408817 ## File path: hbase-shell/src/test/ruby/hbase/admin_test.rb ## @@ -528,274 +528,5 @@ def teardown end end end - - # Simple administration methods tests - class AdminRegionTest < Test::Unit::TestCase Review comment: Why we remove this stuff? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] infraio commented on a change in pull request #2265: HBASE-24892 config 'hbase.hregion.memstore.mslab.indexchunksize' not be used
infraio commented on a change in pull request #2265: URL: https://github.com/apache/hbase/pull/2265#discussion_r474407633 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java ## @@ -52,8 +52,8 @@ String CHUNK_SIZE_KEY = "hbase.hregion.memstore.mslab.chunksize"; int CHUNK_SIZE_DEFAULT = 2048 * 1024; - String INDEX_CHUNK_PERCENTAGE_KEY = "hbase.hregion.memstore.mslab.indexchunksize"; Review comment: This never used? So you changed it to a better name? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer
saintstack commented on pull request #2286: URL: https://github.com/apache/hbase/pull/2286#issuecomment-678036735 `I just saw the code and found that maybe it can be optimized here. It saves 3 mins on my PC and 1 min in Test Results.` Thanks. Good. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer
saintstack commented on a change in pull request #2286:
URL: https://github.com/apache/hbase/pull/2286#discussion_r474406789
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXConnectorServer.java
##
@@ -56,39 +58,47 @@
private static Configuration conf = null;
private static Admin admin;
// RMI registry port
- private static int rmiRegistryPort = 61120;
+ private static int rmiRegistryPort;
// Switch for customized Accesscontroller to throw ACD exception while
executing test case
- static boolean hasAccess;
+ private volatile static boolean hasAccess;
- @Before
- public void setUp() throws Exception {
-UTIL = new HBaseTestingUtility();
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
conf = UTIL.getConfiguration();
+String cps = JMXListener.class.getName() + "," +
MyAccessController.class.getName();
+conf.set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY, cps);
+conf.set(CoprocessorHost.REGIONSERVER_COPROCESSOR_CONF_KEY, cps);
+rmiRegistryPort = UTIL.randomFreePort();
Review comment:
In my experience it is strange how often we meet clashes. Any chance of
catching BindException and retrying?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] infraio merged pull request #2285: HBASE-24912 Enlarge MemstoreFlusherChore/CompactionChecker period for…
infraio merged pull request #2285: URL: https://github.com/apache/hbase/pull/2285 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider
bsglz commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678032130 Digged more, and i think the failure in fact caused by timezone, let see the new build for verify. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] infraio commented on pull request #2285: HBASE-24912 Enlarge MemstoreFlusherChore/CompactionChecker period for…
infraio commented on pull request #2285: URL: https://github.com/apache/hbase/pull/2285#issuecomment-678031458 > @infraio There's a small typo in the commit message: "Enalrge" => "Enlarge" Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2077: HBASE-24684 Fetch ReplicationSink servers list from HMaster instead o…
Apache-HBase commented on pull request #2077: URL: https://github.com/apache/hbase/pull/2077#issuecomment-678030370 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-24666 Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 46s | HBASE-24666 passed | | +1 :green_heart: | checkstyle | 2m 27s | HBASE-24666 passed | | +1 :green_heart: | spotbugs | 7m 37s | HBASE-24666 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 37s | the patch passed | | -0 :warning: | checkstyle | 1m 5s | hbase-server: The patch generated 5 new + 191 unchanged - 2 fixed = 196 total (was 193) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 20s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | hbaseprotoc | 3m 6s | the patch passed | | +1 :green_heart: | spotbugs | 10m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 51s | The patch does not generate ASF License warnings. | | | | 56m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2077 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool | | uname | Linux c3b87ffed699 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-24666 / 06cc3c502e | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 95 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2077/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.
bharathv commented on a change in pull request #2284:
URL: https://github.com/apache/hbase/pull/2284#discussion_r473434176
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -450,6 +451,45 @@ public static ReplicationPeerConfig
appendTableCFsToReplicationPeerConfig(
return builder.build();
}
+ /**
Review comment:
nit: Sample configuration block not needed. Its kind of obvious. Instead
add the configuration value formatting to the javadoc of the config? (and also
what the default is).
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -60,6 +60,7 @@
public final class ReplicationPeerConfigUtil {
private static final Logger LOG =
LoggerFactory.getLogger(ReplicationPeerConfigUtil.class);
+ public static final String HBASE_REPLICATION_PEER_DEFAULT_CONFIG=
"hbase.replication.peer.default.config";
Review comment:
Make it private?
##
File path:
hbase-replication/src/test/java/org/apache/hadoop/hbase/replication/TestZKReplicationPeerStorage.java
##
@@ -215,4 +218,52 @@ public void testNoSyncReplicationState()
assertNotEquals(-1, ZKUtil.checkExists(UTIL.getZooKeeperWatcher(),
STORAGE.getNewSyncReplicationStateNode(peerId)));
}
+
+ @Test
+ public void testDefaultReplicationPeerConfigIsAppliedIfNotAlreadySet(){
+String customPeerConfigKey = "hbase.xxx.custom_config";
+String customPeerConfigValue = "test";
+
+String customPeerConfigSecondKey = "hbase.xxx.custom_second_config";
+String customPeerConfigSecondValue = "testSecond";
+
+ReplicationPeerConfig existingReplicationPeerConfig = getConfig(1);
+
+// custom config not present
+
assertEquals(existingReplicationPeerConfig.getConfiguration().get(customPeerConfigKey),
null);
+
+Configuration conf = UTIL.getConfiguration();
+conf.set(ReplicationPeerConfigUtil.HBASE_REPLICATION_PEER_BASE_CONFIG,
+
customPeerConfigKey.concat("=").concat(customPeerConfigValue).concat(";").
+
concat(customPeerConfigSecondKey).concat("=").concat(customPeerConfigSecondValue));
+
+ReplicationPeerConfig updatedReplicationPeerConfig =
ReplicationPeerConfigUtil.
+ addBasePeerConfigsIfNotPresent(conf,existingReplicationPeerConfig);
+
+assertEquals(customPeerConfigValue,
updatedReplicationPeerConfig.getConfiguration().
+ get(customPeerConfigKey));
+assertEquals(customPeerConfigSecondValue,
updatedReplicationPeerConfig.getConfiguration().
+ get(customPeerConfigSecondKey));
+ }
+
+ @Test
+ public void testDefaultReplicationPeerConfigOverrideIfAlreadySet(){
Review comment:
I think we need more coverage for the following cases.
- Existing peer config gets the config override
- Admin code paths (for getPeerConfig, updatePeerConfig, etc) work well with
the overlays (updating an existing / non-existing config etc)
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -450,6 +451,45 @@ public static ReplicationPeerConfig
appendTableCFsToReplicationPeerConfig(
return builder.build();
}
+ /**
+ Sample Configuration
+
+ hbase.replication.peer.default.configs
+
hbase.replication.source.custom.walentryfilters=x,y,z;hbase.xxx.custom_property=123
+
+ */
+
+ /**
+ * Helper method to add default peer configs from HBase Configuration to
ReplicationPeerConfig
+ * @param conf Configuration
+ * @return true if new configurations was added.
+ */
+ public static ReplicationPeerConfig
addDefaultPeerConfigsIfNotPresent(Configuration conf, ReplicationPeerConfig
receivedPeerConfig){
+
+ReplicationPeerConfigBuilder copiedPeerConfigBuilder =
ReplicationPeerConfig.newBuilder(receivedPeerConfig);
+String defaultPeerConfigs =
conf.get(HBASE_REPLICATION_PEER_DEFAULT_CONFIG);
Review comment:
nit: get(CONFIG, default)
##
File path:
hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeers.java
##
@@ -144,7 +145,12 @@ private ReplicationPeerImpl createPeer(String peerId)
throws ReplicationExceptio
SyncReplicationState syncReplicationState =
peerStorage.getPeerSyncReplicationState(peerId);
SyncReplicationState newSyncReplicationState =
peerStorage.getPeerNewSyncReplicationState(peerId);
+
+ReplicationPeerConfig updatedPeerConfig = ReplicationPeerConfigUtil.
+ addBasePeerConfigsIfNotPresent(this.conf, peerConfig);
+peerStorage.updatePeerConfig(peerId,updatedPeerConfig);
Review comment:
I was thinking this happens only in the master code paths. Ex:
ReplicationPeerManager#create (for existing peers) or addPeer() for new peers
etc. That way the configuration in storage remains consistent.
Doing from the RS code paths (ReplicationPeers) means that if
[GitHub] [hbase] ddupg commented on pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer
ddupg commented on pull request #2286: URL: https://github.com/apache/hbase/pull/2286#issuecomment-678026946 > Oh, want to say why you are making these changes? You having port clashes running tests? What is the difference in test time after these changes? I just saw the code and found that maybe it can be optimized here. It saves 3 mins on my PC and 1 min in Test Results. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ddupg commented on a change in pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer
ddupg commented on a change in pull request #2286:
URL: https://github.com/apache/hbase/pull/2286#discussion_r474396182
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXConnectorServer.java
##
@@ -56,39 +58,47 @@
private static Configuration conf = null;
private static Admin admin;
// RMI registry port
- private static int rmiRegistryPort = 61120;
+ private static int rmiRegistryPort;
// Switch for customized Accesscontroller to throw ACD exception while
executing test case
- static boolean hasAccess;
+ private volatile static boolean hasAccess;
- @Before
- public void setUp() throws Exception {
-UTIL = new HBaseTestingUtility();
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
conf = UTIL.getConfiguration();
+String cps = JMXListener.class.getName() + "," +
MyAccessController.class.getName();
+conf.set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY, cps);
+conf.set(CoprocessorHost.REGIONSERVER_COPROCESSOR_CONF_KEY, cps);
+rmiRegistryPort = UTIL.randomFreePort();
Review comment:
Thank @saintstack for reviewing.
For JMXConnectorServer starting, only use the default port or specifying
port, can't find a free port by retrying. So I use
HBaseTestingUtility#randomFreePort to get a free port, which mark ports as
taken and don't return repeated ports. This patch may not completely avoid port
clash, but at least it can reduce the possibility ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (HBASE-24917) HBase RSGroup: Table region details under RS Groups are in the onder fromat like HBase 1.x
[ https://issues.apache.org/jira/browse/HBASE-24917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad reassigned HBASE-24917: --- Assignee: Mohammad Arshad > HBase RSGroup: Table region details under RS Groups are in the onder fromat > like HBase 1.x > -- > > Key: HBASE-24917 > URL: https://issues.apache.org/jira/browse/HBASE-24917 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Assignee: Mohammad Arshad >Priority: Major > > HBase RSGroup: Table region details under RS Groups are in the older format > like HBase 1.x. > > in HBase2, Master UI will contain table details > > > > ||Namespace||Name||State||Regions||Description|| > ||OPEN||OPENING||CLOSED||CLOSING||OFFLINE||FAILED||SPLIT||Other|| > but under Regroup, table region details are different which are same as in > HBase1.x > > ||Namespace||Table||Stats||Online Regions||Offline Regions||Failed > Regions||Split Regions||Other Regions||Description|| -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24904) Speed up some unit tests
[ https://issues.apache.org/jira/browse/HBASE-24904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24904: --- Summary: Speed up some unit tests (was: HBASE-24904 Speed up TestAsyncTableAdminApi/TestSnapshotTemporaryDirectoryWithRegionReplicas/TestRegionReplicaFailover) > Speed up some unit tests > > > Key: HBASE-24904 > URL: https://issues.apache.org/jira/browse/HBASE-24904 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > > See > [https://ci-hadoop.apache.org/job/HBase/job/HBase-Flaky-Tests/job/branch-2.2/42/testReport/org.apache.hadoop.hbase.client/TestAsyncTableAdminApi/] > [https://ci-hadoop.apache.org/job/HBase/job/HBase-Flaky-Tests/job/branch-2.2/61/testReport/junit/org.apache.hadoop.hbase.client/TestSnapshotTemporaryDirectoryWithRegionReplicas//] > > These ut are flaky because they take too much time which more than 780 > seconds. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization
[
https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181518#comment-17181518
]
Bo Cui edited comment on HBASE-24924 at 8/21/20, 3:03 AM:
--
i think we can enhance it.
[https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-protocol-shaded/src/main/protobuf/server/master/MasterProcedure.proto#L497]
{code:java}
message InitMetaStateData {
required int32 latch = 1;
}
{code}
if the completed InitMetaProcedure exists, and meta znode does not exist,
master should create new InitMetaProcedure
[https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1046]
{code:java}
filter(p -> (p instanceof InitMetaProcedure && !p.isFinished()))
{code}
was (Author: bo cui):
i think we should strengthen it.
[https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-protocol-shaded/src/main/protobuf/server/master/MasterProcedure.proto#L497]
{code:java}
message InitMetaStateData {
required int32 latch = 1;
}
{code}
if the completed InitMetaProcedure exists, and meta znode does not exist,
master should create new InitMetaProcedure
https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1046
{code:java}
filter(p -> (p instanceof InitMetaProcedure && !p.isFinished()))
{code}
> stuck InitMetaProcedure in finishActiveMasterInitialization
> ---
>
> Key: HBASE-24924
> URL: https://issues.apache.org/jira/browse/HBASE-24924
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 3.0.0-alpha-1, 2.2.3
>Reporter: Bo Cui
>Assignee: Bo Cui
>Priority: Major
> Attachments: image-2020-08-21-09-12-33-894.png, masterLog.gif
>
>
> if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished,
> and meta znode does not exist， finishActiveMasterInitialization will stuck
> because during startup，If InitMetaProcedure exists, InitMetaProcedure
> recreates a new CountDownLatch.
> master jstack
> !image-2020-08-21-09-12-33-894.png!
> master log
> !masterLog.gif!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24925) SCP reduce unnecessary get requests
[ https://issues.apache.org/jira/browse/HBASE-24925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24925: --- Component/s: MTTR > SCP reduce unnecessary get requests > --- > > Key: HBASE-24925 > URL: https://issues.apache.org/jira/browse/HBASE-24925 > Project: HBase > Issue Type: Improvement > Components: MTTR >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Priority: Major > > SCP should reduce unnecessary Get request > [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L520] > during startup， the tableNam2State of tableStateManager is not loading > tableState data form metaTable yet. if procThread num is 50 and hbase has > 10K tables, in the worst case, the master needs to query meta table 500K > times(50*10K. and the regions that all SCPs simultaneously check tableState > belong to the same table ) > > i think master can reduce Get request, and AM#loadMeta can load regions and > all tables > [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java#L1532] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24925) SCP reduce unnecessary get requests
[ https://issues.apache.org/jira/browse/HBASE-24925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24925: --- Affects Version/s: 3.0.0-alpha-1 2.2.3 > SCP reduce unnecessary get requests > --- > > Key: HBASE-24925 > URL: https://issues.apache.org/jira/browse/HBASE-24925 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Priority: Major > > SCP should reduce unnecessary Get request > [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L520] > during startup， the tableNam2State of tableStateManager is not loading > tableState data form metaTable yet. if procThread num is 50 and hbase has > 10K tables, in the worst case, the master needs to query meta table 500K > times(50*10K. and the regions that all SCPs simultaneously check tableState > belong to the same table ) > > i think master can reduce Get request, and AM#loadMeta can load regions and > all tables > [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java#L1532] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24924: --- Component/s: master > stuck InitMetaProcedure in finishActiveMasterInitialization > --- > > Key: HBASE-24924 > URL: https://issues.apache.org/jira/browse/HBASE-24924 > Project: HBase > Issue Type: Bug > Components: master >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > Attachments: image-2020-08-21-09-12-33-894.png, masterLog.gif > > > if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, > and meta znode does not exist， finishActiveMasterInitialization will stuck > because during startup，If InitMetaProcedure exists, InitMetaProcedure > recreates a new CountDownLatch. > master jstack > !image-2020-08-21-09-12-33-894.png! > master log > !masterLog.gif! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] infraio merged pull request #2277: HBASE-24906 Enlarge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic
infraio merged pull request #2277: URL: https://github.com/apache/hbase/pull/2277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24925) SCP reduce unnecessary get requests
Bo Cui created HBASE-24925: -- Summary: SCP reduce unnecessary get requests Key: HBASE-24925 URL: https://issues.apache.org/jira/browse/HBASE-24925 Project: HBase Issue Type: Improvement Reporter: Bo Cui SCP should reduce unnecessary Get request [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L520] during startup， the tableNam2State of tableStateManager is not loading tableState data form metaTable yet. if procThread num is 50 and hbase has 10K tables, in the worst case, the master needs to query meta table 500K times(50*10K. and the regions that all SCPs simultaneously check tableState belong to the same table ) i think master can reduce Get request, and AM#loadMeta can load regions and all tables [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java#L1532] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678007032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 45s | master passed | | +1 :green_heart: | compile | 1m 10s | master passed | | +1 :green_heart: | shadedjars | 6m 22s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 33s | the patch passed | | +1 :green_heart: | compile | 1m 9s | the patch passed | | +1 :green_heart: | javac | 1m 9s | the patch passed | | +1 :green_heart: | shadedjars | 6m 18s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 9m 30s | hbase-server in the patch failed. | | | | 36m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2272 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3f7bb69ec499 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 65d28da7c2 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/4/testReport/ | | Max. process+thread count | 505 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678006758 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | master passed | | +1 :green_heart: | checkstyle | 1m 10s | master passed | | +1 :green_heart: | spotbugs | 2m 4s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 43s | the patch passed | | +1 :green_heart: | checkstyle | 1m 11s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 11s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 35m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2272 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 4fbdf49bca41 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 65d28da7c2 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-678005066 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 31s | master passed | | +1 :green_heart: | compile | 0m 53s | master passed | | +1 :green_heart: | shadedjars | 5m 36s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 5m 31s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 6m 27s | hbase-server in the patch failed. | | | | 28m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2272 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 149c101afde6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 65d28da7c2 | | Default Java | 1.8.0_232 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/4/testReport/ | | Max. process+thread count | 576 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2272/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization
[
https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181518#comment-17181518
]
Bo Cui edited comment on HBASE-24924 at 8/21/20, 2:28 AM:
--
i think we should strengthen it.
[https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-protocol-shaded/src/main/protobuf/server/master/MasterProcedure.proto#L497]
{code:java}
message InitMetaStateData {
required int32 latch = 1;
}
{code}
if the completed InitMetaProcedure exists, and meta znode does not exist,
master should create new InitMetaProcedure
https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1046
{code:java}
filter(p -> (p instanceof InitMetaProcedure && !p.isFinished()))
{code}
was (Author: bo cui):
https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-protocol-shaded/src/main/protobuf/server/master/MasterProcedure.proto#L497
i think we should strengthen it.
{code:java}
message InitMetaStateData {
required int32 latch = 1;
}
{code}
> stuck InitMetaProcedure in finishActiveMasterInitialization
> ---
>
> Key: HBASE-24924
> URL: https://issues.apache.org/jira/browse/HBASE-24924
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1, 2.2.3
>Reporter: Bo Cui
>Assignee: Bo Cui
>Priority: Major
> Attachments: image-2020-08-21-09-12-33-894.png, masterLog.gif
>
>
> if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished,
> and meta znode does not exist， finishActiveMasterInitialization will stuck
> because during startup，If InitMetaProcedure exists, InitMetaProcedure
> recreates a new CountDownLatch.
> master jstack
> !image-2020-08-21-09-12-33-894.png!
> master log
> !masterLog.gif!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24924: --- Description: if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, and meta znode does not exist， finishActiveMasterInitialization will stuck because during startup，If InitMetaProcedure exists, InitMetaProcedure recreates a new CountDownLatch. master jstack !image-2020-08-21-09-12-33-894.png! master log !masterLog.gif! was: if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, and meta znode does not exist， finishActiveMasterInitialization will stuck master jstack !image-2020-08-21-09-12-33-894.png! master log !masterLog.gif! > stuck InitMetaProcedure in finishActiveMasterInitialization > --- > > Key: HBASE-24924 > URL: https://issues.apache.org/jira/browse/HBASE-24924 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > Attachments: image-2020-08-21-09-12-33-894.png, masterLog.gif > > > if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, > and meta znode does not exist， finishActiveMasterInitialization will stuck > because during startup，If InitMetaProcedure exists, InitMetaProcedure > recreates a new CountDownLatch. > master jstack > !image-2020-08-21-09-12-33-894.png! > master log > !masterLog.gif! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization
[
https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181518#comment-17181518
]
Bo Cui edited comment on HBASE-24924 at 8/21/20, 2:09 AM:
--
https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-protocol-shaded/src/main/protobuf/server/master/MasterProcedure.proto#L497
i think we should strengthen it.
{code:java}
message InitMetaStateData {
required int32 latch = 1;
}
{code}
was (Author: bo cui):
[https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1046]
i think we should strengthen it.
{code:java}
filter(p -> (p instanceof InitMetaProcedure && !p.isFinished()))
{code}
> stuck InitMetaProcedure in finishActiveMasterInitialization
> ---
>
> Key: HBASE-24924
> URL: https://issues.apache.org/jira/browse/HBASE-24924
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1, 2.2.3
>Reporter: Bo Cui
>Assignee: Bo Cui
>Priority: Major
> Attachments: image-2020-08-21-09-12-33-894.png, masterLog.gif
>
>
> if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished,
> and meta znode does not exist， finishActiveMasterInitialization will stuck
> master jstack
> !image-2020-08-21-09-12-33-894.png!
> master log
> !masterLog.gif!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] ddupg commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…
ddupg commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-677997250 > Thanks @ddupg. One quick question, will the new UT fail without changes in refreshSources()? Just want to make sure that the UT really does its job. +1 pending on your answer. Yes, the UT fail without changes in this patch. Because it failed to updateLogPosition in zk after replicating first WAL edits batch, which aborting RS. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider
bsglz commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677994326 Seems QA stuck in build#3, can you help to stop it? Thanks. @Apache9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181521#comment-17181521 ] Bo Cui commented on HBASE-24924: reproduction steps 1、start new hbase，master will create meta table and submit InitMetaProcedure to procedureExecutor 2、wait until the InitMetaProcedure is complete, and then kill master and all rs 3、delete meta znode 4、start hbase, load procWAL, and load the completed InitMetaProcedure， master is stuck > stuck InitMetaProcedure in finishActiveMasterInitialization > --- > > Key: HBASE-24924 > URL: https://issues.apache.org/jira/browse/HBASE-24924 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > Attachments: image-2020-08-21-09-12-33-894.png, masterLog.gif > > > if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, > and meta znode does not exist， finishActiveMasterInitialization will stuck > master jstack > !image-2020-08-21-09-12-33-894.png! > master log > !masterLog.gif! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui reassigned HBASE-24924: -- Assignee: Bo Cui > stuck InitMetaProcedure in finishActiveMasterInitialization > --- > > Key: HBASE-24924 > URL: https://issues.apache.org/jira/browse/HBASE-24924 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > Attachments: image-2020-08-21-09-12-33-894.png, masterLog.gif > > > if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, > and meta znode does not exist， finishActiveMasterInitialization will stuck > master jstack > !image-2020-08-21-09-12-33-894.png! > master log > !masterLog.gif! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization
[
https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181518#comment-17181518
]
Bo Cui commented on HBASE-24924:
[https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1046]
i think we should strengthen it.
{code:java}
filter(p -> (p instanceof InitMetaProcedure && !p.isFinished()))
{code}
> stuck InitMetaProcedure in finishActiveMasterInitialization
> ---
>
> Key: HBASE-24924
> URL: https://issues.apache.org/jira/browse/HBASE-24924
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1, 2.2.3
>Reporter: Bo Cui
>Priority: Major
> Attachments: image-2020-08-21-09-12-33-894.png, masterLog.gif
>
>
> if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished,
> and meta znode does not exist， finishActiveMasterInitialization will stuck
> master jstack
> !image-2020-08-21-09-12-33-894.png!
> master log
> !masterLog.gif!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24924: --- Affects Version/s: 3.0.0-alpha-1 2.2.3 > stuck InitMetaProcedure in finishActiveMasterInitialization > --- > > Key: HBASE-24924 > URL: https://issues.apache.org/jira/browse/HBASE-24924 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Priority: Major > Attachments: image-2020-08-21-09-12-33-894.png, masterLog.gif > > > if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, > and meta znode does not exist， finishActiveMasterInitialization will stuck > master jstack > !image-2020-08-21-09-12-33-894.png! > master log > !masterLog.gif! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization
[ https://issues.apache.org/jira/browse/HBASE-24924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24924: --- Description: if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, and meta znode does not exist， finishActiveMasterInitialization will stuck master jstack !image-2020-08-21-09-12-33-894.png! master log !masterLog.gif! was: if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, and meta znode does not exist， finishActiveMasterInitialization will stuck master jstack !image-2020-08-21-09-12-33-894.png! master log > stuck InitMetaProcedure in finishActiveMasterInitialization > --- > > Key: HBASE-24924 > URL: https://issues.apache.org/jira/browse/HBASE-24924 > Project: HBase > Issue Type: Bug >Reporter: Bo Cui >Priority: Major > Attachments: image-2020-08-21-09-12-33-894.png, masterLog.gif > > > if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, > and meta znode does not exist， finishActiveMasterInitialization will stuck > master jstack > !image-2020-08-21-09-12-33-894.png! > master log > !masterLog.gif! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24924) stuck InitMetaProcedure in finishActiveMasterInitialization
Bo Cui created HBASE-24924: -- Summary: stuck InitMetaProcedure in finishActiveMasterInitialization Key: HBASE-24924 URL: https://issues.apache.org/jira/browse/HBASE-24924 Project: HBase Issue Type: Bug Reporter: Bo Cui Attachments: image-2020-08-21-09-12-33-894.png, masterLog.gif if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, and meta znode does not exist， finishActiveMasterInitialization will stuck master jstack !image-2020-08-21-09-12-33-894.png! master log -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ankitjain64 commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.
ankitjain64 commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-677976677 > Is there any place this nice new facility is documented? Thanks. I have updated the PR description and also the JIRA about the enhancement that we want to bring as part of this item. Please let me know if you have any questions/concerns will be happy to answer. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ankitjain64 commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.
ankitjain64 commented on a change in pull request #2284:
URL: https://github.com/apache/hbase/pull/2284#discussion_r474346612
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -450,6 +451,45 @@ public static ReplicationPeerConfig
appendTableCFsToReplicationPeerConfig(
return builder.build();
}
+ /**
+ Sample Configuration
+
+ hbase.replication.peer.default.configs
+
hbase.replication.source.custom.walentryfilters=x,y,z;hbase.xxx.custom_property=123
+
+ */
+
+ /**
+ * Helper method to add default peer configs from HBase Configuration to
ReplicationPeerConfig
+ * @param conf Configuration
+ * @return true if new configurations was added.
+ */
+ public static ReplicationPeerConfig
addDefaultPeerConfigsIfNotPresent(Configuration conf, ReplicationPeerConfig
receivedPeerConfig){
+
+ReplicationPeerConfigBuilder copiedPeerConfigBuilder =
ReplicationPeerConfig.newBuilder(receivedPeerConfig);
+String defaultPeerConfigs =
conf.get(HBASE_REPLICATION_PEER_DEFAULT_CONFIG);
+
+Map peerConfigurations =
receivedPeerConfig.getConfiguration();
+
+if(defaultPeerConfigs != null && defaultPeerConfigs.length() != 0){
+ String[] defaultPeerConfigList = defaultPeerConfigs.split(";");
Review comment:
>> so you could choose a delimiter that was outside of the constraint set
Are there any current constraints regarding the convention on peer values
that I can refer to?
I looked around and since there can be multiple values of a particular peer
config that are generally delimited by `,` so I decided to use `;` for
delimiting different peer configs. But I am happy to change this if it can
cause any problems in your opinion. Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (HBASE-24923) Running InitMetaProcedures are missed if Hmaster startup happens after Meta assign
Zach York created HBASE-24923: - Summary: Running InitMetaProcedures are missed if Hmaster startup happens after Meta assign Key: HBASE-24923 URL: https://issues.apache.org/jira/browse/HBASE-24923 Project: HBase Issue Type: Bug Affects Versions: 3.0.0-alpha-1 Reporter: Zach York In HMaster startup, if the InitMetaProcedure was stopped after the meta assign stage, it will have a RegionState assigned to it and will not fall into this if statement: https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1044. This means if an InitMetaProcedure is running (in the INIT_META_CREATE_NAMESPACES state), we won't look for any instances of running InitMetaProcedures and won't correctly await until they are done: https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1065 The check for running InitMetaProcedures should be moved outside of the if statement and only if it is null should it try to add a new InitMetaProcedure (if there is no RegionState for meta or if meta is offline). This way we will correctly wait for procedures that are running that have passed the INIT_META_ASSIGN_META state (which sets the RegionStates that HMaster is looking at). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ankitjain64 commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.
ankitjain64 commented on a change in pull request #2284:
URL: https://github.com/apache/hbase/pull/2284#discussion_r474343617
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -60,6 +60,7 @@
public final class ReplicationPeerConfigUtil {
private static final Logger LOG =
LoggerFactory.getLogger(ReplicationPeerConfigUtil.class);
+ public static final String HBASE_REPLICATION_PEER_DEFAULT_CONFIG=
"hbase.replication.peer.default.config";
Review comment:
Updated in the latest commit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (HBASE-24922) InitMetaProcedure create Namespace is not Idempotent
Zach York created HBASE-24922: - Summary: InitMetaProcedure create Namespace is not Idempotent Key: HBASE-24922 URL: https://issues.apache.org/jira/browse/HBASE-24922 Project: HBase Issue Type: Bug Components: meta, Region Assignment Affects Versions: 3.0.0-alpha-1 Reporter: Zach York If InitMetaProcedure is retried after creating at least one namespace directory: https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/InitMetaProcedure.java#L115, it will not be able to recover as the procedure does not check for existence of the directories before attempting to create them. We should check for existence of the directory first and only execute createDirectories if they do not exist. The rest of the procedure looks like it is idempotent. We can additionally optimize to not overwrite the column families. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated HBASE-24764: --- Description: Today, if a user needs to apply some common base peer configs to all the replication peers on a given cluster, the only way is to execute update_peer_config via CLI which requires manual intervention and can be tedious in case of large deployment fleet. As part of this JIRA, we plan to add the support to have base replication peer configs as part of hbase-site.xml like hbase.replication.peer.base.config="k1=v1;k2=v2.." which can be easily updated and applied as part of a rolling restart. Example below: hbase.replication.peer.base.configs hbase.replication.source.custom.walentryfilters=x,y,z;hbase.rpc.protection=abc;hbase.xxx.custom_property=123 This will be empty by default, but one can override to have base configs in place. The final peer configuration would be a merge of this newly added base config + whatever users override during the peer creation/update (if any). Related Jira: https://issues.apache.org/jira/browse/HBASE-17543. HBASE-17543 added the support to add the WALEntryFilters to default endpoint via peer configuration. By this new Jira we are extending the support to update peer configs via hbase-site.xml. was: Today, if a user needs to apply some common base peer configs to all the replication peers the only way is to execute update_peer_config via CLI which requires manual intervention and can be tedious in case of large deployment fleet. As part of this JIRA, we plan to add the support to have base replication peer configs as part of hbase-site.xml like hbase.replication.peer.base.config="k1=v1;k2=v2.." which can be easily updated and applied as part of a rolling restart. Example below: hbase.replication.peer.base.configs hbase.replication.source.custom.walentryfilters=x,y,z;hbase.rpc.protection=abc;hbase.xxx.custom_property=123 This will be empty by default, but one can override to have base configs in place. The final peer configuration would be a merge of this newly added base config + whatever users override during the peer creation/update (if any). Related Jira: https://issues.apache.org/jira/browse/HBASE-17543. HBASE-17543 added the support to add the WALEntryFilters to default endpoint via peer configuration. By this new Jira we are extending the support to update peer configs via hbase-site.xml. > Add support of adding base peer configs via hbase-site.xml for all > replication peers. > - > > Key: HBASE-24764 > URL: https://issues.apache.org/jira/browse/HBASE-24764 > Project: HBase > Issue Type: Improvement >Reporter: Ankit Jain >Assignee: Ankit Jain >Priority: Minor > Attachments: HBASE-24764-master.patch > > > Today, if a user needs to apply some common base peer configs to all the > replication peers on a given cluster, the only way is to execute > update_peer_config via CLI which requires manual intervention and can be > tedious in case of large deployment fleet. > As part of this JIRA, we plan to add the support to have base replication > peer configs as part of hbase-site.xml like > hbase.replication.peer.base.config="k1=v1;k2=v2.." which can be easily > updated and applied as part of a rolling restart. Example below: > > hbase.replication.peer.base.configs > > hbase.replication.source.custom.walentryfilters=x,y,z;hbase.rpc.protection=abc;hbase.xxx.custom_property=123 > > This will be empty by default, but one can override to have base configs in > place. > The final peer configuration would be a merge of this newly added base config > + whatever users override during the peer creation/update (if any). > Related Jira: https://issues.apache.org/jira/browse/HBASE-17543. HBASE-17543 > added the support to add the WALEntryFilters to default endpoint via peer > configuration. By this new Jira we are extending the support to update peer > configs via hbase-site.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated HBASE-24764: --- Description: Today, if a user needs to apply some common base peer configs to all the replication peers the only way is to execute update_peer_config via CLI which requires manual intervention and can be tedious in case of large deployment fleet. As part of this JIRA, we plan to add the support to have base replication peer configs as part of hbase-site.xml like hbase.replication.peer.base.config="k1=v1;k2=v2.." which can be easily updated and applied as part of a rolling restart. Example below: hbase.replication.peer.base.configs hbase.replication.source.custom.walentryfilters=x,y,z;hbase.rpc.protection=abc;hbase.xxx.custom_property=123 This will be empty by default, but one can override to have base configs in place. The final peer configuration would be a merge of this newly added base config + whatever users override during the peer creation/update (if any). Related Jira: https://issues.apache.org/jira/browse/HBASE-17543. HBASE-17543 added the support to add the WALEntryFilters to default endpoint via peer configuration. By this new Jira we are extending the support to update peer configs via hbase-site.xml. was: Currently, if a user needs to apply some common peer configs to all the default replication peers, the only way is to execute update_peer_config via CLI which requires manual intervention and can be tedious in case of large deployment fleet. As part of this JIRA, we plan to add the support to have default replication peer configs as part of hbase-site.xml like hbase.replication.peer.default.config="k1=v1;k2=v2.." which can be just applied by a rolling restart. Example below: hbase.replication.peer.default.configs hbase.replication.source.custom.walentryfilters=x,y,z;hbase.rpc.protection=abc;hbase.xxx.custom_property=123 This will be empty by default, but one can override to have default configs in place. The final peer configuration would be a merge of this default config + whatever users override during the peer creation/update (if any). Related Jira: https://issues.apache.org/jira/browse/HBASE-17543. HBASE-17543 added the support to add the WALEntryFilters to default endpoint via peer configuration. By this new Jira we are extending the support to update peer configs via hbase-site.xml. > Add support of adding base peer configs via hbase-site.xml for all > replication peers. > - > > Key: HBASE-24764 > URL: https://issues.apache.org/jira/browse/HBASE-24764 > Project: HBase > Issue Type: Improvement >Reporter: Ankit Jain >Assignee: Ankit Jain >Priority: Minor > Attachments: HBASE-24764-master.patch > > > Today, if a user needs to apply some common base peer configs to all the > replication peers the only way is to execute update_peer_config via CLI which > requires manual intervention and can be tedious in case of large deployment > fleet. > As part of this JIRA, we plan to add the support to have base replication > peer configs as part of hbase-site.xml like > hbase.replication.peer.base.config="k1=v1;k2=v2.." which can be easily > updated and applied as part of a rolling restart. Example below: > > hbase.replication.peer.base.configs > > hbase.replication.source.custom.walentryfilters=x,y,z;hbase.rpc.protection=abc;hbase.xxx.custom_property=123 > > This will be empty by default, but one can override to have base configs in > place. > The final peer configuration would be a merge of this newly added base config > + whatever users override during the peer creation/update (if any). > Related Jira: https://issues.apache.org/jira/browse/HBASE-17543. HBASE-17543 > added the support to add the WALEntryFilters to default endpoint via peer > configuration. By this new Jira we are extending the support to update peer > configs via hbase-site.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain updated HBASE-24764: --- Summary: Add support of adding base peer configs via hbase-site.xml for all replication peers. (was: Add support of adding default peer configs via hbase-site.xml for all replication peers.) > Add support of adding base peer configs via hbase-site.xml for all > replication peers. > - > > Key: HBASE-24764 > URL: https://issues.apache.org/jira/browse/HBASE-24764 > Project: HBase > Issue Type: Improvement >Reporter: Ankit Jain >Assignee: Ankit Jain >Priority: Minor > Attachments: HBASE-24764-master.patch > > > Currently, if a user needs to apply some common peer configs to all the > default replication peers, the only way is to execute update_peer_config via > CLI which requires manual intervention and can be tedious in case of large > deployment fleet. > As part of this JIRA, we plan to add the support to have default replication > peer configs as part of hbase-site.xml like > hbase.replication.peer.default.config="k1=v1;k2=v2.." which can be just > applied by a rolling restart. Example below: > > hbase.replication.peer.default.configs > hbase.replication.source.custom.walentryfilters=x,y,z;hbase.rpc.protection=abc;hbase.xxx.custom_property=123 > > This will be empty by default, but one can override to have default configs > in place. > The final peer configuration would be a merge of this default config + > whatever users override during the peer creation/update (if any). > Related Jira: https://issues.apache.org/jira/browse/HBASE-17543. HBASE-17543 > added the support to add the WALEntryFilters to default endpoint via peer > configuration. By this new Jira we are extending the support to update peer > configs via hbase-site.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] z-york commented on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …
z-york commented on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-677947479 I am currently -1 on the implementation pending answers to my questions. I have not been able to find any valid failure modes that will cause data loss or corrupting actions if hbase:meta is onlined. If this is true, we can make InitMetaProcedure idempotent (see above) and we can handle any InitMetaProcedure failure condition. In my investigation I was actually looking at the master branch which contains an additional state for INIT_META_CREATE_NAMESPACES. There are additional bugs associated with this approach that I will open JIRAs for. I will not bring the additional complexity of folding the namespace table into the meta table into this discussion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2277: HBASE-24906 Enlarge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic
Apache-HBase commented on pull request #2277: URL: https://github.com/apache/hbase/pull/2277#issuecomment-677945395 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. | ||| _ branch-2.2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 19s | branch-2.2 passed | | +1 :green_heart: | compile | 0m 55s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 1m 18s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 4m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | branch-2.2 passed | | +0 :ok: | spotbugs | 3m 30s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 28s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 52s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | checkstyle | 1m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 3m 56s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 25m 22s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | | +1 :green_heart: | findbugs | 3m 27s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 293m 2s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 1m 0s | The patch does not generate ASF License warnings. | | | | 353m 28s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.tool.TestLoadIncrementalHFiles | | | hadoop.hbase.client.replication.TestReplicationAdminWithClusters | | | hadoop.hbase.tool.TestSecureLoadIncrementalHFiles | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2277/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2277 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 544e86a10ca0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2277/out/precommit/personality/provided.sh | | git revision | branch-2.2 / 3f10933bf9 | | Default Java | 1.8.0_181 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2277/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2277/4/testReport/ | | Max. process+thread count | 2889 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2277/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24920) A tool to rewrite corrupted HFiles
[ https://issues.apache.org/jira/browse/HBASE-24920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181487#comment-17181487 ] Michael Stack commented on HBASE-24920: --- Sounds like a good plan to me [~timoha] > A tool to rewrite corrupted HFiles > -- > > Key: HBASE-24920 > URL: https://issues.apache.org/jira/browse/HBASE-24920 > Project: HBase > Issue Type: Brainstorming > Components: hbase-operator-tools >Reporter: Andrey Elenskiy >Priority: Major > > Typically I have been dealing with corrupted HFiles (due to loss of hdfs > blocks) by just removing them. However, It always seemed wasteful to throw > away the entire HFile (which can be hundreds of gigabytes), just because one > hdfs block is missing (128MB). > I think there's a possibility for a tool that can rewrite an HFile by > skipping corrupted blocks. > There can be multiple types of issues with hdfs blocks but any of them can be > treated as if the block doesn't exist: > 1. All the replicas can be lost > 2. The block can be corrupted due to some bug in hdfs (I've recently run into > HDFS-15186 by experimenting with EC). > At the simplest the tool can be a local mapreduce job (mapper only) with a > custom HFile reader input that can seek to next DATABLK to skip corrupted > hdfs blocks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.
saintstack commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-677934075 Is there any place this nice new facility is documented? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.
saintstack commented on a change in pull request #2284:
URL: https://github.com/apache/hbase/pull/2284#discussion_r474300228
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -60,6 +60,7 @@
public final class ReplicationPeerConfigUtil {
private static final Logger LOG =
LoggerFactory.getLogger(ReplicationPeerConfigUtil.class);
+ public static final String HBASE_REPLICATION_PEER_DEFAULT_CONFIG=
"hbase.replication.peer.default.config";
Review comment:
Is this 'default' or 'base' configuration for all peers?
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -450,6 +451,45 @@ public static ReplicationPeerConfig
appendTableCFsToReplicationPeerConfig(
return builder.build();
}
+ /**
+ Sample Configuration
+
+ hbase.replication.peer.default.configs
+
hbase.replication.source.custom.walentryfilters=x,y,z;hbase.xxx.custom_property=123
+
+ */
+
+ /**
+ * Helper method to add default peer configs from HBase Configuration to
ReplicationPeerConfig
+ * @param conf Configuration
+ * @return true if new configurations was added.
+ */
+ public static ReplicationPeerConfig
addDefaultPeerConfigsIfNotPresent(Configuration conf, ReplicationPeerConfig
receivedPeerConfig){
+
+ReplicationPeerConfigBuilder copiedPeerConfigBuilder =
ReplicationPeerConfig.newBuilder(receivedPeerConfig);
+String defaultPeerConfigs =
conf.get(HBASE_REPLICATION_PEER_DEFAULT_CONFIG);
+
+Map peerConfigurations =
receivedPeerConfig.getConfiguration();
+
+if(defaultPeerConfigs != null && defaultPeerConfigs.length() != 0){
Review comment:
See how rest of code has space between keyword and brackets as in 'if ('
rather than 'if(' you do this a few times in this PR.
##
File path:
hbase-replication/src/test/java/org/apache/hadoop/hbase/replication/TestZKReplicationPeerStorage.java
##
@@ -215,4 +218,40 @@ public void testNoSyncReplicationState()
assertNotEquals(-1, ZKUtil.checkExists(UTIL.getZooKeeperWatcher(),
STORAGE.getNewSyncReplicationStateNode(peerId)));
}
+
+ @Test
+ public void testDefaultReplicationPeerConfigIsAppliedIfNotAlreadySet(){
+String customPeerConfigKey = "hbase.xxx.custom_config";
+String customPeerConfigValue = "test";
+
+ReplicationPeerConfig existingReplicationPeerConfig = getConfig(1);
+
+// custom config not present
+
assertEquals(existingReplicationPeerConfig.getConfiguration().get(customPeerConfigKey),
null);
+
+Configuration conf = UTIL.getConfiguration();
+conf.set(ReplicationPeerConfigUtil.HBASE_REPLICATION_PEER_DEFAULT_CONFIG,
+ customPeerConfigKey.concat("=").concat(customPeerConfigValue));
+
+ReplicationPeerConfig updatedReplicationPeerConfig =
ReplicationPeerConfigUtil.addDefaultPeerConfigsIfNotPresent(conf,existingReplicationPeerConfig);
Review comment:
Long lines? 100chars is max.
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java
##
@@ -450,6 +451,45 @@ public static ReplicationPeerConfig
appendTableCFsToReplicationPeerConfig(
return builder.build();
}
+ /**
+ Sample Configuration
+
+ hbase.replication.peer.default.configs
+
hbase.replication.source.custom.walentryfilters=x,y,z;hbase.xxx.custom_property=123
+
+ */
+
+ /**
+ * Helper method to add default peer configs from HBase Configuration to
ReplicationPeerConfig
+ * @param conf Configuration
+ * @return true if new configurations was added.
+ */
+ public static ReplicationPeerConfig
addDefaultPeerConfigsIfNotPresent(Configuration conf, ReplicationPeerConfig
receivedPeerConfig){
+
+ReplicationPeerConfigBuilder copiedPeerConfigBuilder =
ReplicationPeerConfig.newBuilder(receivedPeerConfig);
+String defaultPeerConfigs =
conf.get(HBASE_REPLICATION_PEER_DEFAULT_CONFIG);
+
+Map peerConfigurations =
receivedPeerConfig.getConfiguration();
+
+if(defaultPeerConfigs != null && defaultPeerConfigs.length() != 0){
+ String[] defaultPeerConfigList = defaultPeerConfigs.split(";");
Review comment:
';' is safe character to use as delimiter for sure? Will never be part
of a config value? Are the constraint on peer values at all so you could choose
a delimiter that was outside of the constraint set?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private
saintstack commented on pull request #2289: URL: https://github.com/apache/hbase/pull/2289#issuecomment-677928202 @bharathv my fault... loaded but not committed. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer
saintstack commented on pull request #2286: URL: https://github.com/apache/hbase/pull/2286#issuecomment-677927003 Oh, want to say why you are making these changes? You having port clashes running tests? What is the difference in test time after these changes? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private
bharathv commented on pull request #2289: URL: https://github.com/apache/hbase/pull/2289#issuecomment-677927169 @saintstack Looks like the push didn't address the comments or is it just me? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer
saintstack commented on a change in pull request #2286:
URL: https://github.com/apache/hbase/pull/2286#discussion_r474293872
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXConnectorServer.java
##
@@ -56,39 +58,47 @@
private static Configuration conf = null;
private static Admin admin;
// RMI registry port
- private static int rmiRegistryPort = 61120;
+ private static int rmiRegistryPort;
// Switch for customized Accesscontroller to throw ACD exception while
executing test case
- static boolean hasAccess;
+ private volatile static boolean hasAccess;
- @Before
- public void setUp() throws Exception {
-UTIL = new HBaseTestingUtility();
+ @BeforeClass
+ public static void setUpBeforeClass() throws Exception {
conf = UTIL.getConfiguration();
+String cps = JMXListener.class.getName() + "," +
MyAccessController.class.getName();
+conf.set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY, cps);
+conf.set(CoprocessorHost.REGIONSERVER_COPROCESSOR_CONF_KEY, cps);
+rmiRegistryPort = UTIL.randomFreePort();
Review comment:
While the port might have been 'free' when we got it, by the time we go
to use it, it may have been occupied for another. See
HBaseTestingUtility#setupMiniKdc where it loops until no BindException. This
trick is used in a few places to get around port clash.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24920) A tool to rewrite corrupted HFiles
[ https://issues.apache.org/jira/browse/HBASE-24920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181463#comment-17181463 ] Andrey Elenskiy commented on HBASE-24920: - I currently like that `hbase hfile` is read only and allows to debug things (I use it for debugging the corrupt blocks at the moment), the name of the class is even HFilePrettyPrinter. On the mailing list Sean suggested to put it in the repo with `hbase-operator-tools` and I prefer that as it aligns better with the goal of that repo (correct bugs/inconsistencies via operator intervention). What do you think? > A tool to rewrite corrupted HFiles > -- > > Key: HBASE-24920 > URL: https://issues.apache.org/jira/browse/HBASE-24920 > Project: HBase > Issue Type: Brainstorming > Components: hbase-operator-tools >Reporter: Andrey Elenskiy >Priority: Major > > Typically I have been dealing with corrupted HFiles (due to loss of hdfs > blocks) by just removing them. However, It always seemed wasteful to throw > away the entire HFile (which can be hundreds of gigabytes), just because one > hdfs block is missing (128MB). > I think there's a possibility for a tool that can rewrite an HFile by > skipping corrupted blocks. > There can be multiple types of issues with hdfs blocks but any of them can be > treated as if the block doesn't exist: > 1. All the replicas can be lost > 2. The block can be corrupted due to some bug in hdfs (I've recently run into > HDFS-15186 by experimenting with EC). > At the simplest the tool can be a local mapreduce job (mapper only) with a > custom HFile reader input that can seek to next DATABLK to skip corrupted > hdfs blocks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24914) Remove duplicate code appearing continuously in method ReplicationPeerManager.updatePeerConfig
[
https://issues.apache.org/jira/browse/HBASE-24914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-24914.
---
Hadoop Flags: Reviewed
Resolution: Fixed
Merged PR. Thanks for the fix [~Ddupg]
> Remove duplicate code appearing continuously in method
> ReplicationPeerManager.updatePeerConfig
> --
>
> Key: HBASE-24914
> URL: https://issues.apache.org/jira/browse/HBASE-24914
> Project: HBase
> Issue Type: Improvement
> Components: Replication
>Affects Versions: 3.0.0-alpha-1
>Reporter: Sun Xin
>Assignee: Sun Xin
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> In
> [ReplicationPeerManager.updatePeerConfig|https://github.com/apache/hbase/blob/1164531d5ab519ab58af82ba3849f8fcded3453f/hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java#L272],
> I found duplicate code appearing twice continuously, so remove once.
> {code:java}
> newPeerConfigBuilder.putAllConfiguration(oldPeerConfig.getConfiguration());
> newPeerConfigBuilder.putAllConfiguration(peerConfig.getConfiguration());
> newPeerConfigBuilder.putAllConfiguration(oldPeerConfig.getConfiguration());
> newPeerConfigBuilder.putAllConfiguration(peerConfig.getConfiguration());
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack merged pull request #2287: HBASE-24914 Remove duplicate code appearing continuously in method Re…
saintstack merged pull request #2287: URL: https://github.com/apache/hbase/pull/2287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType
saintstack commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-677921557 The patch looks fine. My question is same as @virajjasani `...should have some benefits.` Can you quantify at all? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private
saintstack commented on a change in pull request #2289:
URL: https://github.com/apache/hbase/pull/2289#discussion_r474285921
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java
##
@@ -69,7 +66,15 @@
*/
@InterfaceAudience.Public
public interface RegionInfo extends Comparable {
- RegionInfo UNDEFINED =
RegionInfoBuilder.newBuilder(TableName.valueOf("__UNDEFINED__")).build();
+ /**
+ * @deprecated since 2.3.2/3.0.0; to be removed in 4.0.0 with no replacement
(for internal use).
+ */
+ @Deprecated
+ @InterfaceAudience.Private
+ // Not using RegionInfoBuilder intentionally to avoid a static loading
deadlock: HBASE-24627
Review comment:
Makes sense.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private
saintstack commented on pull request #2289: URL: https://github.com/apache/hbase/pull/2289#issuecomment-677918456 Push addresses @bharathv review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private
saintstack commented on a change in pull request #2289:
URL: https://github.com/apache/hbase/pull/2289#discussion_r474286032
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java
##
@@ -69,7 +66,15 @@
*/
@InterfaceAudience.Public
public interface RegionInfo extends Comparable {
- RegionInfo UNDEFINED =
RegionInfoBuilder.newBuilder(TableName.valueOf("__UNDEFINED__")).build();
+ /**
+ * @deprecated since 2.3.2/3.0.0; to be removed in 4.0.0 with no replacement
(for internal use).
+ */
+ @Deprecated
+ @InterfaceAudience.Private
+ // Not using RegionInfoBuilder intentionally to avoid a static loading
deadlock: HBASE-24627
+ RegionInfo UNDEFINED = new MutableRegionInfo(0,
TableName.valueOf("__UNDEFINED__"),
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] bharathv commented on a change in pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private
bharathv commented on a change in pull request #2289:
URL: https://github.com/apache/hbase/pull/2289#discussion_r474275214
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java
##
@@ -69,7 +66,15 @@
*/
@InterfaceAudience.Public
public interface RegionInfo extends Comparable {
- RegionInfo UNDEFINED =
RegionInfoBuilder.newBuilder(TableName.valueOf("__UNDEFINED__")).build();
+ /**
+ * @deprecated since 2.3.2/3.0.0; to be removed in 4.0.0 with no replacement
(for internal use).
+ */
+ @Deprecated
+ @InterfaceAudience.Private
+ // Not using RegionInfoBuilder intentionally to avoid a static loading
deadlock: HBASE-24627
+ RegionInfo UNDEFINED = new MutableRegionInfo(0,
TableName.valueOf("__UNDEFINED__"),
Review comment:
Switch back to RegionInfoBuilder? (same below?)
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java
##
@@ -69,7 +66,15 @@
*/
@InterfaceAudience.Public
public interface RegionInfo extends Comparable {
- RegionInfo UNDEFINED =
RegionInfoBuilder.newBuilder(TableName.valueOf("__UNDEFINED__")).build();
+ /**
+ * @deprecated since 2.3.2/3.0.0; to be removed in 4.0.0 with no replacement
(for internal use).
+ */
+ @Deprecated
+ @InterfaceAudience.Private
+ // Not using RegionInfoBuilder intentionally to avoid a static loading
deadlock: HBASE-24627
Review comment:
I think this statement can be omitted since this is being handled
separately in the parent task.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24920) A tool to rewrite corrupted HFiles
[ https://issues.apache.org/jira/browse/HBASE-24920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181449#comment-17181449 ] Michael Stack commented on HBASE-24920: --- Do you think it would be an option on [http://hbase.apache.org/book.html#hfile_tool] [~timoha] ? > A tool to rewrite corrupted HFiles > -- > > Key: HBASE-24920 > URL: https://issues.apache.org/jira/browse/HBASE-24920 > Project: HBase > Issue Type: Brainstorming > Components: hbase-operator-tools >Reporter: Andrey Elenskiy >Priority: Major > > Typically I have been dealing with corrupted HFiles (due to loss of hdfs > blocks) by just removing them. However, It always seemed wasteful to throw > away the entire HFile (which can be hundreds of gigabytes), just because one > hdfs block is missing (128MB). > I think there's a possibility for a tool that can rewrite an HFile by > skipping corrupted blocks. > There can be multiple types of issues with hdfs blocks but any of them can be > treated as if the block doesn't exist: > 1. All the replicas can be lost > 2. The block can be corrupted due to some bug in hdfs (I've recently run into > HDFS-15186 by experimenting with EC). > At the simplest the tool can be a local mapreduce job (mapper only) with a > custom HFile reader input that can seek to next DATABLK to skip corrupted > hdfs blocks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2287: HBASE-24914 Remove duplicate code appearing continuously in method Re…
Apache-HBase commented on pull request #2287: URL: https://github.com/apache/hbase/pull/2287#issuecomment-677902114 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | master passed | | +1 :green_heart: | compile | 1m 10s | master passed | | +1 :green_heart: | shadedjars | 6m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 19s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | +1 :green_heart: | shadedjars | 6m 39s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 216m 34s | hbase-server in the patch passed. | | | | 244m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2287 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fca47fce5381 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e98182aa6 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/3/testReport/ | | Max. process+thread count | 3112 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24921) Add help output for shell "magic" commands
Nick Dimiduk created HBASE-24921:
Summary: Add help output for shell "magic" commands
Key: HBASE-24921
URL: https://issues.apache.org/jira/browse/HBASE-24921
Project: HBase
Issue Type: Improvement
Components: shell
Reporter: Nick Dimiduk
The shell has a handful of "magic" commands, things like {{help}} and
{{debug}}, that exist as commands in the shell, but are not implementations of
the command class and have no help documentation of their own.
Let's promote them to proper commands, add a new command group, call it "shell
command group", for example. This makes them discoverable. Give each of them a
help documentation string with examples, as we have for the others, i.e.,
{{help 'help'}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2287: HBASE-24914 Remove duplicate code appearing continuously in method Re…
Apache-HBase commented on pull request #2287: URL: https://github.com/apache/hbase/pull/2287#issuecomment-677889878 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 44s | master passed | | +1 :green_heart: | compile | 1m 11s | master passed | | +1 :green_heart: | shadedjars | 6m 25s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 44s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 30s | the patch passed | | +1 :green_heart: | compile | 1m 10s | the patch passed | | +1 :green_heart: | javac | 1m 10s | the patch passed | | +1 :green_heart: | shadedjars | 6m 21s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 190m 0s | hbase-server in the patch passed. | | | | 218m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2287 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 53e4366288b1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e98182aa6 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/3/testReport/ | | Max. process+thread count | 3500 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24920) A tool to rewrite corrupted HFiles
Andrey Elenskiy created HBASE-24920: --- Summary: A tool to rewrite corrupted HFiles Key: HBASE-24920 URL: https://issues.apache.org/jira/browse/HBASE-24920 Project: HBase Issue Type: Brainstorming Components: hbase-operator-tools Reporter: Andrey Elenskiy Typically I have been dealing with corrupted HFiles (due to loss of hdfs blocks) by just removing them. However, It always seemed wasteful to throw away the entire HFile (which can be hundreds of gigabytes), just because one hdfs block is missing (128MB). I think there's a possibility for a tool that can rewrite an HFile by skipping corrupted blocks. There can be multiple types of issues with hdfs blocks but any of them can be treated as if the block doesn't exist: 1. All the replicas can be lost 2. The block can be corrupted due to some bug in hdfs (I've recently run into HDFS-15186 by experimenting with EC). At the simplest the tool can be a local mapreduce job (mapper only) with a custom HFile reader input that can seek to next DATABLK to skip corrupted hdfs blocks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24919) A tool to rewrite corrupted HFiles
Andrey Elenskiy created HBASE-24919: --- Summary: A tool to rewrite corrupted HFiles Key: HBASE-24919 URL: https://issues.apache.org/jira/browse/HBASE-24919 Project: HBase Issue Type: Brainstorming Components: hbase-operator-tools Reporter: Andrey Elenskiy Typically I have been dealing with corrupted HFiles (due to loss of hdfs blocks) by just removing them. However, It always seemed wasteful to throw away the entire HFile (which can be hundreds of gigabytes), just because one hdfs block is missing (128MB). I think there's a possibility for a tool that can rewrite an HFile by skipping corrupted blocks. There can be multiple types of issues with hdfs blocks but any of them can be treated as if the block doesn't exist: 1. All the replicas can be lost 2. The block can be corrupted due to some bug in hdfs (I've recently run into HDFS-15186 by experimenting with EC). At the simplest the tool can be a local mapreduce job (mapper only) with a custom HFile reader input that can seek to next DATABLK to skip corrupted hdfs blocks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bitoffdev commented on a change in pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter
bitoffdev commented on a change in pull request #2282: URL: https://github.com/apache/hbase/pull/2282#discussion_r474205155 ## File path: hbase-shell/src/main/ruby/shell/formatter.rb ## @@ -192,6 +199,56 @@ def footer(row_count = nil, is_stale = false) end end +# Base abstract class for results formatting. Review comment: I decided to remove the adapter class in the patch update I just pushed. I think it will be better for people to explicitly choose to use TableFormatter. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bitoffdev commented on a change in pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter
bitoffdev commented on a change in pull request #2282:
URL: https://github.com/apache/hbase/pull/2282#discussion_r474204114
##
File path: hbase-shell/src/main/ruby/shell/commands/list_peers.rb
##
@@ -38,10 +38,10 @@ def help
def command
peers = replication_admin.list_peers
-formatter.header(%w[PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME
+table_formatter.start_table({ num_cols: 11, headers: %w[PEER_ID
CLUSTER_KEY ENDPOINT_CLASSNAME
Review comment:
`num_cols` isn't needed. It is derived from headers and widths by
TableFormatter. I just updated the patch to remove `num_cols` from all the
places that unnecessarily specified it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-677838306 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 43s | master passed | | +1 :green_heart: | compile | 2m 38s | master passed | | +1 :green_heart: | shadedjars | 7m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 5m 37s | master passed | | -0 :warning: | patch | 14m 13s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 30s | the patch passed | | +1 :green_heart: | compile | 2m 37s | the patch passed | | +1 :green_heart: | javac | 2m 37s | the patch passed | | +1 :green_heart: | shadedjars | 7m 55s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 55s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 284m 33s | root in the patch failed. | | | | 329m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2261 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d48e04bbd23f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1164531d5a | | Default Java | 1.8.0_232 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/testReport/ | | Max. process+thread count | 4807 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-common hbase-hadoop-compat hbase-client hbase-server hbase-thrift hbase-shell . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private
saintstack commented on pull request #2289: URL: https://github.com/apache/hbase/pull/2289#issuecomment-677831251 This patch is same as last PR attached to HBASE-24896 only no claims it fixes HBASE-24896It is deprecation, annotation, and moving an inner-class out to be standalone only. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack opened a new pull request #2289: HBASE-24918 Make RegionInfo#UNDEFINED IA.Private
saintstack opened a new pull request #2289: URL: https://github.com/apache/hbase/pull/2289 Mark RegionInfo#UNDEFINED IA.Private and deprecated; it is for internal use only and likely to be removed in hbase4. Move MutableRegionInfo out of RegionInfoBuilder and have it as a stanadlone task; a nice-to-have. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24918) Make RegionInfo#UNDEFINED IA.Private
Michael Stack created HBASE-24918: - Summary: Make RegionInfo#UNDEFINED IA.Private Key: HBASE-24918 URL: https://issues.apache.org/jira/browse/HBASE-24918 Project: HBase Issue Type: Sub-task Affects Versions: 2.4.0, 2.3.2 Reporter: Michael Stack Assignee: Michael Stack Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2 >From review of parent PR, RI#UNDEFINED is for internal use only... note it w/ >a IA.Private marking. Also deprecate it so we have option to remove as its >loading implicated in the parent issue static load deadlock. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24896) 'Stuck' in static initialization creating RegionInfo instance
[
https://issues.apache.org/jira/browse/HBASE-24896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181370#comment-17181370
]
Michael Stack commented on HBASE-24896:
---
Update. Helpful back and forth on PR entertaining different possible fixes but
I need to repro the issue so can say for certain if an approach fixes the
problem first. This pointer via [~bharathv] was particularly useful
https://docs.oracle.com/javase/specs/jls/se8/html/jls-12.html#jls-12.4.2
Meantime, filing subissue to make the problematic RI.UNDEFINED IA.Private as
suggested in review will move MRI out of RIB since nice-to-have.
> 'Stuck' in static initialization creating RegionInfo instance
> -
>
> Key: HBASE-24896
> URL: https://issues.apache.org/jira/browse/HBASE-24896
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.3.1
>Reporter: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.2
>
> Attachments: hbasedn192-jstack-0.webarchive,
> hbasedn192-jstack-1.webarchive, hbasedn192-jstack-2.webarchive
>
>
> We ran into the following deadlocked server in testing. The priority handlers
> seem stuck across multiple thread dumps. Seven of the ten total priority
> threads have this state:
> {code:java}
> "RpcServer.priority.RWQ.Fifo.read.handler=5,queue=1,port=16020" #82 daemon
> prio=5 os_prio=0 cpu=0.70ms elapsed=315627.86s allocated=3744B
> defined_classes=0 tid=0x7f3da0983040 nid=0x62d9 in Object.wait()
> [0x7f3d9bc8c000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3327)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1491)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.newRegionScanner(RSRpcServices.java:3143)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3478)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:44858)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)
> {code}
> The anomalous three are as follows:
> h3. #1
> {code:java}
> "RpcServer.priority.RWQ.Fifo.write.handler=0,queue=0,port=16020" #77 daemon
> prio=5 os_prio=0 cpu=175.98ms elapsed=315627.86s allocated=2153K
> defined_classes=14 tid=0x7f3da0ae6ec0 nid=0x62d4 in Object.wait()
> [0x7f3d9c19]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.hadoop.hbase.client.RegionInfo.(RegionInfo.java:72)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3327)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1491)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2912)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:44856)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318){code}
> ...which is the creation of the UNDEFINED in RegionInfo here:
> {color:#808000}@InterfaceAudience.Public{color}{color:#80}public
> interface {color}RegionInfo {color:#80}extends
> {color}Comparable {
> RegionInfo {color:#660e7a}UNDEFINED {color}=
> RegionInfoBuilder.newBuilder(TableName.valueOf({color:#008000}"__UNDEFINED__"{color})).build();
>
> h3. #2
> {code:java}
> "RpcServer.priority.RWQ.Fifo.read.handler=4,queue=1,port=16020" #81 daemon
> prio=5 os_prio=0 cpu=53.85ms elapsed=315627.86s allocated=81984B
> defined_classes=3 tid=0x7f3da0981590 nid=0x62d8 in Object.wait()
> [0x7f3d9bd8c000]
>java.lang.Thread.State: RUNNABLE
> at
> org.apache.hadoop.hbase.client.RegionInfoBuilder.(RegionInfoBuilder.java:49)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toRegionInfo(ProtobufUtil.java:3231)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.executeOpenRegionProcedures(RSRpcServices.java:3755)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.lambda$executeProcedures$2(RSRpcServices.java:3827)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices$$Lambda$173/0x0017c0e40040.accept(Unknown
>
[GitHub] [hbase] saintstack commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…
saintstack commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677814307 Thats for the helpful pointer @bharathv and your input. Given the above discussion and my not wanting to waste valuable review resource, I think I need to reproduce this issue so can say for sure whether an approach works; I speculate too much overusing the 'hard-to-reproduce' license. Let me add the IA.Private and the deprecation per @Apache9 suggests in a separate issue for now at least while I figure how to repro. the lockup. Thank you for reviews @bharathv , @virajjasani , and @Apache9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType
Apache-HBase commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-677806452 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 10s | master passed | | +1 :green_heart: | compile | 1m 2s | master passed | | +1 :green_heart: | shadedjars | 6m 28s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 59s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 6m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 220m 19s | hbase-server in the patch passed. | | | | 247m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2288/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2288 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a221af096464 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1164531d5a | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2288/1/testReport/ | | Max. process+thread count | 3666 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2288/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24917) HBase RSGroup: Table region details under RS Groups are in the onder fromat like HBase 1.x
[ https://issues.apache.org/jira/browse/HBASE-24917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24917: -- Description: HBase RSGroup: Table region details under RS Groups are in the older format like HBase 1.x. in HBase2, Master UI will contain table details ||Namespace||Name||State||Regions||Description|| ||OPEN||OPENING||CLOSED||CLOSING||OFFLINE||FAILED||SPLIT||Other|| but under Regroup, table region details are different which are same as in HBase1.x ||Namespace||Table||Stats||Online Regions||Offline Regions||Failed Regions||Split Regions||Other Regions||Description|| was: HBase RSGroup: Table region details under RS Groups are in the older format like HBase 1.x. in HBase2, Master UI will contain table details ||Namespace||Name||State||Regions||Description|| || || || || || || ||OPEN||OPENING||CLOSED||CLOSING||OFFLINE||FAILED||SPLIT||Other|| but under Regroup, table region details are different which are same as in HBase1.x ||Namespace||Table||Stats||Online Regions||Offline Regions||Failed Regions||Split Regions||Other Regions||Description|| > HBase RSGroup: Table region details under RS Groups are in the onder fromat > like HBase 1.x > -- > > Key: HBASE-24917 > URL: https://issues.apache.org/jira/browse/HBASE-24917 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Priority: Major > > HBase RSGroup: Table region details under RS Groups are in the older format > like HBase 1.x. > > in HBase2, Master UI will contain table details > > > > ||Namespace||Name||State||Regions||Description|| > ||OPEN||OPENING||CLOSED||CLOSING||OFFLINE||FAILED||SPLIT||Other|| > but under Regroup, table region details are different which are same as in > HBase1.x > > ||Namespace||Table||Stats||Online Regions||Offline Regions||Failed > Regions||Split Regions||Other Regions||Description|| -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24917) HBase RSGroup: Table region details under RS Groups are in the onder fromat like HBase 1.x
[ https://issues.apache.org/jira/browse/HBASE-24917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24917: -- Description: HBase RSGroup: Table region details under RS Groups are in the older format like HBase 1.x. in HBase2, Master UI will contain table details ||Namespace||Name||State||Regions||Description|| || || || || || || ||OPEN||OPENING||CLOSED||CLOSING||OFFLINE||FAILED||SPLIT||Other|| but under Regroup, table region details are different which are same as in HBase1.x ||Namespace||Table||Stats||Online Regions||Offline Regions||Failed Regions||Split Regions||Other Regions||Description|| was: HBase RSGroup: Table region details under RS Groups are in the older format like HBase 1.x. in HBase2, Master UI will contain table details ||Namespace||Name||State||Regions||Description|| ||OPEN||OPENING||CLOSED||CLOSING||OFFLINE||FAILED||SPLIT||Other|| but under Regroup, table region details are different which are same as in HBase1.x ||Namespace||Table||Stats||Online Regions||Offline Regions||Failed Regions||Split Regions||Other Regions||Description|| > HBase RSGroup: Table region details under RS Groups are in the onder fromat > like HBase 1.x > -- > > Key: HBASE-24917 > URL: https://issues.apache.org/jira/browse/HBASE-24917 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Priority: Major > > HBase RSGroup: Table region details under RS Groups are in the older format > like HBase 1.x. > > in HBase2, Master UI will contain table details > > ||Namespace||Name||State||Regions||Description|| > || || || || || || > ||OPEN||OPENING||CLOSED||CLOSING||OFFLINE||FAILED||SPLIT||Other|| > > but under Regroup, table region details are different which are same as in > HBase1.x > > ||Namespace||Table||Stats||Online Regions||Offline Regions||Failed > Regions||Split Regions||Other Regions||Description|| -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24917) HBase RSGroup: Table region details under RS Groups are in the onder fromat like HBase 1.x
Ajeet Rai created HBASE-24917: - Summary: HBase RSGroup: Table region details under RS Groups are in the onder fromat like HBase 1.x Key: HBASE-24917 URL: https://issues.apache.org/jira/browse/HBASE-24917 Project: HBase Issue Type: Bug Components: rsgroup Affects Versions: 2.2.3 Reporter: Ajeet Rai HBase RSGroup: Table region details under RS Groups are in the older format like HBase 1.x. in HBase2, Master UI will contain table details ||Namespace||Name||State||Regions||Description|| ||OPEN||OPENING||CLOSED||CLOSING||OFFLINE||FAILED||SPLIT||Other|| but under Regroup, table region details are different which are same as in HBase1.x ||Namespace||Table||Stats||Online Regions||Offline Regions||Failed Regions||Split Regions||Other Regions||Description|| -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2287: HBASE-24914 Remove duplicate code appearing continuously in method Re…
Apache-HBase commented on pull request #2287: URL: https://github.com/apache/hbase/pull/2287#issuecomment-677800330 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | master passed | | +1 :green_heart: | checkstyle | 1m 12s | master passed | | +1 :green_heart: | spotbugs | 2m 8s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 41s | the patch passed | | +1 :green_heart: | checkstyle | 1m 12s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 14s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 35m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2287 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux f5857296e389 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 9e98182aa6 | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on a change in pull request #2130: HBASE-24765: Dynamic master discovery
bharathv commented on a change in pull request #2130:
URL: https://github.com/apache/hbase/pull/2130#discussion_r474150302
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterAddressRefresher.java
##
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.HashSet;
+import java.util.Set;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+import
org.apache.hbase.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder;
+
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos.ClientMetaService;
+
+/**
+ * Thread safe utility that keeps master end points used by {@link
MasterRegistry} up to date. This
+ * uses the RPC {@link ClientMetaService#getMasters} to fetch the latest list
of registered masters.
+ * By default the refresh happens periodically (configured via
+ * {@link #PERIODIC_REFRESH_INTERVAL_SECS}). The refresh can also be triggered
on demand via
+ * {@link #refreshNow()}. To prevent a flood of on-demand refreshes we expect
that any attempts two
+ * should be spaced at least {@link #MIN_SECS_BETWEEN_REFRESHES} seconds apart.
+ */
+@InterfaceAudience.Private
+public class MasterAddressRefresher implements Closeable {
+ private static final Logger LOG =
LoggerFactory.getLogger(MasterAddressRefresher.class);
+ public static final String PERIODIC_REFRESH_INTERVAL_SECS =
+ "hbase.client.master_registry.refresh_interval_secs";
+ private static final int PERIODIC_REFRESH_INTERVAL_SECS_DEFAULT = 300;
+ public static final String MIN_SECS_BETWEEN_REFRESHES =
+ "hbase.client.master_registry.min_secs_between_refreshes";
+ private static final long MIN_SECS_BETWEEN_REFRESHES_DEFAULT = 60;
+
+ private final ExecutorService pool;
+ private final MasterRegistry registry;
+ private final long periodicRefreshMs;
+ private final long timeBetweenRefreshesMs;
+ private final Object refreshMasters = new Object();
+
+ @Override
+ public void close() {
+pool.shutdownNow();
+ }
+
+ /**
+ * Thread that refreshes the master end points until it is interrupted via
{@link #close()}.
+ * Multiple callers attempting to refresh at the same time synchronize on
{@link #refreshMasters}.
+ */
+ private class RefreshThread implements Runnable {
+@Override
+public void run() {
+ long lastRpcTs = 0;
+ while (!Thread.interrupted()) {
+try {
+ // Spurious wake ups are okay, worst case we make an extra RPC call
to refresh. We won't
+ // have duplicate refreshes because once the thread is past the
wait(), notify()s are
+ // ignored until the thread is back to the waiting state.
+ synchronized (refreshMasters) {
+refreshMasters.wait(periodicRefreshMs);
+ }
+ long currentTs = EnvironmentEdgeManager.currentTime();
+ if (lastRpcTs != 0 && currentTs - lastRpcTs <=
timeBetweenRefreshesMs) {
+continue;
+ }
+ lastRpcTs = currentTs;
+ LOG.debug("Attempting to refresh master address end points.");
+ Set newMasters = new
HashSet<>(registry.getMasters().get());
+ registry.populateMasterStubs(newMasters);
+ LOG.debug("Finished refreshing master end points. {}", newMasters);
+} catch (InterruptedException e) {
+ LOG.debug("Interrupted during wait, aborting
refresh-masters-thread.", e);
+ break;
+} catch (ExecutionException | IOException e) {
+ LOG.debug("Error populating latest list of masters.", e);
+}
+ }
+}
+ }
+
+ MasterAddressRefresher(Configuration conf, MasterRegistry registry) {
+pool =
[jira] [Assigned] (HBASE-24916) HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start key is empty
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad reassigned HBASE-24916: --- Assignee: Mohammad Arshad > HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in > meta and start key is empty > --- > > Key: HBASE-24916 > URL: https://issues.apache.org/jira/browse/HBASE-24916 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Assignee: Mohammad Arshad >Priority: Major > > HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in > meta and start key is empty > for hole, it reports two region where hole is present. > Scenario where first region is missing for eg: in below scenario r1 is > missing in meta > start key end key region > empty 10 r1 > 10 20 r2 > 20 30 r2 > 30 empty r3 > > In our test hbck report contains two region where first region belongs to > different table and second region is r2. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24916) HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start key is empty
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24916: -- Description: HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in meta and start key is empty for hole, it reports two region where hole is present. Scenario where first region is missing for eg: in below scenario r1 is missing in meta start key end key region empty 10 r1 10 20 r2 20 30 r2 30 empty r3 In our test hbck report contains two region where first region belongs to another table and second region is r2. was: HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in meta and start key is empty for hole, it reports two region where hole is present. Scenario where first region is missing for eg: in below scenario r1 is missing in meta start key end key region empty 10 r1 10 20 r2 20 30 r2 In our test hbck report contains two region where first region belongs to another table and second region is r2. > HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in > meta and start key is empty > --- > > Key: HBASE-24916 > URL: https://issues.apache.org/jira/browse/HBASE-24916 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Priority: Major > > HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in > meta and start key is empty > for hole, it reports two region where hole is present. > Scenario where first region is missing for eg: in below scenario r1 is > missing in meta > start key end key region > empty 10 r1 > 10 20 r2 > 20 30 r2 > 30 empty r3 > > In our test hbck report contains two region where first region belongs to > another table and second region is r2. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24916) HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start key is empty
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24916: -- Description: HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in meta and start key is empty for hole, it reports two region where hole is present. Scenario where first region is missing for eg: in below scenario r1 is missing in meta start key end key region empty 10 r1 10 20 r2 20 30 r2 30 empty r3 In our test hbck report contains two region where first region belongs to different table and second region is r2. was: HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in meta and start key is empty for hole, it reports two region where hole is present. Scenario where first region is missing for eg: in below scenario r1 is missing in meta start key end key region empty 10 r1 10 20 r2 20 30 r2 30 empty r3 In our test hbck report contains two region where first region belongs to another table and second region is r2. > HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in > meta and start key is empty > --- > > Key: HBASE-24916 > URL: https://issues.apache.org/jira/browse/HBASE-24916 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Priority: Major > > HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in > meta and start key is empty > for hole, it reports two region where hole is present. > Scenario where first region is missing for eg: in below scenario r1 is > missing in meta > start key end key region > empty 10 r1 > 10 20 r2 > 20 30 r2 > 30 empty r3 > > In our test hbck report contains two region where first region belongs to > different table and second region is r2. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24916) HBCK2 Holes:Wrong region detail in HBCK report ,if a region is missing in meta and start key is empty
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24916: -- Summary: HBCK2 Holes:Wrong region detail in HBCK report ,if a region is missing in meta and start key is empty (was: HBCK2 Holes:Wrong region detail in HBCK report a start key of a region which is missing in meta is empty) > HBCK2 Holes:Wrong region detail in HBCK report ,if a region is missing in > meta and start key is empty > -- > > Key: HBASE-24916 > URL: https://issues.apache.org/jira/browse/HBASE-24916 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Priority: Major > > HBCK2 Holes:Wrong region detail in HBCK report a start key of a region which > is missing in meta is empty. > for hole, it reports two region where hole is present. > Scenario where first region is missing for eg: in below scenario r1 is > missing in meta > start key end key region > empty 10 r1 > 10 20 r2 > 20 30 r2 > > In our test hbck report contains two region where first region belongs to > another table and second region is r2. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24916) HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start key is empty
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24916: -- Description: HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in meta and start key is empty for hole, it reports two region where hole is present. Scenario where first region is missing for eg: in below scenario r1 is missing in meta start key end key region empty 10 r1 10 20 r2 20 30 r2 In our test hbck report contains two region where first region belongs to another table and second region is r2. was: HBCK2 Holes:Wrong region detail in HBCK report a start key of a region which is missing in meta is empty. for hole, it reports two region where hole is present. Scenario where first region is missing for eg: in below scenario r1 is missing in meta start key end key region empty 10 r1 10 20 r2 20 30 r2 In our test hbck report contains two region where first region belongs to another table and second region is r2. > HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in > meta and start key is empty > --- > > Key: HBASE-24916 > URL: https://issues.apache.org/jira/browse/HBASE-24916 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Priority: Major > > HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in > meta and start key is empty > for hole, it reports two region where hole is present. > Scenario where first region is missing for eg: in below scenario r1 is > missing in meta > start key end key region > empty 10 r1 > 10 20 r2 > 20 30 r2 > > In our test hbck report contains two region where first region belongs to > another table and second region is r2. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24916) HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start key is empty
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-24916: -- Summary: HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in meta and start key is empty (was: HBCK2 Holes:Wrong region detail in HBCK report ,if a region is missing in meta and start key is empty) > HBCK2 Holes:Wrong region details in HBCK report ,if a region is missing in > meta and start key is empty > --- > > Key: HBASE-24916 > URL: https://issues.apache.org/jira/browse/HBASE-24916 > Project: HBase > Issue Type: Bug > Components: hbck2 >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Priority: Major > > HBCK2 Holes:Wrong region detail in HBCK report a start key of a region which > is missing in meta is empty. > for hole, it reports two region where hole is present. > Scenario where first region is missing for eg: in below scenario r1 is > missing in meta > start key end key region > empty 10 r1 > 10 20 r2 > 20 30 r2 > > In our test hbck report contains two region where first region belongs to > another table and second region is r2. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24916) HBCK2 Holes:Wrong region detail in HBCK report a start key of a region which is missing in meta is empty
Ajeet Rai created HBASE-24916: - Summary: HBCK2 Holes:Wrong region detail in HBCK report a start key of a region which is missing in meta is empty Key: HBASE-24916 URL: https://issues.apache.org/jira/browse/HBASE-24916 Project: HBase Issue Type: Bug Components: hbck2 Affects Versions: 2.2.3 Reporter: Ajeet Rai HBCK2 Holes:Wrong region detail in HBCK report a start key of a region which is missing in meta is empty. for hole, it reports two region where hole is present. Scenario where first region is missing for eg: in below scenario r1 is missing in meta start key end key region empty 10 r1 10 20 r2 20 30 r2 In our test hbck report contains two region where first region belongs to another table and second region is r2. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…
Apache-HBase commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677789166 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 45s | branch-2.3 passed | | +1 :green_heart: | checkstyle | 0m 45s | branch-2.3 passed | | +1 :green_heart: | spotbugs | 1m 31s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 16s | the patch passed | | +1 :green_heart: | checkstyle | 0m 41s | hbase-client: The patch generated 0 new + 23 unchanged - 3 fixed = 23 total (was 26) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 20m 16s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 1m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 41m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2274/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2274 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux d9b5fac11a41 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 4f6e44fe79 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2274/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…
bharathv commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677785949 > This approach looks sufficient breaking the possible static load tangle. I could add this to first patch -- deprecating and nulling UNDEFINED Wondering if this is sufficient. Going by the jstacks, FIRST_META_REGIONINFO access triggers a MutableRegionInfo load and that triggers the parent interface RegionInfo load [1]. And any UNDEFINED access in RegionInfo triggers the exact opposite order. I was under the impression that we should break this tie. While un-nesting MutableRegionInfo is a welcome change, curious if that solves the problem. Thanks. [1] https://docs.oracle.com/javase/specs/jls/se8/html/jls-12.html#jls-12.4.2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…
Apache-HBase commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677785767 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 44s | branch-2.3 passed | | +1 :green_heart: | compile | 0m 40s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 7m 36s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 33s | hbase-client in branch-2.3 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 4s | the patch passed | | +1 :green_heart: | compile | 0m 39s | the patch passed | | +1 :green_heart: | javac | 0m 39s | the patch passed | | +1 :green_heart: | shadedjars | 7m 31s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 32s | hbase-client in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 19s | hbase-client in the patch passed. | | | | 34m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2274/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2274 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fd44bd30b838 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 4f6e44fe79 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2274/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2274/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2274/5/testReport/ | | Max. process+thread count | 206 (vs. ulimit of 12500) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2274/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-677783532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 24s | master passed | | +1 :green_heart: | compile | 4m 16s | master passed | | +1 :green_heart: | shadedjars | 7m 52s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | hbase-common in master failed. | | -0 :warning: | javadoc | 0m 21s | hbase-hadoop-compat in master failed. | | -0 :warning: | javadoc | 0m 29s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 47s | hbase-server in master failed. | | -0 :warning: | javadoc | 1m 5s | hbase-thrift in master failed. | | -0 :warning: | javadoc | 0m 17s | root in master failed. | | -0 :warning: | patch | 12m 58s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 34s | the patch passed | | +1 :green_heart: | compile | 3m 37s | the patch passed | | +1 :green_heart: | javac | 3m 37s | the patch passed | | +1 :green_heart: | shadedjars | 7m 0s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 21s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javadoc | 0m 30s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 51s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 1m 10s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 17s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 167m 30s | root in the patch passed. | | | | 214m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2261 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d7e7fb224cfe 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1164531d5a | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2261/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc |
[GitHub] [hbase] Apache-HBase commented on pull request #2277: HBASE-24906 Enlarge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic
Apache-HBase commented on pull request #2277: URL: https://github.com/apache/hbase/pull/2277#issuecomment-677783756 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-2.2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 45s | branch-2.2 passed | | +1 :green_heart: | compile | 1m 4s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 1m 36s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 4m 57s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | branch-2.2 passed | | +0 :ok: | spotbugs | 4m 0s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 57s | branch-2.2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | +1 :green_heart: | checkstyle | 1m 36s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 30m 27s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | | +1 :green_heart: | findbugs | 3m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 171m 49s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 33s | The patch does not generate ASF License warnings. | | | | 242m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2277/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2277 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a26848fc7f7f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2277/out/precommit/personality/provided.sh | | git revision | branch-2.2 / 3f10933bf9 | | Default Java | 1.8.0_181 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2277/3/testReport/ | | Max. process+thread count | 3856 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2277/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2287: HBASE-24914 Remove duplicate code appearing continuously in method Re…
Apache-HBase commented on pull request #2287: URL: https://github.com/apache/hbase/pull/2287#issuecomment-677781976 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 44s | master passed | | +1 :green_heart: | compile | 1m 13s | master passed | | +1 :green_heart: | shadedjars | 7m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 15s | the patch passed | | +1 :green_heart: | compile | 1m 8s | the patch passed | | +1 :green_heart: | javac | 1m 8s | the patch passed | | +1 :green_heart: | shadedjars | 7m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 51s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 217m 24s | hbase-server in the patch passed. | | | | 247m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2287 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0a7dfff57dd5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1164531d5a | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/2/testReport/ | | Max. process+thread count | 3308 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2287/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…
Apache-HBase commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677780020 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 47s | branch-2.3 passed | | +1 :green_heart: | compile | 0m 27s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 13s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 17s | the patch passed | | +1 :green_heart: | compile | 0m 28s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | shadedjars | 5m 3s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 13s | hbase-client in the patch passed. | | | | 23m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2274/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2274 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4888231358c0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 4f6e44fe79 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2274/5/testReport/ | | Max. process+thread count | 342 (vs. ulimit of 12500) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2274/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-24867) Add 2.3.1 to the downloads page
[ https://issues.apache.org/jira/browse/HBASE-24867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24867. -- Resolution: Fixed > Add 2.3.1 to the downloads page > --- > > Key: HBASE-24867 > URL: https://issues.apache.org/jira/browse/HBASE-24867 > Project: HBase > Issue Type: Sub-task >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Fix For: 3.0.0-alpha-1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24867) Add 2.3.1 to the downloads page
[ https://issues.apache.org/jira/browse/HBASE-24867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24867: - Fix Version/s: 3.0.0-alpha-1 > Add 2.3.1 to the downloads page > --- > > Key: HBASE-24867 > URL: https://issues.apache.org/jira/browse/HBASE-24867 > Project: HBase > Issue Type: Sub-task >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Fix For: 3.0.0-alpha-1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2281: HBASE-24867 Add 2.3.1 to the downloads page
Apache-HBase commented on pull request #2281: URL: https://github.com/apache/hbase/pull/2281#issuecomment-677768587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…
saintstack commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677767879 Added IA.Private and deprecation on UNDEFINED in RI per @Apache9 suggestion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #2281: HBASE-24867 Add 2.3.1 to the downloads page
ndimiduk commented on pull request #2281: URL: https://github.com/apache/hbase/pull/2281#issuecomment-677768088 thanks for the reviews! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
