[GitHub] [hbase] ZhaoBQ commented on pull request #2898: HBASE-25522 Remove deprecated methods in ReplicationPeerConfig

2021-01-21 Thread GitBox
ZhaoBQ commented on pull request #2898: URL: https://github.com/apache/hbase/pull/2898#issuecomment-765183927 Mockito cannot mock/spy because ReplicationPeerConfig is final class. Modify it back and ignore the checkstyle.

[GitHub] [hbase] Apache9 commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

2021-01-21 Thread GitBox
Apache9 commented on a change in pull request #2889: URL: https://github.com/apache/hbase/pull/2889#discussion_r562404279 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -921,8 +921,10 @@ public boolean isClusterShutdown() {

[GitHub] [hbase] cuibo01 commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

2021-01-21 Thread GitBox
cuibo01 commented on a change in pull request #2889: URL: https://github.com/apache/hbase/pull/2889#discussion_r562415590 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -921,8 +921,10 @@ public boolean isClusterShutdown() {

[GitHub] [hbase] Apache-HBase commented on pull request #2898: HBASE-25522 Remove deprecated methods in ReplicationPeerConfig

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2898: URL: https://github.com/apache/hbase/pull/2898#issuecomment-765171887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] virajjasani commented on a change in pull request #2899: HBASE-25523 Region normalizer chore thread is getting killed

2021-01-21 Thread GitBox
virajjasani commented on a change in pull request #2899: URL: https://github.com/apache/hbase/pull/2899#discussion_r562404352 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -222,8 +223,12 @@ public void

[GitHub] [hbase] gjacoby126 opened a new pull request #2900: HBASE-25525 - WALKey Extended Attributes don't serialize to Replicati…

2021-01-21 Thread GitBox
gjacoby126 opened a new pull request #2900: URL: https://github.com/apache/hbase/pull/2900 …onSink This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache9 opened a new pull request #2901: HBASE-22120 Replace HTrace with OpenTelemetry

2021-01-21 Thread GitBox
Apache9 opened a new pull request #2901: URL: https://github.com/apache/hbase/pull/2901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache9 commented on pull request #2885: HBASE-25510 Optimize TableName.valueOf from O(n) to O(1)

2021-01-21 Thread GitBox
Apache9 commented on pull request #2885: URL: https://github.com/apache/hbase/pull/2885#issuecomment-765067363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hbase] Apache9 commented on a change in pull request #2892: HBASE-25484 Add trace support for WAL sync

2021-01-21 Thread GitBox
Apache9 commented on a change in pull request #2892: URL: https://github.com/apache/hbase/pull/2892#discussion_r562324710 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java ## @@ -1135,14 +1163,12 @@ protected final long

[GitHub] [hbase] bharathv commented on a change in pull request #2899: HBASE-25523 Region normalizer chore thread is getting killed

2021-01-21 Thread GitBox
bharathv commented on a change in pull request #2899: URL: https://github.com/apache/hbase/pull/2899#discussion_r562129209 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -222,8 +223,12 @@ public void

[GitHub] [hbase] Apache9 merged pull request #2892: HBASE-25484 Add trace support for WAL sync

2021-01-21 Thread GitBox
Apache9 merged pull request #2892: URL: https://github.com/apache/hbase/pull/2892 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 commented on pull request #2898: HBASE-25522 Remove deprecated methods in ReplicationPeerConfig

2021-01-21 Thread GitBox
Apache9 commented on pull request #2898: URL: https://github.com/apache/hbase/pull/2898#issuecomment-765063838 Please fix the checkstyle issues? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #2899: HBASE-25523 Region normalizer chore thread is getting killed

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2899: URL: https://github.com/apache/hbase/pull/2899#issuecomment-764844645 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache9 closed pull request #1215: HBASE-23897. [OpenTracing] Add traces in Procedure V2.

2021-01-21 Thread GitBox
Apache9 closed pull request #1215: URL: https://github.com/apache/hbase/pull/1215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] zhengzhuobinzzb commented on pull request #2885: HBASE-25510 Optimize TableName.valueOf from O(n) to O(1)

2021-01-21 Thread GitBox
zhengzhuobinzzb commented on pull request #2885: URL: https://github.com/apache/hbase/pull/2885#issuecomment-765098428 > It is a bit strange that we convert bytes or ByteBuffer to String, and then convert back to store them... Thank you very much for reviewing my code. In face, i

[GitHub] [hbase] sunhelly commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

2021-01-21 Thread GitBox
sunhelly commented on a change in pull request #2889: URL: https://github.com/apache/hbase/pull/2889#discussion_r562014142 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -921,8 +921,10 @@ public boolean isClusterShutdown() {

[GitHub] [hbase] Apache-HBase commented on pull request #2892: HBASE-25484 Add trace support for WAL sync

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2892: URL: https://github.com/apache/hbase/pull/2892#issuecomment-764684621 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] cuibo01 commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

2021-01-21 Thread GitBox
cuibo01 commented on a change in pull request #2889: URL: https://github.com/apache/hbase/pull/2889#discussion_r562303540 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -921,8 +921,10 @@ public boolean isClusterShutdown() {

[GitHub] [hbase] Apache-HBase commented on pull request #2898: HBASE-25522 Remove deprecated methods in ReplicationPeerConfig

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2898: URL: https://github.com/apache/hbase/pull/2898#issuecomment-76102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2893: HBASE-25517 Reduce race conditions between balance of RSGroups and support concurrently balance RSGroups

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2893: URL: https://github.com/apache/hbase/pull/2893#issuecomment-764460390 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] virajjasani commented on a change in pull request #2899: HBASE-25523 Region normalizer chore thread is getting killed

2021-01-21 Thread GitBox
virajjasani commented on a change in pull request #2899: URL: https://github.com/apache/hbase/pull/2899#discussion_r562031466 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -222,8 +223,12 @@ public void

[GitHub] [hbase] Apache9 commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

2021-01-21 Thread GitBox
Apache9 commented on a change in pull request #2889: URL: https://github.com/apache/hbase/pull/2889#discussion_r562337042 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -921,8 +921,10 @@ public boolean isClusterShutdown() {

[GitHub] [hbase] Apache9 commented on pull request #2885: HBASE-25510 Optimize TableName.valueOf from O(n) to O(1)

2021-01-21 Thread GitBox
Apache9 commented on pull request #2885: URL: https://github.com/apache/hbase/pull/2885#issuecomment-765127874 > > It is a bit strange that we convert bytes or ByteBuffer to String, and then convert back to store them... > > Thank you very much for reviewing my code. > > In face,

[GitHub] [hbase] cuibo01 commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

2021-01-21 Thread GitBox
cuibo01 commented on a change in pull request #2889: URL: https://github.com/apache/hbase/pull/2889#discussion_r562380863 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -921,8 +921,10 @@ public boolean isClusterShutdown() {

[GitHub] [hbase] sunhelly commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

2021-01-21 Thread GitBox
sunhelly commented on a change in pull request #2889: URL: https://github.com/apache/hbase/pull/2889#discussion_r562378846 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -921,8 +921,10 @@ public boolean isClusterShutdown() {

[GitHub] [hbase] zhengzhuobinzzb commented on pull request #2885: HBASE-25510 Optimize TableName.valueOf from O(n) to O(1)

2021-01-21 Thread GitBox
zhengzhuobinzzb commented on pull request #2885: URL: https://github.com/apache/hbase/pull/2885#issuecomment-765098428 > It is a bit strange that we convert bytes or ByteBuffer to String, and then convert back to store them... Thank you very much for reviewing my code. In face, i

[GitHub] [hbase] Apache-HBase commented on pull request #2898: HBASE-25522 Remove deprecated methods in ReplicationPeerConfig

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2898: URL: https://github.com/apache/hbase/pull/2898#issuecomment-765094345 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] cuibo01 commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

2021-01-21 Thread GitBox
cuibo01 commented on a change in pull request #2889: URL: https://github.com/apache/hbase/pull/2889#discussion_r562362710 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -921,8 +921,10 @@ public boolean isClusterShutdown() {

[jira] [Updated] (HBASE-23762) Add documentation on how to enable and view tracing with OpenTelemetry

2021-01-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23762: -- Summary: Add documentation on how to enable and view tracing with OpenTelemetry (was: [OpenTracing]

[jira] [Resolved] (HBASE-23759) [OpenTracing] Migrate hbase shell and scripts from HTrace to OpenTracing

2021-01-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23759. --- Resolution: Won't Fix > [OpenTracing] Migrate hbase shell and scripts from HTrace to OpenTracing >

[jira] [Updated] (HBASE-23897) [OpenTracing] Add traces in Procedure V2

2021-01-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23897: -- Resolution: Won't Fix Status: Resolved (was: Patch Available) > [OpenTracing] Add traces in

[GitHub] [hbase] Apache9 closed pull request #1215: HBASE-23897. [OpenTracing] Add traces in Procedure V2.

2021-01-21 Thread GitBox
Apache9 closed pull request #1215: URL: https://github.com/apache/hbase/pull/1215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HBASE-25453) Add trace support for scan operation

2021-01-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25453: -- Parent Issue: HBASE-25526 (was: HBASE-22120) > Add trace support for scan operation >

[GitHub] [hbase] Apache9 commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

2021-01-21 Thread GitBox
Apache9 commented on a change in pull request #2889: URL: https://github.com/apache/hbase/pull/2889#discussion_r562337042 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -921,8 +921,10 @@ public boolean isClusterShutdown() {

[jira] [Created] (HBASE-25526) Implement more detailed tracing in HBase

2021-01-21 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25526: - Summary: Implement more detailed tracing in HBase Key: HBASE-25526 URL: https://issues.apache.org/jira/browse/HBASE-25526 Project: HBase Issue Type: Umbrella

[jira] [Resolved] (HBASE-25484) Add trace support for WAL sync

2021-01-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25484. --- Fix Version/s: HBASE-22120 Hadoop Flags: Reviewed Resolution: Fixed Merged to branch

[GitHub] [hbase] Apache9 merged pull request #2892: HBASE-25484 Add trace support for WAL sync

2021-01-21 Thread GitBox
Apache9 merged pull request #2892: URL: https://github.com/apache/hbase/pull/2892 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 commented on pull request #2885: HBASE-25510 Optimize TableName.valueOf from O(n) to O(1)

2021-01-21 Thread GitBox
Apache9 commented on pull request #2885: URL: https://github.com/apache/hbase/pull/2885#issuecomment-765067363 It is a bit strange that we convert bytes or ByteBuffer to String, and then convert back to store them... This

[GitHub] [hbase] Apache9 commented on a change in pull request #2892: HBASE-25484 Add trace support for WAL sync

2021-01-21 Thread GitBox
Apache9 commented on a change in pull request #2892: URL: https://github.com/apache/hbase/pull/2892#discussion_r562324710 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java ## @@ -1135,14 +1163,12 @@ protected final long

[GitHub] [hbase] Apache9 commented on pull request #2898: HBASE-25522 Remove deprecated methods in ReplicationPeerConfig

2021-01-21 Thread GitBox
Apache9 commented on pull request #2898: URL: https://github.com/apache/hbase/pull/2898#issuecomment-765063838 Please fix the checkstyle issues? This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (HBASE-25521) Change ChoreService and ScheduledChore to IA.Private

2021-01-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25521: -- Hadoop Flags: Incompatible change > Change ChoreService and ScheduledChore to IA.Private >

[GitHub] [hbase] cuibo01 commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

2021-01-21 Thread GitBox
cuibo01 commented on a change in pull request #2889: URL: https://github.com/apache/hbase/pull/2889#discussion_r562303540 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -921,8 +921,10 @@ public boolean isClusterShutdown() {

[GitHub] [hbase] cuibo01 commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

2021-01-21 Thread GitBox
cuibo01 commented on a change in pull request #2889: URL: https://github.com/apache/hbase/pull/2889#discussion_r562303540 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -921,8 +921,10 @@ public boolean isClusterShutdown() {

[jira] [Created] (HBASE-25525) WALKey Extended Attributes don't serialize to ReplicationSink

2021-01-21 Thread Geoffrey Jacoby (Jira)
Geoffrey Jacoby created HBASE-25525: --- Summary: WALKey Extended Attributes don't serialize to ReplicationSink Key: HBASE-25525 URL: https://issues.apache.org/jira/browse/HBASE-25525 Project: HBase

[jira] [Created] (HBASE-25524) Region Servers should give some indication that short-circuit reads are configured properly and working

2021-01-21 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-25524: Summary: Region Servers should give some indication that short-circuit reads are configured properly and working Key: HBASE-25524 URL:

[GitHub] [hbase] bharathv commented on a change in pull request #2899: HBASE-25523 Region normalizer chore thread is getting killed

2021-01-21 Thread GitBox
bharathv commented on a change in pull request #2899: URL: https://github.com/apache/hbase/pull/2899#discussion_r562129209 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -222,8 +223,12 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2898: HBASE-25522 Remove deprecated methods in ReplicationPeerConfig

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2898: URL: https://github.com/apache/hbase/pull/2898#issuecomment-764873932 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m

[GitHub] [hbase] Apache-HBase commented on pull request #2899: HBASE-25523 Region normalizer chore thread is getting killed

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2899: URL: https://github.com/apache/hbase/pull/2899#issuecomment-764844645 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2898: HBASE-25522 Remove deprecated methods in ReplicationPeerConfig

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2898: URL: https://github.com/apache/hbase/pull/2898#issuecomment-764825086 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2892: HBASE-25484 Add trace support for WAL sync

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2892: URL: https://github.com/apache/hbase/pull/2892#issuecomment-764791327 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #2899: HBASE-25523 Region normalizer chore thread is getting killed

2021-01-21 Thread GitBox
virajjasani commented on a change in pull request #2899: URL: https://github.com/apache/hbase/pull/2899#discussion_r562031466 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -222,8 +223,12 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2892: HBASE-25484 Add trace support for WAL sync

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2892: URL: https://github.com/apache/hbase/pull/2892#issuecomment-764778990 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] sunhelly commented on a change in pull request #2889: HBASE-25506 ServerManager#startChore affects MTTR of HMaster

2021-01-21 Thread GitBox
sunhelly commented on a change in pull request #2889: URL: https://github.com/apache/hbase/pull/2889#discussion_r562014142 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java ## @@ -921,8 +921,10 @@ public boolean isClusterShutdown() {

[GitHub] [hbase] Apache-HBase commented on pull request #2893: HBASE-25517 Reduce race conditions between balance of RSGroups and support concurrently balance RSGroups

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2893: URL: https://github.com/apache/hbase/pull/2893#issuecomment-764764406 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2893: HBASE-25517 Reduce race conditions between balance of RSGroups and support concurrently balance RSGroups

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2893: URL: https://github.com/apache/hbase/pull/2893#issuecomment-764763043 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2898: HBASE-25522 Remove deprecated methods in ReplicationPeerConfig

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2898: URL: https://github.com/apache/hbase/pull/2898#issuecomment-764747719 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m

[GitHub] [hbase] mnpoonia opened a new pull request #2899: HBASE-25523 Region normalizer chore thread is getting killed

2021-01-21 Thread GitBox
mnpoonia opened a new pull request #2899: URL: https://github.com/apache/hbase/pull/2899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (HBASE-25523) Region normalizer chore thread is getting killed

2021-01-21 Thread Aman Poonia (Jira)
Aman Poonia created HBASE-25523: --- Summary: Region normalizer chore thread is getting killed Key: HBASE-25523 URL: https://issues.apache.org/jira/browse/HBASE-25523 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2892: HBASE-25484 Add trace support for WAL sync

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2892: URL: https://github.com/apache/hbase/pull/2892#issuecomment-764684621 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2893: HBASE-25517 Reduce race conditions between balance of RSGroups and support concurrently balance RSGroups

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2893: URL: https://github.com/apache/hbase/pull/2893#issuecomment-764677877 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2893: HBASE-25517 Reduce race conditions between balance of RSGroups and support concurrently balance RSGroups

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2893: URL: https://github.com/apache/hbase/pull/2893#issuecomment-764637402 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25368) Filter out more invalid encoded name in isEncodedRegionName(byte[] regionName)

2021-01-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269283#comment-17269283 ] Hudson commented on HBASE-25368: Results for branch master [build #193 on

[GitHub] [hbase] Apache-HBase commented on pull request #2893: HBASE-25517 Reduce race conditions between balance of RSGroups and support concurrently balance RSGroups

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2893: URL: https://github.com/apache/hbase/pull/2893#issuecomment-764629552 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Commented] (HBASE-25509) ChoreService.cancelChore will not call ScheduledChore.cleanup which may lead to resource leak

2021-01-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269239#comment-17269239 ] Hudson commented on HBASE-25509: Results for branch branch-2.4 [build #40 on

[jira] [Commented] (HBASE-25509) ChoreService.cancelChore will not call ScheduledChore.cleanup which may lead to resource leak

2021-01-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269229#comment-17269229 ] Hudson commented on HBASE-25509: Results for branch branch-2 [build #163 on

[jira] [Commented] (HBASE-25513) When the table is turned on normalize, the first region may not be merged even the size is 0

2021-01-21 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269226#comment-17269226 ] Baiqiang Zhao commented on HBASE-25513: --- Thanks [~ndimiduk]. Normalizer is a nice feature, and we

[GitHub] [hbase] Apache-HBase commented on pull request #2893: HBASE-25517 Reduce race conditions between balance of RSGroups and support concurrently balance RSGroups

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2893: URL: https://github.com/apache/hbase/pull/2893#issuecomment-764560126 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2898: HBASE-25522 Remove deprecated methods in ReplicationPeerConfig

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2898: URL: https://github.com/apache/hbase/pull/2898#issuecomment-764553764 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m

[GitHub] [hbase] Apache-HBase commented on pull request #2893: HBASE-25517 Reduce race conditions between balance of RSGroups and support concurrently balance RSGroups

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2893: URL: https://github.com/apache/hbase/pull/2893#issuecomment-764530853 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2893: HBASE-25517 Reduce race conditions between balance of RSGroups and support concurrently balance RSGroups

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2893: URL: https://github.com/apache/hbase/pull/2893#issuecomment-764520385 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2893: HBASE-25517 Reduce race conditions between balance of RSGroups and support concurrently balance RSGroups

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2893: URL: https://github.com/apache/hbase/pull/2893#issuecomment-764460390 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2898: HBASE-25522 Remove deprecated methods in ReplicationPeerConfig

2021-01-21 Thread GitBox
Apache-HBase commented on pull request #2898: URL: https://github.com/apache/hbase/pull/2898#issuecomment-764454902 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 19m