[jira] [Commented] (HBASE-26036) DBB released too early and dirty data for some operations

2021-07-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373890#comment-17373890 ] Duo Zhang commented on HBASE-26036: --- {quote} checkAndMutate performs getting cells, the

[GitHub] [hbase] Apache9 commented on a change in pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

2021-07-02 Thread GitBox
Apache9 commented on a change in pull request #3436: URL: https://github.com/apache/hbase/pull/3436#discussion_r663310572 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java ## @@ -221,22 +223,25 @@ private boolean

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-873337129 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on pull request #3443: HBASE-25516 [JDK17] reflective access Field.class.getDeclaredField("modifiers") not supported

2021-07-02 Thread GitBox
Apache9 commented on pull request #3443: URL: https://github.com/apache/hbase/pull/3443#issuecomment-873336806 > I'm ok either way. So far, I have not yet seen an incompatible change required, so branch-2 can support too. It adds extra code to deal with JDK17 but if we do not want

[jira] [Updated] (HBASE-26030) hbase-cleanup.sh did not clean the wal dir if hbase.wal.dir configured individually

2021-07-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26030: -- Fix Version/s: 2.4.5 2.3.6 2.5.0

[jira] [Resolved] (HBASE-26030) hbase-cleanup.sh did not clean the wal dir if hbase.wal.dir configured individually

2021-07-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26030. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.3+. Thanks [~mokai87] for

[GitHub] [hbase] Apache9 merged pull request #3432: HBASE-26030 hbase-cleanup.sh did not clean the wal dir if hbase.wal.dir configured individually

2021-07-02 Thread GitBox
Apache9 merged pull request #3432: URL: https://github.com/apache/hbase/pull/3432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-26057) Remove reflections used to access Hadoop 2 API in FanOutOneBlockAsyncDFSOutputHelper

2021-07-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26057: -- Fix Version/s: (was: 3.0.0-alpha-2) 3.0.0-alpha-1 > Remove reflections used to

[jira] [Updated] (HBASE-26051) Remove reflections used to access HDFS EC APIs

2021-07-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26051: -- Fix Version/s: (was: 3.0.0-alpha-2) 3.0.0-alpha-1 > Remove reflections used to

[jira] [Updated] (HBASE-26050) Remove the reflection used in FSUtils.isInSafeMode

2021-07-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26050: -- Fix Version/s: (was: 3.0.0-alpha-2) 3.0.0-alpha-1 > Remove the reflection used

[jira] [Updated] (HBASE-26041) Replace PrintThreadInfoHelper with HBase's own ReflectionUtils.printThreadInfo()

2021-07-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26041: -- Fix Version/s: (was: 3.0.0-alpha-2) 3.0.0-alpha-1 > Replace

[jira] [Resolved] (HBASE-26061) [create-release] The indent of checkcompatibility.py is broken after HBASE-25473

2021-07-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26061. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~niuyulin] for reviewing.

[GitHub] [hbase] Apache9 merged pull request #3454: HBASE-26061 [create-release] The indent of checkcompatibility.py is b…

2021-07-02 Thread GitBox
Apache9 merged pull request #3454: URL: https://github.com/apache/hbase/pull/3454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-873323665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26062) SIGSEGV in AsyncFSWAL consume

2021-07-02 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373857#comment-17373857 ] Michael Stack commented on HBASE-26062: --- Only thing around the crash are these: 2021-07-01

[jira] [Comment Edited] (HBASE-26062) SIGSEGV in AsyncFSWAL consume

2021-07-02 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373806#comment-17373806 ] Michael Stack edited comment on HBASE-26062 at 7/3/21, 12:14 AM: - Made

[GitHub] [hbase] Apache-HBase commented on pull request #3456: HBASE-22923 Consider minVersionToMoveSysTables while moving region and creating regionPlan (ADDENDUM)

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3456: URL: https://github.com/apache/hbase/pull/3456#issuecomment-873292276 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on a change in pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

2021-07-02 Thread GitBox
saintstack commented on a change in pull request #3436: URL: https://github.com/apache/hbase/pull/3436#discussion_r663271264 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java ## @@ -476,6 +476,7 @@ boolean checkAndRowMutate(byte [] row,

[GitHub] [hbase] Apache-HBase commented on pull request #3455: HBASE-22923 Consider minVersionToMoveSysTables while moving region and creating regionPlan (ADDENDUM)

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3455: URL: https://github.com/apache/hbase/pull/3455#issuecomment-873285304 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3455: HBASE-22923 Consider minVersionToMoveSysTables while moving region and creating regionPlan (ADDENDUM)

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3455: URL: https://github.com/apache/hbase/pull/3455#issuecomment-873283022 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25975) Row commit sequencer

2021-07-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25975: Attachment: results_baseline.txt > Row commit sequencer > >

[jira] [Comment Edited] (HBASE-25975) Row commit sequencer

2021-07-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373808#comment-17373808 ] Andrew Kyle Purtell edited comment on HBASE-25975 at 7/2/21, 10:16 PM:

[jira] [Updated] (HBASE-25975) Row commit sequencer

2021-07-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25975: Attachment: jmh.txt > Row commit sequencer > > >

[jira] [Updated] (HBASE-25975) Row commit sequencer

2021-07-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25975: Attachment: results.txt > Row commit sequencer > > >

[jira] [Commented] (HBASE-26062) SIGSEGV in AsyncFSWAL consume

2021-07-02 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373806#comment-17373806 ] Michael Stack commented on HBASE-26062: --- Made this an issue. I don't think it related to

[jira] [Commented] (HBASE-25975) Row commit sequencer

2021-07-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373808#comment-17373808 ] Andrew Kyle Purtell commented on HBASE-25975: - Approaching time for review. Ensuring unit

[jira] [Issue Comment Deleted] (HBASE-25975) Row commit sequencer

2021-07-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25975: Comment: was deleted (was: As of

[jira] [Updated] (HBASE-25975) Row commit sequencer

2021-07-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25975: Attachment: (was: JMH-25975-17614de8.pdf) > Row commit sequencer >

[jira] [Issue Comment Deleted] (HBASE-25975) Row commit sequencer

2021-07-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25975: Comment: was deleted (was: Attached as [^JMH-25975-17614de8.pdf] a JMH based

[jira] [Issue Comment Deleted] (HBASE-25975) Row commit sequencer

2021-07-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25975: Comment: was deleted (was: Latest code with better microbenchmark, measuring

[jira] [Issue Comment Deleted] (HBASE-25975) Row commit sequencer

2021-07-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25975: Comment: was deleted (was: As of version 90bf60d7: - Reduced time under lock -

[jira] [Updated] (HBASE-25975) Row commit sequencer

2021-07-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25975: Attachment: (was: HBASE-25975-c4cf83ce.pdf) > Row commit sequencer >

[jira] [Issue Comment Deleted] (HBASE-25975) Row commit sequencer

2021-07-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25975: Comment: was deleted (was: Performance is good enough for the first pass. Next

[jira] [Updated] (HBASE-26062) SIGSEGV in AsyncFSWAL consume

2021-07-02 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-26062: -- Parent: (was: HBASE-26036) Issue Type: Bug (was: Sub-task) > SIGSEGV in

[jira] [Created] (HBASE-26062) SIGSEGV in AsyncFSWAL consume

2021-07-02 Thread Michael Stack (Jira)
Michael Stack created HBASE-26062: - Summary: SIGSEGV in AsyncFSWAL consume Key: HBASE-26062 URL: https://issues.apache.org/jira/browse/HBASE-26062 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] Apache-HBase commented on pull request #3455: HBASE-22923 Consider minVersionToMoveSysTables while moving region and creating regionPlan (ADDENDUM)

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3455: URL: https://github.com/apache/hbase/pull/3455#issuecomment-873233976 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani opened a new pull request #3456: HBASE-22923 Consider minVersionToMoveSysTables while moving region and creating regionPlan (ADDENDUM)

2021-07-02 Thread GitBox
virajjasani opened a new pull request #3456: URL: https://github.com/apache/hbase/pull/3456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] virajjasani commented on pull request #3455: HBASE-22923 Consider minVersionToMoveSysTables while moving region and creating regionPlan (ADDENDUM)

2021-07-02 Thread GitBox
virajjasani commented on pull request #3455: URL: https://github.com/apache/hbase/pull/3455#issuecomment-873214310 FYI @d-c-manning Tested region_mover and balancer with mixed mode of servers, works as expected, meaning no workflow considers moving system tables to higher version

[GitHub] [hbase] virajjasani opened a new pull request #3455: HBASE-22923 Consider minVersionToMoveSysTables while moving region and creating regionPlan (ADDENDUM)

2021-07-02 Thread GitBox
virajjasani opened a new pull request #3455: URL: https://github.com/apache/hbase/pull/3455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Reopened] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

2021-07-02 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reopened HBASE-22923: -- Reopening as [~dmanning] has identified an issue that I was able to repro. Will come up with

[jira] [Commented] (HBASE-26041) Replace PrintThreadInfoHelper with HBase's own ReflectionUtils.printThreadInfo()

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373673#comment-17373673 ] Hudson commented on HBASE-26041: Results for branch branch-2 [build #291 on

[jira] [Commented] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373670#comment-17373670 ] Hudson commented on HBASE-22923: Results for branch branch-2 [build #291 on

[jira] [Commented] (HBASE-25902) Add missing CFs in meta during HBase 1 to 2.3+ Upgrade

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373669#comment-17373669 ] Hudson commented on HBASE-25902: Results for branch branch-2 [build #291 on

[jira] [Commented] (HBASE-26027) The calling of HTable.batch blocked at AsyncRequestFutureImpl.waitUntilDone caused by ArrayStoreException

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373671#comment-17373671 ] Hudson commented on HBASE-26027: Results for branch branch-2 [build #291 on

[jira] [Commented] (HBASE-26035) Redundant null check in the compareTo function

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373672#comment-17373672 ] Hudson commented on HBASE-26035: Results for branch branch-2 [build #291 on

[jira] [Commented] (HBASE-26050) Remove the reflection used in FSUtils.isInSafeMode

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373674#comment-17373674 ] Hudson commented on HBASE-26050: Results for branch branch-2 [build #291 on

[jira] [Commented] (HBASE-26035) Redundant null check in the compareTo function

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373638#comment-17373638 ] Hudson commented on HBASE-26035: Results for branch branch-2.3 [build #249 on

[jira] [Commented] (HBASE-25902) Add missing CFs in meta during HBase 1 to 2.3+ Upgrade

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373635#comment-17373635 ] Hudson commented on HBASE-25902: Results for branch branch-2.3 [build #249 on

[jira] [Commented] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373636#comment-17373636 ] Hudson commented on HBASE-22923: Results for branch branch-2.3 [build #249 on

[jira] [Commented] (HBASE-26027) The calling of HTable.batch blocked at AsyncRequestFutureImpl.waitUntilDone caused by ArrayStoreException

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373637#comment-17373637 ] Hudson commented on HBASE-26027: Results for branch branch-2.3 [build #249 on

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-873083378 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3454: HBASE-26061 [create-release] The indent of checkcompatibility.py is b…

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3454: URL: https://github.com/apache/hbase/pull/3454#issuecomment-873059177 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3454: HBASE-26061 [create-release] The indent of checkcompatibility.py is b…

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3454: URL: https://github.com/apache/hbase/pull/3454#issuecomment-873058681 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3454: HBASE-26061 [create-release] The indent of checkcompatibility.py is b…

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3454: URL: https://github.com/apache/hbase/pull/3454#issuecomment-873058528 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 opened a new pull request #3454: HBASE-26061 [create-release] The indent of checkcompatibility.py is b…

2021-07-02 Thread GitBox
Apache9 opened a new pull request #3454: URL: https://github.com/apache/hbase/pull/3454 …roken after HBASE-25473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (HBASE-26061) [create-release] The indent of checkcompatibility.py is broken after HBASE-25473

2021-07-02 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26061: - Summary: [create-release] The indent of checkcompatibility.py is broken after HBASE-25473 Key: HBASE-26061 URL: https://issues.apache.org/jira/browse/HBASE-26061 Project:

[jira] [Updated] (HBASE-25473) [create-release] checkcompatibility.py failing with "KeyError: 'binary'"

2021-07-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25473: -- Component/s: scripts > [create-release] checkcompatibility.py failing with "KeyError: 'binary'" >

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-873039867 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26051) Remove reflections used to access HDFS EC APIs

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373514#comment-17373514 ] Hudson commented on HBASE-26051: Results for branch master [build #336 on

[jira] [Commented] (HBASE-26041) Replace PrintThreadInfoHelper with HBase's own ReflectionUtils.printThreadInfo()

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373513#comment-17373513 ] Hudson commented on HBASE-26041: Results for branch master [build #336 on

[jira] [Commented] (HBASE-26059) Set version as 3.0.0-alpha-1 in master in prep for first RC of 3.0.0-alpha-1

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373512#comment-17373512 ] Hudson commented on HBASE-26059: Results for branch master [build #336 on

[jira] [Commented] (HBASE-26035) Redundant null check in the compareTo function

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373511#comment-17373511 ] Hudson commented on HBASE-26035: Results for branch master [build #336 on

[jira] [Commented] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373510#comment-17373510 ] Hudson commented on HBASE-22923: Results for branch master [build #336 on

[jira] [Commented] (HBASE-25902) Add missing CFs in meta during HBase 1 to 2.3+ Upgrade

2021-07-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373509#comment-17373509 ] Hudson commented on HBASE-25902: Results for branch master [build #336 on

[GitHub] [hbase] Apache-HBase commented on pull request #3356: HBASE-25973 Balancer should explain progress in a better way in log

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3356: URL: https://github.com/apache/hbase/pull/3356#issuecomment-872977588 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3356: HBASE-25973 Balancer should explain progress in a better way in log

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3356: URL: https://github.com/apache/hbase/pull/3356#issuecomment-872975020 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-872961104 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3356: HBASE-25973 Balancer should explain progress in a better way in log

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3356: URL: https://github.com/apache/hbase/pull/3356#issuecomment-872911228 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-872894129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Comment Edited] (HBASE-26026) HBase Write may be stuck forever when using CompactingMemStore

2021-07-02 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370389#comment-17370389 ] chenglei edited comment on HBASE-26026 at 7/2/21, 9:32 AM: --- [~zhangduo],would

[GitHub] [hbase] Apache-HBase commented on pull request #3451: HBASE-26056 Cell TTL set to -1 should mean never expire, the same as CF TTL

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3451: URL: https://github.com/apache/hbase/pull/3451#issuecomment-872854818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3451: HBASE-26056 Cell TTL set to -1 should mean never expire, the same as CF TTL

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3451: URL: https://github.com/apache/hbase/pull/3451#issuecomment-872849122 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-872847117 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-872843982 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] jojochuang commented on pull request #3443: HBASE-25516 [JDK17] reflective access Field.class.getDeclaredField("modifiers") not supported

2021-07-02 Thread GitBox
jojochuang commented on pull request #3443: URL: https://github.com/apache/hbase/pull/3443#issuecomment-872841564 I'm ok either way. So far, I have not yet seen an incompatible change required, so branch-2 can support too. -- This is an automated message from the Apache Git Service. To

[jira] [Resolved] (HBASE-26057) Remove reflections used to access Hadoop 2 API in FanOutOneBlockAsyncDFSOutputHelper

2021-07-02 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HBASE-26057. - Resolution: Fixed > Remove reflections used to access Hadoop 2 API in >

[GitHub] [hbase] jojochuang merged pull request #3448: HBASE-26057 Remove reflections used to access Hadoop 2 API in FanOutOneBlockAsyncDFSOutputHelper

2021-07-02 Thread GitBox
jojochuang merged pull request #3448: URL: https://github.com/apache/hbase/pull/3448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-872840091 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] jojochuang commented on pull request #3448: HBASE-26057 Remove reflections used to access Hadoop 2 API in FanOutOneBlockAsyncDFSOutputHelper

2021-07-02 Thread GitBox
jojochuang commented on pull request #3448: URL: https://github.com/apache/hbase/pull/3448#issuecomment-872839938 Merging this one. Thanks for the review @saintstack @Apache9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] mokai87 commented on pull request #3432: HBASE-26030 hbase-cleanup.sh did not clean the wal dir if hbase.wal.dir configured individually

2021-07-02 Thread GitBox
mokai87 commented on pull request #3432: URL: https://github.com/apache/hbase/pull/3432#issuecomment-872829123 Yes, it depends on the scheme of path. I tested it on HDFS and OBS both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HBASE-25761) POC: hbase:meta,,1 as ROOT

2021-07-02 Thread Francis Christopher Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1737#comment-1737 ] Francis Christopher Liu commented on HBASE-25761: - [~stack] Sounds good I'll integrate

[GitHub] [hbase] nyl3532016 edited a comment on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-07-02 Thread GitBox
nyl3532016 edited a comment on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-872368228 > Now I have another question. Seems we maintain the compacting files in compaction server. Keep compacting files is useful if you want to run multiple compactions on

[jira] [Commented] (HBASE-26036) DBB released too early and dirty data for some operations

2021-07-02 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373322#comment-17373322 ] Xiaolin Ha commented on HBASE-26036: [~anoop.hbase] Thanks for the comments, I agree with you.  >

[jira] [Updated] (HBASE-26036) DBB released too early and dirty data for some operations

2021-07-02 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-26036: --- Summary: DBB released too early and dirty data for some operations (was: DBB released too early in

[jira] [Commented] (HBASE-25902) Add missing CFs in meta during HBase 1 to 2.3+ Upgrade

2021-07-02 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373300#comment-17373300 ] Viraj Jasani commented on HBASE-25902: -- Btw [~apurtell] has some suggestions over not aborting

[jira] [Updated] (HBASE-25902) Add missing CFs in meta during HBase 1 to 2.3+ Upgrade

2021-07-02 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25902: - Release Note: While upgrading cluster from 1.x to 2.3+ versions, after the active master is

[jira] [Updated] (HBASE-25902) Add missing CFs in meta during HBase 1 to 2.3+ Upgrade

2021-07-02 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25902: - Summary: Add missing CFs in meta during HBase 1 to 2.3+ Upgrade (was: 1.x to 2.3.x upgrade

[GitHub] [hbase] Apache-HBase commented on pull request #3451: HBASE-26056 Cell TTL set to -1 should mean never expire, the same as CF TTL

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3451: URL: https://github.com/apache/hbase/pull/3451#issuecomment-872781464 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-26060) Put up 3.0.0-alpha-1RC0

2021-07-02 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26060: - Assignee: Duo Zhang > Put up 3.0.0-alpha-1RC0 > --- > >

[GitHub] [hbase] Apache-HBase commented on pull request #3448: HBASE-26057 Remove reflections used to access Hadoop 2 API in FanOutOneBlockAsyncDFSOutputHelper

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3448: URL: https://github.com/apache/hbase/pull/3448#issuecomment-872776958 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3448: HBASE-26057 Remove reflections used to access Hadoop 2 API in FanOutOneBlockAsyncDFSOutputHelper

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3448: URL: https://github.com/apache/hbase/pull/3448#issuecomment-872774973 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3448: HBASE-26057 Remove reflections used to access Hadoop 2 API in FanOutOneBlockAsyncDFSOutputHelper

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3448: URL: https://github.com/apache/hbase/pull/3448#issuecomment-872773489 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3451: HBASE-26056 Cell TTL set to -1 should mean never expire, the same as CF TTL

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3451: URL: https://github.com/apache/hbase/pull/3451#issuecomment-872754166 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on pull request #3423: HBASE-26017 fix pe tool totalRows exceed maximum of int

2021-07-02 Thread GitBox
Apache9 commented on pull request #3423: URL: https://github.com/apache/hbase/pull/3423#issuecomment-872752883 Please add some comments in the code? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] Apache-HBase commented on pull request #3360: HBASE-25975 Row Commit Sequencer

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3360: URL: https://github.com/apache/hbase/pull/3360#issuecomment-872750232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-26050) Remove the reflection used in FSUtils.isInSafeMode

2021-07-02 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HBASE-26050. - Fix Version/s: 3.0.0-alpha-2 2.5.0 Resolution: Fixed > Remove

[GitHub] [hbase] Apache-HBase commented on pull request #3451: HBASE-26056 Cell TTL set to -1 should mean never expire, the same as CF TTL

2021-07-02 Thread GitBox
Apache-HBase commented on pull request #3451: URL: https://github.com/apache/hbase/pull/3451#issuecomment-872749686 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] jojochuang merged pull request #3445: HBASE-26050 Remove the reflection used in FSUtils.isInSafeMode

2021-07-02 Thread GitBox
jojochuang merged pull request #3445: URL: https://github.com/apache/hbase/pull/3445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] jojochuang commented on pull request #3445: HBASE-26050 Remove the reflection used in FSUtils.isInSafeMode

2021-07-02 Thread GitBox
jojochuang commented on pull request #3445: URL: https://github.com/apache/hbase/pull/3445#issuecomment-872747487 The test came back green so I'll merge it. Thanks for the review, @saintstack @Apache9 @virajjasani -- This is an automated message from the Apache Git Service. To respond