[GitHub] [hbase] virajjasani edited a comment on pull request #3581: HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group)

2021-08-16 Thread GitBox
virajjasani edited a comment on pull request #3581: URL: https://github.com/apache/hbase/pull/3581#issuecomment-87414 Changes look good (and this is indeed must-have change, I have seen cluster not coming up well if stop all services and start them soon as regions with destination

[GitHub] [hbase] virajjasani commented on pull request #3581: HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to bra

2021-08-16 Thread GitBox
virajjasani commented on pull request #3581: URL: https://github.com/apache/hbase/pull/3581#issuecomment-87414 Changes look good (and this is indeed must-have change, I have seen cluster not coming up well if stop all services and start them soon), I have retriggered QA build. Let's

[GitHub] [hbase] sunhelly commented on a change in pull request #3489: HBASE-26087 JVM crash when displaying RPC params by MonitoredRPCHandler

2021-08-16 Thread GitBox
sunhelly commented on a change in pull request #3489: URL: https://github.com/apache/hbase/pull/3489#discussion_r690025427 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java ## @@ -43,6 +43,8 @@ private String

[jira] [Commented] (HBASE-26198) RegionServer dead on hadoop 3.3.1: NoSuchMethodError LocatedBlocks.getLocations()

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400115#comment-17400115 ] Michael Stack commented on HBASE-26198: --- We cannot vouch for vendor version of HBase >

[jira] [Commented] (HBASE-26196) Support configuration override for remote cluster of HFileOutputFormat locality sensitive

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400113#comment-17400113 ] Michael Stack commented on HBASE-26196: --- Thanks for improving release note. Make sub task for

[jira] [Updated] (HBASE-26203) Minor cleanups to reduce checkstyle warnings on backup code

2021-08-16 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-26203: Description: As suggested in this PR -->

[GitHub] [hbase] rda3mon commented on a change in pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup

2021-08-16 Thread GitBox
rda3mon commented on a change in pull request #3359: URL: https://github.com/apache/hbase/pull/3359#discussion_r689997830 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java ## @@ -178,11 +174,10 @@ public String toString() {

[jira] [Created] (HBASE-26203) Minor cleanups to reduce checkstyle warnings on backup code

2021-08-16 Thread Mallikarjun (Jira)
Mallikarjun created HBASE-26203: --- Summary: Minor cleanups to reduce checkstyle warnings on backup code Key: HBASE-26203 URL: https://issues.apache.org/jira/browse/HBASE-26203 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #3589: HBASE-26129 Backport HBASE-25481 "Add host and port attribute when tr…

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3589: URL: https://github.com/apache/hbase/pull/3589#issuecomment-899952561 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] rda3mon commented on a change in pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup

2021-08-16 Thread GitBox
rda3mon commented on a change in pull request #3359: URL: https://github.com/apache/hbase/pull/3359#discussion_r689993418 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java ## @@ -99,68 +95,19 @@ public

[jira] [Updated] (HBASE-26202) Review deprecated WALProcedureStore usage in Backup

2021-08-16 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-26202: Description: `WALProcedureStore` stands deprecated. Review its usage in Backup/Restore > Review

[jira] [Created] (HBASE-26202) Review deprecated WALProcedureStore usage in Backup

2021-08-16 Thread Mallikarjun (Jira)
Mallikarjun created HBASE-26202: --- Summary: Review deprecated WALProcedureStore usage in Backup Key: HBASE-26202 URL: https://issues.apache.org/jira/browse/HBASE-26202 Project: HBase Issue

[jira] [Assigned] (HBASE-26201) Backport HBASE-26196 to branch-1

2021-08-16 Thread Shinya Yoshida (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shinya Yoshida reassigned HBASE-26201: -- Assignee: Shinya Yoshida > Backport HBASE-26196 to branch-1 >

[jira] [Created] (HBASE-26201) Backport HBASE-26196 to branch-1

2021-08-16 Thread Shinya Yoshida (Jira)
Shinya Yoshida created HBASE-26201: -- Summary: Backport HBASE-26196 to branch-1 Key: HBASE-26201 URL: https://issues.apache.org/jira/browse/HBASE-26201 Project: HBase Issue Type: Sub-task

[jira] [Updated] (HBASE-26196) Support configuration override for remote cluster of HFileOutputFormat locality sensitive

2021-08-16 Thread Shinya Yoshida (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shinya Yoshida updated HBASE-26196: --- Release Note: Allow any configuration for the remote cluster in HFileOutputFormat2 that

[jira] [Commented] (HBASE-26196) Support configuration override for remote cluster of HFileOutputFormat locality sensitive

2021-08-16 Thread Shinya Yoshida (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400093#comment-17400093 ] Shinya Yoshida commented on HBASE-26196: Thank you for merging and handling backport to 2.4. I'd

[GitHub] [hbase] rda3mon commented on a change in pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup

2021-08-16 Thread GitBox
rda3mon commented on a change in pull request #3359: URL: https://github.com/apache/hbase/pull/3359#discussion_r689984154 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java ## @@ -514,24 +513,6 @@ public void

[GitHub] [hbase] rda3mon commented on a change in pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup

2021-08-16 Thread GitBox
rda3mon commented on a change in pull request #3359: URL: https://github.com/apache/hbase/pull/3359#discussion_r689984154 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java ## @@ -514,24 +513,6 @@ public void

[GitHub] [hbase] rda3mon commented on pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup

2021-08-16 Thread GitBox
rda3mon commented on pull request #3359: URL: https://github.com/apache/hbase/pull/3359#issuecomment-899940780 @saintstack I dont have anything for this one. Unless there are some suggestions. Can we merge if no comments? @Apache9 ? -- This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #3589: HBASE-26129 Backport HBASE-25481 "Add host and port attribute when tr…

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3589: URL: https://github.com/apache/hbase/pull/3589#issuecomment-899932059 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26198) RegionServer dead on hadoop 3.3.1: NoSuchMethodError LocatedBlocks.getLocations()

2021-08-16 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400070#comment-17400070 ] Wei-Chiu Chuang commented on HBASE-26198: - I am pretty sure CDH6.2 HBase doesn't compile against

[jira] [Commented] (HBASE-26199) hbck2 should support remove deleted meta region

2021-08-16 Thread mengqi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400065#comment-17400065 ] mengqi commented on HBASE-26199: Our hbase version is 2.1.0-cdh6.2.0 This situation happened when a lot

[jira] [Resolved] (HBASE-26128) Backport HBASE-25454 "Add trace support for connection registry" to branch-2

2021-08-16 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-26128. -- Resolution: Fixed > Backport HBASE-25454 "Add trace support for connection

[jira] [Commented] (HBASE-26128) Backport HBASE-25454 "Add trace support for connection registry" to branch-2

2021-08-16 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400063#comment-17400063 ] Tak-Lon (Stephen) Wu commented on HBASE-26128: -- merged to feature branch 

[jira] [Assigned] (HBASE-26129) Backport HBASE-25481 "Add host and port attribute when tracing rpc call at client side" to branch-2

2021-08-16 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu reassigned HBASE-26129: Assignee: Tak-Lon (Stephen) Wu > Backport HBASE-25481 "Add host and port

[jira] [Work started] (HBASE-26129) Backport HBASE-25481 "Add host and port attribute when tracing rpc call at client side" to branch-2

2021-08-16 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26129 started by Tak-Lon (Stephen) Wu. > Backport HBASE-25481 "Add host and port attribute when

[jira] [Commented] (HBASE-26198) RegionServer dead on hadoop 3.3.1: NoSuchMethodError LocatedBlocks.getLocations()

2021-08-16 Thread mengqi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400062#comment-17400062 ] mengqi commented on HBASE-26198: Our hbase version is 2.1.0-cdh6.2.0 > RegionServer dead on hadoop

[jira] [Resolved] (HBASE-24842) make export snapshot report size can be config

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24842. --- Fix Version/s: 3.0.0-alpha-2 Hadoop Flags: Reviewed Release Note: Set new config

[GitHub] [hbase] saintstack merged pull request #2233: HBASE-24842 make export snapshot report size can be config

2021-08-16 Thread GitBox
saintstack merged pull request #2233: URL: https://github.com/apache/hbase/pull/2233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-24570) connection#close throws NPE

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24570: -- Fix Version/s: 2.3.7 2.4.6 2.5.0 Resolution:

[GitHub] [hbase] saintstack closed pull request #2082: HBASE-24570 connection#close throws NPE

2021-08-16 Thread GitBox
saintstack closed pull request #2082: URL: https://github.com/apache/hbase/pull/2082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] saintstack commented on pull request #2082: HBASE-24570 connection#close throws NPE

2021-08-16 Thread GitBox
saintstack commented on pull request #2082: URL: https://github.com/apache/hbase/pull/2082#issuecomment-899897356 Applied manually to branch-2.3=>branch-2... Doesn't work against master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] ndimiduk commented on pull request #1647: add IntelliJ project files

2021-08-16 Thread GitBox
ndimiduk commented on pull request #1647: URL: https://github.com/apache/hbase/pull/1647#issuecomment-899890716 Dropping this one. It seems IntelliJ won't let us exclude the detailed JDK specification from the project definitions. -- This is an automated message from the Apache Git

[GitHub] [hbase] ndimiduk closed pull request #1647: add IntelliJ project files

2021-08-16 Thread GitBox
ndimiduk closed pull request #1647: URL: https://github.com/apache/hbase/pull/1647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-26191) Annotate shaded generated protobuf as InterfaceAudience.Private

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400055#comment-17400055 ] Michael Stack commented on HBASE-26191: --- {quote}Perhaps we can use something like

[GitHub] [hbase] Apache-HBase commented on pull request #3589: HBASE-26129 Backport HBASE-25481 "Add host and port attribute when tr…

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3589: URL: https://github.com/apache/hbase/pull/3589#issuecomment-899885776 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24652) master-status UI make date type fields sortable

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400049#comment-17400049 ] Michael Stack commented on HBASE-24652: --- HBASE-25165 is where I took us in the wrong direction

[GitHub] [hbase] Apache-HBase commented on pull request #3588: HBASE-24337 Backport HBASE-23968 to branch-2

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3588: URL: https://github.com/apache/hbase/pull/3588#issuecomment-899879329 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3588: HBASE-24337 Backport HBASE-23968 to branch-2

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3588: URL: https://github.com/apache/hbase/pull/3588#issuecomment-899876060 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-24652) master-status UI make date type fields sortable

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24652. --- Fix Version/s: 2.3.7 2.4.6 2.5.0 Hadoop Flags:

[GitHub] [hbase] saintstack closed pull request #1993: HBASE-24652 master-status UI, make date type fields sortable

2021-08-16 Thread GitBox
saintstack closed pull request #1993: URL: https://github.com/apache/hbase/pull/1993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] saintstack commented on pull request #1993: HBASE-24652 master-status UI, make date type fields sortable

2021-08-16 Thread GitBox
saintstack commented on pull request #1993: URL: https://github.com/apache/hbase/pull/1993#issuecomment-899873568 Merged manually to branch-2.3+. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #3581: HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to br

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3581: URL: https://github.com/apache/hbase/pull/3581#issuecomment-899872059 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] taklwu opened a new pull request #3589: HBASE-26129 Backport HBASE-25481 "Add host and port attribute when tr…

2021-08-16 Thread GitBox
taklwu opened a new pull request #3589: URL: https://github.com/apache/hbase/pull/3589 …acing rpc call at client side" to branch-2 6/17 commits of HBASE-22120, original commit ae2c62ffaad5ba4c976b0a79c10a365edf2844fd -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (HBASE-26129) Backport HBASE-25481 "Add host and port attribute when tracing rpc call at client side" to branch-2

2021-08-16 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26129: - Description: 6/17 commits of HBASE-22120, original commit

[GitHub] [hbase] Apache-HBase commented on pull request #3579: HBASE-26189 Reduce log level of CompactionProgress notice to DEBUG

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3579: URL: https://github.com/apache/hbase/pull/3579#issuecomment-899854438 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3587: Backport "HBASE-6908: Add pluggable rpc queue implementation (#3522)" to branch-2.3

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3587: URL: https://github.com/apache/hbase/pull/3587#issuecomment-899851748 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3579: HBASE-26189 Reduce log level of CompactionProgress notice to DEBUG

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3579: URL: https://github.com/apache/hbase/pull/3579#issuecomment-899849738 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3587: Backport "HBASE-6908: Add pluggable rpc queue implementation (#3522)" to branch-2.3

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3587: URL: https://github.com/apache/hbase/pull/3587#issuecomment-899813550 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-26200) Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of HBASE-24652

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-26200. --- Fix Version/s: 2.3.7 2.4.6 3.0.0-alpha-2

[jira] [Comment Edited] (HBASE-26200) Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of HBASE-24652

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1737#comment-1737 ] Michael Stack edited comment on HBASE-26200 at 8/16/21, 8:43 PM: -

[jira] [Commented] (HBASE-26200) Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of HBASE-24652

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1737#comment-1737 ] Michael Stack commented on HBASE-26200: --- HBASE-25165 had us show 'start time' as ISO8601 which our

[jira] [Created] (HBASE-26200) Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of HBASE-24652

2021-08-16 Thread Michael Stack (Jira)
Michael Stack created HBASE-26200: - Summary: Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of HBASE-24652 Key: HBASE-26200 URL: https://issues.apache.org/jira/browse/HBASE-26200

[jira] [Commented] (HBASE-26191) Annotate shaded generated protobuf as InterfaceAudience.Private

2021-08-16 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399984#comment-17399984 ] Nick Dimiduk commented on HBASE-26191: -- An interface for decoration of generated classes looks like

[GitHub] [hbase] caroliney14 commented on pull request #3581: HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to bra

2021-08-16 Thread GitBox
caroliney14 commented on pull request #3581: URL: https://github.com/apache/hbase/pull/3581#issuecomment-899772548 @bharathv nothing I can think of, thanks for the review. I also backported HBASE-25298 as you suggested. -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (HBASE-25849) Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to branch-1

2021-08-16 Thread Caroline Zhou (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline Zhou updated HBASE-25849: -- Summary: Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups

[GitHub] [hbase] Apache-HBase commented on pull request #3588: HBASE-24337 Backport HBASE-23968 to branch-2

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3588: URL: https://github.com/apache/hbase/pull/3588#issuecomment-899769348 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-899768520 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bharathv commented on pull request #3581: HBASE-25849 Backport HBASE-22738 & HBASE-24760 (Fallback feature for RS groups when there are no RS in current group) to branch-1

2021-08-16 Thread GitBox
bharathv commented on pull request #3581: URL: https://github.com/apache/hbase/pull/3581#issuecomment-899762733 Backport lgtm. @caroliney14 Any tricky conflicts you ran into that needs a closer look? If not we can merge this. -- This is an automated message from the Apache Git

[jira] [Resolved] (HBASE-6908) Pluggable Call BlockingQueue for HBaseServer

2021-08-16 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-6908. - Resolution: Fixed Nevermind. Let's not backport new features to existing patch release lines. >

[GitHub] [hbase] ndimiduk commented on pull request #3587: Backport "HBASE-6908: Add pluggable rpc queue implementation (#3522)" to branch-2.3

2021-08-16 Thread GitBox
ndimiduk commented on pull request #3587: URL: https://github.com/apache/hbase/pull/3587#issuecomment-899751912 Nevermind. Let's not backport new features to existing patch release lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] ndimiduk closed pull request #3587: Backport "HBASE-6908: Add pluggable rpc queue implementation (#3522)" to branch-2.3

2021-08-16 Thread GitBox
ndimiduk closed pull request #3587: URL: https://github.com/apache/hbase/pull/3587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3579: HBASE-26189 Reduce log level of CompactionProgress notice to DEBUG

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3579: URL: https://github.com/apache/hbase/pull/3579#issuecomment-899751794 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] z-york commented on a change in pull request #3583: HBASE-26193 Do not store meta region location as permanent state on z…

2021-08-16 Thread GitBox
z-york commented on a change in pull request #3583: URL: https://github.com/apache/hbase/pull/3583#discussion_r689789751 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -753,8 +763,49 @@ private void initializeZKBasedSystemTrackers()

[GitHub] [hbase] saintstack commented on pull request #2003: HBASE-24633 Remove data locality and StoreFileCostFunction for replic…

2021-08-16 Thread GitBox
saintstack commented on pull request #2003: URL: https://github.com/apache/hbase/pull/2003#issuecomment-899743828 @huaxiangsun You want to refresh this PR or is it stale now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (HBASE-24339) Backport HBASE-23968 to branch-1

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24339. --- Resolution: Won't Fix > Backport HBASE-23968 to branch-1 >

[jira] [Commented] (HBASE-24339) Backport HBASE-23968 to branch-1

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399945#comment-17399945 ] Michael Stack commented on HBASE-24339: --- I closed the PR. No more releases off branch-1. Resolving

[GitHub] [hbase] saintstack commented on pull request #1673: HBASE-24339 Backport HBASE-23968 to branch-1

2021-08-16 Thread GitBox
saintstack commented on pull request #1673: URL: https://github.com/apache/hbase/pull/1673#issuecomment-899740355 Closing. No more releases off branch-1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] saintstack closed pull request #1673: HBASE-24339 Backport HBASE-23968 to branch-1

2021-08-16 Thread GitBox
saintstack closed pull request #1673: URL: https://github.com/apache/hbase/pull/1673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-24337) Backport HBASE-23968 to branch-2

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399944#comment-17399944 ] Michael Stack commented on HBASE-24337: --- Refreshed PR. > Backport HBASE-23968 to branch-2 >

[GitHub] [hbase] saintstack commented on a change in pull request #3489: HBASE-26087 JVM crash when displaying RPC params by MonitoredRPCHandler

2021-08-16 Thread GitBox
saintstack commented on a change in pull request #3489: URL: https://github.com/apache/hbase/pull/3489#discussion_r689760442 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java ## @@ -43,6 +43,8 @@ private String

[GitHub] [hbase] ndimiduk commented on pull request #3587: Backport "HBASE-6908: Add pluggable rpc queue implementation (#3522)" to branch-2.3

2021-08-16 Thread GitBox
ndimiduk commented on pull request #3587: URL: https://github.com/apache/hbase/pull/3587#issuecomment-899722100 Patch from branch-2.4 applies cleanly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] ndimiduk opened a new pull request #3587: Backport "HBASE-6908: Add pluggable rpc queue implementation (#3522)" to branch-2.3

2021-08-16 Thread GitBox
ndimiduk opened a new pull request #3587: URL: https://github.com/apache/hbase/pull/3587 Can pass in a FQCN to load as the call queue implementation. Standardized arguments to the constructor are the max queue length, the PriorityFunction, and the Configuration.

[GitHub] [hbase] saintstack commented on pull request #3447: HBASE-26055 Master local region "table" should be considered a system…

2021-08-16 Thread GitBox
saintstack commented on pull request #3447: URL: https://github.com/apache/hbase/pull/3447#issuecomment-899721752 Any resolution here. We going to add a flag to bypass new logic? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Reopened] (HBASE-6908) Pluggable Call BlockingQueue for HBaseServer

2021-08-16 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-6908: - Reopening for branch-2.3 backport. > Pluggable Call BlockingQueue for HBaseServer >

[GitHub] [hbase] saintstack commented on pull request #3502: HBASE-26097: to resolve hbase version 2.x protobuf version conflict

2021-08-16 Thread GitBox
saintstack commented on pull request #3502: URL: https://github.com/apache/hbase/pull/3502#issuecomment-899719368 Actually close! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] saintstack closed pull request #3502: HBASE-26097: to resolve hbase version 2.x protobuf version conflict

2021-08-16 Thread GitBox
saintstack closed pull request #3502: URL: https://github.com/apache/hbase/pull/3502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] saintstack commented on pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup

2021-08-16 Thread GitBox
saintstack commented on pull request #3359: URL: https://github.com/apache/hbase/pull/3359#issuecomment-899718573 Do you want to push a new PR here @rda3mon ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] saintstack commented on a change in pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup

2021-08-16 Thread GitBox
saintstack commented on a change in pull request #3359: URL: https://github.com/apache/hbase/pull/3359#discussion_r689755547 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java ## @@ -514,24 +513,6 @@ public void

[jira] [Resolved] (HBASE-26037) Implement namespace and table level access control for thrift & thrift2

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-26037. --- Fix Version/s: 3.0.0-alpha-2 Hadoop Flags: Reviewed Resolution: Fixed Merged to

[GitHub] [hbase] clarax commented on a change in pull request #3575: HBASE-26178 Improve data structure and algorithm for BalanceClusterSt…

2021-08-16 Thread GitBox
clarax commented on a change in pull request #3575: URL: https://github.com/apache/hbase/pull/3575#discussion_r689754575 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerClusterState.java ## @@ -207,15 +212,20 @@ public String

[GitHub] [hbase] saintstack merged pull request #3437: HBASE-26037 Implement namespace and table level access control for thrift & thrift2

2021-08-16 Thread GitBox
saintstack merged pull request #3437: URL: https://github.com/apache/hbase/pull/3437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] bbeaudreault commented on pull request #3565: HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned

2021-08-16 Thread GitBox
bbeaudreault commented on pull request #3565: URL: https://github.com/apache/hbase/pull/3565#issuecomment-899709916 Hey @saintstack, sorry I've been distracted by internal stuff the last few work days. But will be getting back to this this week. Yes, this PR needs to be updated based on

[GitHub] [hbase] clarax commented on a change in pull request #3575: HBASE-26178 Improve data structure and algorithm for BalanceClusterSt…

2021-08-16 Thread GitBox
clarax commented on a change in pull request #3575: URL: https://github.com/apache/hbase/pull/3575#discussion_r689747141 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerClusterState.java ## @@ -207,15 +212,20 @@ public String

[GitHub] [hbase] saintstack commented on pull request #3426: HBASE-26032 Make HRegion.getStores() an O(1) operation

2021-08-16 Thread GitBox
saintstack commented on pull request #3426: URL: https://github.com/apache/hbase/pull/3426#issuecomment-899707261 Kicking @anoopsjohn again!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-26017) hbase performance evaluation tool could not support datasize more than 2048g

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399898#comment-17399898 ] Michael Stack commented on HBASE-26017: --- The PR looks good. I left some comments. Can do the

[jira] [Commented] (HBASE-26016) HFilePrettyPrinter tool can not print the last LEAF_INDEX block or BLOOM_CHUNK.

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399889#comment-17399889 ] Michael Stack commented on HBASE-26016: --- [~dingwei2019] over on PR asking for example of the fix

[GitHub] [hbase] saintstack commented on pull request #3418: HBASE-26016 fix pretty tool print header missing last indexblock and bloomchunk

2021-08-16 Thread GitBox
saintstack commented on pull request #3418: URL: https://github.com/apache/hbase/pull/3418#issuecomment-899700503 @dingwei-2017 Patch looks good. Was wondering if an example of it working? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (HBASE-25996) add hbase hbck result on jmx

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399888#comment-17399888 ] Michael Stack commented on HBASE-25996: --- Please say more about why we would do this? > add hbase

[GitHub] [hbase] Apache-HBase commented on pull request #3574: HBASE-26187 Write straight into the store directory when Splitting an…

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3574: URL: https://github.com/apache/hbase/pull/3574#issuecomment-899696004 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack closed pull request #3576: HBASE-26122: Only create ScannerContext for Gets with setMaxResultSize > 0 (ADDENDUM)

2021-08-16 Thread GitBox
saintstack closed pull request #3576: URL: https://github.com/apache/hbase/pull/3576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] saintstack commented on pull request #3576: HBASE-26122: Only create ScannerContext for Gets with setMaxResultSize > 0 (ADDENDUM)

2021-08-16 Thread GitBox
saintstack commented on pull request #3576: URL: https://github.com/apache/hbase/pull/3576#issuecomment-899693695 Closing as original was reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #3586: HBASE-26197 Fix some obvious bugs in MultiByteBuff.put

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3586: URL: https://github.com/apache/hbase/pull/3586#issuecomment-899692307 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26196) Support configuration override for remote cluster of HFileOutputFormat locality sensitive

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399867#comment-17399867 ] Michael Stack commented on HBASE-26196: --- Thanks for PR [~lineyshinya] . Pushed to branch-2.4+. It

[GitHub] [hbase] Apache-HBase commented on pull request #3586: HBASE-26197 Fix some obvious bugs in MultiByteBuff.put

2021-08-16 Thread GitBox
Apache-HBase commented on pull request #3586: URL: https://github.com/apache/hbase/pull/3586#issuecomment-899691613 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-26196) Support configuration override for remote cluster of HFileOutputFormat locality sensitive

2021-08-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-26196: -- Fix Version/s: 2.4.6 3.0.0-alpha-2 2.5.0 Hadoop

[GitHub] [hbase] saintstack merged pull request #3582: HBASE-26196 Support configuration override for remote cluster of HFileOutputFormat locality sensitive

2021-08-16 Thread GitBox
saintstack merged pull request #3582: URL: https://github.com/apache/hbase/pull/3582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-26147) Add dry run mode to hbase balancer

2021-08-16 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26147: - Fix Version/s: 3.0.0-alpha-2 2.5.0 > Add dry run mode to hbase balancer >

[GitHub] [hbase] ndimiduk commented on a change in pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves

2021-08-16 Thread GitBox
ndimiduk commented on a change in pull request #3536: URL: https://github.com/apache/hbase/pull/3536#discussion_r689717013 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalanceRequest.java ## @@ -0,0 +1,96 @@ +/* + * + * Licensed to the Apache

[jira] [Commented] (HBASE-26186) "Packaging and Integration" stage broken on branch-2 since 8bc180c7737bbd1792851004625c552896bf57c6

2021-08-16 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399830#comment-17399830 ] Nick Dimiduk commented on HBASE-26186: -- In fact we do make use of it... > "Packaging and

  1   2   >