[GitHub] [hbase] virajjasani edited a comment on pull request #3581: HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group)
virajjasani edited a comment on pull request #3581: URL: https://github.com/apache/hbase/pull/3581#issuecomment-87414 Changes look good (and this is indeed must-have change, I have seen cluster not coming up well if stop all services and start them soon as regions with destination bogus server are stuck), I have retriggered QA build. Let's wait one more time and this can be merged most likely by today EOD. Thanks @caroliney14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #3581: HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to bra
virajjasani commented on pull request #3581: URL: https://github.com/apache/hbase/pull/3581#issuecomment-87414 Changes look good (and this is indeed must-have change, I have seen cluster not coming up well if stop all services and start them soon), I have retriggered QA build. Let's wait one more time and this can be merged most likely by today EOD. Thanks @caroliney14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sunhelly commented on a change in pull request #3489: HBASE-26087 JVM crash when displaying RPC params by MonitoredRPCHandler
sunhelly commented on a change in pull request #3489:
URL: https://github.com/apache/hbase/pull/3489#discussion_r690025427
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
##
@@ -43,6 +43,8 @@
private String methodName = "";
private Object [] params = {};
private Message packet;
+ private boolean isSnapshot = false;
Review comment:
Thanks, I'll change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-26198) RegionServer dead on hadoop 3.3.1: NoSuchMethodError LocatedBlocks.getLocations()
[ https://issues.apache.org/jira/browse/HBASE-26198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400115#comment-17400115 ] Michael Stack commented on HBASE-26198: --- We cannot vouch for vendor version of HBase > RegionServer dead on hadoop 3.3.1: NoSuchMethodError > LocatedBlocks.getLocations() > - > > Key: HBASE-26198 > URL: https://issues.apache.org/jira/browse/HBASE-26198 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: mengqi >Priority: Major > Attachments: 4ad46153842c29898189b90fc986925c87966ce6.diff, > image-2021-08-16-16-24-32-418.png > > > !image-2021-08-16-16-24-32-418.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26196) Support configuration override for remote cluster of HFileOutputFormat locality sensitive
[ https://issues.apache.org/jira/browse/HBASE-26196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400113#comment-17400113 ] Michael Stack commented on HBASE-26196: --- Thanks for improving release note. Make sub task for branch 1 but releases off branch 1 are coming to an end is my understanding. See dev mailing lust for discussion. Thanks > Support configuration override for remote cluster of HFileOutputFormat > locality sensitive > - > > Key: HBASE-26196 > URL: https://issues.apache.org/jira/browse/HBASE-26196 > Project: HBase > Issue Type: Bug > Components: mapreduce >Affects Versions: 1.8.0, 3.0.0-alpha-2, 2.4.5 >Reporter: Shinya Yoshida >Assignee: Shinya Yoshida >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6 > > > We introduced support to generate hfile with good locality for a remote > cluster even in HBASE-25608. > I realized we need to override other configurations for the remote cluster in > addition to the zookeeper cluster key. > For example, read from a non-secure cluster and write hfiles for a secure > cluster. > In this case, we use TableInputFormat for non-secure cluster with > hbase.security.authentication=simple in job configuration. > So HFileOutputFormat failed to connect to remote secure cluster because > requires hbase.security.authentication=kerberos in job conf. > > Thus let's introduce configuration override for remote-cluster-aware > HFileOutputFormat locality-sensitive feature. > > -Another example is to read from a secure cluster (A) and write hfiles for > another secure cluster (B) and we use different principal for each cluster.- > -For instance, we use cluster-a/_h...@example.com for A and > cluster-b/_h...@example.com for B.- > -Then we need to override MASTER_KRB_PRINCIPAL and > REGIONSERVER_KRB_PRINCIPAL using cluster-b/_h...@example.com to connect > cluster B.- > ^ This is not truth, we use token based digest auth in mapper/reducer, so > principal difference for kerberos should be fine -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26203) Minor cleanups to reduce checkstyle warnings on backup code
[ https://issues.apache.org/jira/browse/HBASE-26203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-26203: Description: As suggested in this PR --> [https://github.com/apache/hbase/pull/3359#pullrequestreview-716511415] Created this issue to clean up Backup classes to reduce checkstyle warnings. was:`WALProcedureStore` stands deprecated. Review its usage in Backup/Restore > Minor cleanups to reduce checkstyle warnings on backup code > --- > > Key: HBASE-26203 > URL: https://issues.apache.org/jira/browse/HBASE-26203 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Affects Versions: 3.0.0-alpha-2 >Reporter: Mallikarjun >Assignee: Mallikarjun >Priority: Trivial > Fix For: 3.0.0-alpha-2 > > > As suggested in this PR --> > [https://github.com/apache/hbase/pull/3359#pullrequestreview-716511415] > Created this issue to clean up Backup classes to reduce checkstyle warnings. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] rda3mon commented on a change in pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup
rda3mon commented on a change in pull request #3359:
URL: https://github.com/apache/hbase/pull/3359#discussion_r689997830
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java
##
@@ -178,11 +174,10 @@ public String toString() {
final static byte[] BL_PREPARE = Bytes.toBytes("R");
Review comment:
Created issue here -->
https://issues.apache.org/jira/browse/HBASE-26203. Will raise PR in this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (HBASE-26203) Minor cleanups to reduce checkstyle warnings on backup code
Mallikarjun created HBASE-26203: --- Summary: Minor cleanups to reduce checkstyle warnings on backup code Key: HBASE-26203 URL: https://issues.apache.org/jira/browse/HBASE-26203 Project: HBase Issue Type: Improvement Components: backuprestore Affects Versions: 3.0.0-alpha-2 Reporter: Mallikarjun Assignee: Mallikarjun Fix For: 3.0.0-alpha-2 `WALProcedureStore` stands deprecated. Review its usage in Backup/Restore -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3589: HBASE-26129 Backport HBASE-25481 "Add host and port attribute when tr…
Apache-HBase commented on pull request #3589: URL: https://github.com/apache/hbase/pull/3589#issuecomment-899952561 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-25853 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 51s | HBASE-25853 passed | | +1 :green_heart: | compile | 2m 10s | HBASE-25853 passed | | +1 :green_heart: | shadedjars | 7m 54s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 34s | HBASE-25853 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 33s | the patch passed | | +1 :green_heart: | compile | 2m 12s | the patch passed | | +1 :green_heart: | javac | 2m 12s | the patch passed | | +1 :green_heart: | shadedjars | 8m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 52s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 2m 51s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 207m 57s | hbase-server in the patch passed. | | | | 249m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3589/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3589 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1b8d838cb5f9 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-25853 / 77b1dde130 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3589/1/testReport/ | | Max. process+thread count | 2649 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3589/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] rda3mon commented on a change in pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup
rda3mon commented on a change in pull request #3359:
URL: https://github.com/apache/hbase/pull/3359#discussion_r689993418
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java
##
@@ -99,68 +95,19 @@ public IncrementalBackupManager(Connection conn,
Configuration conf) throws IOEx
newTimestamps = readRegionServerLastLogRollResult();
logList = getLogFilesForNewBackup(previousTimestampMins, newTimestamps,
conf, savedStartCode);
-List logFromSystemTable =
-getLogFilesFromBackupSystem(previousTimestampMins, newTimestamps,
getBackupInfo()
-.getBackupRootDir());
-logList = excludeAlreadyBackedUpAndProcV2WALs(logList, logFromSystemTable);
+logList = excludeProcV2WALs(logList);
backupInfo.setIncrBackupFileList(logList);
return newTimestamps;
}
- /**
- * Get list of WAL files eligible for incremental backup.
- *
- * @return list of WAL files
- * @throws IOException if getting the list of WAL files fails
- */
- public List getIncrBackupLogFileList() throws IOException {
-List logList;
-HashMap newTimestamps;
-HashMap previousTimestampMins;
-
-String savedStartCode = readBackupStartCode();
-
-// key: tableName
-// value:
-HashMap> previousTimestampMap =
readLogTimestampMap();
-
-previousTimestampMins =
BackupUtils.getRSLogTimestampMins(previousTimestampMap);
-
-if (LOG.isDebugEnabled()) {
- LOG.debug("StartCode " + savedStartCode + "for backupID " +
backupInfo.getBackupId());
-}
-// get all new log files from .logs and .oldlogs after last TS and before
new timestamp
-if (savedStartCode == null || previousTimestampMins == null
-|| previousTimestampMins.isEmpty()) {
- throw new IOException(
- "Cannot read any previous back up timestamps from backup system
table. "
- + "In order to create an incremental backup, at least one full
backup is needed.");
-}
-
-newTimestamps = readRegionServerLastLogRollResult();
-
-logList = getLogFilesForNewBackup(previousTimestampMins, newTimestamps,
conf, savedStartCode);
-List logFromSystemTable =
-getLogFilesFromBackupSystem(previousTimestampMins, newTimestamps,
getBackupInfo()
-.getBackupRootDir());
-
-logList = excludeAlreadyBackedUpAndProcV2WALs(logList, logFromSystemTable);
-backupInfo.setIncrBackupFileList(logList);
-
-return logList;
- }
-
- private List excludeAlreadyBackedUpAndProcV2WALs(List
logList,
- List logFromSystemTable) {
-Set walFileNameSet = convertToSet(logFromSystemTable);
-
+ private List excludeProcV2WALs(List logList) {
List list = new ArrayList<>();
for (int i=0; i < logList.size(); i++) {
Path p = new Path(logList.get(i));
String name = p.getName();
- if (walFileNameSet.contains(name) ||
name.startsWith(WALProcedureStore.LOG_PREFIX)) {
+ if (name.startsWith(WALProcedureStore.LOG_PREFIX)) {
Review comment:
Create issue here --> https://issues.apache.org/jira/browse/HBASE-26202.
Will raise PR in this week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-26202) Review deprecated WALProcedureStore usage in Backup
[ https://issues.apache.org/jira/browse/HBASE-26202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-26202: Description: `WALProcedureStore` stands deprecated. Review its usage in Backup/Restore > Review deprecated WALProcedureStore usage in Backup > --- > > Key: HBASE-26202 > URL: https://issues.apache.org/jira/browse/HBASE-26202 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Affects Versions: 3.0.0-alpha-2 >Reporter: Mallikarjun >Assignee: Mallikarjun >Priority: Trivial > Fix For: 3.0.0-alpha-2 > > > `WALProcedureStore` stands deprecated. Review its usage in Backup/Restore -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-26202) Review deprecated WALProcedureStore usage in Backup
Mallikarjun created HBASE-26202: --- Summary: Review deprecated WALProcedureStore usage in Backup Key: HBASE-26202 URL: https://issues.apache.org/jira/browse/HBASE-26202 Project: HBase Issue Type: Improvement Components: backuprestore Affects Versions: 3.0.0-alpha-2 Reporter: Mallikarjun Assignee: Mallikarjun Fix For: 3.0.0-alpha-2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-26201) Backport HBASE-26196 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-26201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shinya Yoshida reassigned HBASE-26201: -- Assignee: Shinya Yoshida > Backport HBASE-26196 to branch-1 > > > Key: HBASE-26201 > URL: https://issues.apache.org/jira/browse/HBASE-26201 > Project: HBase > Issue Type: Sub-task >Reporter: Shinya Yoshida >Assignee: Shinya Yoshida >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-26201) Backport HBASE-26196 to branch-1
Shinya Yoshida created HBASE-26201: -- Summary: Backport HBASE-26196 to branch-1 Key: HBASE-26201 URL: https://issues.apache.org/jira/browse/HBASE-26201 Project: HBase Issue Type: Sub-task Reporter: Shinya Yoshida -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26196) Support configuration override for remote cluster of HFileOutputFormat locality sensitive
[ https://issues.apache.org/jira/browse/HBASE-26196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shinya Yoshida updated HBASE-26196: --- Release Note: Allow any configuration for the remote cluster in HFileOutputFormat2 that could be useful the different configuration from the job's configuration is necessary to connect the remote cluster, for instance, non-secure vs secure. (was: Allow zookeeper configuration for remote cluster in HFileOutputFormat2.) > Support configuration override for remote cluster of HFileOutputFormat > locality sensitive > - > > Key: HBASE-26196 > URL: https://issues.apache.org/jira/browse/HBASE-26196 > Project: HBase > Issue Type: Bug > Components: mapreduce >Affects Versions: 1.8.0, 3.0.0-alpha-2, 2.4.5 >Reporter: Shinya Yoshida >Assignee: Shinya Yoshida >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6 > > > We introduced support to generate hfile with good locality for a remote > cluster even in HBASE-25608. > I realized we need to override other configurations for the remote cluster in > addition to the zookeeper cluster key. > For example, read from a non-secure cluster and write hfiles for a secure > cluster. > In this case, we use TableInputFormat for non-secure cluster with > hbase.security.authentication=simple in job configuration. > So HFileOutputFormat failed to connect to remote secure cluster because > requires hbase.security.authentication=kerberos in job conf. > > Thus let's introduce configuration override for remote-cluster-aware > HFileOutputFormat locality-sensitive feature. > > -Another example is to read from a secure cluster (A) and write hfiles for > another secure cluster (B) and we use different principal for each cluster.- > -For instance, we use cluster-a/_h...@example.com for A and > cluster-b/_h...@example.com for B.- > -Then we need to override MASTER_KRB_PRINCIPAL and > REGIONSERVER_KRB_PRINCIPAL using cluster-b/_h...@example.com to connect > cluster B.- > ^ This is not truth, we use token based digest auth in mapper/reducer, so > principal difference for kerberos should be fine -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26196) Support configuration override for remote cluster of HFileOutputFormat locality sensitive
[ https://issues.apache.org/jira/browse/HBASE-26196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400093#comment-17400093 ] Shinya Yoshida commented on HBASE-26196: Thank you for merging and handling backport to 2.4. I'd like to backport it to branch-1. I'll create a subtask for it. Seems the release note is ambiguous, let me update it, please. > Support configuration override for remote cluster of HFileOutputFormat > locality sensitive > - > > Key: HBASE-26196 > URL: https://issues.apache.org/jira/browse/HBASE-26196 > Project: HBase > Issue Type: Bug > Components: mapreduce >Affects Versions: 1.8.0, 3.0.0-alpha-2, 2.4.5 >Reporter: Shinya Yoshida >Assignee: Shinya Yoshida >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6 > > > We introduced support to generate hfile with good locality for a remote > cluster even in HBASE-25608. > I realized we need to override other configurations for the remote cluster in > addition to the zookeeper cluster key. > For example, read from a non-secure cluster and write hfiles for a secure > cluster. > In this case, we use TableInputFormat for non-secure cluster with > hbase.security.authentication=simple in job configuration. > So HFileOutputFormat failed to connect to remote secure cluster because > requires hbase.security.authentication=kerberos in job conf. > > Thus let's introduce configuration override for remote-cluster-aware > HFileOutputFormat locality-sensitive feature. > > -Another example is to read from a secure cluster (A) and write hfiles for > another secure cluster (B) and we use different principal for each cluster.- > -For instance, we use cluster-a/_h...@example.com for A and > cluster-b/_h...@example.com for B.- > -Then we need to override MASTER_KRB_PRINCIPAL and > REGIONSERVER_KRB_PRINCIPAL using cluster-b/_h...@example.com to connect > cluster B.- > ^ This is not truth, we use token based digest auth in mapper/reducer, so > principal difference for kerberos should be fine -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] rda3mon commented on a change in pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup
rda3mon commented on a change in pull request #3359:
URL: https://github.com/apache/hbase/pull/3359#discussion_r689984154
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java
##
@@ -514,24 +513,6 @@ public void addIncrementalBackupTableSet(Set
tables) throws IOExcepti
systemTable.addIncrementalBackupTableSet(tables,
backupInfo.getBackupRootDir());
}
- /**
- * Saves list of WAL files after incremental backup operation. These files
will be stored until
- * TTL expiration and are used by Backup Log Cleaner plug-in to determine
which WAL files can be
- * safely purged.
- */
- public void recordWALFiles(List files) throws IOException {
-systemTable.addWALFiles(files, backupInfo.getBackupId(),
backupInfo.getBackupRootDir());
Review comment:
@saintstack Sorry, I missed to reply on this one.
There is more cleanup possible, but not everything can be removed. Do you
think It can be merged to `hbase:meta`? Or is there a recommendation on what
should be in `hbase:meta` and what shouldn't?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] rda3mon commented on a change in pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup
rda3mon commented on a change in pull request #3359:
URL: https://github.com/apache/hbase/pull/3359#discussion_r689984154
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java
##
@@ -514,24 +513,6 @@ public void addIncrementalBackupTableSet(Set
tables) throws IOExcepti
systemTable.addIncrementalBackupTableSet(tables,
backupInfo.getBackupRootDir());
}
- /**
- * Saves list of WAL files after incremental backup operation. These files
will be stored until
- * TTL expiration and are used by Backup Log Cleaner plug-in to determine
which WAL files can be
- * safely purged.
- */
- public void recordWALFiles(List files) throws IOException {
-systemTable.addWALFiles(files, backupInfo.getBackupId(),
backupInfo.getBackupRootDir());
Review comment:
@saintstack Sorry, I missed to reply on this one.
There is more cleanup possible, but not everything can be removed. Do you
think It can be merged to `hbase:meta`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] rda3mon commented on pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup
rda3mon commented on pull request #3359: URL: https://github.com/apache/hbase/pull/3359#issuecomment-899940780 @saintstack I dont have anything for this one. Unless there are some suggestions. Can we merge if no comments? @Apache9 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3589: HBASE-26129 Backport HBASE-25481 "Add host and port attribute when tr…
Apache-HBase commented on pull request #3589: URL: https://github.com/apache/hbase/pull/3589#issuecomment-899932059 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ HBASE-25853 Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 39s | HBASE-25853 passed | | +1 :green_heart: | compile | 1m 48s | HBASE-25853 passed | | +1 :green_heart: | shadedjars | 6m 24s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 25s | HBASE-25853 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | +1 :green_heart: | compile | 1m 49s | the patch passed | | +1 :green_heart: | javac | 1m 49s | the patch passed | | +1 :green_heart: | shadedjars | 6m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 27s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 2m 36s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 154m 31s | hbase-server in the patch passed. | | | | 189m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3589/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3589 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9aba40d9bb7f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-25853 / 77b1dde130 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3589/1/testReport/ | | Max. process+thread count | 3477 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3589/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26198) RegionServer dead on hadoop 3.3.1: NoSuchMethodError LocatedBlocks.getLocations()
[ https://issues.apache.org/jira/browse/HBASE-26198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400070#comment-17400070 ] Wei-Chiu Chuang commented on HBASE-26198: - I am pretty sure CDH6.2 HBase doesn't compile against Hadoop 3.3.1. Did you simply replace the CDH Hadoop jars with Apache Hadoop 3.3.1? If so, I can believe it doesn't work out of box due to HDFS-15255. There are a number of HBase changes you would need to apply on top of CDH HBase 6.2.0. If you can apply them and recompile against Apache Hadoop 3.3.1, you should be able to run. > RegionServer dead on hadoop 3.3.1: NoSuchMethodError > LocatedBlocks.getLocations() > - > > Key: HBASE-26198 > URL: https://issues.apache.org/jira/browse/HBASE-26198 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: mengqi >Priority: Major > Attachments: 4ad46153842c29898189b90fc986925c87966ce6.diff, > image-2021-08-16-16-24-32-418.png > > > !image-2021-08-16-16-24-32-418.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26199) hbck2 should support remove deleted meta region
[ https://issues.apache.org/jira/browse/HBASE-26199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400065#comment-17400065 ] mengqi commented on HBASE-26199: Our hbase version is 2.1.0-cdh6.2.0 This situation happened when a lot of regionserver dead，I guess something wrong with regionserver who own the meta table regioin. > hbck2 should support remove deleted meta region > --- > > Key: HBASE-26199 > URL: https://issues.apache.org/jira/browse/HBASE-26199 > Project: HBase > Issue Type: Bug > Components: hbase-operator-tools, hbck2 >Reporter: mengqi >Priority: Major > > A large number of regions of deleted tables will enter rit when hbase2.x > restarts， and these region will also appear on hbck web page, we just delete > these region in meta table，and change active master。 > here is my request: [pull > request|https://github.com/apache/hbase-operator-tools/pull/81] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-26128) Backport HBASE-25454 "Add trace support for connection registry" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-26128. -- Resolution: Fixed > Backport HBASE-25454 "Add trace support for connection registry" to branch-2 > > > Key: HBASE-26128 > URL: https://issues.apache.org/jira/browse/HBASE-26128 > Project: HBase > Issue Type: Sub-task > Components: tracing >Affects Versions: 2.5.0 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > Labels: trace > Fix For: 2.5.0 > > > 5/17 commits of HBASE-22120, original commit > [dcb78bd4bda4a4ae13d863df8aec266031e5bc93|https://github.com/apache/hbase/commit/dcb78bd4bda4a4ae13d863df8aec266031e5bc93] > and merged conflicts after rebasing on HBASE-26150 (branch-2 commit > [620806e3fb27947fa3b36f24921060e328f4b39d|https://github.com/apache/hbase/commit/620806e3fb27947fa3b36f24921060e328f4b39d]) > with commit > [63d4970de451bf234f2ddbda949995b1420e525b|https://github.com/apache/hbase/commit/63d4970de451bf234f2ddbda949995b1420e525b] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26128) Backport HBASE-25454 "Add trace support for connection registry" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400063#comment-17400063 ] Tak-Lon (Stephen) Wu commented on HBASE-26128: -- merged to feature branch https://github.com/apache/hbase/commit/77b1dde13058c4490624a34053d3fa4f89033bdc > Backport HBASE-25454 "Add trace support for connection registry" to branch-2 > > > Key: HBASE-26128 > URL: https://issues.apache.org/jira/browse/HBASE-26128 > Project: HBase > Issue Type: Sub-task > Components: tracing >Affects Versions: 2.5.0 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > Labels: trace > Fix For: 2.5.0 > > > 5/17 commits of HBASE-22120, original commit > [dcb78bd4bda4a4ae13d863df8aec266031e5bc93|https://github.com/apache/hbase/commit/dcb78bd4bda4a4ae13d863df8aec266031e5bc93] > and merged conflicts after rebasing on HBASE-26150 (branch-2 commit > [620806e3fb27947fa3b36f24921060e328f4b39d|https://github.com/apache/hbase/commit/620806e3fb27947fa3b36f24921060e328f4b39d]) > with commit > [63d4970de451bf234f2ddbda949995b1420e525b|https://github.com/apache/hbase/commit/63d4970de451bf234f2ddbda949995b1420e525b] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-26129) Backport HBASE-25481 "Add host and port attribute when tracing rpc call at client side" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu reassigned HBASE-26129: Assignee: Tak-Lon (Stephen) Wu > Backport HBASE-25481 "Add host and port attribute when tracing rpc call at > client side" to branch-2 > --- > > Key: HBASE-26129 > URL: https://issues.apache.org/jira/browse/HBASE-26129 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > 6/17 commits of HBASE-22120, original commit > ae2c62ffaad5ba4c976b0a79c10a365edf2844fd -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-26129) Backport HBASE-25481 "Add host and port attribute when tracing rpc call at client side" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26129 started by Tak-Lon (Stephen) Wu. > Backport HBASE-25481 "Add host and port attribute when tracing rpc call at > client side" to branch-2 > --- > > Key: HBASE-26129 > URL: https://issues.apache.org/jira/browse/HBASE-26129 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > 6/17 commits of HBASE-22120, original commit > ae2c62ffaad5ba4c976b0a79c10a365edf2844fd -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26198) RegionServer dead on hadoop 3.3.1: NoSuchMethodError LocatedBlocks.getLocations()
[ https://issues.apache.org/jira/browse/HBASE-26198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400062#comment-17400062 ] mengqi commented on HBASE-26198: Our hbase version is 2.1.0-cdh6.2.0 > RegionServer dead on hadoop 3.3.1: NoSuchMethodError > LocatedBlocks.getLocations() > - > > Key: HBASE-26198 > URL: https://issues.apache.org/jira/browse/HBASE-26198 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: mengqi >Priority: Major > Attachments: 4ad46153842c29898189b90fc986925c87966ce6.diff, > image-2021-08-16-16-24-32-418.png > > > !image-2021-08-16-16-24-32-418.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24842) make export snapshot report size can be config
[ https://issues.apache.org/jira/browse/HBASE-24842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24842. --- Fix Version/s: 3.0.0-alpha-2 Hadoop Flags: Reviewed Release Note: Set new config snapshot.export.report.size to size at which you want to see reporting. Resolution: Fixed Merged to master. Make subtask if you'd like it backported. Thanks for the PR [~chenyechao] > make export snapshot report size can be config > -- > > Key: HBASE-24842 > URL: https://issues.apache.org/jira/browse/HBASE-24842 > Project: HBase > Issue Type: Improvement > Components: mapreduce >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Minor > Fix For: 3.0.0-alpha-2 > > > current export snapshot will be report ONE MB (1*1024*1024 Bytes), > we can make it can be config -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack merged pull request #2233: HBASE-24842 make export snapshot report size can be config
saintstack merged pull request #2233: URL: https://github.com/apache/hbase/pull/2233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24570) connection#close throws NPE
[
https://issues.apache.org/jira/browse/HBASE-24570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack updated HBASE-24570:
--
Fix Version/s: 2.3.7
2.4.6
2.5.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
Appled to branch-2.3+ (doesn't apply to master... doesn't make sense there).
Thanks for the PR [~Bo Cui]
> connection#close throws NPE
> ---
>
> Key: HBASE-24570
> URL: https://issues.apache.org/jira/browse/HBASE-24570
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 2.2.3
>Reporter: Bo Cui
>Assignee: Bo Cui
>Priority: Minor
> Fix For: 2.5.0, 2.4.6, 2.3.7
>
>
> In the ConnectionImplementation construction method, if getRegistry throws
> exception， registry will be null，and then close will throw NPE
> {code:java}
> try {
> this.registry = AsyncRegistryFactory.getRegistry(conf);
> ...
> } catch (Throwable e) {
> // avoid leaks: registry, rpcClient, ...
> LOG.debug("connection construction failed", e);
> close();
> throw e;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack closed pull request #2082: HBASE-24570 connection#close throws NPE
saintstack closed pull request #2082: URL: https://github.com/apache/hbase/pull/2082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #2082: HBASE-24570 connection#close throws NPE
saintstack commented on pull request #2082: URL: https://github.com/apache/hbase/pull/2082#issuecomment-899897356 Applied manually to branch-2.3=>branch-2... Doesn't work against master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #1647: add IntelliJ project files
ndimiduk commented on pull request #1647: URL: https://github.com/apache/hbase/pull/1647#issuecomment-899890716 Dropping this one. It seems IntelliJ won't let us exclude the detailed JDK specification from the project definitions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk closed pull request #1647: add IntelliJ project files
ndimiduk closed pull request #1647: URL: https://github.com/apache/hbase/pull/1647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26191) Annotate shaded generated protobuf as InterfaceAudience.Private
[
https://issues.apache.org/jira/browse/HBASE-26191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400055#comment-17400055
]
Michael Stack commented on HBASE-26191:
---
{quote}Perhaps we can use something like
[Rewrite|https://github.com/openrewrite/rewrite-maven-plugin] to annotate the
generated classes during the build process.
{quote}
Yeah. Was thinking. We do some gymnastics w/ it already IIRC.
> Annotate shaded generated protobuf as InterfaceAudience.Private
> ---
>
> Key: HBASE-26191
> URL: https://issues.apache.org/jira/browse/HBASE-26191
> Project: HBase
> Issue Type: Task
> Components: Coprocessors, Protobufs
>Reporter: Michael Stack
>Priority: Major
>
> Annotate generated shaded protobufs as InterfaceAudience.Private. It might
> not be able to add the annotation to each class; at a minimum update the doc
> on our story around shaded internal protobufs.
> See the prompting mailing list discussion here:
> [https://lists.apache.org/thread.html/r9e6eb11106727d245f6eb2a5023823901637971d6ed0f0aedaf8d149%40%3Cdev.hbase.apache.org%3E]
> So far the consensus has it that the shaded generated protobuf should be made
> IA.Private. Will wait on it to settle.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3589: HBASE-26129 Backport HBASE-25481 "Add host and port attribute when tr…
Apache-HBase commented on pull request #3589: URL: https://github.com/apache/hbase/pull/3589#issuecomment-899885776 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ HBASE-25853 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 0s | HBASE-25853 passed | | +1 :green_heart: | compile | 5m 10s | HBASE-25853 passed | | +1 :green_heart: | checkstyle | 2m 14s | HBASE-25853 passed | | +1 :green_heart: | spotbugs | 4m 6s | HBASE-25853 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 44s | the patch passed | | +1 :green_heart: | compile | 5m 5s | the patch passed | | +1 :green_heart: | javac | 5m 5s | the patch passed | | +1 :green_heart: | checkstyle | 2m 11s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 6s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 4m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 33s | The patch does not generate ASF License warnings. | | | | 55m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3589/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3589 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 579912591f2e 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | HBASE-25853 / 77b1dde130 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 86 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3589/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24652) master-status UI make date type fields sortable
[ https://issues.apache.org/jira/browse/HBASE-24652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17400049#comment-17400049 ] Michael Stack commented on HBASE-24652: --- HBASE-25165 is where I took us in the wrong direction before re-surfacing this old issue. > master-status UI make date type fields sortable > --- > > Key: HBASE-24652 > URL: https://issues.apache.org/jira/browse/HBASE-24652 > Project: HBase > Issue Type: Improvement > Components: master, Operability, UI, Usability >Affects Versions: 3.0.0-alpha-1, 2.2.0, 2.3.0, 2.1.5, 2.2.1, 2.1.6 >Reporter: Jeongmin Kim >Assignee: jeongmin kim >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6, 2.3.7 > > Attachments: SCREEN_SHOT1.png > > > Revisit of HBASE-21207, HBASE-22543 > date type values such as regionserver list 'Start time' field on > master-status page, are not sorted by time. > HBASE-21207, HBASE-22543 missed it. so before this fix, date sorted as String. > The first field of it is 'day'. therefore always Friday goes first Wednesday > goes last, no matter what date it is. > * SCREEN_SHOT1.png > > this fix make date type values sorted by time and date. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3588: HBASE-24337 Backport HBASE-23968 to branch-2
Apache-HBase commented on pull request #3588: URL: https://github.com/apache/hbase/pull/3588#issuecomment-899879329 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 19s | branch-2 passed | | +1 :green_heart: | compile | 1m 3s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 6m 44s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 241m 46s | hbase-server in the patch passed. | | | | 270m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3588/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3588 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 126d1a541487 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / e08b3642a7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3588/1/testReport/ | | Max. process+thread count | 2429 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3588/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3588: HBASE-24337 Backport HBASE-23968 to branch-2
Apache-HBase commented on pull request #3588: URL: https://github.com/apache/hbase/pull/3588#issuecomment-899876060 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 11s | branch-2 passed | | +1 :green_heart: | compile | 1m 19s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 46s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 45s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | +1 :green_heart: | shadedjars | 8m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 52s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 229m 15s | hbase-server in the patch failed. | | | | 263m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3588/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3588 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux bdf476270e96 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / e08b3642a7 | | Default Java | AdoptOpenJDK-11.0.10+9 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3588/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3588/1/testReport/ | | Max. process+thread count | 2470 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3588/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-24652) master-status UI make date type fields sortable
[ https://issues.apache.org/jira/browse/HBASE-24652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24652. --- Fix Version/s: 2.3.7 2.4.6 2.5.0 Hadoop Flags: Reviewed Release Note: Makes RegionServer 'Start time' sortable in the Master UI Assignee: jeongmin kim Resolution: Fixed [~jeongmin.kim] pardon me. I forgot about this one. I pushed to branch-2.3+ Thanks for the fix and please pardon my oversight. > master-status UI make date type fields sortable > --- > > Key: HBASE-24652 > URL: https://issues.apache.org/jira/browse/HBASE-24652 > Project: HBase > Issue Type: Improvement > Components: master, Operability, UI, Usability >Affects Versions: 3.0.0-alpha-1, 2.2.0, 2.3.0, 2.1.5, 2.2.1, 2.1.6 >Reporter: Jeongmin Kim >Assignee: jeongmin kim >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6, 2.3.7 > > Attachments: SCREEN_SHOT1.png > > > Revisit of HBASE-21207, HBASE-22543 > date type values such as regionserver list 'Start time' field on > master-status page, are not sorted by time. > HBASE-21207, HBASE-22543 missed it. so before this fix, date sorted as String. > The first field of it is 'day'. therefore always Friday goes first Wednesday > goes last, no matter what date it is. > * SCREEN_SHOT1.png > > this fix make date type values sorted by time and date. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack closed pull request #1993: HBASE-24652 master-status UI, make date type fields sortable
saintstack closed pull request #1993: URL: https://github.com/apache/hbase/pull/1993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #1993: HBASE-24652 master-status UI, make date type fields sortable
saintstack commented on pull request #1993: URL: https://github.com/apache/hbase/pull/1993#issuecomment-899873568 Merged manually to branch-2.3+. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3581: HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to br
Apache-HBase commented on pull request #3581: URL: https://github.com/apache/hbase/pull/3581#issuecomment-899872059 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 2m 29s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 7s | branch-1 passed | | +1 :green_heart: | compile | 0m 59s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | compile | 1m 8s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +1 :green_heart: | checkstyle | 1m 57s | branch-1 passed | | +1 :green_heart: | shadedjars | 3m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 56s | branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | javadoc | 1m 0s | branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +0 :ok: | spotbugs | 2m 47s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 52s | branch-1 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 52s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | javac | 1m 0s | the patch passed | | +1 :green_heart: | compile | 1m 8s | the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +1 :green_heart: | javac | 1m 8s | the patch passed | | +1 :green_heart: | checkstyle | 1m 49s | the patch passed | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 2m 53s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 4m 27s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 0m 47s | the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19 | | +1 :green_heart: | javadoc | 0m 59s | the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10 | | +1 :green_heart: | findbugs | 3m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 133m 37s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 14m 32s | hbase-rsgroup in the patch passed. | | +1 :green_heart: | asflicense | 0m 57s | The patch does not generate ASF License warnings. | | | | 196m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3581 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux dbca82165da6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3581/out/precommit/personality/provided.sh | | git revision | branch-1 / 75844c8 | | Default Java | Azul Systems, Inc.-1.7.0_272-b10 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/4/testReport/ | | Max. process+thread count | 4425 (vs. ulimit of 1) | | modules | C: hbase-server hbase-rsgroup U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3581/4/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
[GitHub] [hbase] taklwu opened a new pull request #3589: HBASE-26129 Backport HBASE-25481 "Add host and port attribute when tr…
taklwu opened a new pull request #3589: URL: https://github.com/apache/hbase/pull/3589 …acing rpc call at client side" to branch-2 6/17 commits of HBASE-22120, original commit ae2c62ffaad5ba4c976b0a79c10a365edf2844fd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26129) Backport HBASE-25481 "Add host and port attribute when tracing rpc call at client side" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26129: - Description: 6/17 commits of HBASE-22120, original commit ae2c62ffaad5ba4c976b0a79c10a365edf2844fd > Backport HBASE-25481 "Add host and port attribute when tracing rpc call at > client side" to branch-2 > --- > > Key: HBASE-26129 > URL: https://issues.apache.org/jira/browse/HBASE-26129 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > > 6/17 commits of HBASE-22120, original commit > ae2c62ffaad5ba4c976b0a79c10a365edf2844fd -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3579: HBASE-26189 Reduce log level of CompactionProgress notice to DEBUG
Apache-HBase commented on pull request #3579: URL: https://github.com/apache/hbase/pull/3579#issuecomment-899854438 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | master passed | | +1 :green_heart: | compile | 1m 8s | master passed | | +1 :green_heart: | shadedjars | 9m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 17s | the patch passed | | +1 :green_heart: | compile | 1m 10s | the patch passed | | +1 :green_heart: | javac | 1m 10s | the patch passed | | +1 :green_heart: | shadedjars | 9m 13s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 210m 58s | hbase-server in the patch passed. | | | | 244m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3579/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3579 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0b416e60f021 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1c71cb20d6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3579/2/testReport/ | | Max. process+thread count | 2921 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3579/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3587: Backport "HBASE-6908: Add pluggable rpc queue implementation (#3522)" to branch-2.3
Apache-HBase commented on pull request #3587: URL: https://github.com/apache/hbase/pull/3587#issuecomment-899851748 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 56s | branch-2.3 passed | | +1 :green_heart: | compile | 0m 57s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 29s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 5m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 204m 53s | hbase-server in the patch passed. | | | | 229m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3587/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3587 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f5bb02d574ee 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / b34d0cdc0b | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3587/1/testReport/ | | Max. process+thread count | 2594 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3587/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3579: HBASE-26189 Reduce log level of CompactionProgress notice to DEBUG
Apache-HBase commented on pull request #3579: URL: https://github.com/apache/hbase/pull/3579#issuecomment-899849738 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 5s | master passed | | +1 :green_heart: | compile | 1m 20s | master passed | | +1 :green_heart: | shadedjars | 9m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 50s | the patch passed | | +1 :green_heart: | compile | 1m 18s | the patch passed | | +1 :green_heart: | javac | 1m 18s | the patch passed | | +1 :green_heart: | shadedjars | 8m 57s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 200m 38s | hbase-server in the patch passed. | | | | 235m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3579/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3579 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f9e7e2295d4c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1c71cb20d6 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3579/2/testReport/ | | Max. process+thread count | 2907 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3579/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3587: Backport "HBASE-6908: Add pluggable rpc queue implementation (#3522)" to branch-2.3
Apache-HBase commented on pull request #3587: URL: https://github.com/apache/hbase/pull/3587#issuecomment-899813550 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 14s | branch-2.3 passed | | +1 :green_heart: | compile | 1m 5s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 49s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 55s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 5m 57s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 129m 29s | hbase-server in the patch passed. | | | | 155m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3587/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3587 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a9f784d05432 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / b34d0cdc0b | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3587/1/testReport/ | | Max. process+thread count | 4232 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3587/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-26200) Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of HBASE-24652
[ https://issues.apache.org/jira/browse/HBASE-26200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-26200. --- Fix Version/s: 2.3.7 2.4.6 3.0.0-alpha-2 2.5.0 Release Note: Undid showing RegionServer 'Start time' in ISO-8601 format. Revert. Assignee: Michael Stack Resolution: Fixed > Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of > HBASE-24652 > - > > Key: HBASE-26200 > URL: https://issues.apache.org/jira/browse/HBASE-26200 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6, 2.3.7 > > > The below change by me does not actually work and I found an old issue that > does the proper job that was neglected. I'm undoing the below in favor of > HBASE-24652. > > kalashnikov:hbase.apache.git stack$ git show > d07d181ea4a9da316659bb21fd4fffc979b5f77a > commit d07d181ea4a9da316659bb21fd4fffc979b5f77a > Author: Michael Stack > Date: Thu Oct 8 09:10:30 2020 -0700 > HBASE-25165 Change 'State time' in UI so sorts (#2508) > Display startcode in iso8601. > Signed-off-by: Nick Dimiduk -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-26200) Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of HBASE-24652
[ https://issues.apache.org/jira/browse/HBASE-26200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1737#comment-1737 ] Michael Stack edited comment on HBASE-26200 at 8/16/21, 8:43 PM: - HBASE-25165 had us show 'start time' as ISO8601 which our String sort in UI doesn't. The other issue w/ ISO8601 is that it rendors as UTC which isn't what all want. Let me undo HBASE-25165 then apply HBASE-24652. was (Author: stack): HBASE-25165 had us show 'start time' as ISO8601 which our String sort in UI doesn't. The other issue w/ ISO8601 is that it rendors as UTC which isn't what all want. Let me revert this then apply HBASE-24652. > Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of > HBASE-24652 > - > > Key: HBASE-26200 > URL: https://issues.apache.org/jira/browse/HBASE-26200 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: Michael Stack >Priority: Major > > The below change by me does not actually work and I found an old issue that > does the proper job that was neglected. I'm undoing the below in favor of > HBASE-24652. > > kalashnikov:hbase.apache.git stack$ git show > d07d181ea4a9da316659bb21fd4fffc979b5f77a > commit d07d181ea4a9da316659bb21fd4fffc979b5f77a > Author: Michael Stack > Date: Thu Oct 8 09:10:30 2020 -0700 > HBASE-25165 Change 'State time' in UI so sorts (#2508) > Display startcode in iso8601. > Signed-off-by: Nick Dimiduk -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26200) Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of HBASE-24652
[ https://issues.apache.org/jira/browse/HBASE-26200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1737#comment-1737 ] Michael Stack commented on HBASE-26200: --- HBASE-25165 had us show 'start time' as ISO8601 which our String sort in UI doesn't. The other issue w/ ISO8601 is that it rendors as UTC which isn't what all want. Let me revert this then apply HBASE-24652. > Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of > HBASE-24652 > - > > Key: HBASE-26200 > URL: https://issues.apache.org/jira/browse/HBASE-26200 > Project: HBase > Issue Type: Bug > Components: UI >Reporter: Michael Stack >Priority: Major > > The below change by me does not actually work and I found an old issue that > does the proper job that was neglected. I'm undoing the below in favor of > HBASE-24652. > > kalashnikov:hbase.apache.git stack$ git show > d07d181ea4a9da316659bb21fd4fffc979b5f77a > commit d07d181ea4a9da316659bb21fd4fffc979b5f77a > Author: Michael Stack > Date: Thu Oct 8 09:10:30 2020 -0700 > HBASE-25165 Change 'State time' in UI so sorts (#2508) > Display startcode in iso8601. > Signed-off-by: Nick Dimiduk -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-26200) Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of HBASE-24652
Michael Stack created HBASE-26200: - Summary: Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of HBASE-24652 Key: HBASE-26200 URL: https://issues.apache.org/jira/browse/HBASE-26200 Project: HBase Issue Type: Bug Components: UI Reporter: Michael Stack The below change by me does not actually work and I found an old issue that does the proper job that was neglected. I'm undoing the below in favor of HBASE-24652. kalashnikov:hbase.apache.git stack$ git show d07d181ea4a9da316659bb21fd4fffc979b5f77a commit d07d181ea4a9da316659bb21fd4fffc979b5f77a Author: Michael Stack Date: Thu Oct 8 09:10:30 2020 -0700 HBASE-25165 Change 'State time' in UI so sorts (#2508) Display startcode in iso8601. Signed-off-by: Nick Dimiduk -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26191) Annotate shaded generated protobuf as InterfaceAudience.Private
[ https://issues.apache.org/jira/browse/HBASE-26191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399984#comment-17399984 ] Nick Dimiduk commented on HBASE-26191: -- An interface for decoration of generated classes looks like a [long-standing request| https://github.com/protocolbuffers/protobuf/issues/42]. As far as I can tell, it's not available as of now, expect perhaps through an undocumented flag on recent versions of the compiler. Perhaps we can use something like [Rewrite|https://github.com/openrewrite/rewrite-maven-plugin] to annotate the generated classes during the build process. > Annotate shaded generated protobuf as InterfaceAudience.Private > --- > > Key: HBASE-26191 > URL: https://issues.apache.org/jira/browse/HBASE-26191 > Project: HBase > Issue Type: Task > Components: Coprocessors, Protobufs >Reporter: Michael Stack >Priority: Major > > Annotate generated shaded protobufs as InterfaceAudience.Private. It might > not be able to add the annotation to each class; at a minimum update the doc > on our story around shaded internal protobufs. > See the prompting mailing list discussion here: > [https://lists.apache.org/thread.html/r9e6eb11106727d245f6eb2a5023823901637971d6ed0f0aedaf8d149%40%3Cdev.hbase.apache.org%3E] > So far the consensus has it that the shaded generated protobuf should be made > IA.Private. Will wait on it to settle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] caroliney14 commented on pull request #3581: HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to bra
caroliney14 commented on pull request #3581: URL: https://github.com/apache/hbase/pull/3581#issuecomment-899772548 @bharathv nothing I can think of, thanks for the review. I also backported HBASE-25298 as you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25849) Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to branch-1
[ https://issues.apache.org/jira/browse/HBASE-25849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline Zhou updated HBASE-25849: -- Summary: Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to branch-1 (was: Backport HBASE-22738 & HBASE-24760 (Fallback feature for RS groups when there are no RS in current group) to branch-1) > Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS > groups when there are no RS in current group) to branch-1 > --- > > Key: HBASE-25849 > URL: https://issues.apache.org/jira/browse/HBASE-25849 > Project: HBase > Issue Type: Improvement >Reporter: Caroline Zhou >Assignee: Caroline Zhou >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3588: HBASE-24337 Backport HBASE-23968 to branch-2
Apache-HBase commented on pull request #3588: URL: https://github.com/apache/hbase/pull/3588#issuecomment-899769348 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 3s | branch-2 passed | | +1 :green_heart: | compile | 4m 22s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 32s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 37s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 40s | the patch passed | | +1 :green_heart: | compile | 3m 47s | the patch passed | | +1 :green_heart: | javac | 3m 47s | the patch passed | | +1 :green_heart: | checkstyle | 1m 35s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 16m 12s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 1s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 52m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3588/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3588 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8c710eb93835 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / e08b3642a7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 96 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3588/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves
Apache-HBase commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-899768520 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 16s | branch-2 passed | | +1 :green_heart: | compile | 3m 25s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 0s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 23s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | compile | 3m 23s | the patch passed | | +1 :green_heart: | javac | 3m 23s | the patch passed | | +1 :green_heart: | shadedjars | 6m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 40s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 2m 48s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 143m 33s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 6m 26s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 3m 27s | hbase-rsgroup in the patch passed. | | +1 :green_heart: | unit | 7m 14s | hbase-shell in the patch passed. | | | | 199m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/17/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3536 | | JIRA Issue | HBASE-26147 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ecbec3870a35 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 4aec407c02 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/17/testReport/ | | Max. process+thread count | 4018 (vs. ulimit of 12500) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/17/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on pull request #3581: HBASE-25849 Backport HBASE-22738 & HBASE-24760 (Fallback feature for RS groups when there are no RS in current group) to branch-1
bharathv commented on pull request #3581: URL: https://github.com/apache/hbase/pull/3581#issuecomment-899762733 Backport lgtm. @caroliney14 Any tricky conflicts you ran into that needs a closer look? If not we can merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-6908) Pluggable Call BlockingQueue for HBaseServer
[ https://issues.apache.org/jira/browse/HBASE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-6908. - Resolution: Fixed Nevermind. Let's not backport new features to existing patch release lines. > Pluggable Call BlockingQueue for HBaseServer > > > Key: HBASE-6908 > URL: https://issues.apache.org/jira/browse/HBASE-6908 > Project: HBase > Issue Type: New Feature > Components: IPC/RPC >Reporter: James Taylor >Assignee: Richard Marscher >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6 > > > Allow the BlockingQueue implementation class to be specified in the HBase > config to enable different behavior than a FIFO queue. The use case we have > is around fairness and starvation for big scans that are parallelized on the > client. It's easy to fill up the HBase server Call BlockingQueue when > processing a single parallelized scan, leadng other scans to time out. > Instead, doing round robin processesing on a dequeue through a different > BlockingQueue implementation will prevent this from occurring. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ndimiduk commented on pull request #3587: Backport "HBASE-6908: Add pluggable rpc queue implementation (#3522)" to branch-2.3
ndimiduk commented on pull request #3587: URL: https://github.com/apache/hbase/pull/3587#issuecomment-899751912 Nevermind. Let's not backport new features to existing patch release lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk closed pull request #3587: Backport "HBASE-6908: Add pluggable rpc queue implementation (#3522)" to branch-2.3
ndimiduk closed pull request #3587: URL: https://github.com/apache/hbase/pull/3587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3579: HBASE-26189 Reduce log level of CompactionProgress notice to DEBUG
Apache-HBase commented on pull request #3579: URL: https://github.com/apache/hbase/pull/3579#issuecomment-899751794 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 30s | master passed | | +1 :green_heart: | compile | 3m 36s | master passed | | +1 :green_heart: | checkstyle | 1m 8s | master passed | | +1 :green_heart: | spotbugs | 2m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 11s | the patch passed | | +1 :green_heart: | compile | 3m 32s | the patch passed | | +1 :green_heart: | javac | 3m 32s | the patch passed | | +1 :green_heart: | checkstyle | 1m 10s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 22m 7s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 52s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 56m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3579/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3579 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 478db7cc6962 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 1c71cb20d6 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3579/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] z-york commented on a change in pull request #3583: HBASE-26193 Do not store meta region location as permanent state on z…
z-york commented on a change in pull request #3583:
URL: https://github.com/apache/hbase/pull/3583#discussion_r689789751
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -753,8 +763,49 @@ private void initializeZKBasedSystemTrackers()
// Will be overriden in test to inject customized AssignmentManager
@InterfaceAudience.Private
- protected AssignmentManager createAssignmentManager(MasterServices master) {
-return new AssignmentManager(master);
+ protected AssignmentManager createAssignmentManager(MasterServices master,
+MasterRegion masterRegion) {
+return new AssignmentManager(master, masterRegion);
+ }
+
+ private void tryMigrateMetaLocationsFromZooKeeper() throws IOException,
KeeperException {
+// try migrate data from zookeeper
+try (ResultScanner scanner =
+ masterRegion.getScanner(new
Scan().addFamily(HConstants.CATALOG_FAMILY))) {
+ if (scanner.next() != null) {
+// notice that all replicas for a region are in the same row, so the
migration can be
+// done with in a one row put, which means if we have data in catalog
family then we can
+// make sure that the migration is done.
+LOG.info("The {} family in master local region already has data in it,
skip migrating...",
+ HConstants.CATALOG_FAMILY);
+return;
+ }
+}
+// start migrating
+byte[] row =
CatalogFamilyFormat.getMetaKeyForRegion(RegionInfoBuilder.FIRST_META_REGIONINFO);
+Put put = new Put(row);
+List metaReplicaNodes = zooKeeper.getMetaReplicaNodes();
+StringBuilder info = new StringBuilder("Migrating meta locations:");
+for (String metaReplicaNode : metaReplicaNodes) {
+ int replicaId =
zooKeeper.getZNodePaths().getMetaReplicaIdFromZNode(metaReplicaNode);
+ RegionState state = MetaTableLocator.getMetaRegionState(zooKeeper,
replicaId);
+ info.append(" ").append(state);
+ put.setTimestamp(state.getStamp());
+ MetaTableAccessor.addRegionInfo(put, state.getRegion());
+ if (state.getServerName() != null) {
+MetaTableAccessor.addLocation(put, state.getServerName(),
HConstants.NO_SEQNUM, replicaId);
+ }
Review comment:
When will this condition be triggered? I expect on a new install there
won't even be any metaReplicaNodes, right? (IMP hasn't ran yet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #2003: HBASE-24633 Remove data locality and StoreFileCostFunction for replic…
saintstack commented on pull request #2003: URL: https://github.com/apache/hbase/pull/2003#issuecomment-899743828 @huaxiangsun You want to refresh this PR or is it stale now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-24339) Backport HBASE-23968 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-24339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24339. --- Resolution: Won't Fix > Backport HBASE-23968 to branch-1 > > > Key: HBASE-24339 > URL: https://issues.apache.org/jira/browse/HBASE-24339 > Project: HBase > Issue Type: Sub-task >Reporter: Minwoo Kang >Assignee: Minwoo Kang >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24339) Backport HBASE-23968 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-24339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399945#comment-17399945 ] Michael Stack commented on HBASE-24339: --- I closed the PR. No more releases off branch-1. Resolving as won't fix. > Backport HBASE-23968 to branch-1 > > > Key: HBASE-24339 > URL: https://issues.apache.org/jira/browse/HBASE-24339 > Project: HBase > Issue Type: Sub-task >Reporter: Minwoo Kang >Assignee: Minwoo Kang >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack commented on pull request #1673: HBASE-24339 Backport HBASE-23968 to branch-1
saintstack commented on pull request #1673: URL: https://github.com/apache/hbase/pull/1673#issuecomment-899740355 Closing. No more releases off branch-1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack closed pull request #1673: HBASE-24339 Backport HBASE-23968 to branch-1
saintstack closed pull request #1673: URL: https://github.com/apache/hbase/pull/1673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24337) Backport HBASE-23968 to branch-2
[ https://issues.apache.org/jira/browse/HBASE-24337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399944#comment-17399944 ] Michael Stack commented on HBASE-24337: --- Refreshed PR. > Backport HBASE-23968 to branch-2 > > > Key: HBASE-24337 > URL: https://issues.apache.org/jira/browse/HBASE-24337 > Project: HBase > Issue Type: Sub-task >Reporter: Minwoo Kang >Assignee: Minwoo Kang >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack commented on a change in pull request #3489: HBASE-26087 JVM crash when displaying RPC params by MonitoredRPCHandler
saintstack commented on a change in pull request #3489:
URL: https://github.com/apache/hbase/pull/3489#discussion_r689760442
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
##
@@ -43,6 +43,8 @@
private String methodName = "";
private Object [] params = {};
private Message packet;
+ private boolean isSnapshot = false;
Review comment:
fyi, isSnapshot is a method name, not a datamember name.
s/isSnapshot/snapshot/?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
##
@@ -43,6 +43,8 @@
private String methodName = "";
private Object [] params = {};
private Message packet;
+ private boolean isSnapshot = false;
Review comment:
This is a nit. Can fix later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3587: Backport "HBASE-6908: Add pluggable rpc queue implementation (#3522)" to branch-2.3
ndimiduk commented on pull request #3587: URL: https://github.com/apache/hbase/pull/3587#issuecomment-899722100 Patch from branch-2.4 applies cleanly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk opened a new pull request #3587: Backport "HBASE-6908: Add pluggable rpc queue implementation (#3522)" to branch-2.3
ndimiduk opened a new pull request #3587: URL: https://github.com/apache/hbase/pull/3587 Can pass in a FQCN to load as the call queue implementation. Standardized arguments to the constructor are the max queue length, the PriorityFunction, and the Configuration. `PluggableBlockingQueue` abstract class provided to help guide the correct constructor signature Hard fails if the class fails to load as a `BlockingQueue` Signed-off-by: stack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3447: HBASE-26055 Master local region "table" should be considered a system…
saintstack commented on pull request #3447: URL: https://github.com/apache/hbase/pull/3447#issuecomment-899721752 Any resolution here. We going to add a flag to bypass new logic? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (HBASE-6908) Pluggable Call BlockingQueue for HBaseServer
[ https://issues.apache.org/jira/browse/HBASE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-6908: - Reopening for branch-2.3 backport. > Pluggable Call BlockingQueue for HBaseServer > > > Key: HBASE-6908 > URL: https://issues.apache.org/jira/browse/HBASE-6908 > Project: HBase > Issue Type: New Feature > Components: IPC/RPC >Reporter: James Taylor >Assignee: Richard Marscher >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6 > > > Allow the BlockingQueue implementation class to be specified in the HBase > config to enable different behavior than a FIFO queue. The use case we have > is around fairness and starvation for big scans that are parallelized on the > client. It's easy to fill up the HBase server Call BlockingQueue when > processing a single parallelized scan, leadng other scans to time out. > Instead, doing round robin processesing on a dequeue through a different > BlockingQueue implementation will prevent this from occurring. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack commented on pull request #3502: HBASE-26097: to resolve hbase version 2.x protobuf version conflict
saintstack commented on pull request #3502: URL: https://github.com/apache/hbase/pull/3502#issuecomment-899719368 Actually close! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack closed pull request #3502: HBASE-26097: to resolve hbase version 2.x protobuf version conflict
saintstack closed pull request #3502: URL: https://github.com/apache/hbase/pull/3502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup
saintstack commented on pull request #3359: URL: https://github.com/apache/hbase/pull/3359#issuecomment-899718573 Do you want to push a new PR here @rda3mon ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup
saintstack commented on a change in pull request #3359:
URL: https://github.com/apache/hbase/pull/3359#discussion_r689755547
##
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java
##
@@ -514,24 +513,6 @@ public void addIncrementalBackupTableSet(Set
tables) throws IOExcepti
systemTable.addIncrementalBackupTableSet(tables,
backupInfo.getBackupRootDir());
}
- /**
- * Saves list of WAL files after incremental backup operation. These files
will be stored until
- * TTL expiration and are used by Backup Log Cleaner plug-in to determine
which WAL files can be
- * safely purged.
- */
- public void recordWALFiles(List files) throws IOException {
-systemTable.addWALFiles(files, backupInfo.getBackupId(),
backupInfo.getBackupRootDir());
Review comment:
Did you figure anything @rda3mon ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (HBASE-26037) Implement namespace and table level access control for thrift & thrift2
[ https://issues.apache.org/jira/browse/HBASE-26037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-26037. --- Fix Version/s: 3.0.0-alpha-2 Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks for the PR [~xytss123] (and review [~zhangduo] ). I tried to go back to branch-2 so could be in 2.5.0 but CONFLICT. Make a sub-task if you want a backport. Thank you. > Implement namespace and table level access control for thrift & thrift2 > --- > > Key: HBASE-26037 > URL: https://issues.apache.org/jira/browse/HBASE-26037 > Project: HBase > Issue Type: Improvement > Components: Admin, Thrift >Reporter: Yutong Xiao >Assignee: Yutong Xiao >Priority: Major > Fix For: 3.0.0-alpha-2 > > > Client can grant or revoke ns & table level user permissions through thrift & > thrift2. This is implemented with AccessControlClient. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] clarax commented on a change in pull request #3575: HBASE-26178 Improve data structure and algorithm for BalanceClusterSt…
clarax commented on a change in pull request #3575:
URL: https://github.com/apache/hbase/pull/3575#discussion_r689754575
##
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerClusterState.java
##
@@ -207,15 +212,20 @@ public String getRack(ServerName server) {
serverIndexToHostIndex = new int[numServers];
serverIndexToRackIndex = new int[numServers];
-regionsPerServer = new int[numServers][];
-serverIndexToRegionsOffset = new int[numServers];
-regionsPerHost = new int[numHosts][];
-regionsPerRack = new int[numRacks][];
-primariesOfRegionsPerServer = new int[numServers][];
-primariesOfRegionsPerHost = new int[numHosts][];
-primariesOfRegionsPerRack = new int[numRacks][];
+regionsPerServer = new ArrayList>(numServers);
Review comment:
This is a two dimensional collection. The same as regionsPerHost and
regionPerRack which are changed from int[][] to ArrayList> for
lookup/insert and delete by value. There are methods that take all three as
input. The best I can do is to make all three as array of collections(HashSet
or int[]). The biggest concerns I have is to mix generic and primitives and
arrays which is generally not recommended. Let me test the perf difference and
report back if it is worth it. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] saintstack merged pull request #3437: HBASE-26037 Implement namespace and table level access control for thrift & thrift2
saintstack merged pull request #3437: URL: https://github.com/apache/hbase/pull/3437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #3565: HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned
bbeaudreault commented on pull request #3565: URL: https://github.com/apache/hbase/pull/3565#issuecomment-899709916 Hey @saintstack, sorry I've been distracted by internal stuff the last few work days. But will be getting back to this this week. Yes, this PR needs to be updated based on our convo in the other PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] clarax commented on a change in pull request #3575: HBASE-26178 Improve data structure and algorithm for BalanceClusterSt…
clarax commented on a change in pull request #3575:
URL: https://github.com/apache/hbase/pull/3575#discussion_r689747141
##
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerClusterState.java
##
@@ -207,15 +212,20 @@ public String getRack(ServerName server) {
serverIndexToHostIndex = new int[numServers];
serverIndexToRackIndex = new int[numServers];
-regionsPerServer = new int[numServers][];
-serverIndexToRegionsOffset = new int[numServers];
-regionsPerHost = new int[numHosts][];
-regionsPerRack = new int[numRacks][];
-primariesOfRegionsPerServer = new int[numServers][];
-primariesOfRegionsPerHost = new int[numHosts][];
-primariesOfRegionsPerRack = new int[numRacks][];
+regionsPerServer = new ArrayList>(numServers);
+regionsPerHost = new ArrayList>(numHosts);
+regionsPerRack = new ArrayList>(numRacks);
+primariesOfRegionsPerServer = new ArrayList>>(numServers);
+primariesOfRegionsPerHost = new ArrayList>>(numHosts);
Review comment:
The key is the value of primary index that we need to look up in the
collection and the value of hash map is the list of region indexes of all
colocated replicas here so we don't need to do O(n) look up on
regionIndexToPrimaryIndex at
https://github.com/apache/hbase/blob/master/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionReplicaCandidateGenerator.java#L72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3426: HBASE-26032 Make HRegion.getStores() an O(1) operation
saintstack commented on pull request #3426: URL: https://github.com/apache/hbase/pull/3426#issuecomment-899707261 Kicking @anoopsjohn again!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26017) hbase performance evaluation tool could not support datasize more than 2048g
[ https://issues.apache.org/jira/browse/HBASE-26017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399898#comment-17399898 ] Michael Stack commented on HBASE-26017: --- The PR looks good. I left some comments. Can do the refactor of pe to do bigger sizes in a follow-on. > hbase performance evaluation tool could not support datasize more than 2048g > - > > Key: HBASE-26017 > URL: https://issues.apache.org/jira/browse/HBASE-26017 > Project: HBase > Issue Type: Bug > Components: PE >Affects Versions: 2.1.0, 2.3.2, 2.4.4 >Reporter: dingwei2019 >Assignee: dingwei2019 >Priority: Minor > > in our daily test, we may hope to test more datasize than 2048g, when we set > --size more than 2048g, pe print abnormal message like this: > [TestClient-1] hbase.PerformanceEvaluation: Start class > org.apache.hadoop.hbase.PerformanceEvaluation$SequentialWriteTest at offset > -1138166308 for -21474836 rows > > this is due to variable totalRows in TestOptions defined by int(-2147483648 > --- 2147483647), One GB is 1048576(1024*1024) by default. The max value of > totalRow is 2147483647, in this condition, we may write not larger than > 2147483647/1048576 = 2047.999G. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26016) HFilePrettyPrinter tool can not print the last LEAF_INDEX block or BLOOM_CHUNK.
[ https://issues.apache.org/jira/browse/HBASE-26016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399889#comment-17399889 ] Michael Stack commented on HBASE-26016: --- [~dingwei2019] over on PR asking for example of the fix in action? Thanks. > HFilePrettyPrinter tool can not print the last LEAF_INDEX block or > BLOOM_CHUNK. > --- > > Key: HBASE-26016 > URL: https://issues.apache.org/jira/browse/HBASE-26016 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.1.0, 2.3.2, 2.4.4 >Reporter: dingwei2019 >Assignee: dingwei2019 >Priority: Minor > Attachments: HBASE-26016-prettyPrintTool-1.patch > > > when i use pretty printer tool to print the headers of block, i can not get > the last LEAF_INDEX block and BLOOM_CHUNK. the last info of the tools is blow: > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack commented on pull request #3418: HBASE-26016 fix pretty tool print header missing last indexblock and bloomchunk
saintstack commented on pull request #3418: URL: https://github.com/apache/hbase/pull/3418#issuecomment-899700503 @dingwei-2017 Patch looks good. Was wondering if an example of it working? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25996) add hbase hbck result on jmx
[ https://issues.apache.org/jira/browse/HBASE-25996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399888#comment-17399888 ] Michael Stack commented on HBASE-25996: --- Please say more about why we would do this? > add hbase hbck result on jmx > > > Key: HBASE-25996 > URL: https://issues.apache.org/jira/browse/HBASE-25996 > Project: HBase > Issue Type: Improvement >Reporter: xijiawen >Assignee: xijiawen >Priority: Major > > https://github.com/apache/hbase/pull/3379 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3574: HBASE-26187 Write straight into the store directory when Splitting an…
Apache-HBase commented on pull request #3574: URL: https://github.com/apache/hbase/pull/3574#issuecomment-899696004 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 4s | master passed | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | shadedjars | 9m 1s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 7s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 9m 3s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 208m 14s | hbase-server in the patch passed. | | | | 240m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3574/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3574 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9cc07f8e6b64 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 44d5624908 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3574/6/testReport/ | | Max. process+thread count | 2512 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3574/6/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack closed pull request #3576: HBASE-26122: Only create ScannerContext for Gets with setMaxResultSize > 0 (ADDENDUM)
saintstack closed pull request #3576: URL: https://github.com/apache/hbase/pull/3576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #3576: HBASE-26122: Only create ScannerContext for Gets with setMaxResultSize > 0 (ADDENDUM)
saintstack commented on pull request #3576: URL: https://github.com/apache/hbase/pull/3576#issuecomment-899693695 Closing as original was reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3586: HBASE-26197 Fix some obvious bugs in MultiByteBuff.put
Apache-HBase commented on pull request #3586: URL: https://github.com/apache/hbase/pull/3586#issuecomment-899692307 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 30s | master passed | | +1 :green_heart: | compile | 0m 26s | master passed | | +1 :green_heart: | shadedjars | 8m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 14s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | shadedjars | 8m 10s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 3s | hbase-common in the patch passed. | | | | 30m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3586/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3586 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 86289c95b204 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 44d5624908 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3586/3/testReport/ | | Max. process+thread count | 291 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3586/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26196) Support configuration override for remote cluster of HFileOutputFormat locality sensitive
[ https://issues.apache.org/jira/browse/HBASE-26196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399867#comment-17399867 ] Michael Stack commented on HBASE-26196: --- Thanks for PR [~lineyshinya] . Pushed to branch-2.4+. It would not go back to branch-1 w/o CONFLICT and I think we're done w/ making releases off branch-1 (Make s sub-task for backport if you want it to go in still. Thanks). > Support configuration override for remote cluster of HFileOutputFormat > locality sensitive > - > > Key: HBASE-26196 > URL: https://issues.apache.org/jira/browse/HBASE-26196 > Project: HBase > Issue Type: Bug > Components: mapreduce >Affects Versions: 1.8.0, 3.0.0-alpha-2, 2.4.5 >Reporter: Shinya Yoshida >Assignee: Shinya Yoshida >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6 > > > We introduced support to generate hfile with good locality for a remote > cluster even in HBASE-25608. > I realized we need to override other configurations for the remote cluster in > addition to the zookeeper cluster key. > For example, read from a non-secure cluster and write hfiles for a secure > cluster. > In this case, we use TableInputFormat for non-secure cluster with > hbase.security.authentication=simple in job configuration. > So HFileOutputFormat failed to connect to remote secure cluster because > requires hbase.security.authentication=kerberos in job conf. > > Thus let's introduce configuration override for remote-cluster-aware > HFileOutputFormat locality-sensitive feature. > > -Another example is to read from a secure cluster (A) and write hfiles for > another secure cluster (B) and we use different principal for each cluster.- > -For instance, we use cluster-a/_h...@example.com for A and > cluster-b/_h...@example.com for B.- > -Then we need to override MASTER_KRB_PRINCIPAL and > REGIONSERVER_KRB_PRINCIPAL using cluster-b/_h...@example.com to connect > cluster B.- > ^ This is not truth, we use token based digest auth in mapper/reducer, so > principal difference for kerberos should be fine -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3586: HBASE-26197 Fix some obvious bugs in MultiByteBuff.put
Apache-HBase commented on pull request #3586: URL: https://github.com/apache/hbase/pull/3586#issuecomment-899691613 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | master passed | | +1 :green_heart: | compile | 0m 25s | master passed | | +1 :green_heart: | shadedjars | 8m 14s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 43s | the patch passed | | +1 :green_heart: | compile | 0m 24s | the patch passed | | +1 :green_heart: | javac | 0m 24s | the patch passed | | +1 :green_heart: | shadedjars | 8m 13s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 52s | hbase-common in the patch passed. | | | | 29m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3586/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3586 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c3e435a79047 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 44d5624908 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3586/3/testReport/ | | Max. process+thread count | 341 (vs. ulimit of 3) | | modules | C: hbase-common U: hbase-common | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3586/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26196) Support configuration override for remote cluster of HFileOutputFormat locality sensitive
[ https://issues.apache.org/jira/browse/HBASE-26196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-26196: -- Fix Version/s: 2.4.6 3.0.0-alpha-2 2.5.0 Hadoop Flags: Reviewed Release Note: Allow zookeeper configuration for remote cluster in HFileOutputFormat2. Resolution: Fixed Status: Resolved (was: Patch Available) > Support configuration override for remote cluster of HFileOutputFormat > locality sensitive > - > > Key: HBASE-26196 > URL: https://issues.apache.org/jira/browse/HBASE-26196 > Project: HBase > Issue Type: Bug > Components: mapreduce >Affects Versions: 1.8.0, 3.0.0-alpha-2, 2.4.5 >Reporter: Shinya Yoshida >Assignee: Shinya Yoshida >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6 > > > We introduced support to generate hfile with good locality for a remote > cluster even in HBASE-25608. > I realized we need to override other configurations for the remote cluster in > addition to the zookeeper cluster key. > For example, read from a non-secure cluster and write hfiles for a secure > cluster. > In this case, we use TableInputFormat for non-secure cluster with > hbase.security.authentication=simple in job configuration. > So HFileOutputFormat failed to connect to remote secure cluster because > requires hbase.security.authentication=kerberos in job conf. > > Thus let's introduce configuration override for remote-cluster-aware > HFileOutputFormat locality-sensitive feature. > > -Another example is to read from a secure cluster (A) and write hfiles for > another secure cluster (B) and we use different principal for each cluster.- > -For instance, we use cluster-a/_h...@example.com for A and > cluster-b/_h...@example.com for B.- > -Then we need to override MASTER_KRB_PRINCIPAL and > REGIONSERVER_KRB_PRINCIPAL using cluster-b/_h...@example.com to connect > cluster B.- > ^ This is not truth, we use token based digest auth in mapper/reducer, so > principal difference for kerberos should be fine -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack merged pull request #3582: HBASE-26196 Support configuration override for remote cluster of HFileOutputFormat locality sensitive
saintstack merged pull request #3582: URL: https://github.com/apache/hbase/pull/3582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26147) Add dry run mode to hbase balancer
[ https://issues.apache.org/jira/browse/HBASE-26147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26147: - Fix Version/s: 3.0.0-alpha-2 2.5.0 > Add dry run mode to hbase balancer > -- > > Key: HBASE-26147 > URL: https://issues.apache.org/jira/browse/HBASE-26147 > Project: HBase > Issue Type: Improvement > Components: Balancer, master >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-2 > > > It's often rather hard to know how the cost function changes you're making > will affect the balance of the cluster, and currently the only way to know is > to run it. If the cost decisions are not good, you may have just moved many > regions towards a non-ideal balance. Region moves themselves are not free for > clients, and the resulting balance may cause a regression. > We should add a mode to the balancer so that it can be invoked without > actually executing any plans. This will allow an administrator to iterate on > their cost functions and used the balancer's logging to see how their changes > would affect the cluster. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ndimiduk commented on a change in pull request #3536: HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves
ndimiduk commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r689717013
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalanceRequest.java
##
@@ -0,0 +1,96 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+/**
+ * Encapsulates options for executing an unscheduled run of the Balancer.
+ */
+@InterfaceAudience.Public
+@InterfaceStability.Evolving
+public class BalanceRequest {
Review comment:
nit: There's no public constructors, so both `BalanceRequest` and it's
`Builder` could be declared `final`.
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalanceRequest.java
##
@@ -0,0 +1,96 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+/**
+ * Encapsulates options for executing an unscheduled run of the Balancer.
+ */
+@InterfaceAudience.Public
+@InterfaceStability.Evolving
+public class BalanceRequest {
+ private static BalanceRequest DEFAULT = BalanceRequest.newBuilder().build();
Review comment:
nit: should be `final`.
##
File path:
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
##
@@ -541,6 +544,11 @@ public boolean balanceRSGroup(String groupName) throws
IOException {
getRSGroupAssignmentsByTable(master.getTableStateManager(),
groupName);
List plans = balancer.balanceCluster(assignmentsByTable);
boolean balancerRan = !plans.isEmpty();
+
+ if (request.isDryRun()) {
+return balancerRan;
Review comment:
Yes. I suggest we enrich this return type before 2.5.0. That can be this
PR or a follow-on.
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
##
@@ -20,6 +20,7 @@
import static org.apache.hadoop.hbase.util.FutureUtils.addListener;
import com.google.protobuf.RpcChannel;
+import java.io.IOException;
Review comment:
unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-26186) "Packaging and Integration" stage broken on branch-2 since 8bc180c7737bbd1792851004625c552896bf57c6
[ https://issues.apache.org/jira/browse/HBASE-26186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17399830#comment-17399830 ] Nick Dimiduk commented on HBASE-26186: -- In fact we do make use of it... > "Packaging and Integration" stage broken on branch-2 since > 8bc180c7737bbd1792851004625c552896bf57c6 > --- > > Key: HBASE-26186 > URL: https://issues.apache.org/jira/browse/HBASE-26186 > Project: HBase > Issue Type: Task > Components: build, integration tests >Affects Versions: 2.5.0 >Reporter: Nick Dimiduk >Priority: Major > > Nightly builds of branch-2 have been failing on the "Packaging and > Integration" stage since 2021-07-22, commit > 8bc180c7737bbd1792851004625c552896bf57c6. > The first failing build was > https://ci-hadoop.apache.org/blue/organizations/jenkins/HBase%2FHBase%20Nightly/detail/branch-2/304/pipeline/12 -- This message was sent by Atlassian Jira (v8.3.4#803005)
