[jira] [Commented] (HBASE-27646) Should not use pread when prefetching in HFilePreadReader
[
https://issues.apache.org/jira/browse/HBASE-27646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703042#comment-17703042
]
Hudson commented on HBASE-27646:
Results for branch branch-2
[build #774 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/774/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/774/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/774/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/774/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/774/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should not use pread when prefetching in HFilePreadReader
> -
>
> Key: HBASE-27646
> URL: https://issues.apache.org/jira/browse/HBASE-27646
> Project: HBase
> Issue Type: Improvement
> Components: Performance
>Affects Versions: 2.5.3
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>
>
> While prefetchOnOpen will read althrough the hfile, we should use stream read
> for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27651) hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
[
https://issues.apache.org/jira/browse/HBASE-27651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703043#comment-17703043
]
Hudson commented on HBASE-27651:
Results for branch branch-2
[build #774 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/774/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/774/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/774/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/774/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/774/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
>
>
> Key: HBASE-27651
> URL: https://issues.apache.org/jira/browse/HBASE-27651
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>
>
> Running HBase in a container environment, launched using
> {{{}bin/hbase-daemon.sh foreground_start ...{}}}. Signaling the container for
> config refresh or for graceful termination doesn't make it through to the JVM
> process. Rather, the {{trap}} function is unconditionally sending {{{}kill
> -9{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27717) Add rsgroup name for dead region servers on master UI
[ https://issues.apache.org/jira/browse/HBASE-27717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703041#comment-17703041 ] Xiaolin Ha commented on HBASE-27717: [~zhangduo] I can't assign this issue to [~xieyupei] , could you help to take a look? > Add rsgroup name for dead region servers on master UI > - > > Key: HBASE-27717 > URL: https://issues.apache.org/jira/browse/HBASE-27717 > Project: HBase > Issue Type: Improvement > Components: UI >Affects Versions: 2.5.3 >Reporter: Xiaolin Ha >Priority: Minor > > We also want to known the rsgroup name of dead region servers, which are > showed in the `Dead Region Servers` of master UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-27684) Client metrics for user region lock related behaviors.
[ https://issues.apache.org/jira/browse/HBASE-27684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-27684. -- Fix Version/s: 2.6.0 2.5.4 Hadoop Flags: Reviewed Resolution: Fixed > Client metrics for user region lock related behaviors. > -- > > Key: HBASE-27684 > URL: https://issues.apache.org/jira/browse/HBASE-27684 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0 >Reporter: Victor Li >Assignee: Victor Li >Priority: Major > Fix For: 2.6.0, 2.5.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] virajjasani commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.
virajjasani commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1477313565 Merged to branch-2 and backported to branch-2.5. The patch could not be applied to branch-2.4 as is. @vli02 could you please create branch-2.4 PR as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani merged pull request #5081: HBASE-27684: add client metrics related to user region lock.
virajjasani merged PR #5081: URL: https://github.com/apache/hbase/pull/5081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27651) hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
[
https://issues.apache.org/jira/browse/HBASE-27651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703024#comment-17703024
]
Hudson commented on HBASE-27651:
Results for branch branch-2.4
[build #534 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/534/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/534/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/534/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/534/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/534/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
>
>
> Key: HBASE-27651
> URL: https://issues.apache.org/jira/browse/HBASE-27651
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>
>
> Running HBase in a container environment, launched using
> {{{}bin/hbase-daemon.sh foreground_start ...{}}}. Signaling the container for
> config refresh or for graceful termination doesn't make it through to the JVM
> process. Rather, the {{trap}} function is unconditionally sending {{{}kill
> -9{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27646) Should not use pread when prefetching in HFilePreadReader
[
https://issues.apache.org/jira/browse/HBASE-27646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703023#comment-17703023
]
Hudson commented on HBASE-27646:
Results for branch branch-2.4
[build #534 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/534/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/534/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/534/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/534/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/534/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should not use pread when prefetching in HFilePreadReader
> -
>
> Key: HBASE-27646
> URL: https://issues.apache.org/jira/browse/HBASE-27646
> Project: HBase
> Issue Type: Improvement
> Components: Performance
>Affects Versions: 2.5.3
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>
>
> While prefetchOnOpen will read althrough the hfile, we should use stream read
> for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27717) Add rsgroup name for dead region servers on master UI
[ https://issues.apache.org/jira/browse/HBASE-27717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703022#comment-17703022 ] Xiaolin Ha commented on HBASE-27717: [~xieyupei] OK > Add rsgroup name for dead region servers on master UI > - > > Key: HBASE-27717 > URL: https://issues.apache.org/jira/browse/HBASE-27717 > Project: HBase > Issue Type: Improvement > Components: UI >Affects Versions: 2.5.3 >Reporter: Xiaolin Ha >Priority: Minor > > We also want to known the rsgroup name of dead region servers, which are > showed in the `Dead Region Servers` of master UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-27717) Add rsgroup name for dead region servers on master UI
[ https://issues.apache.org/jira/browse/HBASE-27717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha reassigned HBASE-27717: -- Assignee: (was: Xiaolin Ha) > Add rsgroup name for dead region servers on master UI > - > > Key: HBASE-27717 > URL: https://issues.apache.org/jira/browse/HBASE-27717 > Project: HBase > Issue Type: Improvement > Components: UI >Affects Versions: 2.5.3 >Reporter: Xiaolin Ha >Priority: Minor > > We also want to known the rsgroup name of dead region servers, which are > showed in the `Dead Region Servers` of master UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27734) [JDK17] Backport to branch-2.4 HBASE-25058 HBase-27510
[
https://issues.apache.org/jira/browse/HBASE-27734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703009#comment-17703009
]
tianhang tang commented on HBASE-27734:
---
Hi [~mrzhao] , you mean just {quote}unify build with jdk11 argLine in
pom{quote}, but remove them from the shell?
First of all I think if If we can converge these things together, of course it
is the best. But the problem seems at the run-time. We not only need this
configs when compiling, but also at run time. For example, UTs or HBase shell.
So if only setting in pom may not be enough. [JEP
261|https://openjdk.org/jeps/261]
> [JDK17] Backport to branch-2.4 HBASE-25058 HBase-27510
> --
>
> Key: HBASE-27734
> URL: https://issues.apache.org/jira/browse/HBASE-27734
> Project: HBase
> Issue Type: Improvement
>Reporter: Moran
>Priority: Minor
>
> I use jdk17 on branch-2.4，encountered some WARN like:
> {code:java}
> WARN FilenoUtil : Native subprocess control requires open access to the JDK
> IO subsystem
> Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens
> java.base/java.io=ALL-UNNAMED' to enable.{code}
> Backport HBASE-25058 and HBASE-27510 PR can resolve the warn problem.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5121: HBASE-27733
Apache-HBase commented on PR #5121: URL: https://github.com/apache/hbase/pull/5121#issuecomment-1477224276 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 21s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 18s | master passed | | +1 :green_heart: | compile | 2m 24s | master passed | | +1 :green_heart: | checkstyle | 0m 35s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 27s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | compile | 2m 25s | the patch passed | | +1 :green_heart: | javac | 2m 25s | the patch passed | | +1 :green_heart: | checkstyle | 0m 33s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 5s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 37m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5121/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5121 | | JIRA Issue | HBASE-27733 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 0d6bc0f07f43 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 814f3267d7 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 85 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5121/3/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] haohao0103 commented on a diff in pull request #5121: HBASE-27733
haohao0103 commented on code in PR #5121:
URL: https://github.com/apache/hbase/pull/5121#discussion_r1142842551
##
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesTool.java:
##
@@ -768,13 +782,50 @@ private static void copyHFileHalf(Configuration conf,
Path inFile, Path outFile,
.withChecksumType(StoreUtils.getChecksumType(conf))
.withBytesPerCheckSum(StoreUtils.getBytesPerChecksum(conf)).withBlockSize(blocksize)
.withDataBlockEncoding(familyDescriptor.getDataBlockEncoding()).withIncludesTags(true)
-.withCreateTime(EnvironmentEdgeManager.currentTime()).build();
- halfWriter = new StoreFileWriter.Builder(conf, cacheConf,
fs).withFilePath(outFile)
-.withBloomType(bloomFilterType).withFileContext(hFileContext).build();
+.build();
+
HFileScanner scanner = halfReader.getScanner(false, false, false);
scanner.seekTo();
do {
-halfWriter.append(scanner.getCell());
+final Cell cell = scanner.getCell();
+if (null != halfWriter) {
+ halfWriter.append(cell);
+} else {
+
+ // init halfwriter
+ if (conf.getBoolean(LOCALITY_SENSITIVE_CONF_KEY,
DEFAULT_LOCALITY_SENSITIVE)) {
+byte[] rowKey = CellUtil.cloneRow(cell);
+HRegionLocation hRegionLocation =
FutureUtils.get(loc.getRegionLocation(rowKey));
+InetSocketAddress[] favoredNodes = null;
+if (null == hRegionLocation) {
+ LOG.trace("Failed get of location, use default writer {}",
Bytes.toString(rowKey));
+} else {
+ LOG.debug("First rowkey: [{}]", Bytes.toString(rowKey));
+ InetSocketAddress initialIsa =
+new InetSocketAddress(hRegionLocation.getHostname(),
hRegionLocation.getPort());
+ if (initialIsa.isUnresolved()) {
+LOG.trace("Failed resolve address {}, use default writer",
+ hRegionLocation.getHostnamePort());
+ } else {
+LOG.debug("Use favored nodes writer: {}",
initialIsa.getHostString());
+favoredNodes = new InetSocketAddress[] { initialIsa };
+ }
+}
+if (null == favoredNodes) {
+ halfWriter = new StoreFileWriter.Builder(conf, cacheConf,
fs).withFilePath(outFile)
+
.withBloomType(bloomFilterType).withFileContext(hFileContext).build();
+} else {
+ halfWriter = new StoreFileWriter.Builder(conf, cacheConf,
fs).withFilePath(outFile)
+.withBloomType(bloomFilterType).withFileContext(hFileContext)
+.withFavoredNodes(favoredNodes).build();
+}
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-27676) Scan handlers in the RPC executor should match at least one scan queues
[
https://issues.apache.org/jira/browse/HBASE-27676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha updated HBASE-27676:
---
Description:
This issue is try to avoid NO scan queues for some scan handlers.
For example, if we set hbase.regionserver.handler.count=150,
hbase.ipc.server.callqueue.scan.ratio=0.1,
hbase.ipc.server.callqueue.read.ratio=0.5,
hbase.ipc.server.callqueue.handler.factor=0.1, then there will be 150 * 0.5 *
0.1 = 7 scan handlers, but there are 150 * 0.1 * 0.5 * 0.1 = 0 scan RPC queues.
When there are no scan rpc queues, all the scan and get requests will be
dispatched to the read rpc queues, while we we thought they had been dealt with
separately, since the scan handler count is not 0. When there are not enough
handlers for large scan requests under this circumstance, the small get
requests will be blocked in the rpc queues.
We can see from the codes,
{code:java}
int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
int scanHandlers = Math.max(0, (int) Math.floor(readHandlers * callqScanShare));
if ((readQueues - scanQueues) > 0) {
readQueues -= scanQueues;
readHandlers -= scanHandlers;
} else {
scanQueues = 0;
scanHandlers = 0;
} {code}
when readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
there will be some iddle scan handlers with NO scan queues.
was:
This issue is try to avoid NO scan queues for some scan handlers.
For example, if we set hbase.regionserver.handler.count=150,
hbase.ipc.server.callqueue.scan.ratio=0.1,
hbase.ipc.server.callqueue.read.ratio=0.5,
hbase.ipc.server.callqueue.handler.factor=0.1, then there will be 150 * 0.5 *
{*}{*}0.1 = 7 scan handlers, but there are 150 * 0.1 * 0.5 * 0.1 = 0 scan RPC
queues.
When there are no scan rpc queues, all the scan and get requests will be
dispatched to the read rpc queues, while we we thought they had been dealt with
separately, since the scan handler count is not 0. When there are not enough
handlers for large scan requests under this circumstance, the small get
requests will be blocked in the rpc queues.
We can see from the codes,
{code:java}
int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
int scanHandlers = Math.max(0, (int) Math.floor(readHandlers * callqScanShare));
if ((readQueues - scanQueues) > 0) {
readQueues -= scanQueues;
readHandlers -= scanHandlers;
} else {
scanQueues = 0;
scanHandlers = 0;
} {code}
when readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
there will be some iddle scan handlers with NO scan queues.
> Scan handlers in the RPC executor should match at least one scan queues
> ---
>
> Key: HBASE-27676
> URL: https://issues.apache.org/jira/browse/HBASE-27676
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.5.3
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> This issue is try to avoid NO scan queues for some scan handlers.
> For example, if we set hbase.regionserver.handler.count=150,
> hbase.ipc.server.callqueue.scan.ratio=0.1,
> hbase.ipc.server.callqueue.read.ratio=0.5,
> hbase.ipc.server.callqueue.handler.factor=0.1, then there will be 150 * 0.5 *
> 0.1 = 7 scan handlers, but there are 150 * 0.1 * 0.5 * 0.1 = 0 scan RPC
> queues.
> When there are no scan rpc queues, all the scan and get requests will be
> dispatched to the read rpc queues, while we we thought they had been dealt
> with separately, since the scan handler count is not 0. When there are not
> enough handlers for large scan requests under this circumstance, the small
> get requests will be blocked in the rpc queues.
> We can see from the codes,
> {code:java}
> int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
> int scanHandlers = Math.max(0, (int) Math.floor(readHandlers *
> callqScanShare));
> if ((readQueues - scanQueues) > 0) {
> readQueues -= scanQueues;
> readHandlers -= scanHandlers;
> } else {
> scanQueues = 0;
> scanHandlers = 0;
> } {code}
> when readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
> there will be some iddle scan handlers with NO scan queues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27676) Scan handlers in the RPC executor should match at least one scan queues
[
https://issues.apache.org/jira/browse/HBASE-27676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha updated HBASE-27676:
---
Description:
This issue is try to avoid NO scan queues for some scan handlers.
For example, if we set hbase.regionserver.handler.count=150,
hbase.ipc.server.callqueue.scan.ratio=0.1,
hbase.ipc.server.callqueue.read.ratio=0.5,
hbase.ipc.server.callqueue.handler.factor=0.1, then there will be
150*0.5{_}*{_}0.1=7 scan handlers, but there are 150*0.1{_}*{_}0.5*0.1=0 scan
RPC queues.
When there are no scan rpc queues, all the scan and get requests will be
dispatched to the read rpc queues, while we we thought they had been dealt with
separately, since the scan handler count is not 0. When there are not enough
handlers for large scan requests under this circumstance, the small get
requests will be blocked in the rpc queues.
We can see from the codes,
{code:java}
int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
int scanHandlers = Math.max(0, (int) Math.floor(readHandlers * callqScanShare));
if ((readQueues - scanQueues) > 0) {
readQueues -= scanQueues;
readHandlers -= scanHandlers;
} else {
scanQueues = 0;
scanHandlers = 0;
} {code}
when readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
there will be some iddle scan handlers with NO scan queues.
was:
This issue is try to avoid NO scan queues for some scan handlers.
For example, if we set hbase.regionserver.handler.count=150,
hbase.ipc.server.callqueue.scan.ratio=0.1,
hbase.ipc.server.callqueue.read.ratio=0.5,
hbase.ipc.server.callqueue.handler.factor=0.1, then there will be
150{_}0.5{_}0.1=7 scan handlers, but there are 150{_}0.1{_}0.5*0.1=0 scan RPC
queues.
When there are no scan rpc queues, all the scan and get requests will be
dispatched to the read rpc queues, while we we thought they had been dealt with
separately, since the scan handler count is not 0. When there are not enough
handlers for large scan requests under this circumstance, the small get
requests will be blocked in the rpc queues.
We can see from the codes,
{code:java}
int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
int scanHandlers = Math.max(0, (int) Math.floor(readHandlers * callqScanShare));
if ((readQueues - scanQueues) > 0) {
readQueues -= scanQueues;
readHandlers -= scanHandlers;
} else {
scanQueues = 0;
scanHandlers = 0;
} {code}
when readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
there will be some iddle scan handlers with NO scan queues.
> Scan handlers in the RPC executor should match at least one scan queues
> ---
>
> Key: HBASE-27676
> URL: https://issues.apache.org/jira/browse/HBASE-27676
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.5.3
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> This issue is try to avoid NO scan queues for some scan handlers.
> For example, if we set hbase.regionserver.handler.count=150,
> hbase.ipc.server.callqueue.scan.ratio=0.1,
> hbase.ipc.server.callqueue.read.ratio=0.5,
> hbase.ipc.server.callqueue.handler.factor=0.1, then there will be
> 150*0.5{_}*{_}0.1=7 scan handlers, but there are 150*0.1{_}*{_}0.5*0.1=0 scan
> RPC queues.
> When there are no scan rpc queues, all the scan and get requests will be
> dispatched to the read rpc queues, while we we thought they had been dealt
> with separately, since the scan handler count is not 0. When there are not
> enough handlers for large scan requests under this circumstance, the small
> get requests will be blocked in the rpc queues.
> We can see from the codes,
> {code:java}
> int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
> int scanHandlers = Math.max(0, (int) Math.floor(readHandlers *
> callqScanShare));
> if ((readQueues - scanQueues) > 0) {
> readQueues -= scanQueues;
> readHandlers -= scanHandlers;
> } else {
> scanQueues = 0;
> scanHandlers = 0;
> } {code}
> when readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
> there will be some iddle scan handlers with NO scan queues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27676) Scan handlers in the RPC executor should match at least one scan queues
[
https://issues.apache.org/jira/browse/HBASE-27676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha updated HBASE-27676:
---
Description:
This issue is try to avoid NO scan queues for some scan handlers.
For example, if we set hbase.regionserver.handler.count=150,
hbase.ipc.server.callqueue.scan.ratio=0.1,
hbase.ipc.server.callqueue.read.ratio=0.5,
hbase.ipc.server.callqueue.handler.factor=0.1, then there will be 150 * 0.5 *
{*}{*}0.1 = 7 scan handlers, but there are 150 * 0.1 * 0.5 * 0.1 = 0 scan RPC
queues.
When there are no scan rpc queues, all the scan and get requests will be
dispatched to the read rpc queues, while we we thought they had been dealt with
separately, since the scan handler count is not 0. When there are not enough
handlers for large scan requests under this circumstance, the small get
requests will be blocked in the rpc queues.
We can see from the codes,
{code:java}
int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
int scanHandlers = Math.max(0, (int) Math.floor(readHandlers * callqScanShare));
if ((readQueues - scanQueues) > 0) {
readQueues -= scanQueues;
readHandlers -= scanHandlers;
} else {
scanQueues = 0;
scanHandlers = 0;
} {code}
when readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
there will be some iddle scan handlers with NO scan queues.
was:
This issue is try to avoid NO scan queues for some scan handlers.
For example, if we set hbase.regionserver.handler.count=150,
hbase.ipc.server.callqueue.scan.ratio=0.1,
hbase.ipc.server.callqueue.read.ratio=0.5,
hbase.ipc.server.callqueue.handler.factor=0.1, then there will be
150*0.5{_}*{_}0.1=7 scan handlers, but there are 150*0.1{_}*{_}0.5*0.1=0 scan
RPC queues.
When there are no scan rpc queues, all the scan and get requests will be
dispatched to the read rpc queues, while we we thought they had been dealt with
separately, since the scan handler count is not 0. When there are not enough
handlers for large scan requests under this circumstance, the small get
requests will be blocked in the rpc queues.
We can see from the codes,
{code:java}
int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
int scanHandlers = Math.max(0, (int) Math.floor(readHandlers * callqScanShare));
if ((readQueues - scanQueues) > 0) {
readQueues -= scanQueues;
readHandlers -= scanHandlers;
} else {
scanQueues = 0;
scanHandlers = 0;
} {code}
when readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
there will be some iddle scan handlers with NO scan queues.
> Scan handlers in the RPC executor should match at least one scan queues
> ---
>
> Key: HBASE-27676
> URL: https://issues.apache.org/jira/browse/HBASE-27676
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.5.3
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> This issue is try to avoid NO scan queues for some scan handlers.
> For example, if we set hbase.regionserver.handler.count=150,
> hbase.ipc.server.callqueue.scan.ratio=0.1,
> hbase.ipc.server.callqueue.read.ratio=0.5,
> hbase.ipc.server.callqueue.handler.factor=0.1, then there will be 150 * 0.5 *
> {*}{*}0.1 = 7 scan handlers, but there are 150 * 0.1 * 0.5 * 0.1 = 0 scan RPC
> queues.
> When there are no scan rpc queues, all the scan and get requests will be
> dispatched to the read rpc queues, while we we thought they had been dealt
> with separately, since the scan handler count is not 0. When there are not
> enough handlers for large scan requests under this circumstance, the small
> get requests will be blocked in the rpc queues.
> We can see from the codes,
> {code:java}
> int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
> int scanHandlers = Math.max(0, (int) Math.floor(readHandlers *
> callqScanShare));
> if ((readQueues - scanQueues) > 0) {
> readQueues -= scanQueues;
> readHandlers -= scanHandlers;
> } else {
> scanQueues = 0;
> scanHandlers = 0;
> } {code}
> when readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
> there will be some iddle scan handlers with NO scan queues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27676) Scan handlers in the RPC executor should match at least one scan queues
[
https://issues.apache.org/jira/browse/HBASE-27676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha updated HBASE-27676:
---
Description:
This issue is try to avoid NO scan queues for some scan handlers.
For example, if we set hbase.regionserver.handler.count=150,
hbase.ipc.server.callqueue.scan.ratio=0.1,
hbase.ipc.server.callqueue.read.ratio=0.5,
hbase.ipc.server.callqueue.handler.factor=0.1, then there will be
150{_}0.5{_}0.1=7 scan handlers, but there are 150{_}0.1{_}0.5*0.1=0 scan RPC
queues.
When there are no scan rpc queues, all the scan and get requests will be
dispatched to the read rpc queues, while we we thought they had been dealt with
separately, since the scan handler count is not 0. When there are not enough
handlers for large scan requests under this circumstance, the small get
requests will be blocked in the rpc queues.
We can see from the codes,
{code:java}
int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
int scanHandlers = Math.max(0, (int) Math.floor(readHandlers * callqScanShare));
if ((readQueues - scanQueues) > 0) {
readQueues -= scanQueues;
readHandlers -= scanHandlers;
} else {
scanQueues = 0;
scanHandlers = 0;
} {code}
when readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
there will be some iddle scan handlers with NO scan queues.
was:
This issue is try to avoid NO scan queues for some scan handlers.
For example, if we set hbase.regionserver.handler.count=150,
hbase.ipc.server.callqueue.scan.ratio=0.1,
hbase.ipc.server.callqueue.read.ratio=0.5,
hbase.ipc.server.callqueue.handler.factor=0.1, then there will be
150{_}0.5{_}0.1=7 scan handlers, but there are 150{_}0.1{_}0.5*0.1=0 scan RPC
queues.
When there are no scan rpc queues, all the scan and get requests will be
dispatched to the read rpc queues, while we we thought they had been dealt with
separately, since the scan handler count is not 0. When there are not enough
handlers for large scan requests under this circumstance, the small get
requests will be blocked in the rpc queues.
{code:java}
int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
int scanHandlers = Math.max(0, (int) Math.floor(readHandlers * callqScanShare));
if ((readQueues - scanQueues) > 0) {
readQueues -= scanQueues;
readHandlers -= scanHandlers;
} else {
scanQueues = 0;
scanHandlers = 0;
} {code}
When readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
there will be some iddle scan handlers with NO scan queues.
> Scan handlers in the RPC executor should match at least one scan queues
> ---
>
> Key: HBASE-27676
> URL: https://issues.apache.org/jira/browse/HBASE-27676
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.5.3
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> This issue is try to avoid NO scan queues for some scan handlers.
> For example, if we set hbase.regionserver.handler.count=150,
> hbase.ipc.server.callqueue.scan.ratio=0.1,
> hbase.ipc.server.callqueue.read.ratio=0.5,
> hbase.ipc.server.callqueue.handler.factor=0.1, then there will be
> 150{_}0.5{_}0.1=7 scan handlers, but there are 150{_}0.1{_}0.5*0.1=0 scan RPC
> queues.
> When there are no scan rpc queues, all the scan and get requests will be
> dispatched to the read rpc queues, while we we thought they had been dealt
> with separately, since the scan handler count is not 0. When there are not
> enough handlers for large scan requests under this circumstance, the small
> get requests will be blocked in the rpc queues.
> We can see from the codes,
> {code:java}
> int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
> int scanHandlers = Math.max(0, (int) Math.floor(readHandlers *
> callqScanShare));
> if ((readQueues - scanQueues) > 0) {
> readQueues -= scanQueues;
> readHandlers -= scanHandlers;
> } else {
> scanQueues = 0;
> scanHandlers = 0;
> } {code}
> when readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
> there will be some iddle scan handlers with NO scan queues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27676) Scan handlers in the RPC executor should match at least one scan queues
[
https://issues.apache.org/jira/browse/HBASE-27676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha updated HBASE-27676:
---
Description:
This issue is try to avoid NO scan queues for some scan handlers.
For example, if we set hbase.regionserver.handler.count=150,
hbase.ipc.server.callqueue.scan.ratio=0.1,
hbase.ipc.server.callqueue.read.ratio=0.5,
hbase.ipc.server.callqueue.handler.factor=0.1, then there will be
150{_}0.5{_}0.1=7 scan handlers, but there are 150{_}0.1{_}0.5*0.1=0 scan RPC
queues.
When there are no scan rpc queues, all the scan and get requests will be
dispatched to the read rpc queues, while we we thought they had been dealt with
separately, since the scan handler count is not 0. When there are not enough
handlers for large scan requests under this circumstance, the small get
requests will be blocked in the rpc queues.
{code:java}
int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
int scanHandlers = Math.max(0, (int) Math.floor(readHandlers * callqScanShare));
if ((readQueues - scanQueues) > 0) {
readQueues -= scanQueues;
readHandlers -= scanHandlers;
} else {
scanQueues = 0;
scanHandlers = 0;
} {code}
When readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
there will be some iddle scan handlers with NO scan queues.
was:
{code:java}
int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
int scanHandlers = Math.max(0, (int) Math.floor(readHandlers * callqScanShare));
if ((readQueues - scanQueues) > 0) {
readQueues -= scanQueues;
readHandlers -= scanHandlers;
} else {
scanQueues = 0;
scanHandlers = 0;
} {code}
When readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
there will be some iddle scan handlers with NO scan queues.
> Scan handlers in the RPC executor should match at least one scan queues
> ---
>
> Key: HBASE-27676
> URL: https://issues.apache.org/jira/browse/HBASE-27676
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.5.3
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Minor
>
> This issue is try to avoid NO scan queues for some scan handlers.
> For example, if we set hbase.regionserver.handler.count=150,
> hbase.ipc.server.callqueue.scan.ratio=0.1,
> hbase.ipc.server.callqueue.read.ratio=0.5,
> hbase.ipc.server.callqueue.handler.factor=0.1, then there will be
> 150{_}0.5{_}0.1=7 scan handlers, but there are 150{_}0.1{_}0.5*0.1=0 scan RPC
> queues.
> When there are no scan rpc queues, all the scan and get requests will be
> dispatched to the read rpc queues, while we we thought they had been dealt
> with separately, since the scan handler count is not 0. When there are not
> enough handlers for large scan requests under this circumstance, the small
> get requests will be blocked in the rpc queues.
> {code:java}
> int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
> int scanHandlers = Math.max(0, (int) Math.floor(readHandlers *
> callqScanShare));
> if ((readQueues - scanQueues) > 0) {
> readQueues -= scanQueues;
> readHandlers -= scanHandlers;
> } else {
> scanQueues = 0;
> scanHandlers = 0;
> } {code}
> When readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
> there will be some iddle scan handlers with NO scan queues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27676) Scan handlers in the RPC executor should match at least one scan queues
[
https://issues.apache.org/jira/browse/HBASE-27676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha updated HBASE-27676:
---
Priority: Major (was: Minor)
> Scan handlers in the RPC executor should match at least one scan queues
> ---
>
> Key: HBASE-27676
> URL: https://issues.apache.org/jira/browse/HBASE-27676
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.5.3
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> This issue is try to avoid NO scan queues for some scan handlers.
> For example, if we set hbase.regionserver.handler.count=150,
> hbase.ipc.server.callqueue.scan.ratio=0.1,
> hbase.ipc.server.callqueue.read.ratio=0.5,
> hbase.ipc.server.callqueue.handler.factor=0.1, then there will be
> 150{_}0.5{_}0.1=7 scan handlers, but there are 150{_}0.1{_}0.5*0.1=0 scan RPC
> queues.
> When there are no scan rpc queues, all the scan and get requests will be
> dispatched to the read rpc queues, while we we thought they had been dealt
> with separately, since the scan handler count is not 0. When there are not
> enough handlers for large scan requests under this circumstance, the small
> get requests will be blocked in the rpc queues.
> {code:java}
> int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare));
> int scanHandlers = Math.max(0, (int) Math.floor(readHandlers *
> callqScanShare));
> if ((readQueues - scanQueues) > 0) {
> readQueues -= scanQueues;
> readHandlers -= scanHandlers;
> } else {
> scanQueues = 0;
> scanHandlers = 0;
> } {code}
> When readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1,
> there will be some iddle scan handlers with NO scan queues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27110) Move replication peer storage from zookeeper to other storage systems
[ https://issues.apache.org/jira/browse/HBASE-27110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702991#comment-17702991 ] Duo Zhang commented on HBASE-27110: --- After HBASE-26193, the hbase:meta location is stored in master local region too, so there is no persistent data on zookeeper any more, besides replication data. The long term decision is to remove zookeeper as persistent data storage, but yeah, what is the most suitable storage for the data is still under discussion. Thanks. > Move replication peer storage from zookeeper to other storage systems > - > > Key: HBASE-27110 > URL: https://issues.apache.org/jira/browse/HBASE-27110 > Project: HBase > Issue Type: New Feature > Components: Replication >Reporter: Duo Zhang >Priority: Major > > This is a more specific issue based on the works which are already done in > HBASE-15867. > There are several candidates for storing replication peer. > 1. A new family of master local region > 2. On FileSystem > 3. A new family of hbase:meta > Either choice has pros and cons. We need to decide which way to go first. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] haohao0103 commented on a diff in pull request #5121: HBASE-27733
haohao0103 commented on code in PR #5121:
URL: https://github.com/apache/hbase/pull/5121#discussion_r1142830952
##
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesTool.java:
##
@@ -768,13 +782,50 @@ private static void copyHFileHalf(Configuration conf,
Path inFile, Path outFile,
.withChecksumType(StoreUtils.getChecksumType(conf))
.withBytesPerCheckSum(StoreUtils.getBytesPerChecksum(conf)).withBlockSize(blocksize)
.withDataBlockEncoding(familyDescriptor.getDataBlockEncoding()).withIncludesTags(true)
-.withCreateTime(EnvironmentEdgeManager.currentTime()).build();
- halfWriter = new StoreFileWriter.Builder(conf, cacheConf,
fs).withFilePath(outFile)
-.withBloomType(bloomFilterType).withFileContext(hFileContext).build();
+.build();
+
HFileScanner scanner = halfReader.getScanner(false, false, false);
scanner.seekTo();
do {
-halfWriter.append(scanner.getCell());
+final Cell cell = scanner.getCell();
+if (null != halfWriter) {
+ halfWriter.append(cell);
+} else {
+
+ // init halfwriter
+ if (conf.getBoolean(LOCALITY_SENSITIVE_CONF_KEY,
DEFAULT_LOCALITY_SENSITIVE)) {
Review Comment:
Sorry, I don't understand what you mean by waste, I think this code will
only be executed once when the halfwriter is first initialized, not once for
each cell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] sunhelly commented on pull request #4732: HBASE-27333 Abort RS when the hostname is different from master seen
sunhelly commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1477183601 Ping @Apache9 @apurtell , please take a look. If there are some other concerns, please let me know, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27734) [JDK17] Backport to branch-2.4 HBASE-25058 HBase-27510
[
https://issues.apache.org/jira/browse/HBASE-27734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702986#comment-17702986
]
Moran commented on HBASE-27734:
---
--add-opens appears in pom files and sh files to adapt to higher versions of
jdk.
Should we unify build with jdk11 argLine in pom.
[~tangtianhang] You recently worked on jdk17, what do you think?
> [JDK17] Backport to branch-2.4 HBASE-25058 HBase-27510
> --
>
> Key: HBASE-27734
> URL: https://issues.apache.org/jira/browse/HBASE-27734
> Project: HBase
> Issue Type: Improvement
>Reporter: Moran
>Priority: Minor
>
> I use jdk17 on branch-2.4，encountered some WARN like:
> {code:java}
> WARN FilenoUtil : Native subprocess control requires open access to the JDK
> IO subsystem
> Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens
> java.base/java.io=ALL-UNNAMED' to enable.{code}
> Backport HBASE-25058 and HBASE-27510 PR can resolve the warn problem.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] haohao0103 commented on a diff in pull request #5121: HBASE-27733
haohao0103 commented on code in PR #5121:
URL: https://github.com/apache/hbase/pull/5121#discussion_r1142826895
##
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesTool.java:
##
@@ -768,13 +782,50 @@ private static void copyHFileHalf(Configuration conf,
Path inFile, Path outFile,
.withChecksumType(StoreUtils.getChecksumType(conf))
.withBytesPerCheckSum(StoreUtils.getBytesPerChecksum(conf)).withBlockSize(blocksize)
.withDataBlockEncoding(familyDescriptor.getDataBlockEncoding()).withIncludesTags(true)
-.withCreateTime(EnvironmentEdgeManager.currentTime()).build();
- halfWriter = new StoreFileWriter.Builder(conf, cacheConf,
fs).withFilePath(outFile)
-.withBloomType(bloomFilterType).withFileContext(hFileContext).build();
+.build();
+
HFileScanner scanner = halfReader.getScanner(false, false, false);
scanner.seekTo();
do {
-halfWriter.append(scanner.getCell());
+final Cell cell = scanner.getCell();
+if (null != halfWriter) {
+ halfWriter.append(cell);
+} else {
+
+ // init halfwriter
+ if (conf.getBoolean(LOCALITY_SENSITIVE_CONF_KEY,
DEFAULT_LOCALITY_SENSITIVE)) {
+byte[] rowKey = CellUtil.cloneRow(cell);
+HRegionLocation hRegionLocation =
FutureUtils.get(loc.getRegionLocation(rowKey));
+InetSocketAddress[] favoredNodes = null;
+if (null == hRegionLocation) {
+ LOG.trace("Failed get of location, use default writer {}",
Bytes.toString(rowKey));
+} else {
+ LOG.debug("First rowkey: [{}]", Bytes.toString(rowKey));
+ InetSocketAddress initialIsa =
+new InetSocketAddress(hRegionLocation.getHostname(),
hRegionLocation.getPort());
+ if (initialIsa.isUnresolved()) {
+LOG.trace("Failed resolve address {}, use default writer",
Review Comment:
ok,i got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] haohao0103 commented on a diff in pull request #5121: HBASE-27733
haohao0103 commented on code in PR #5121:
URL: https://github.com/apache/hbase/pull/5121#discussion_r1142826021
##
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesTool.java:
##
@@ -768,13 +782,50 @@ private static void copyHFileHalf(Configuration conf,
Path inFile, Path outFile,
.withChecksumType(StoreUtils.getChecksumType(conf))
.withBytesPerCheckSum(StoreUtils.getBytesPerChecksum(conf)).withBlockSize(blocksize)
.withDataBlockEncoding(familyDescriptor.getDataBlockEncoding()).withIncludesTags(true)
-.withCreateTime(EnvironmentEdgeManager.currentTime()).build();
- halfWriter = new StoreFileWriter.Builder(conf, cacheConf,
fs).withFilePath(outFile)
-.withBloomType(bloomFilterType).withFileContext(hFileContext).build();
+.build();
+
HFileScanner scanner = halfReader.getScanner(false, false, false);
scanner.seekTo();
do {
-halfWriter.append(scanner.getCell());
+final Cell cell = scanner.getCell();
+if (null != halfWriter) {
+ halfWriter.append(cell);
+} else {
+
+ // init halfwriter
+ if (conf.getBoolean(LOCALITY_SENSITIVE_CONF_KEY,
DEFAULT_LOCALITY_SENSITIVE)) {
+byte[] rowKey = CellUtil.cloneRow(cell);
+HRegionLocation hRegionLocation =
FutureUtils.get(loc.getRegionLocation(rowKey));
+InetSocketAddress[] favoredNodes = null;
+if (null == hRegionLocation) {
+ LOG.trace("Failed get of location, use default writer {}",
Bytes.toString(rowKey));
Review Comment:
yes,default writer that doesn't take region location into account,i will
raise the log level to warn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] haohao0103 commented on a diff in pull request #5121: HBASE-27733
haohao0103 commented on code in PR #5121: URL: https://github.com/apache/hbase/pull/5121#discussion_r1142824027 ## hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesTool.java: ## @@ -768,13 +782,50 @@ private static void copyHFileHalf(Configuration conf, Path inFile, Path outFile, .withChecksumType(StoreUtils.getChecksumType(conf)) .withBytesPerCheckSum(StoreUtils.getBytesPerChecksum(conf)).withBlockSize(blocksize) .withDataBlockEncoding(familyDescriptor.getDataBlockEncoding()).withIncludesTags(true) -.withCreateTime(EnvironmentEdgeManager.currentTime()).build(); - halfWriter = new StoreFileWriter.Builder(conf, cacheConf, fs).withFilePath(outFile) -.withBloomType(bloomFilterType).withFileContext(hFileContext).build(); +.build(); Review Comment: It was my mistake and I will correct it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a diff in pull request #5119: HBASE-27732 NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOl…
virajjasani commented on code in PR #5119:
URL: https://github.com/apache/hbase/pull/5119#discussion_r1142821115
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java:
##
@@ -778,32 +774,35 @@ private void waitForSafePoint() {
}
}
- protected final long closeWriter(AsyncWriter writer, Path path) {
-if (writer != null) {
- inflightWALClosures.put(path.getName(), writer);
- long fileLength = writer.getLength();
- closeExecutor.execute(() -> {
-try {
- writer.close();
-} catch (IOException e) {
- LOG.warn("close old writer failed", e);
-} finally {
- inflightWALClosures.remove(path.getName());
-}
- });
- return fileLength;
-} else {
- return 0L;
-}
+ private void closeWriter(AsyncWriter writer, Path path) {
+inflightWALClosures.put(path.getName(), writer);
+closeExecutor.execute(() -> {
+ try {
+writer.close();
+ } catch (IOException e) {
+LOG.warn("close old writer failed", e);
+ } finally {
+// call this even if the above close fails, as there is no other
chance we can set closed to
+// true, it will not cause big problems.
+markClosedAndClean(path);
+inflightWALClosures.remove(path.getName());
+ }
+});
}
@Override
protected void doReplaceWriter(Path oldPath, Path newPath, AsyncWriter
nextWriter)
throws IOException {
Preconditions.checkNotNull(nextWriter);
waitForSafePoint();
-long oldFileLen = closeWriter(this.writer, oldPath);
-logRollAndSetupWalProps(oldPath, newPath, oldFileLen);
+if (writer != null) {
+ long oldFileLen = writer.getLength();
+ logRollAndSetupWalProps(oldPath, newPath, oldFileLen);
+ closeWriter(writer, oldPath);
+} else {
+ logRollAndSetupWalProps(oldPath, newPath, 0);
Review Comment:
Ah, we can come here after shutdown?
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##
@@ -298,27 +298,34 @@
final Comparator LOG_NAME_COMPARATOR =
(o1, o2) -> Long.compare(getFileNumFromFileName(o1),
getFileNumFromFileName(o2));
- private static final class WalProps {
+ private static final class WALProps {
/**
* Map the encoded region name to the highest sequence id.
*
* Contains all the regions it has an entry for.
*/
-public final Map encodedName2HighestSequenceId;
+final Map encodedName2HighestSequenceId;
/**
* The log file size. Notice that the size may not be accurate if we do
asynchronous close in
* sub classes.
*/
-public final long logSize;
+final long logSize;
/**
* The nanoTime of the log rolling, used to determine the time interval
that has passed since.
*/
-public final long rollTimeNs;
+final long rollTimeNs;
Review Comment:
Shall we also make them `private`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-27740) Support Ozone as a WAL backing storage
[ https://issues.apache.org/jira/browse/HBASE-27740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HBASE-27740: Description: As discussed in the [thread|https://lists.apache.org/thread/tcrp8vxxs3z12y36mpzx35txhpp7tvxv], we'd like to make HBase workloads possible on Ozone. This feature is to be built on top of # HDDS-7593 (support hsync and lease recovery in Ozone), and # HADOOP-18671 (Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem). was: As discussed in the [thread|https://lists.apache.org/thread/tcrp8vxxs3z12y36mpzx35txhpp7tvxv], we'd like to make HBase workloads possible on Ozone. This features is to be built on top of # HDDS-7593 (support hsync and lease recovery in Ozone), and # HADOOP-18671 (Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem). > Support Ozone as a WAL backing storage > -- > > Key: HBASE-27740 > URL: https://issues.apache.org/jira/browse/HBASE-27740 > Project: HBase > Issue Type: New Feature >Reporter: Wei-Chiu Chuang >Priority: Major > > As discussed in the > [thread|https://lists.apache.org/thread/tcrp8vxxs3z12y36mpzx35txhpp7tvxv], > we'd like to make HBase workloads possible on Ozone. > This feature is to be built on top of > # HDDS-7593 (support hsync and lease recovery in Ozone), and > # HADOOP-18671 (Add recoverLease(), setSafeMode(), isFileClosed() APIs to > FileSystem). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27740) Support Ozone as a WAL backing storage
[ https://issues.apache.org/jira/browse/HBASE-27740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702979#comment-17702979 ] Wei-Chiu Chuang commented on HBASE-27740: - cc: [~swu] > Support Ozone as a WAL backing storage > -- > > Key: HBASE-27740 > URL: https://issues.apache.org/jira/browse/HBASE-27740 > Project: HBase > Issue Type: New Feature >Reporter: Wei-Chiu Chuang >Priority: Major > > As discussed in the > [thread|https://lists.apache.org/thread/tcrp8vxxs3z12y36mpzx35txhpp7tvxv], > we'd like to make HBase workloads possible on Ozone. > This features is to be built on top of > # HDDS-7593 (support hsync and lease recovery in Ozone), and > # HADOOP-18671 (Add recoverLease(), setSafeMode(), isFileClosed() APIs to > FileSystem). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-27740) Support Ozone as a WAL backing storage
Wei-Chiu Chuang created HBASE-27740: --- Summary: Support Ozone as a WAL backing storage Key: HBASE-27740 URL: https://issues.apache.org/jira/browse/HBASE-27740 Project: HBase Issue Type: New Feature Reporter: Wei-Chiu Chuang As discussed in the [thread|https://lists.apache.org/thread/tcrp8vxxs3z12y36mpzx35txhpp7tvxv], we'd like to make HBase workloads possible on Ozone. This features is to be built on top of # HDDS-7593 (support hsync and lease recovery in Ozone), and # HADOOP-18671 (Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27110) Move replication peer storage from zookeeper to other storage systems
[ https://issues.apache.org/jira/browse/HBASE-27110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702976#comment-17702976 ] Guanghao Zhang commented on HBASE-27110: HBase used hbase:meta or ZK as meta info storage. Then HBase 2.x introduced a new master local region to store some meta info. Need a discussion about the long-term road map about meta info storage? It's not just a problem of hbase replication peer storage. > Move replication peer storage from zookeeper to other storage systems > - > > Key: HBASE-27110 > URL: https://issues.apache.org/jira/browse/HBASE-27110 > Project: HBase > Issue Type: New Feature > Components: Replication >Reporter: Duo Zhang >Priority: Major > > This is a more specific issue based on the works which are already done in > HBASE-15867. > There are several candidates for storing replication peer. > 1. A new family of master local region > 2. On FileSystem > 3. A new family of hbase:meta > Either choice has pros and cons. We need to decide which way to go first. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] virajjasani commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.
virajjasani commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1477016628 Had an offline sync with @vli02, looks like this is for branch-2 only. Will merge this by EOD unless any objections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #5081: HBASE-27684: add client metrics related to user region lock.
virajjasani commented on PR #5081: URL: https://github.com/apache/hbase/pull/5081#issuecomment-1477014249 @vli02 you might also have to create PR against master branch, as we can't directly merge to branch-2 without master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-27671) Client should not be able to restore/clone a snapshot after it's TTL has expired
[ https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-27671. -- Resolution: Fixed > Client should not be able to restore/clone a snapshot after it's TTL has > expired > > > Key: HBASE-27671 > URL: https://issues.apache.org/jira/browse/HBASE-27671 > Project: HBase > Issue Type: Bug >Affects Versions: 2.5.2 > Environment: ENV- HBase 2.5.2 >Reporter: Ashok shetty >Assignee: Nihal Jain >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4 > > Attachments: Screenshot 2023-03-15 at 8.20.31 PM.png > > > Steps: > precondition : base.master.cleaner.snapshot.interval to 5 min in > hbase-site.xml > 1. create a table t1 , put some data > 2. create a snapshot 'snapt1' with TTL 1 mins > let the TTL expries > 3. disable and drop table t1 > 4. restore snapshot t1 > Actual : restore snapshot successful > Expected : restore operation should fail and throw specified snapshot TTL > expried cant restore > Note : its can consider as improvement point -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27671) Client should not be able to restore/clone a snapshot after it's TTL has expired
[ https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-27671: - Fix Version/s: 2.4.17 > Client should not be able to restore/clone a snapshot after it's TTL has > expired > > > Key: HBASE-27671 > URL: https://issues.apache.org/jira/browse/HBASE-27671 > Project: HBase > Issue Type: Bug >Affects Versions: 2.5.2 > Environment: ENV- HBase 2.5.2 >Reporter: Ashok shetty >Assignee: Nihal Jain >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4 > > Attachments: Screenshot 2023-03-15 at 8.20.31 PM.png > > > Steps: > precondition : base.master.cleaner.snapshot.interval to 5 min in > hbase-site.xml > 1. create a table t1 , put some data > 2. create a snapshot 'snapt1' with TTL 1 mins > let the TTL expries > 3. disable and drop table t1 > 4. restore snapshot t1 > Actual : restore snapshot successful > Expected : restore operation should fail and throw specified snapshot TTL > expried cant restore > Note : its can consider as improvement point -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (HBASE-27671) Client should not be able to restore/clone a snapshot after it's TTL has expired
[ https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reopened HBASE-27671: -- Backporting to branch-2.4 > Client should not be able to restore/clone a snapshot after it's TTL has > expired > > > Key: HBASE-27671 > URL: https://issues.apache.org/jira/browse/HBASE-27671 > Project: HBase > Issue Type: Bug >Affects Versions: 2.5.2 > Environment: ENV- HBase 2.5.2 >Reporter: Ashok shetty >Assignee: Nihal Jain >Priority: Minor > Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.4 > > Attachments: Screenshot 2023-03-15 at 8.20.31 PM.png > > > Steps: > precondition : base.master.cleaner.snapshot.interval to 5 min in > hbase-site.xml > 1. create a table t1 , put some data > 2. create a snapshot 'snapt1' with TTL 1 mins > let the TTL expries > 3. disable and drop table t1 > 4. restore snapshot t1 > Actual : restore snapshot successful > Expected : restore operation should fail and throw specified snapshot TTL > expried cant restore > Note : its can consider as improvement point -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] virajjasani merged pull request #5118: HBASE-27671 Client should not be able to restore/clone a snapshot aft…
virajjasani merged PR #5118: URL: https://github.com/apache/hbase/pull/5118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-27739) Remove Java reflection used in FSUtils.create()
Wei-Chiu Chuang created HBASE-27739: --- Summary: Remove Java reflection used in FSUtils.create() Key: HBASE-27739 URL: https://issues.apache.org/jira/browse/HBASE-27739 Project: HBase Issue Type: Improvement Reporter: Wei-Chiu Chuang FSUtils.create() uses reflection to access a HDFS API DistributedFileSystem.create() that supports favored node. This API is added in Hadoop 2.1.0-beta (HDFS-2576) so we can use it directly without reflection. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27729) Missed one parameter when logging exception in StoreFileListFile
[
https://issues.apache.org/jira/browse/HBASE-27729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702907#comment-17702907
]
Hudson commented on HBASE-27729:
Results for branch master
[build #800 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Missed one parameter when logging exception in StoreFileListFile
>
>
> Key: HBASE-27729
> URL: https://issues.apache.org/jira/browse/HBASE-27729
> Project: HBase
> Issue Type: Bug
> Components: logging
>Reporter: Duo Zhang
>Assignee: Shilun Fan
>Priority: Major
> Labels: beginner, trivial
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.4
>
>
> At line 265
> {code}
> LOG.debug("Failed to delete old track file {}, ignoring the exception",
> e);
> {code}
> Should add 'trackFiles[nextTrackFile]' before 'e'.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27646) Should not use pread when prefetching in HFilePreadReader
[
https://issues.apache.org/jira/browse/HBASE-27646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702910#comment-17702910
]
Hudson commented on HBASE-27646:
Results for branch master
[build #800 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Should not use pread when prefetching in HFilePreadReader
> -
>
> Key: HBASE-27646
> URL: https://issues.apache.org/jira/browse/HBASE-27646
> Project: HBase
> Issue Type: Improvement
> Components: Performance
>Affects Versions: 2.5.3
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>
>
> While prefetchOnOpen will read althrough the hfile, we should use stream read
> for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27702) Remove 'hbase.regionserver.hlog.writer.impl' config
[
https://issues.apache.org/jira/browse/HBASE-27702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702909#comment-17702909
]
Hudson commented on HBASE-27702:
Results for branch master
[build #800 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove 'hbase.regionserver.hlog.writer.impl' config
> ---
>
> Key: HBASE-27702
> URL: https://issues.apache.org/jira/browse/HBASE-27702
> Project: HBase
> Issue Type: Task
> Components: wal
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> We do not support sequence file based WAL file any more, and we should also
> automatically choose SecureProtobufWALWriter if WAL entryption is enabled.
> This is a follow up issue for HBASE-27632.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27718) The regionStateNode only need remove once in regionOffline
[
https://issues.apache.org/jira/browse/HBASE-27718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702908#comment-17702908
]
Hudson commented on HBASE-27718:
Results for branch master
[build #800 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/800/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> The regionStateNode only need remove once in regionOffline
> --
>
> Key: HBASE-27718
> URL: https://issues.apache.org/jira/browse/HBASE-27718
> Project: HBase
> Issue Type: Bug
> Components: amv2
>Affects Versions: 2.4.14
>Reporter: chaijunjie
>Assignee: chaijunjie
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>
>
> The regionStateNode only need remove once in regionOffline when delete a
> table.
> In
> org.apache.hadoop.hbase.master.assignment.AssignmentManager#deleteTable
>
> why need delete twice? i think one is enougth
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (HBASE-27738) Remove DNS reflection helper method
Wei-Chiu Chuang created HBASE-27738: --- Summary: Remove DNS reflection helper method Key: HBASE-27738 URL: https://issues.apache.org/jira/browse/HBASE-27738 Project: HBase Issue Type: Improvement Reporter: Wei-Chiu Chuang HBASE-14594 used a reflection helper method to use an Hadoop API added in 2.8.0. We should remove this reflection from the master branch now. https://github.com/apache/hbase/blob/fbe3b90e0c4eef1dc13fb2a5ed9381106ca671dd/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java#L57 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27702) Remove 'hbase.regionserver.hlog.writer.impl' config
[
https://issues.apache.org/jira/browse/HBASE-27702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702880#comment-17702880
]
Hudson commented on HBASE-27702:
Results for branch branch-2
[build #773 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/773/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/773/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/773/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/773/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/773/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove 'hbase.regionserver.hlog.writer.impl' config
> ---
>
> Key: HBASE-27702
> URL: https://issues.apache.org/jira/browse/HBASE-27702
> Project: HBase
> Issue Type: Task
> Components: wal
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> We do not support sequence file based WAL file any more, and we should also
> automatically choose SecureProtobufWALWriter if WAL entryption is enabled.
> This is a follow up issue for HBASE-27632.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27718) The regionStateNode only need remove once in regionOffline
[
https://issues.apache.org/jira/browse/HBASE-27718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702864#comment-17702864
]
Hudson commented on HBASE-27718:
Results for branch branch-2.5
[build #321 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/321/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/321/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/321/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/321/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/321/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> The regionStateNode only need remove once in regionOffline
> --
>
> Key: HBASE-27718
> URL: https://issues.apache.org/jira/browse/HBASE-27718
> Project: HBase
> Issue Type: Bug
> Components: amv2
>Affects Versions: 2.4.14
>Reporter: chaijunjie
>Assignee: chaijunjie
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>
>
> The regionStateNode only need remove once in regionOffline when delete a
> table.
> In
> org.apache.hadoop.hbase.master.assignment.AssignmentManager#deleteTable
>
> why need delete twice? i think one is enougth
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27729) Missed one parameter when logging exception in StoreFileListFile
[
https://issues.apache.org/jira/browse/HBASE-27729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702863#comment-17702863
]
Hudson commented on HBASE-27729:
Results for branch branch-2.5
[build #321 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/321/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/321/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/321/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/321/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/321/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Missed one parameter when logging exception in StoreFileListFile
>
>
> Key: HBASE-27729
> URL: https://issues.apache.org/jira/browse/HBASE-27729
> Project: HBase
> Issue Type: Bug
> Components: logging
>Reporter: Duo Zhang
>Assignee: Shilun Fan
>Priority: Major
> Labels: beginner, trivial
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.4
>
>
> At line 265
> {code}
> LOG.debug("Failed to delete old track file {}, ignoring the exception",
> e);
> {code}
> Should add 'trackFiles[nextTrackFile]' before 'e'.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5125: HBASE-27736 HFileSystem.getLocalFs is not used
Apache-HBase commented on PR #5125: URL: https://github.com/apache/hbase/pull/5125#issuecomment-1476630471 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 17s | master passed | | +1 :green_heart: | compile | 0m 54s | master passed | | +1 :green_heart: | shadedjars | 4m 56s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 1s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 5m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 245m 45s | hbase-server in the patch passed. | | | | 273m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5125/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5125 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 403d6cf1272a 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0110bf3a6e | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5125/1/testReport/ | | Max. process+thread count | 2384 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5125/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5121: HBASE-27733
Apache-HBase commented on PR #5121: URL: https://github.com/apache/hbase/pull/5121#issuecomment-1476616999 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 13s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 6m 13s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 4s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 6m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 324m 49s | hbase-server in the patch failed. | | | | 355m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5121/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5121 | | JIRA Issue | HBASE-27733 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6addf7f36576 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0110bf3a6e | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5121/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5121/2/testReport/ | | Max. process+thread count | 2301 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5121/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-27109) Move replication queue storage from zookeeper to a separated HBase table
[
https://issues.apache.org/jira/browse/HBASE-27109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702853#comment-17702853
]
Hudson commented on HBASE-27109:
Results for branch HBASE-27109/table_based_rqs
[build #56 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/56/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/56/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/56/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-27109%252Ftable_based_rqs/56/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move replication queue storage from zookeeper to a separated HBase table
>
>
> Key: HBASE-27109
> URL: https://issues.apache.org/jira/browse/HBASE-27109
> Project: HBase
> Issue Type: New Feature
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a more specific issue based on the works which are already done in
> HBASE-15867.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5125: HBASE-27736 HFileSystem.getLocalFs is not used
Apache-HBase commented on PR #5125: URL: https://github.com/apache/hbase/pull/5125#issuecomment-1476579774 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 58s | master passed | | +1 :green_heart: | compile | 0m 46s | master passed | | +1 :green_heart: | shadedjars | 5m 21s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 30s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 25s | the patch passed | | +1 :green_heart: | compile | 0m 54s | the patch passed | | +1 :green_heart: | javac | 0m 54s | the patch passed | | +1 :green_heart: | shadedjars | 5m 21s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 213m 38s | hbase-server in the patch passed. | | | | 240m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5125/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5125 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1a775475bc98 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0110bf3a6e | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5125/1/testReport/ | | Max. process+thread count | 2670 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5125/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5129: HBASE-27737 Add supplemental model for com.aayushatharva.brotli4j:native-osx-aarch64
Apache-HBase commented on PR #5129: URL: https://github.com/apache/hbase/pull/5129#issuecomment-1476564558 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | spotless | 0m 38s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 10m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5129/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5129 | | Optional Tests | dupname asflicense javac spotless xml | | uname | Linux 87d7b50f2cf3 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 814f3267d7 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 84 (vs. ulimit of 3) | | modules | C: hbase-resource-bundle U: hbase-resource-bundle | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5129/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5129: HBASE-27737 Add supplemental model for com.aayushatharva.brotli4j:native-osx-aarch64
Apache-HBase commented on PR #5129: URL: https://github.com/apache/hbase/pull/5129#issuecomment-1476561970 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | javadoc | 0m 10s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | javadoc | 0m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 8s | hbase-resource-bundle in the patch passed. | | | | 8m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5129/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5129 | | Optional Tests | javac javadoc unit | | uname | Linux 9b5f9e01a8f4 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 814f3267d7 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5129/1/testReport/ | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-resource-bundle U: hbase-resource-bundle | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5129/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5129: HBASE-27737 Add supplemental model for com.aayushatharva.brotli4j:native-osx-aarch64
Apache-HBase commented on PR #5129: URL: https://github.com/apache/hbase/pull/5129#issuecomment-1476560506 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 3s | master passed | | +1 :green_heart: | javadoc | 0m 12s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 47s | the patch passed | | +1 :green_heart: | javadoc | 0m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 9s | hbase-resource-bundle in the patch passed. | | | | 8m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5129/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5129 | | Optional Tests | javac javadoc unit | | uname | Linux b096a1772a5e 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 814f3267d7 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5129/1/testReport/ | | Max. process+thread count | 71 (vs. ulimit of 3) | | modules | C: hbase-resource-bundle U: hbase-resource-bundle | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5129/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27737) Add supplemental model for com.aayushatharva.brotli4j:native-osx-aarch64
[ https://issues.apache.org/jira/browse/HBASE-27737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27737: - Affects Version/s: 2.5.0 2.6.0 3.0.0-alpha-4 > Add supplemental model for com.aayushatharva.brotli4j:native-osx-aarch64 > > > Key: HBASE-27737 > URL: https://issues.apache.org/jira/browse/HBASE-27737 > Project: HBase > Issue Type: Task > Components: build, community >Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-4 >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > > License aggregation fails on Apple Silicon because we're missing the > supplemental model entry for this architecture's brotli4j implementation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27737) Add supplemental model for com.aayushatharva.brotli4j:native-osx-aarch64
[
https://issues.apache.org/jira/browse/HBASE-27737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702837#comment-17702837
]
Nick Dimiduk commented on HBASE-27737:
--
{noformat}
--
This product includes AOP alliance licensed under the Public Domain.
LICENCE: all the source code provided by AOP Alliance is Public Domain.
--
This product includes native-osx-aarch64 licensed under the Apache License 2.0.
ERROR: Please check this License for acceptability here:
https://www.apache.org/legal/resolved
If it is okay, then update the list named 'non_aggregate_fine' in the
LICENSE.vm file.
If it isn't okay, then revert the change that added the dependency.
More info on the dependency:
com.aayushatharva.brotli4j
native-osx-aarch64
1.8.0
maven central search
g:com.aayushatharva.brotli4j AND a:native-osx-aarch64 AND v:1.8.0
[jira] [Created] (HBASE-27737) Add supplemental model for com.aayushatharva.brotli4j:native-osx-aarch64
Nick Dimiduk created HBASE-27737: Summary: Add supplemental model for com.aayushatharva.brotli4j:native-osx-aarch64 Key: HBASE-27737 URL: https://issues.apache.org/jira/browse/HBASE-27737 Project: HBase Issue Type: Task Components: build, community Reporter: Nick Dimiduk Assignee: Nick Dimiduk License aggregation fails on Apple Silicon because we're missing the supplemental model entry for this architecture's brotli4j implementation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5121: HBASE-27733
Apache-HBase commented on PR #5121: URL: https://github.com/apache/hbase/pull/5121#issuecomment-1476458431 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 25s | master passed | | +1 :green_heart: | compile | 0m 50s | master passed | | +1 :green_heart: | shadedjars | 5m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 9s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 5m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 236m 51s | hbase-server in the patch failed. | | | | 263m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5121/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5121 | | JIRA Issue | HBASE-27733 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e3661cb54369 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0110bf3a6e | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5121/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5121/2/testReport/ | | Max. process+thread count | 2737 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5121/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5119: HBASE-27732 NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOl…
Apache-HBase commented on PR #5119: URL: https://github.com/apache/hbase/pull/5119#issuecomment-1476444966 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 1s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 6m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 31s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 40s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | shadedjars | 6m 11s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 291m 48s | hbase-server in the patch failed. | | | | 323m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5119/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5119 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 85fd9e937ac7 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 201846b726 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5119/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5119/2/testReport/ | | Max. process+thread count | 2360 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5119/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27735) Skip hbase:meta table scan if the normalizer not enabled for any of the tables as well as default table wise normalization disabled
[
https://issues.apache.org/jira/browse/HBASE-27735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajeshbabu Chintaguntla updated HBASE-27735:
Summary: Skip hbase:meta table scan if the normalizer not enabled for any
of the tables as well as default table wise normalization disabled (was:
Considering Normalizer on in case of zk data is null leading to unnecessary
meta table scans )
> Skip hbase:meta table scan if the normalizer not enabled for any of the
> tables as well as default table wise normalization disabled
> ---
>
> Key: HBASE-27735
> URL: https://issues.apache.org/jira/browse/HBASE-27735
> Project: HBase
> Issue Type: Improvement
> Components: Normalizer
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
>
> Currently when the zk data is null considering normaliser on which leads to
> unnecessary hbase meta scans. Would be better to scan through meta only when
> normalizer enabled explictly.
> {noformat}
> public boolean isNormalizerOn() {
> byte[] upData = super.getData(false);
> try {
> // if data in ZK is null, use default of on.
> return upData == null || parseFrom(upData).getNormalizerOn();
> } catch (DeserializationException dex) {
> LOG
> .error("ZK state for RegionNormalizer could not be parsed " +
> Bytes.toStringBinary(upData));
> // return false to be safe.
> return false;
> }
> }
> {noformat}
> {noformat}
> public boolean normalizeRegions(final NormalizeTableFilterParams ntfp,
> final boolean isHighPriority) throws IOException {
> if (regionNormalizerManager == null ||
> !regionNormalizerManager.isNormalizerOn()) {
> LOG.debug("Region normalization is disabled, don't run region
> normalizer.");
> return false;
> }
> if (skipRegionManagementAction("region normalizer")) {
> return false;
> }
> if (assignmentManager.hasRegionsInTransition()) {
> return false;
> }
> final Set matchingTables = getTableDescriptors(new
> LinkedList<>(),
> ntfp.getNamespace(), ntfp.getRegex(), ntfp.getTableNames(),
> false).stream()
> .map(TableDescriptor::getTableName).collect(Collectors.toSet());
> final Set allEnabledTables =
> tableStateManager.getTablesInStates(TableState.State.ENABLED);
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27651) hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
[
https://issues.apache.org/jira/browse/HBASE-27651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-27651:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the reviews.
> hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
>
>
> Key: HBASE-27651
> URL: https://issues.apache.org/jira/browse/HBASE-27651
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>
>
> Running HBase in a container environment, launched using
> {{{}bin/hbase-daemon.sh foreground_start ...{}}}. Signaling the container for
> config refresh or for graceful termination doesn't make it through to the JVM
> process. Rather, the {{trap}} function is unconditionally sending {{{}kill
> -9{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27651) hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
[
https://issues.apache.org/jira/browse/HBASE-27651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-27651:
-
Fix Version/s: 2.4.17
> hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
>
>
> Key: HBASE-27651
> URL: https://issues.apache.org/jira/browse/HBASE-27651
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>
>
> Running HBase in a container environment, launched using
> {{{}bin/hbase-daemon.sh foreground_start ...{}}}. Signaling the container for
> config refresh or for graceful termination doesn't make it through to the JVM
> process. Rather, the {{trap}} function is unconditionally sending {{{}kill
> -9{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27651) hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
[
https://issues.apache.org/jira/browse/HBASE-27651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-27651:
-
Fix Version/s: 2.5.4
> hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
>
>
> Key: HBASE-27651
> URL: https://issues.apache.org/jira/browse/HBASE-27651
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.4
>
>
> Running HBase in a container environment, launched using
> {{{}bin/hbase-daemon.sh foreground_start ...{}}}. Signaling the container for
> config refresh or for graceful termination doesn't make it through to the JVM
> process. Rather, the {{trap}} function is unconditionally sending {{{}kill
> -9{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] ndimiduk merged pull request #5128: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2.4
ndimiduk merged PR #5128: URL: https://github.com/apache/hbase/pull/5128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #5127: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2.5
ndimiduk merged PR #5127: URL: https://github.com/apache/hbase/pull/5127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27651) hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
[
https://issues.apache.org/jira/browse/HBASE-27651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-27651:
-
Fix Version/s: 2.6.0
> hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
>
>
> Key: HBASE-27651
> URL: https://issues.apache.org/jira/browse/HBASE-27651
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> Running HBase in a container environment, launched using
> {{{}bin/hbase-daemon.sh foreground_start ...{}}}. Signaling the container for
> config refresh or for graceful termination doesn't make it through to the JVM
> process. Rather, the {{trap}} function is unconditionally sending {{{}kill
> -9{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] ndimiduk merged pull request #5126: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2
ndimiduk merged PR #5126: URL: https://github.com/apache/hbase/pull/5126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5126: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2
Apache-HBase commented on PR #5126: URL: https://github.com/apache/hbase/pull/5126#issuecomment-1476313721 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | spotless | 0m 53s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | shellcheck | 0m 0s | The patch generated 0 new + 126 unchanged - 12 fixed = 126 total (was 138) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 37s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 4m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5126/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5126 | | Optional Tests | dupname asflicense spotless shellcheck shelldocs | | uname | Linux 69f9c24f65e9 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 873f8987f1 | | Max. process+thread count | 45 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5126/1/console | | versions | git=2.34.1 maven=3.8.6 shellcheck=0.8.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5126: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2
Apache-HBase commented on PR #5126: URL: https://github.com/apache/hbase/pull/5126#issuecomment-1476313485 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5126/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5126 | | Optional Tests | | | uname | Linux 98371ab557ac 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 873f8987f1 | | Max. process+thread count | 38 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5126/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5127: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2.5
Apache-HBase commented on PR #5127: URL: https://github.com/apache/hbase/pull/5127#issuecomment-1476313387 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.5 Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 3m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5127/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5127 | | Optional Tests | | | uname | Linux c5e586c4b74e 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 0bc7f56a00 | | Max. process+thread count | 33 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5127/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5119: HBASE-27732 NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOl…
Apache-HBase commented on PR #5119: URL: https://github.com/apache/hbase/pull/5119#issuecomment-1476312700 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | -1 :x: | mvninstall | 3m 20s | root in master failed. | | +1 :green_heart: | compile | 0m 55s | master passed | | +1 :green_heart: | shadedjars | 5m 14s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 12s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 48s | the patch passed | | +1 :green_heart: | shadedjars | 4m 45s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 20s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 225m 49s | hbase-server in the patch failed. | | | | 249m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5119/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5119 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5ec3f9edcce4 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 201846b726 | | Default Java | Temurin-1.8.0_352-b08 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5119/2/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5119/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5119/2/testReport/ | | Max. process+thread count | 2505 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5119/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5128: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2.4
Apache-HBase commented on PR #5128: URL: https://github.com/apache/hbase/pull/5128#issuecomment-1476312269 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.4 Compile Tests _ | | +1 :green_heart: | spotless | 0m 43s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | shellcheck | 0m 1s | The patch generated 0 new + 126 unchanged - 12 fixed = 126 total (was 138) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 33s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 3m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5128/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5128 | | Optional Tests | dupname asflicense spotless shellcheck shelldocs | | uname | Linux ab7daa5d6dad 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / fde0f4b5ee | | Max. process+thread count | 45 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5128/1/console | | versions | git=2.34.1 maven=3.8.6 shellcheck=0.8.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5127: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2.5
Apache-HBase commented on PR #5127: URL: https://github.com/apache/hbase/pull/5127#issuecomment-1476311969 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.5 Compile Tests _ | | +1 :green_heart: | spotless | 0m 46s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | shellcheck | 0m 1s | The patch generated 0 new + 126 unchanged - 12 fixed = 126 total (was 138) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 3m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5127/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5127 | | Optional Tests | dupname asflicense spotless shellcheck shelldocs | | uname | Linux b887b387bb6d 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 0bc7f56a00 | | Max. process+thread count | 43 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5127/1/console | | versions | git=2.34.1 maven=3.8.6 shellcheck=0.8.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5128: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2.4
Apache-HBase commented on PR #5128: URL: https://github.com/apache/hbase/pull/5128#issuecomment-1476311452 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.4 Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5128/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5128 | | Optional Tests | | | uname | Linux caa6a0ae2423 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / fde0f4b5ee | | Max. process+thread count | 40 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5128/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5127: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2.5
Apache-HBase commented on PR #5127: URL: https://github.com/apache/hbase/pull/5127#issuecomment-1476310852 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.5 Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5127/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5127 | | Optional Tests | | | uname | Linux be07bf4db0db 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 0bc7f56a00 | | Max. process+thread count | 41 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5127/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5126: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2
Apache-HBase commented on PR #5126: URL: https://github.com/apache/hbase/pull/5126#issuecomment-1476310963 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5126/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5126 | | Optional Tests | | | uname | Linux 8445614c4e9e 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 873f8987f1 | | Max. process+thread count | 29 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5126/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5128: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2.4
Apache-HBase commented on PR #5128: URL: https://github.com/apache/hbase/pull/5128#issuecomment-1476309320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.4 Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5128/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5128 | | Optional Tests | | | uname | Linux dc888140b013 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / fde0f4b5ee | | Max. process+thread count | 29 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5128/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk opened a new pull request, #5128: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2.4
ndimiduk opened a new pull request, #5128: URL: https://github.com/apache/hbase/pull/5128 Introduce separate `trap`s for SIGHUP vs. the rest. Treat `SIGINT`, `SIGKILL`, and `EXIT` identically, as before. Use the signal name without `SIG` prefix for increased portability, as per the POSIX man page for `trap`. `SIGTERM` handler will now honor `HBASE_STOP_TIMEOUT` as described in the file header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk opened a new pull request, #5127: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2.5
ndimiduk opened a new pull request, #5127: URL: https://github.com/apache/hbase/pull/5127 Introduce separate `trap`s for SIGHUP vs. the rest. Treat `SIGINT`, `SIGKILL`, and `EXIT` identically, as before. Use the signal name without `SIG` prefix for increased portability, as per the POSIX man page for `trap`. `SIGTERM` handler will now honor `HBASE_STOP_TIMEOUT` as described in the file header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk opened a new pull request, #5126: Backport "HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM" to branch-2
ndimiduk opened a new pull request, #5126: URL: https://github.com/apache/hbase/pull/5126 Introduce separate `trap`s for SIGHUP vs. the rest. Treat `SIGINT`, `SIGKILL`, and `EXIT` identically, as before. Use the signal name without `SIG` prefix for increased portability, as per the POSIX man page for `trap`. `SIGTERM` handler will now honor `HBASE_STOP_TIMEOUT` as described in the file header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27651) hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
[
https://issues.apache.org/jira/browse/HBASE-27651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-27651:
-
Fix Version/s: 3.0.0-alpha-4
> hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
>
>
> Key: HBASE-27651
> URL: https://issues.apache.org/jira/browse/HBASE-27651
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0-alpha-4
>
>
> Running HBase in a container environment, launched using
> {{{}bin/hbase-daemon.sh foreground_start ...{}}}. Signaling the container for
> config refresh or for graceful termination doesn't make it through to the JVM
> process. Rather, the {{trap}} function is unconditionally sending {{{}kill
> -9{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] ndimiduk merged pull request #5035: HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
ndimiduk merged PR #5035: URL: https://github.com/apache/hbase/pull/5035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27736) HFileSystem.getLocalFs is not used
[ https://issues.apache.org/jira/browse/HBASE-27736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27736: -- Summary: HFileSystem.getLocalFs is not used (was: HFileSystem.getLocalFs is not used in code base) > HFileSystem.getLocalFs is not used > -- > > Key: HBASE-27736 > URL: https://issues.apache.org/jira/browse/HBASE-27736 > Project: HBase > Issue Type: Wish > Components: HFile >Affects Versions: 2.4.15, 2.5.3 >Reporter: xy >Assignee: xy >Priority: Major > > HFileSystem::getLocalFs not be used by any method in source code，so make a > hotfix by removing it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27736) HFileSystem.getLocalFs is not used in code base
[ https://issues.apache.org/jira/browse/HBASE-27736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27736: -- Summary: HFileSystem.getLocalFs is not used in code base (was: HFileSystem::getLocalFs hotfix) > HFileSystem.getLocalFs is not used in code base > --- > > Key: HBASE-27736 > URL: https://issues.apache.org/jira/browse/HBASE-27736 > Project: HBase > Issue Type: Wish > Components: HFile >Affects Versions: 2.4.15, 2.5.3 >Reporter: xy >Assignee: xy >Priority: Major > > HFileSystem::getLocalFs not be used by any method in source code，so make a > hotfix by removing it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27651) hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
[
https://issues.apache.org/jira/browse/HBASE-27651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-27651:
-
Release Note:
Introduce separate `trap`s for SIGHUP vs. the rest. Treat `SIGINT`, `SIGKILL`,
and `EXIT` identically, as before. Use the signal name without `SIG` prefix for
increased portability, as per the POSIX man page for `trap`.
`SIGTERM` handler will now honor `HBASE_STOP_TIMEOUT` as described in the file
header.
> hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
>
>
> Key: HBASE-27651
> URL: https://issues.apache.org/jira/browse/HBASE-27651
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.4
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
>
> Running HBase in a container environment, launched using
> {{{}bin/hbase-daemon.sh foreground_start ...{}}}. Signaling the container for
> config refresh or for graceful termination doesn't make it through to the JVM
> process. Rather, the {{trap}} function is unconditionally sending {{{}kill
> -9{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (HBASE-27736) HFileSystem::getLocalFs hotfix
[ https://issues.apache.org/jira/browse/HBASE-27736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27736: - Assignee: xy > HFileSystem::getLocalFs hotfix > -- > > Key: HBASE-27736 > URL: https://issues.apache.org/jira/browse/HBASE-27736 > Project: HBase > Issue Type: Wish > Components: HFile >Affects Versions: 2.4.15, 2.5.3 >Reporter: xy >Assignee: xy >Priority: Major > > HFileSystem::getLocalFs not be used by any method in source code，so make a > hotfix by removing it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-27736) HFileSystem::getLocalFs hotfix
[ https://issues.apache.org/jira/browse/HBASE-27736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27736: -- Fix Version/s: (was: hbase-7290) > HFileSystem::getLocalFs hotfix > -- > > Key: HBASE-27736 > URL: https://issues.apache.org/jira/browse/HBASE-27736 > Project: HBase > Issue Type: Wish > Components: HFile >Affects Versions: 2.4.15, 2.5.3 >Reporter: xy >Priority: Major > > HFileSystem::getLocalFs not be used by any method in source code，so make a > hotfix by removing it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5125: HBASE-27736
Apache-HBase commented on PR #5125: URL: https://github.com/apache/hbase/pull/5125#issuecomment-1476248873 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 41s | master passed | | +1 :green_heart: | compile | 2m 53s | master passed | | +1 :green_heart: | checkstyle | 0m 37s | master passed | | +1 :green_heart: | spotless | 0m 50s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 49s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 1s | the patch passed | | +1 :green_heart: | compile | 2m 50s | the patch passed | | +1 :green_heart: | javac | 2m 50s | the patch passed | | +1 :green_heart: | checkstyle | 0m 37s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 20m 33s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | +1 :green_heart: | spotless | 0m 53s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 55m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5125/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5125 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux fe4152db4650 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0110bf3a6e | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 81 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5125/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #5035: HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
ndimiduk commented on PR #5035: URL: https://github.com/apache/hbase/pull/5035#issuecomment-1476219459 The new code will also honor the documented timeout between sending SIGTERM and SIGKILL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #5035: HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM
ndimiduk commented on PR #5035: URL: https://github.com/apache/hbase/pull/5035#issuecomment-1476218005 > So in the old code we will always use `kill -9` when receiving any signals, and the PR here will handle SIGHUP differently? Correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-27735) Considering Normalizer on in case of zk data is null leading to unnecessary meta table scans
[
https://issues.apache.org/jira/browse/HBASE-27735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajeshbabu Chintaguntla updated HBASE-27735:
Issue Type: Improvement (was: Bug)
> Considering Normalizer on in case of zk data is null leading to unnecessary
> meta table scans
> -
>
> Key: HBASE-27735
> URL: https://issues.apache.org/jira/browse/HBASE-27735
> Project: HBase
> Issue Type: Improvement
> Components: Normalizer
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
>
> Currently when the zk data is null considering normaliser on which leads to
> unnecessary hbase meta scans. Would be better to scan through meta only when
> normalizer enabled explictly.
> {noformat}
> public boolean isNormalizerOn() {
> byte[] upData = super.getData(false);
> try {
> // if data in ZK is null, use default of on.
> return upData == null || parseFrom(upData).getNormalizerOn();
> } catch (DeserializationException dex) {
> LOG
> .error("ZK state for RegionNormalizer could not be parsed " +
> Bytes.toStringBinary(upData));
> // return false to be safe.
> return false;
> }
> }
> {noformat}
> {noformat}
> public boolean normalizeRegions(final NormalizeTableFilterParams ntfp,
> final boolean isHighPriority) throws IOException {
> if (regionNormalizerManager == null ||
> !regionNormalizerManager.isNormalizerOn()) {
> LOG.debug("Region normalization is disabled, don't run region
> normalizer.");
> return false;
> }
> if (skipRegionManagementAction("region normalizer")) {
> return false;
> }
> if (assignmentManager.hasRegionsInTransition()) {
> return false;
> }
> final Set matchingTables = getTableDescriptors(new
> LinkedList<>(),
> ntfp.getNamespace(), ntfp.getRegex(), ntfp.getTableNames(),
> false).stream()
> .map(TableDescriptor::getTableName).collect(Collectors.toSet());
> final Set allEnabledTables =
> tableStateManager.getTablesInStates(TableState.State.ENABLED);
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async
Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1476195432 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 45s | master passed | | +1 :green_heart: | compile | 0m 17s | master passed | | +1 :green_heart: | shadedjars | 5m 16s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 14s | the patch passed | | +1 :green_heart: | compile | 0m 21s | the patch passed | | +1 :green_heart: | javac | 0m 21s | the patch passed | | -1 :x: | shadedjars | 4m 35s | patch has 10 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 15m 19s | hbase-mapreduce in the patch passed. | | | | 37m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5051 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ba08d4469c7e 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0110bf3a6e | | Default Java | Eclipse Adoptium-11.0.17+8 | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/testReport/ | | Max. process+thread count | 2759 (vs. ulimit of 3) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async
Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1476192956 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 34s | master passed | | +1 :green_heart: | compile | 0m 18s | master passed | | +1 :green_heart: | shadedjars | 4m 54s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 12s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | +1 :green_heart: | compile | 0m 18s | the patch passed | | +1 :green_heart: | javac | 0m 18s | the patch passed | | -1 :x: | shadedjars | 4m 5s | patch has 10 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 15m 33s | hbase-mapreduce in the patch passed. | | | | 35m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5051 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 1a09fa0205e5 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0110bf3a6e | | Default Java | Temurin-1.8.0_352-b08 | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/testReport/ | | Max. process+thread count | 3043 (vs. ulimit of 3) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async
Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1476186481 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 23s | master passed | | +1 :green_heart: | compile | 0m 31s | master passed | | +1 :green_heart: | checkstyle | 0m 13s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 0m 31s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 18s | the patch passed | | +1 :green_heart: | compile | 0m 30s | the patch passed | | -0 :warning: | javac | 0m 30s | hbase-mapreduce generated 1 new + 197 unchanged - 0 fixed = 198 total (was 197) | | -0 :warning: | checkstyle | 0m 11s | hbase-mapreduce: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 9s | Patch does not cause any errors with Hadoop 3.2.4 3.3.4. | | -1 :x: | spotless | 0m 48s | patch has 32 errors when running spotless:check, run spotless:apply to fix. | | +1 :green_heart: | spotbugs | 0m 49s | the patch passed | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 7s | The patch generated 1 ASF License warnings. | | | | 31m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5051 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 3b795f2637c8 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0110bf3a6e | | Default Java | Eclipse Adoptium-11.0.17+8 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/artifact/yetus-general-check/output/patch-spotless.txt | | asflicense | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 85 (vs. ulimit of 3) | | modules | C: hbase-mapreduce U: hbase-mapreduce | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5051/7/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-27736) HFileSystem::getLocalFs hotfix
xy created HBASE-27736: -- Summary: HFileSystem::getLocalFs hotfix Key: HBASE-27736 URL: https://issues.apache.org/jira/browse/HBASE-27736 Project: HBase Issue Type: Wish Components: HFile Affects Versions: 2.5.3, 2.4.15 Reporter: xy Fix For: hbase-7290 HFileSystem::getLocalFs not be used by any method in source code，so make a hotfix by removing it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [hbase] xuzifu666 commented on pull request #5125: [HotFix] HFileSystem::getLocalFs hotfix
xuzifu666 commented on PR #5125: URL: https://github.com/apache/hbase/pull/5125#issuecomment-1476158204 @Apache9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] xuzifu666 opened a new pull request, #5125: [HotFix] HFileSystem::getLocalFs hotfix
xuzifu666 opened a new pull request, #5125: URL: https://github.com/apache/hbase/pull/5125 HFileSystem::getLocalFs useless，and can be remove -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-27735) Considering Normalizer on in case of zk data is null leading to unnecessary meta table scans
Rajeshbabu Chintaguntla created HBASE-27735:
---
Summary: Considering Normalizer on in case of zk data is null
leading to unnecessary meta table scans
Key: HBASE-27735
URL: https://issues.apache.org/jira/browse/HBASE-27735
Project: HBase
Issue Type: Bug
Components: Normalizer
Reporter: Rajeshbabu Chintaguntla
Assignee: Rajeshbabu Chintaguntla
Currently when the zk data is null considering normaliser on which leads to
unnecessary hbase meta scans. Would be better to scan through meta only when
normalizer enabled explictly.
{noformat}
public boolean isNormalizerOn() {
byte[] upData = super.getData(false);
try {
// if data in ZK is null, use default of on.
return upData == null || parseFrom(upData).getNormalizerOn();
} catch (DeserializationException dex) {
LOG
.error("ZK state for RegionNormalizer could not be parsed " +
Bytes.toStringBinary(upData));
// return false to be safe.
return false;
}
}
{noformat}
{noformat}
public boolean normalizeRegions(final NormalizeTableFilterParams ntfp,
final boolean isHighPriority) throws IOException {
if (regionNormalizerManager == null ||
!regionNormalizerManager.isNormalizerOn()) {
LOG.debug("Region normalization is disabled, don't run region
normalizer.");
return false;
}
if (skipRegionManagementAction("region normalizer")) {
return false;
}
if (assignmentManager.hasRegionsInTransition()) {
return false;
}
final Set matchingTables = getTableDescriptors(new
LinkedList<>(),
ntfp.getNamespace(), ntfp.getRegex(), ntfp.getTableNames(),
false).stream()
.map(TableDescriptor::getTableName).collect(Collectors.toSet());
final Set allEnabledTables =
tableStateManager.getTablesInStates(TableState.State.ENABLED);
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27734) [JDK17] Backport to branch-2.4 HBASE-25058 HBase-27510
[
https://issues.apache.org/jira/browse/HBASE-27734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Moran updated HBASE-27734:
--
Description:
I use jdk17 on branch-2.4，encountered some WARN like:
{code:java}
WARN FilenoUtil : Native subprocess control requires open access to the JDK IO
subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens
java.base/java.io=ALL-UNNAMED' to enable.{code}
Backport HBASE-25058 and HBASE-27510 PR can resolve the warn problem.
was:
I use jdk17 on branch-2.4，encountered some WARN like:
{code:java}
WARN FilenoUtil : Native subprocess control requires open access to the JDK IO
subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens
java.base/java.io=ALL-UNNAMED' to enable.{code}
Backport HBASE-25058 and HBase-27510 PR can resolve the warn problem.
> [JDK17] Backport to branch-2.4 HBASE-25058 HBase-27510
> --
>
> Key: HBASE-27734
> URL: https://issues.apache.org/jira/browse/HBASE-27734
> Project: HBase
> Issue Type: Improvement
>Reporter: Moran
>Priority: Minor
>
> I use jdk17 on branch-2.4，encountered some WARN like:
> {code:java}
> WARN FilenoUtil : Native subprocess control requires open access to the JDK
> IO subsystem
> Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens
> java.base/java.io=ALL-UNNAMED' to enable.{code}
> Backport HBASE-25058 and HBASE-27510 PR can resolve the warn problem.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27734) [JDK17] Backport to branch-2.4 HBASE-25058 HBase-27510
[
https://issues.apache.org/jira/browse/HBASE-27734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Moran updated HBASE-27734:
--
Description:
I use jdk17 on branch-2.4，encountered some WARN like:
{code:java}
WARN FilenoUtil : Native subprocess control requires open access to the JDK IO
subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens
java.base/java.io=ALL-UNNAMED' to enable.{code}
Backport HBASE-25058 and HBase-27510 PR can resolve the warn problem.
was:
I use jdk17 on branch-2.4，encountered some WARN like:
{code:java}
WARN FilenoUtil : Native subprocess control requires open access to the JDK IO
subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens
java.base/java.io=ALL-UNNAMED' to enable.{code}
> [JDK17] Backport to branch-2.4 HBASE-25058 HBase-27510
> --
>
> Key: HBASE-27734
> URL: https://issues.apache.org/jira/browse/HBASE-27734
> Project: HBase
> Issue Type: Improvement
>Reporter: Moran
>Priority: Minor
>
> I use jdk17 on branch-2.4，encountered some WARN like:
> {code:java}
> WARN FilenoUtil : Native subprocess control requires open access to the JDK
> IO subsystem
> Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens
> java.base/java.io=ALL-UNNAMED' to enable.{code}
> Backport HBASE-25058 and HBase-27510 PR can resolve the warn problem.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (HBASE-27734) [JDK17] Backport to branch-2.4 HBASE-25058 HBase-27510
[
https://issues.apache.org/jira/browse/HBASE-27734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Moran updated HBASE-27734:
--
Description:
I use jdk17 on branch-2.4，encountered some WARN like:
{code:java}
WARN FilenoUtil : Native subprocess control requires open access to the JDK IO
subsystem
Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens
java.base/java.io=ALL-UNNAMED' to enable.{code}
> [JDK17] Backport to branch-2.4 HBASE-25058 HBase-27510
> --
>
> Key: HBASE-27734
> URL: https://issues.apache.org/jira/browse/HBASE-27734
> Project: HBase
> Issue Type: Improvement
>Reporter: Moran
>Priority: Minor
>
> I use jdk17 on branch-2.4，encountered some WARN like:
> {code:java}
> WARN FilenoUtil : Native subprocess control requires open access to the JDK
> IO subsystem
> Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens
> java.base/java.io=ALL-UNNAMED' to enable.{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
