[jira] [Commented] (HBASE-5782) Edits can be appended out of seqid order since HBASE-4487

2012-04-17 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256200#comment-13256200 ] Lars Hofhansl commented on HBASE-5782: -- Yes, we need a test for this. What scared me

[jira] [Commented] (HBASE-5782) Edits can be appended out of seqid order since HBASE-4487

2012-04-17 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256202#comment-13256202 ] Lars Hofhansl commented on HBASE-5782: -- I can work on a test, unless you like to

[jira] [Commented] (HBASE-5545) region can't be opened for a long time. Because the creating File failed.

2012-04-17 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256206#comment-13256206 ] Lars Hofhansl commented on HBASE-5545: -- I see. Yep, that is more likely to happen

[jira] [Commented] (HBASE-5545) region can't be opened for a long time. Because the creating File failed.

2012-04-17 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256210#comment-13256210 ] Lars Hofhansl commented on HBASE-5545: -- 2nd patch looks good. I don't think you

[jira] [Commented] (HBASE-5782) Edits can be appended out of seqid order since HBASE-4487

2012-04-18 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256756#comment-13256756 ] Lars Hofhansl commented on HBASE-5782: -- For some reason I cannot run TestHLog

[jira] [Commented] (HBASE-5545) region can't be opened for a long time. Because the creating File failed.

2012-04-18 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256757#comment-13256757 ] Lars Hofhansl commented on HBASE-5545: -- @Ram: yes that is what I meant to say

[jira] [Commented] (HBASE-5782) Edits can be appended out of seqid order since HBASE-4487

2012-04-18 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256933#comment-13256933 ] Lars Hofhansl commented on HBASE-5782: -- Now note, that TestHLog still does not run

[jira] [Commented] (HBASE-5545) region can't be opened for a long time. Because the creating File failed.

2012-04-18 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256938#comment-13256938 ] Lars Hofhansl commented on HBASE-5545: -- I'm going to commit this 0.94 and 0.96 in the

[jira] [Commented] (HBASE-5782) Edits can be appended out of seqid order since HBASE-4487

2012-04-18 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257105#comment-13257105 ] Lars Hofhansl commented on HBASE-5782: -- Yes. Edits can be appended

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-04-18 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257114#comment-13257114 ] Lars Hofhansl commented on HBASE-5547: -- What I had in mind when I filed this was

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-04-19 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257818#comment-13257818 ] Lars Hofhansl commented on HBASE-5547: -- For this I was actually thinking a single

[jira] [Commented] (HBASE-5635) If getTaskList() returns null splitlogWorker is down. It wont serve any requests.

2012-04-20 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258414#comment-13258414 ] Lars Hofhansl commented on HBASE-5635: -- +1 on patch. I wonder how many more problems

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-26 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114941#comment-13114941 ] Lars Hofhansl commented on HBASE-4488: -- The fact that this has not tripped any test

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-26 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114948#comment-13114948 ] Lars Hofhansl commented on HBASE-4488: -- Also removes two unused variables and an

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-09-26 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114964#comment-13114964 ] Lars Hofhansl commented on HBASE-4335: -- @Stack... Not sure how you can test the

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-09-26 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115071#comment-13115071 ] Lars Hofhansl commented on HBASE-4335: -- @Joe... Understood. :) And you are right

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-09-26 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115075#comment-13115075 ] Lars Hofhansl commented on HBASE-4335: -- Ran all test. There are three failures

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-26 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115220#comment-13115220 ] Lars Hofhansl commented on HBASE-4488: -- Looking at the StoreScanner/ScanQueryMatcher

[jira] [Commented] (HBASE-4496) HFile V2 does not honor setCacheBlocks when scanning.

2011-09-27 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115775#comment-13115775 ] Lars Hofhansl commented on HBASE-4496: -- In a simple test this shaves about 20% of

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-27 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115805#comment-13115805 ] Lars Hofhansl commented on HBASE-4488: -- @Jon, so you gonna commit this? :)

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-27 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115877#comment-13115877 ] Lars Hofhansl commented on HBASE-4488: -- Not yet... :) Store could

[jira] [Commented] (HBASE-3130) [replication] ReplicationSource can't recover from session expired on remote clusters

2011-09-27 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116072#comment-13116072 ] Lars Hofhansl commented on HBASE-3130: -- You sound like you are surprised :)

[jira] [Commented] (HBASE-4496) HFile V2 does not honor setCacheBlocks when scanning.

2011-09-27 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116101#comment-13116101 ] Lars Hofhansl commented on HBASE-4496: -- That sounds like a plan Jon. Let me know if

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-28 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116547#comment-13116547 ] Lars Hofhansl commented on HBASE-4488: -- Looks like HBASE-4433 can potentially trigger

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-28 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116572#comment-13116572 ] Lars Hofhansl commented on HBASE-4488: -- Nothing to worry once this is committed. Just

[jira] [Commented] (HBASE-3130) [replication] ReplicationSource can't recover from session expired on remote clusters

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117718#comment-13117718 ] Lars Hofhansl commented on HBASE-3130: -- +1 [replication]

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117724#comment-13117724 ] Lars Hofhansl commented on HBASE-4335: -- I think when this is fixed we can mark

[jira] [Commented] (HBASE-4501) [replication] Shutting down a stream leaves recovered sources running

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117752#comment-13117752 ] Lars Hofhansl commented on HBASE-4501: -- So is this just a matter of calling terminate

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117759#comment-13117759 ] Lars Hofhansl commented on HBASE-4335: -- I split up SplitTransaction.execute is three

[jira] [Commented] (HBASE-4422) Move block cache parameters and references into single CacheConf class

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117832#comment-13117832 ] Lars Hofhansl commented on HBASE-4422: -- Want me to take your latest patch and fold my

[jira] [Commented] (HBASE-4412) no need to retry scan operation on the same server in the case of RegionServerStoppedException

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117833#comment-13117833 ] Lars Hofhansl commented on HBASE-4412: -- +1 no need to retry scan

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117839#comment-13117839 ] Lars Hofhansl commented on HBASE-4487: -- How does that relate to the logic in

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118222#comment-13118222 ] Lars Hofhansl commented on HBASE-4487: -- @ramkrishna and @dhruba. I agree with

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-09-30 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118237#comment-13118237 ] Lars Hofhansl commented on HBASE-4335: -- Agreed that HBASE-4334 is important. At least

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-09-30 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118290#comment-13118290 ] Lars Hofhansl commented on HBASE-4334: -- I think the best way here is to check the

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-10-01 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118689#comment-13118689 ] Lars Hofhansl commented on HBASE-4334: -- Sigh... I think you're right. Probably a lot

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-10-01 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118691#comment-13118691 ] Lars Hofhansl commented on HBASE-4334: -- Actually it looks like only a single test was

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-10-01 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118918#comment-13118918 ] Lars Hofhansl commented on HBASE-4334: -- In turns out that coprocessor can -

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-10-01 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118942#comment-13118942 ] Lars Hofhansl commented on HBASE-4334: -- Ran all tests. Got this: Tests run: 1021,

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-10-01 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118960#comment-13118960 ] Lars Hofhansl commented on HBASE-4487: -- Is this too risky for 0.92? I guess we have

[jira] [Commented] (HBASE-4496) HFile V2 does not honor setCacheBlocks when scanning.

2011-10-02 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119062#comment-13119062 ] Lars Hofhansl commented on HBASE-4496: -- Tried Mikhail's patch with my test scenario.

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-10-03 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119458#comment-13119458 ] Lars Hofhansl commented on HBASE-4334: -- There's a thread on the mailing about a

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-10-03 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119459#comment-13119459 ] Lars Hofhansl commented on HBASE-4334: -- Wanna commit this Ted?

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-10-03 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119586#comment-13119586 ] Lars Hofhansl commented on HBASE-4334: -- Probably... Maybe let it bake in 0.92/trunk

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-03 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119780#comment-13119780 ] Lars Hofhansl commented on HBASE-4536: -- @Andrew: Agree. There's no point really in

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13119932#comment-13119932 ] Lars Hofhansl commented on HBASE-4536: -- There's a fourth scan type: 4. Memstore flush

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120469#comment-13120469 ] Lars Hofhansl commented on HBASE-4536: -- Turns out that currently it is not at all

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120603#comment-13120603 ] Lars Hofhansl commented on HBASE-4536: -- Re: New config param. Wasn't sure in the

[jira] [Commented] (HBASE-4501) [replication] Shutting down a stream leaves recovered sources running

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120621#comment-13120621 ] Lars Hofhansl commented on HBASE-4501: -- +1 [replication] Shutting

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120654#comment-13120654 ] Lars Hofhansl commented on HBASE-4536: -- @Ted, yep... That's what the parent is :)

[jira] [Commented] (HBASE-4479) TestMasterFailover failure in Hbase-0.92#17

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120665#comment-13120665 ] Lars Hofhansl commented on HBASE-4479: -- +1 looks good to me

[jira] [Commented] (HBASE-4541) [book] book.xml - claritying schema design section on versions

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121103#comment-13121103 ] Lars Hofhansl commented on HBASE-4541: -- Looks good +1. NB: this may change slightly

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121166#comment-13121166 ] Lars Hofhansl commented on HBASE-4536: -- You are right. I have a new version of the

[jira] [Commented] (HBASE-4241) Optimize flushing of the Store cache for max versions and (new) min versions

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121568#comment-13121568 ] Lars Hofhansl commented on HBASE-4241: -- Hi Liyin, just seeing this now. Let me have a

[jira] [Commented] (HBASE-4241) Optimize flushing of the Store cache for max versions and (new) min versions

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121594#comment-13121594 ] Lars Hofhansl commented on HBASE-4241: -- During memstore flush we only want to read

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121734#comment-13121734 ] Lars Hofhansl commented on HBASE-4536: -- Thinking about this a bit more. I think this

[jira] [Commented] (HBASE-4402) Retaining locality after restart broken

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121741#comment-13121741 ] Lars Hofhansl commented on HBASE-4402: -- We just ran into this yesterday in our 0.92

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-06 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121762#comment-13121762 ] Lars Hofhansl commented on HBASE-4536: -- That might be getting hard to understand.

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-06 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122322#comment-13122322 ] Lars Hofhansl commented on HBASE-4536: -- A simple option would be to only allow the

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-10-06 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122482#comment-13122482 ] Lars Hofhansl commented on HBASE-4488: -- I see that Store.compactStore does the same

[jira] [Commented] (HBASE-4333) Client does not check for holes in .META.

2011-10-06 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122496#comment-13122496 ] Lars Hofhansl commented on HBASE-4333: -- I would prefer to have a log message on the

[jira] [Commented] (HBASE-4462) Properly treating SocketTimeoutException

2011-10-06 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122515#comment-13122515 ] Lars Hofhansl commented on HBASE-4462: -- So this problem is fixed in 0.92 it seems. If

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-10-07 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123342#comment-13123342 ] Lars Hofhansl commented on HBASE-4335: -- I like those names. Will do. @Jon. Initially

[jira] [Commented] (HBASE-4333) Client does not check for holes in .META.

2011-10-07 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123360#comment-13123360 ] Lars Hofhansl commented on HBASE-4333: -- The standard ClientScanner will do the right

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-07 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123368#comment-13123368 ] Lars Hofhansl commented on HBASE-4536: -- Yet another option is to take the smallest

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-10-07 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123383#comment-13123383 ] Lars Hofhansl commented on HBASE-4488: -- I'll open another jira and fix all those.

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-10-07 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123384#comment-13123384 ] Lars Hofhansl commented on HBASE-4488: -- created HBASE-4556 Store

[jira] [Commented] (HBASE-4102) atomicAppend: A put that appends to the latest version of a cell; i.e. reads current value then adds the bytes offered by the client to the tail and writes out a new en

2011-10-08 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123572#comment-13123572 ] Lars Hofhansl commented on HBASE-4102: -- I have this working now. But now I realized

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-10 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13124372#comment-13124372 ] Lars Hofhansl commented on HBASE-4536: -- This issue is pretty resistant to all my

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-10 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13124376#comment-13124376 ] Lars Hofhansl commented on HBASE-4536: -- and 3a. Have Store.java keep track of the

[jira] [Commented] (HBASE-4556) Fix all incorrect uses of InternalScanner.next(...)

2011-10-10 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13124387#comment-13124387 ] Lars Hofhansl commented on HBASE-4556: -- Many scanners only return false when there

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-10 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13124665#comment-13124665 ] Lars Hofhansl commented on HBASE-4536: -- That's what I concluded shortly after I

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13124728#comment-13124728 ] Lars Hofhansl commented on HBASE-4335: -- Results : Tests run: 1031, Failures: 0,

[jira] [Commented] (HBASE-4556) Fix all incorrect uses of InternalScanner.next(...)

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13124745#comment-13124745 ] Lars Hofhansl commented on HBASE-4556: -- I think we could use some tests that

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13124768#comment-13124768 ] Lars Hofhansl commented on HBASE-4536: -- You mean set TTL to FOREVER and minVersions

[jira] [Commented] (HBASE-4102) atomicAppend: A put that appends to the latest version of a cell; i.e. reads current value then adds the bytes offered by the client to the tail and writes out a new en

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125134#comment-13125134 ] Lars Hofhansl commented on HBASE-4102: -- All tests pass.

[jira] [Commented] (HBASE-4102) atomicAppend: A put that appends to the latest version of a cell; i.e. reads current value then adds the bytes offered by the client to the tail and writes out a new en

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125374#comment-13125374 ] Lars Hofhansl commented on HBASE-4102: -- Agree with trunk only (otherwise never get

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125399#comment-13125399 ] Lars Hofhansl commented on HBASE-4536: -- I think I'd like to keep the error, to avoid

[jira] [Commented] (HBASE-4556) Fix all incorrect uses of InternalScanner.next(...)

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125475#comment-13125475 ] Lars Hofhansl commented on HBASE-4556: -- Another pattern to use would be: {code}

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125482#comment-13125482 ] Lars Hofhansl commented on HBASE-4536: -- Converted to feature. Allow

[jira] [Commented] (HBASE-4102) atomicAppend: A put that appends to the latest version of a cell; i.e. reads current value then adds the bytes offered by the client to the tail and writes out a new en

2011-10-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126137#comment-13126137 ] Lars Hofhansl commented on HBASE-4102: -- At closer look Append and Put are subtly

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-10-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126185#comment-13126185 ] Lars Hofhansl commented on HBASE-4488: -- Let's do this as part of HBASE-4556.

[jira] [Commented] (HBASE-4102) atomicAppend: A put that appends to the latest version of a cell; i.e. reads current value then adds the bytes offered by the client to the tail and writes out a new en

2011-10-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126203#comment-13126203 ] Lars Hofhansl commented on HBASE-4102: -- Created HBASE-4583 for RWCC discussion.

[jira] [Commented] (HBASE-4556) Fix all incorrect uses of InternalScanner.next(...)

2011-10-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126260#comment-13126260 ] Lars Hofhansl commented on HBASE-4556: -- Running tests... Just to be sure... Will

[jira] [Commented] (HBASE-4556) Fix all incorrect uses of InternalScanner.next(...)

2011-10-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126339#comment-13126339 ] Lars Hofhansl commented on HBASE-4556: -- It turns out most of the test are written in

[jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler and TestOpenRegionHandler.

2011-10-13 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126768#comment-13126768 ] Lars Hofhansl commented on HBASE-4558: -- I don't think the addendum needs to be

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-10-13 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127251#comment-13127251 ] Lars Hofhansl commented on HBASE-4335: -- Ted already pointed that out to me :)

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-15 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128305#comment-13128305 ] Lars Hofhansl commented on HBASE-4536: -- @Ted, I can change the order in which the

[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

2011-10-15 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128348#comment-13128348 ] Lars Hofhansl commented on HBASE-4562: -- Are the attached patches the full story? I

[jira] [Commented] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write read

2011-10-15 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128350#comment-13128350 ] Lars Hofhansl commented on HBASE-4563: -- +1 on patches (pending all tests pass and

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-15 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128355#comment-13128355 ] Lars Hofhansl commented on HBASE-4536: -- Fair enough. Was picking up on Stack's

[jira] [Commented] (HBASE-3443) ICV optimization to look in memstore first and then store files (HBASE-3082) does not work when deletes are in the mix

2011-10-16 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128564#comment-13128564 ] Lars Hofhansl commented on HBASE-3443: -- I agree. I think delete handling is generally

[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

2011-10-16 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128573#comment-13128573 ] Lars Hofhansl commented on HBASE-4562: -- I see... Thanks Ted. When

[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

2011-10-16 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128602#comment-13128602 ] Lars Hofhansl commented on HBASE-4562: -- +1 for latest patches (assuming all tests

[jira] [Commented] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

2011-10-16 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128660#comment-13128660 ] Lars Hofhansl commented on HBASE-4563: -- @Ted... You wanna commit, or should I? I'm

[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

2011-10-16 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128675#comment-13128675 ] Lars Hofhansl commented on HBASE-4562: -- Committing this too. When

[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

2011-10-16 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128678#comment-13128678 ] Lars Hofhansl commented on HBASE-4562: -- 0.90 patch fails to apply. @bluedavy, could

[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

2011-10-17 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13129457#comment-13129457 ] Lars Hofhansl commented on HBASE-4562: -- No problem. Thanks for patch :)

[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte arrays...

2011-10-19 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131086#comment-13131086 ] Lars Hofhansl commented on HBASE-4626: -- Exactly! There are a bunch subclasses of

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-19 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131168#comment-13131168 ] Lars Hofhansl commented on HBASE-4536: -- So we have three +1's now. Ted, Jonathan...

<    4   5   6   7   8   9   10   11   >