[jira] [Commented] (HBASE-5209) HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205575#comment-13205575 ] Zhihong Yu commented on HBASE-5209: --- For ServerName to provide info port, we can open a

[jira] [Commented] (HBASE-5323) Need to handle assertion error while splitting log through ServerShutDownHandler by shutting down the master

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205610#comment-13205610 ] Zhihong Yu commented on HBASE-5323: --- Some comments for patch v2. In MasterFileSystem.jav

[jira] [Commented] (HBASE-5323) Need to handle assertion error while splitting log through ServerShutDownHandler by shutting down the master

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205612#comment-13205612 ] Zhihong Yu commented on HBASE-5323: --- I would suggest starting with a patch for TRUNK whi

[jira] [Commented] (HBASE-5381) Make memstore.flush.size as a table level configuration

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205621#comment-13205621 ] Zhihong Yu commented on HBASE-5381: --- I would suggest putting more attention to HBASE-534

[jira] [Commented] (HBASE-5263) Preserving cached data on compactions through cache-on-write

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205648#comment-13205648 ] Zhihong Yu commented on HBASE-5263: --- @Kannan: I think you were referring to HBASE-5369.

[jira] [Commented] (HBASE-5347) GC free memory management in Level-1 Block Cache

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205651#comment-13205651 ] Zhihong Yu commented on HBASE-5347: --- Agreed. This initiative is on the right track.

[jira] [Commented] (HBASE-3134) [replication] Add the ability to enable/disable streams

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205707#comment-13205707 ] Zhihong Yu commented on HBASE-3134: --- For #3 above, in changePeerState() etc, we should d

[jira] [Commented] (HBASE-3134) [replication] Add the ability to enable/disable streams

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205710#comment-13205710 ] Zhihong Yu commented on HBASE-3134: --- For #1 above, is it about peerStateTrackers ? {code

[jira] [Commented] (HBASE-5382) Test that we always cache index and bloom blocks

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205713#comment-13205713 ] Zhihong Yu commented on HBASE-5382: --- I think the test failure reported here: https://bui

[jira] [Commented] (HBASE-5382) Test that we always cache index and bloom blocks

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205720#comment-13205720 ] Zhihong Yu commented on HBASE-5382: --- Looks like the patch has been checked in: {code} 1

[jira] [Commented] (HBASE-5382) Test that we always cache index and bloom blocks

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205735#comment-13205735 ] Zhihong Yu commented on HBASE-5382: --- J-D's +1 came 44 minutes before Hadoop QA report. I

[jira] [Commented] (HBASE-3852) ThriftServer leaks scanners

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205805#comment-13205805 ] Zhihong Yu commented on HBASE-3852: --- {code} + timestamp = System.currentTimeMillis(

[jira] [Commented] (HBASE-5313) Restructure hfiles layout for better compression

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205909#comment-13205909 ] Zhihong Yu commented on HBASE-5313: --- @Yongqiang: Thanks for sharing the results. Can you

[jira] [Commented] (HBASE-5313) Restructure hfiles layout for better compression

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205978#comment-13205978 ] Zhihong Yu commented on HBASE-5313: --- There're only two weeks before we branch 0.94 I thi

[jira] [Commented] (HBASE-5317) Fix TestHFileOutputFormat to work against hadoop 0.23

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205983#comment-13205983 ] Zhihong Yu commented on HBASE-5317: --- @Gregory: I think we should try approach #1 first.

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206009#comment-13206009 ] Zhihong Yu commented on HBASE-5387: --- Looks like TestHFileBlock passes this time.

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206020#comment-13206020 ] Zhihong Yu commented on HBASE-5387: --- I ran TestSplitTransactionOnCluster twice on MacBoo

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206030#comment-13206030 ] Zhihong Yu commented on HBASE-5387: --- w.r.t. the second comment above, I see the followin

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-10 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206040#comment-13206040 ] Zhihong Yu commented on HBASE-5387: --- See http://crawler.archive.org/apidocs/org/archive

[jira] [Commented] (HBASE-5179) Concurrent processing of processFaileOver and ServerShutdownHandler may cause region to be assigned before log splitting is completed, causing data loss

2012-02-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206120#comment-13206120 ] Zhihong Yu commented on HBASE-5179: --- I think this patch should be included in the new RC

[jira] [Commented] (HBASE-5200) AM.ProcessRegionInTransition() and AM.handleRegion() race thus leaving the region assignment inconsistent

2012-02-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206143#comment-13206143 ] Zhihong Yu commented on HBASE-5200: --- For #1 above, the change is only needed in 0.90 In

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206150#comment-13206150 ] Zhihong Yu commented on HBASE-5387: --- I looked at https://reviews.facebook.net/D1719 and

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206157#comment-13206157 ] Zhihong Yu commented on HBASE-5387: --- I went through http://www.docjar.com/html/api/java

[jira] [Commented] (HBASE-5199) Delete out of TTL store files before compaction selection

2012-02-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206163#comment-13206163 ] Zhihong Yu commented on HBASE-5199: --- The test failures were not related to this patch.

[jira] [Commented] (HBASE-5371) Introduce AccessControllerProtocol.checkPermissions(Permission[] permissons) API

2012-02-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206225#comment-13206225 ] Zhihong Yu commented on HBASE-5371: --- Thanks for the update, Enis. Can you run patch v2

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206273#comment-13206273 ] Zhihong Yu commented on HBASE-5387: --- Something like that. > Reuse compr

[jira] [Commented] (HBASE-3584) Allow atomic put/delete in one call

2012-02-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206297#comment-13206297 ] Zhihong Yu commented on HBASE-3584: --- I looked at 89-fb/src/main/java/org/apache/hadoop/h

[jira] [Commented] (HBASE-3584) Allow atomic put/delete in one call

2012-02-11 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206339#comment-13206339 ] Zhihong Yu commented on HBASE-3584: --- Since RowMutation in both code bases only represent

[jira] [Commented] (HBASE-5388) tunning getCachedLocation method

2012-02-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206417#comment-13206417 ] Zhihong Yu commented on HBASE-5388: --- @Ronghai: Can you upload a patch ? The improvement

[jira] [Commented] (HBASE-5388) tunning getCachedLocation method

2012-02-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206431#comment-13206431 ] Zhihong Yu commented on HBASE-5388: --- Here you can find source location: http://hbase.apa

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206435#comment-13206435 ] Zhihong Yu commented on HBASE-5387: --- The failure of Phabricator attaching patches might

[jira] [Commented] (HBASE-3584) Allow atomic put/delete in one call

2012-02-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206436#comment-13206436 ] Zhihong Yu commented on HBASE-3584: --- RowMutation isn't in 0.92 so there shouldn't be muc

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206543#comment-13206543 ] Zhihong Yu commented on HBASE-5388: --- @Ronghai: I haven't seen your patch yet. According

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206559#comment-13206559 ] Zhihong Yu commented on HBASE-5388: --- I see. Should this new method, getLower(), be call

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206561#comment-13206561 ] Zhihong Yu commented on HBASE-5388: --- Please also publish performance numbers before and

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206653#comment-13206653 ] Zhihong Yu commented on HBASE-5388: --- @Ronghai: Since this is an improvement, we should s

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-12 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206686#comment-13206686 ] Zhihong Yu commented on HBASE-5388: --- It wouldn't be an overkill if you have strong belie

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206916#comment-13206916 ] Zhihong Yu commented on HBASE-5387: --- I ran the following tests with latest patch and the

[jira] [Commented] (HBASE-5379) Backport HBASE-4287 to 0.90 - If region opening fails, try to transition region back to "offline" in ZK

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207034#comment-13207034 ] Zhihong Yu commented on HBASE-5379: --- I am running through unit test suite.

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207036#comment-13207036 ] Zhihong Yu commented on HBASE-5388: --- The javadoc involving 'greatest' comes from javadoc

[jira] [Commented] (HBASE-5327) Print a message when an invalid hbase.rootdir is passed

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207062#comment-13207062 ] Zhihong Yu commented on HBASE-5327: --- Integrated to 0.90, 0.92 and TRUNK. Thanks for the

[jira] [Commented] (HBASE-3584) Allow atomic put/delete in one call

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207091#comment-13207091 ] Zhihong Yu commented on HBASE-3584: --- I think some users would ask what the relationship

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207106#comment-13207106 ] Zhihong Yu commented on HBASE-5388: --- @Lars: What do you think ? > Tunin

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207108#comment-13207108 ] Zhihong Yu commented on HBASE-5387: --- @Mikhail: Can you integrate the patch so that we ha

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207124#comment-13207124 ] Zhihong Yu commented on HBASE-5387: --- Thanks for being prudent. > Reuse

[jira] [Commented] (HBASE-5379) Backport HBASE-4287 to 0.90 - If region opening fails, try to transition region back to "offline" in ZK

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207179#comment-13207179 ] Zhihong Yu commented on HBASE-5379: --- Unit test suite passed. +1 on patch.

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207226#comment-13207226 ] Zhihong Yu commented on HBASE-5388: --- The new method, lowerValueByKey(), isn't in Navigab

[jira] [Commented] (HBASE-5387) Reuse compression streams in HFileBlock.Writer

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207252#comment-13207252 ] Zhihong Yu commented on HBASE-5387: --- Looks like patch has been integrated. Please annou

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207258#comment-13207258 ] Zhihong Yu commented on HBASE-5388: --- lower() isn't in NavigableMap or TreeMap. And the n

[jira] [Commented] (HBASE-5197) [replication] Handle socket timeouts in ReplicationSource to prevent DDOS

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207275#comment-13207275 ] Zhihong Yu commented on HBASE-5197: --- Patch looks good. Minor comment: {code} +

[jira] [Commented] (HBASE-5317) Fix TestHFileOutputFormat to work against hadoop 0.23

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207280#comment-13207280 ] Zhihong Yu commented on HBASE-5317: --- I agree with the proposal. Another option is to pu

[jira] [Commented] (HBASE-5197) [replication] Handle socket timeouts in ReplicationSource to prevent DDOS

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207304#comment-13207304 ] Zhihong Yu commented on HBASE-5197: --- Patch v2 looks good. > [replicatio

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207310#comment-13207310 ] Zhihong Yu commented on HBASE-5388: --- @Lars: Can you clarify which patch you favor: v2 or

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207364#comment-13207364 ] Zhihong Yu commented on HBASE-5388: --- @Lars: What do you think of patch v6 ?

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207375#comment-13207375 ] Zhihong Yu commented on HBASE-5388: --- I prefer keeping the remove() call. Isn't it nice t

[jira] [Commented] (HBASE-5200) AM.ProcessRegionInTransition() and AM.handleRegion() race thus leaving the region assignment inconsistent

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207387#comment-13207387 ] Zhihong Yu commented on HBASE-5200: --- 5200-v2.txt applied to TRUNK. However, TestAssignm

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207409#comment-13207409 ] Zhihong Yu commented on HBASE-5388: --- TestSplitLogManager passed locally on MacBook with

[jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207413#comment-13207413 ] Zhihong Yu commented on HBASE-5388: --- @Ronghai: Do you think patch v6 is good to go ? Th

[jira] [Commented] (HBASE-5371) Introduce AccessControllerProtocol.checkPermissions(Permission[] permissons) API

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207471#comment-13207471 ] Zhihong Yu commented on HBASE-5371: --- @Enis: Can you run latest patch through secure HBas

[jira] [Commented] (HBASE-5371) Introduce AccessControllerProtocol.checkPermissions(Permission[] permissons) API

2012-02-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207478#comment-13207478 ] Zhihong Yu commented on HBASE-5371: --- @Andy: Does latest patch look Okay to you ?

[jira] [Commented] (HBASE-5388) Tune HConnectionManager#getCachedLocation method

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207773#comment-13207773 ] Zhihong Yu commented on HBASE-5388: --- Integrated to TRUNK. Thanks for the patch Ronghai.

[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans while processing ServerShutdownHandler

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207856#comment-13207856 ] Zhihong Yu commented on HBASE-5396: --- @Jieshan: Have you tested your patch in a 0.90 clus

[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans while processing ServerShutdownHandler

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207860#comment-13207860 ] Zhihong Yu commented on HBASE-5396: --- {code} +&& regionPlanOnThisServer !

[jira] [Commented] (HBASE-5379) Backport HBASE-4287 to 0.90 - If region opening fails, try to transition region back to "offline" in ZK

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207864#comment-13207864 ] Zhihong Yu commented on HBASE-5379: --- Integrated the patch to 0.90 as Ram is having troub

[jira] [Commented] (HBASE-5371) Introduce AccessControllerProtocol.checkPermissions(Permission[] permissons) API

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207873#comment-13207873 ] Zhihong Yu commented on HBASE-5371: --- @Andy: Do you think this should go into 0.92.1 ?

[jira] [Commented] (HBASE-5209) HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207912#comment-13207912 ] Zhihong Yu commented on HBASE-5209: --- @Stack: Can you take a look at David's latest patch

[jira] [Commented] (HBASE-5371) Introduce AccessControllerProtocol.checkPermissions(Permission[] permissons) API

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207941#comment-13207941 ] Zhihong Yu commented on HBASE-5371: --- I ran TestAccessController with latest patch: {code

[jira] [Commented] (HBASE-5371) Introduce AccessControllerProtocol.checkPermissions(Permission[] permissons) API

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207988#comment-13207988 ] Zhihong Yu commented on HBASE-5371: --- We should open a JIRA for annotating tests under se

[jira] [Commented] (HBASE-5200) AM.ProcessRegionInTransition() and AM.handleRegion() race thus leaving the region assignment inconsistent

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207999#comment-13207999 ] Zhihong Yu commented on HBASE-5200: --- bq. if we go the fb route of not handling events du

[jira] [Commented] (HBASE-5400) Some tests does not have annotations for (Small|Medium|Large)Tests

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208069#comment-13208069 ] Zhihong Yu commented on HBASE-5400: --- Patch looks good to me. @Andy, @Gary: Can you take

[jira] [Commented] (HBASE-5200) AM.ProcessRegionInTransition() and AM.handleRegion() race thus leaving the region assignment inconsistent

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208151#comment-13208151 ] Zhihong Yu commented on HBASE-5200: --- A little confused about the following code in patch

[jira] [Commented] (HBASE-5200) AM.ProcessRegionInTransition() and AM.handleRegion() race thus leaving the region assignment inconsistent

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208175#comment-13208175 ] Zhihong Yu commented on HBASE-5200: --- w.r.t. porting HBASE-5344, I think it is a good eff

[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans while processing ServerShutdownHandler

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208223#comment-13208223 ] Zhihong Yu commented on HBASE-5396: --- If you agree with renaming RegionsWithDeadServer to

[jira] [Commented] (HBASE-5200) AM.ProcessRegionInTransition() and AM.handleRegion() race thus leaving the region assignment inconsistent

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208235#comment-13208235 ] Zhihong Yu commented on HBASE-5200: --- No patch for this issue has ever been integrated to

[jira] [Commented] (HBASE-5400) Some tests does not have annotations for (Small|Medium|Large)Tests

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208242#comment-13208242 ] Zhihong Yu commented on HBASE-5400: --- Will integrate tomorrow if there is no objection.

[jira] [Commented] (HBASE-5371) Introduce AccessControllerProtocol.checkPermissions(Permission[] permissons) API

2012-02-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208243#comment-13208243 ] Zhihong Yu commented on HBASE-5371: --- Will integrate patch v3 tomorrow.

[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans while processing ServerShutdownHandler

2012-02-15 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208384#comment-13208384 ] Zhihong Yu commented on HBASE-5396: --- {code} + // Store the related regions in r

[jira] [Commented] (HBASE-5200) AM.ProcessRegionInTransition() and AM.handleRegion() race thus leaving the region assignment inconsistent

2012-02-15 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208585#comment-13208585 ] Zhihong Yu commented on HBASE-5200: --- What about 0.92 ? The substantial fix wouldn't make

[jira] [Commented] (HBASE-5371) Introduce AccessControllerProtocol.checkPermissions(Permission[] permissons) API

2012-02-15 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208626#comment-13208626 ] Zhihong Yu commented on HBASE-5371: --- The failed tests were unrelated to the patch. I ran

[jira] [Commented] (HBASE-5200) AM.ProcessRegionInTransition() and AM.handleRegion() race thus leaving the region assignment inconsistent

2012-02-15 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208740#comment-13208740 ] Zhihong Yu commented on HBASE-5200: --- By Feb. 29th, I am not sure HBASE-5344 would make i

[jira] [Commented] (HBASE-4608) HLog Compression

2012-02-15 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208763#comment-13208763 ] Zhihong Yu commented on HBASE-4608: --- @Li: Do you have time to address Todd and Liying's

[jira] [Commented] (HBASE-5400) Some tests does not have annotations for (Small|Medium|Large)Tests

2012-02-15 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208797#comment-13208797 ] Zhihong Yu commented on HBASE-5400: --- Integrated to TRUNK. Thanks for the patch, Enis.

[jira] [Commented] (HBASE-3996) Support multiple tables and scanners as input to the mapper in map/reduce jobs

2012-02-15 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208814#comment-13208814 ] Zhihong Yu commented on HBASE-3996: --- I couldn't apply the patch against TRUNK: {code} zh

[jira] [Commented] (HBASE-5241) Deletes should not mask Puts that come after it.

2012-02-15 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209092#comment-13209092 ] Zhihong Yu commented on HBASE-5241: --- I am in favor of internal timestamp so that we don'

[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans while processing ServerShutdownHandler

2012-02-15 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209104#comment-13209104 ] Zhihong Yu commented on HBASE-5396: --- +1 on patch for 90. Running test suite.

[jira] [Commented] (HBASE-5396) Handle the regions in regionPlans while processing ServerShutdownHandler

2012-02-15 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209124#comment-13209124 ] Zhihong Yu commented on HBASE-5396: --- Test result for latest patch is positive. HBASE-53

[jira] [Commented] (HBASE-5411) Add more metrics for ThriftMetrics

2012-02-16 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209364#comment-13209364 ] Zhihong Yu commented on HBASE-5411: --- Integrated to TRUNK. Thanks for the patch, Scott.

[jira] [Commented] (HBASE-5200) AM.ProcessRegionInTransition() and AM.handleRegion() race thus leaving the region assignment inconsistent

2012-02-16 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209373#comment-13209373 ] Zhihong Yu commented on HBASE-5200: --- +1 on hbase-5200_90_latest_new.patch, if tests pass

[jira] [Commented] (HBASE-4365) Add a decent heuristic for region size

2012-02-16 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209379#comment-13209379 ] Zhihong Yu commented on HBASE-4365: --- Thanks for the patch. {code} +boolean force = r

[jira] [Commented] (HBASE-4991) Provide capability to delete named region

2012-02-16 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209897#comment-13209897 ] Zhihong Yu commented on HBASE-4991: --- @Todd: In HMasterInterface, there is already API ex

[jira] [Commented] (HBASE-4991) Provide capability to delete named region

2012-02-16 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209921#comment-13209921 ] Zhihong Yu commented on HBASE-4991: --- Hmm, maybe I am a bit slow: in both cases the data

[jira] [Commented] (HBASE-4991) Provide capability to delete named region

2012-02-16 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209934#comment-13209934 ] Zhihong Yu commented on HBASE-4991: --- Mubarak did borrow some code from merge() We'll con

[jira] [Commented] (HBASE-4991) Provide capability to delete named region

2012-02-17 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210680#comment-13210680 ] Zhihong Yu commented on HBASE-4991: --- The introduction of new (range) delete marker shoul

[jira] [Commented] (HBASE-5270) Handle potential data loss due to concurrent processing of processFaileOver and ServerShutdownHandler

2012-02-18 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211068#comment-13211068 ] Zhihong Yu commented on HBASE-5270: --- w.r.t. Chunhui's comment @ 18/Feb/12 02:52 We shou

[jira] [Commented] (HBASE-5347) GC free memory management in Level-1 Block Cache

2012-02-19 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211290#comment-13211290 ] Zhihong Yu commented on HBASE-5347: --- In filterRow(), we should deref the KeyValue which

[jira] [Commented] (HBASE-3134) [replication] Add the ability to enable/disable streams

2012-02-20 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211796#comment-13211796 ] Zhihong Yu commented on HBASE-3134: --- Patch v3 looks good. > [replicatio

[jira] [Commented] (HBASE-5166) MultiThreaded Table Mapper analogous to MultiThreaded Mapper in hadoop

2012-02-21 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212547#comment-13212547 ] Zhihong Yu commented on HBASE-5166: --- Can you use --no-prefix to generat a new patch for

[jira] [Commented] (HBASE-5209) HConnection/HMasterInterface should allow for way to get hostname of currently active master in multi-master HBase setup

2012-02-21 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213073#comment-13213073 ] Zhihong Yu commented on HBASE-5209: --- Addendum integrated to 0.92 branch. Thanks for the

[jira] [Commented] (HBASE-5166) MultiThreaded Table Mapper analogous to MultiThreaded Mapper in hadoop

2012-02-21 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213139#comment-13213139 ] Zhihong Yu commented on HBASE-5166: --- @Jai: {code} + * Copyright 2007 The Apache Software

[jira] [Commented] (HBASE-5317) Fix TestHFileOutputFormat to work against hadoop 0.23

2012-02-21 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213147#comment-13213147 ] Zhihong Yu commented on HBASE-5317: --- Based on latest patch, I got: {code} Failed tests:

<    4   5   6   7   8   9   10   11   12   13   >