[GitHub] [hbase] bbeaudreault merged pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

bbeaudreault merged PR #5228: URL: https://github.com/apache/hbase/pull/5228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] bbeaudreault commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

bbeaudreault commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1716207454 @zhuyaogai thanks for all the work here! Can you submit a backport PR for branch-2? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1323047115 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java: ## @@ -196,13 +196,17 @@ static boolean isEmptyStopRow(byte[] row) { return

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

bbeaudreault commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1323080007 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java: ## @@ -196,13 +196,17 @@ static boolean isEmptyStopRow(byte[] row) { return

[GitHub] [hbase] Apache-HBase commented on pull request #5392: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5392: URL: https://github.com/apache/hbase/pull/5392#issuecomment-1715787109 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s |

[GitHub] [hbase] Apache-HBase commented on pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

Apache-HBase commented on PR #5381: URL: https://github.com/apache/hbase/pull/5381#issuecomment-1716048144 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

[GitHub] [hbase] virajjasani commented on a diff in pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

virajjasani commented on code in PR #5391: URL: https://github.com/apache/hbase/pull/5391#discussion_r1323315239 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java: ## @@ -306,6 +307,10 @@ private boolean

[GitHub] [hbase] stoty opened a new pull request, #5397: HBASE-28076 NPE on initialization error in RecoveredReplicationSource…

stoty opened a new pull request, #5397: URL: https://github.com/apache/hbase/pull/5397 …Shipper -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1323173236 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1697,8 +1722,27 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] bbeaudreault commented on pull request #5384: HBASE-28065 Corrupt HFile data is mishandled in several cases (branch-2.5)

bbeaudreault commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1716017608 @ndimiduk looks like there are a couple unit test failures in the new TestHFileBlockHeaderCorruption, and 1 checkstyle warning. -- This is an automated message from the Apache Git

[GitHub] [hbase] Apache9 commented on pull request #5374: HBASE-28047 Deadlock when opening mob files

Apache9 commented on PR #5374: URL: https://github.com/apache/hbase/pull/5374#issuecomment-1715766127 I do not think this is the correct way to fix the problem? If hashCode could conflict, then the algorithm here is incorrect... -- This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1715819482 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #5398: Forward-port "HBASE-28065 Corrupt HFile data is mishandled in several cases" to master

Apache-HBase commented on PR #5398: URL: https://github.com/apache/hbase/pull/5398#issuecomment-1716023789 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[GitHub] [hbase] Apache-HBase commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

Apache-HBase commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1716168328 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1323097842 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1700,6 +1721,21 @@ protected HFileBlock

[GitHub] [hbase] Apache-HBase commented on pull request #5397: HBASE-28076 NPE on initialization error in RecoveredReplicationSource…

Apache-HBase commented on PR #5397: URL: https://github.com/apache/hbase/pull/5397#issuecomment-1715828726 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s |

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1323158894 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1700,6 +1721,21 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: HBASE-28065 Corrupt HFile data is mishandled in several cases (branch-2.5)

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1323187904 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1700,6 +1721,21 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] Apache-HBase commented on pull request #5398: Forward-port "HBASE-28065 Corrupt HFile data is mishandled in several cases" to master

Apache-HBase commented on PR #5398: URL: https://github.com/apache/hbase/pull/5398#issuecomment-1715995049 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: HBASE-28065 Corrupt HFile data is mishandled in several cases (branch-2.5)

bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1323266286 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1700,6 +1721,21 @@ protected HFileBlock

[GitHub] [hbase] hiping-tech commented on pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

hiping-tech commented on PR #5381: URL: https://github.com/apache/hbase/pull/5381#issuecomment-1716002678 hi @frostruan thanks for you excellent suggestions. I have made the necessary changes. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] dependabot[bot] opened a new pull request, #5395: Bump gitpython from 3.1.34 to 3.1.35 in /dev-support/flaky-tests

dependabot[bot] opened a new pull request, #5395: URL: https://github.com/apache/hbase/pull/5395 Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.34 to 3.1.35. Release notes Sourced from

[GitHub] [hbase] dependabot[bot] opened a new pull request, #5396: Bump gitpython from 3.1.32 to 3.1.35 in /dev-support/git-jira-release-audit

dependabot[bot] opened a new pull request, #5396: URL: https://github.com/apache/hbase/pull/5396 Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.32 to 3.1.35. Release notes Sourced from

[GitHub] [hbase] dependabot[bot] commented on pull request #5386: Bump gitpython from 3.1.32 to 3.1.34 in /dev-support/git-jira-release-audit

dependabot[bot] commented on PR #5386: URL: https://github.com/apache/hbase/pull/5386#issuecomment-1715236462 Superseded by #5396. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5363: HBASE-28008 Add support for netty tcnative

bbeaudreault commented on code in PR #5363: URL: https://github.com/apache/hbase/pull/5363#discussion_r1322983399 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -83,9 +88,10 @@ public final class X509Util { public static final String

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

bbeaudreault commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1322934452 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java: ## @@ -196,13 +196,17 @@ static boolean isEmptyStopRow(byte[] row) { return

[GitHub] [hbase] Apache-HBase commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1715626805 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase] dependabot[bot] closed pull request #5386: HBASE-28073 Bump gitpython from 3.1.32 to 3.1.34 in /dev-support/git-jira-release-audit

dependabot[bot] closed pull request #5386: HBASE-28073 Bump gitpython from 3.1.32 to 3.1.34 in /dev-support/git-jira-release-audit URL: https://github.com/apache/hbase/pull/5386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #5392: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5392: URL: https://github.com/apache/hbase/pull/5392#issuecomment-1715331692 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5363: HBASE-28008 Add support for netty tcnative

bbeaudreault commented on code in PR #5363: URL: https://github.com/apache/hbase/pull/5363#discussion_r1322984856 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java: ## @@ -131,6 +137,34 @@ private static String[] getCBCCiphers() { private

[GitHub] [hbase] Apache-HBase commented on pull request #5395: Bump gitpython from 3.1.34 to 3.1.35 in /dev-support/flaky-tests

Apache-HBase commented on PR #5395: URL: https://github.com/apache/hbase/pull/5395#issuecomment-1715252146 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5396: HBASE-28073 Bump gitpython from 3.1.32 to 3.1.35 in /dev-support/git-jira-release-audit

Apache-HBase commented on PR #5396: URL: https://github.com/apache/hbase/pull/5396#issuecomment-1715252266 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[GitHub] [hbase] Apache-HBase commented on pull request #5395: Bump gitpython from 3.1.34 to 3.1.35 in /dev-support/flaky-tests

Apache-HBase commented on PR #5395: URL: https://github.com/apache/hbase/pull/5395#issuecomment-1715252303 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5396: HBASE-28073 Bump gitpython from 3.1.32 to 3.1.35 in /dev-support/git-jira-release-audit

Apache-HBase commented on PR #5396: URL: https://github.com/apache/hbase/pull/5396#issuecomment-1715251744 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s |

[GitHub] [hbase] Apache9 merged pull request #5396: HBASE-28073 Bump gitpython from 3.1.32 to 3.1.35 in /dev-support/git-jira-release-audit

Apache9 merged PR #5396: URL: https://github.com/apache/hbase/pull/5396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1715622968 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[GitHub] [hbase] Apache-HBase commented on pull request #5393: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5393: URL: https://github.com/apache/hbase/pull/5393#issuecomment-1715276292 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

[GitHub] [hbase] NihalJain merged pull request #5346: HBASE-27991 fixing ClassCastException in multithread client run

NihalJain merged PR #5346: URL: https://github.com/apache/hbase/pull/5346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1322922297 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] Apache-HBase commented on pull request #5395: Bump gitpython from 3.1.34 to 3.1.35 in /dev-support/flaky-tests

Apache-HBase commented on PR #5395: URL: https://github.com/apache/hbase/pull/5395#issuecomment-1715254917 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[GitHub] [hbase] Apache-HBase commented on pull request #5394: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5394: URL: https://github.com/apache/hbase/pull/5394#issuecomment-1715519393 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[GitHub] [hbase] Apache-HBase commented on pull request #5393: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5393: URL: https://github.com/apache/hbase/pull/5393#issuecomment-1715600281 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase] Apache-HBase commented on pull request #5393: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5393: URL: https://github.com/apache/hbase/pull/5393#issuecomment-1715647660 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[GitHub] [hbase] bbeaudreault merged pull request #5363: HBASE-28008 Add support for netty tcnative

bbeaudreault merged PR #5363: URL: https://github.com/apache/hbase/pull/5363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 commented on a diff in pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

Apache9 commented on code in PR #5391: URL: https://github.com/apache/hbase/pull/5391#discussion_r1322634863 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java: ## @@ -306,6 +307,10 @@ private boolean scheduleForRetry(IOException

[GitHub] [hbase] Apache-HBase commented on pull request #5393: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5393: URL: https://github.com/apache/hbase/pull/5393#issuecomment-1715278142 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase] Apache-HBase commented on pull request #5394: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5394: URL: https://github.com/apache/hbase/pull/5394#issuecomment-1715383197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[GitHub] [hbase] Apache-HBase commented on pull request #5392: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5392: URL: https://github.com/apache/hbase/pull/5392#issuecomment-1715446882 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] Apache-HBase commented on pull request #5394: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5394: URL: https://github.com/apache/hbase/pull/5394#issuecomment-1715468123 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

bbeaudreault commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1322965001 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1625,14 +1641,16 @@ private void cacheNextBlockHeader(final long offset,

[GitHub] [hbase] Apache-HBase commented on pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1715639840 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s |

[GitHub] [hbase] Apache-HBase commented on pull request #5393: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5393: URL: https://github.com/apache/hbase/pull/5393#issuecomment-1715334392 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

[GitHub] [hbase] Apache-HBase commented on pull request #5392: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5392: URL: https://github.com/apache/hbase/pull/5392#issuecomment-1715493035 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[GitHub] [hbase] Apache-HBase commented on pull request #5396: HBASE-28073 Bump gitpython from 3.1.32 to 3.1.35 in /dev-support/git-jira-release-audit

Apache-HBase commented on PR #5396: URL: https://github.com/apache/hbase/pull/5396#issuecomment-1715254355 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[GitHub] [hbase] NihalJain commented on pull request #5346: HBASE-27991 fixing ClassCastException in multithread client run

NihalJain commented on PR #5346: URL: https://github.com/apache/hbase/pull/5346#issuecomment-1715376070 Thanks for making your 1st contribution in Apache HBase @nikita15p :) Also, could you please raise a backport PR for branch-2 (since the failure is only relevant for branch-2 as

[GitHub] [hbase] Apache-HBase commented on pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

Apache-HBase commented on PR #5381: URL: https://github.com/apache/hbase/pull/5381#issuecomment-1716323216 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[GitHub] [hbase] Apache-HBase commented on pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

Apache-HBase commented on PR #5391: URL: https://github.com/apache/hbase/pull/5391#issuecomment-1716420087 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[GitHub] [hbase] Apache-HBase commented on pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

Apache-HBase commented on PR #5391: URL: https://github.com/apache/hbase/pull/5391#issuecomment-1716799818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase] Apache-HBase commented on pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

Apache-HBase commented on PR #5381: URL: https://github.com/apache/hbase/pull/5381#issuecomment-1716334926 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[GitHub] [hbase] Apache-HBase commented on pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

Apache-HBase commented on PR #5391: URL: https://github.com/apache/hbase/pull/5391#issuecomment-1716418580 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[GitHub] [hbase] Apache-HBase commented on pull request #5399: HBASE-28079 Unhandled TableExistsException and NamespaceExistException in BackupSystemTable

Apache-HBase commented on PR #5399: URL: https://github.com/apache/hbase/pull/5399#issuecomment-1716361974 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[GitHub] [hbase] Apache-HBase commented on pull request #5399: HBASE-28079 Unhandled TableExistsException and NamespaceExistException in BackupSystemTable

Apache-HBase commented on PR #5399: URL: https://github.com/apache/hbase/pull/5399#issuecomment-1716363613 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[GitHub] [hbase] Apache-HBase commented on pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

Apache-HBase commented on PR #5391: URL: https://github.com/apache/hbase/pull/5391#issuecomment-1716486288 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[GitHub] [hbase] virajjasani commented on a diff in pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

virajjasani commented on code in PR #5391: URL: https://github.com/apache/hbase/pull/5391#discussion_r1323674395 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -347,7 +348,7 @@ public void operationComplete(ChannelFuture future) throws

[GitHub] [hbase] virajjasani commented on a diff in pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

virajjasani commented on code in PR #5391: URL: https://github.com/apache/hbase/pull/5391#discussion_r1323678057 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java: ## @@ -306,6 +308,10 @@ private boolean

[GitHub] [hbase] virajjasani commented on a diff in pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

virajjasani commented on code in PR #5391: URL: https://github.com/apache/hbase/pull/5391#discussion_r1323674395 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -347,7 +348,7 @@ public void operationComplete(ChannelFuture future) throws

[GitHub] [hbase] Apache-HBase commented on pull request #5384: HBASE-28065 Corrupt HFile data is mishandled in several cases (branch-2.5)

Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1716365593 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

[GitHub] [hbase] Apache-HBase commented on pull request #5384: HBASE-28065 Corrupt HFile data is mishandled in several cases (branch-2.5)

Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1716297424 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

[GitHub] [hbase] Apache-HBase commented on pull request #5398: Forward-port "HBASE-28065 Corrupt HFile data is mishandled in several cases" to master

Apache-HBase commented on PR #5398: URL: https://github.com/apache/hbase/pull/5398#issuecomment-1716306370 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

[GitHub] [hbase] Apache-HBase commented on pull request #5399: HBASE-28079 Unhandled TableExistsException and NamespaceExistException in BackupSystemTable

Apache-HBase commented on PR #5399: URL: https://github.com/apache/hbase/pull/5399#issuecomment-1716372092 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s |

[GitHub] [hbase] zhuyaogai commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

zhuyaogai commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1716832898 > @zhuyaogai thanks for all the work here! Can you submit a backport PR for branch-2? I think you will need to add a bit more code for the sync client (HTable) there @bbeaudreault

[GitHub] [hbase] bbeaudreault opened a new pull request, #5399: HBASE-28079 Unhandled TableExistsException and NamespaceExistException in BackupSystemTable

bbeaudreault opened a new pull request, #5399: URL: https://github.com/apache/hbase/pull/5399 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hbase] apurtell commented on a diff in pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

apurtell commented on code in PR #5391: URL: https://github.com/apache/hbase/pull/5391#discussion_r1323672892 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java: ## @@ -306,6 +308,10 @@ private boolean scheduleForRetry(IOException

[GitHub] [hbase] Apache-HBase commented on pull request #5384: HBASE-28065 Corrupt HFile data is mishandled in several cases (branch-2.5)

Apache-HBase commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1716732016 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

[GitHub] [hbase] Apache-HBase commented on pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

Apache-HBase commented on PR #5391: URL: https://github.com/apache/hbase/pull/5391#issuecomment-1716783464 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[GitHub] [hbase] Apache-HBase commented on pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

Apache-HBase commented on PR #5381: URL: https://github.com/apache/hbase/pull/5381#issuecomment-1716900565 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

Apache-HBase commented on PR #5381: URL: https://github.com/apache/hbase/pull/5381#issuecomment-1717127212 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[GitHub] [hbase] Apache9 commented on a diff in pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

Apache9 commented on code in PR #5391: URL: https://github.com/apache/hbase/pull/5391#discussion_r1323863142 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java: ## @@ -306,6 +308,10 @@ private boolean scheduleForRetry(IOException

[GitHub] [hbase] Apache-HBase commented on pull request #5400: HBASE-28080 correct span name in AbstractRpcBasedConnectionRegistry#getActiveMaster

Apache-HBase commented on PR #5400: URL: https://github.com/apache/hbase/pull/5400#issuecomment-1716871282 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[GitHub] [hbase] Apache-HBase commented on pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

Apache-HBase commented on PR #5381: URL: https://github.com/apache/hbase/pull/5381#issuecomment-1716926450 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] ndimiduk commented on pull request #5384: HBASE-28065 Corrupt HFile data is mishandled in several cases (branch-2.5)

ndimiduk commented on PR #5384: URL: https://github.com/apache/hbase/pull/5384#issuecomment-1717035645 > https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5384/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt Checkstyle warning is, ```

[GitHub] [hbase] Apache-HBase commented on pull request #5400: HBASE-28080 correct span name in AbstractRpcBasedConnectionRegistry#getActiveMaster

Apache-HBase commented on PR #5400: URL: https://github.com/apache/hbase/pull/5400#issuecomment-1716865504 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #5400: HBASE-28080 correct span name in AbstractRpcBasedConnectionRegistry#getActiveMaster

Apache-HBase commented on PR #5400: URL: https://github.com/apache/hbase/pull/5400#issuecomment-1716866530 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[GitHub] [hbase] Apache9 commented on pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

Apache9 commented on PR #5381: URL: https://github.com/apache/hbase/pull/5381#issuecomment-1716872660 Please run `mvn spotless:apply` to fix the style error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache9 merged pull request #5400: HBASE-28080 correct span name in AbstractRpcBasedConnectionRegistry#getActiveMaster

Apache9 merged PR #5400: URL: https://github.com/apache/hbase/pull/5400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] frostruan opened a new pull request, #5400: HBASE-28080 correct span name in AbstractRpcBasedConnectionRegistry#getActiveMaster

frostruan opened a new pull request, #5400: URL: https://github.com/apache/hbase/pull/5400 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hbase] Apache-HBase commented on pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

Apache-HBase commented on PR #5381: URL: https://github.com/apache/hbase/pull/5381#issuecomment-1717123980 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache9 commented on pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

Apache9 commented on PR #5381: URL: https://github.com/apache/hbase/pull/5381#issuecomment-1717370972 Oh, just notice that the PR is opened against branch-3... Next time please open an PR against master branch. In HBase we will first apply changes to master branch, and then

[GitHub] [hbase] Apache9 merged pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

Apache9 merged PR #5381: URL: https://github.com/apache/hbase/pull/5381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 commented on a diff in pull request #5399: HBASE-28079 Unhandled TableExistsException and NamespaceExistException in BackupSystemTable

Apache9 commented on code in PR #5399: URL: https://github.com/apache/hbase/pull/5399#discussion_r1324309903 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java: ## @@ -202,17 +204,25 @@ private void checkSystemTable() throws IOException {

[GitHub] [hbase] hiping-tech commented on pull request #5381: HBASE-28058 Adjust the order of acquiring the takeSnapshot locks to r…esolve the deadlock issue.

hiping-tech commented on PR #5381: URL: https://github.com/apache/hbase/pull/5381#issuecomment-1717569067 @Apache9 Thanks for your reminder. I will pay attention next time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] Apache-HBase commented on pull request #5399: HBASE-28079 Unhandled TableExistsException and NamespaceExistException in BackupSystemTable

Apache-HBase commented on PR #5399: URL: https://github.com/apache/hbase/pull/5399#issuecomment-1717586902 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[GitHub] [hbase] Apache-HBase commented on pull request #5399: HBASE-28079 Unhandled TableExistsException and NamespaceExistException in BackupSystemTable

Apache-HBase commented on PR #5399: URL: https://github.com/apache/hbase/pull/5399#issuecomment-1717601811 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase] Apache-HBase commented on pull request #5399: HBASE-28079 Unhandled TableExistsException and NamespaceExistException in BackupSystemTable

Apache-HBase commented on PR #5399: URL: https://github.com/apache/hbase/pull/5399#issuecomment-1717588383 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] bbeaudreault merged pull request #5399: HBASE-28079 Unhandled TableExistsException and NamespaceExistException in BackupSystemTable

bbeaudreault merged PR #5399: URL: https://github.com/apache/hbase/pull/5399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] virajjasani commented on a diff in pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for SaslException

virajjasani commented on code in PR #5391: URL: https://github.com/apache/hbase/pull/5391#discussion_r1324992854 ## hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java: ## @@ -347,7 +348,7 @@ public void operationComplete(ChannelFuture future) throws

[GitHub] [hbase] Apache-HBase commented on pull request #5391: HBASE-28050 RSProcedureDispatcher to fail-fast for krb auth failures

Apache-HBase commented on PR #5391: URL: https://github.com/apache/hbase/pull/5391#issuecomment-1718274909 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] ss77892 opened a new pull request, #5392: HBASE-28055 Addendum. Fixing the compilation failure

ss77892 opened a new pull request, #5392: URL: https://github.com/apache/hbase/pull/5392 the source of OLDEST_TIMESTAMP is different in the master branch and that has been missed during the rebase. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] ss77892 opened a new pull request, #5393: HBASE-28055 Addendum. Fixing the compilation failure

ss77892 opened a new pull request, #5393: URL: https://github.com/apache/hbase/pull/5393 the source of OLDEST_TIMESTAMP is different in the master branch and that has been missed during the rebase. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #5392: HBASE-28055 Addendum. Fixing the compilation failure

Apache-HBase commented on PR #5392: URL: https://github.com/apache/hbase/pull/5392#issuecomment-1715029032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

<    1   2   3   4   5   6   7   8   9   10   >