[jira] [Commented] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
[
https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14060394#comment-14060394
]
Hudson commented on HBASE-11499:
SUCCESS: Integrated in HBase-TRUNK #5296 (See
[https://builds.apache.org/job/HBase-TRUNK/5296/])
HBASE-11499 AsyncProcess.buildDetailedErrorMessage concatenates strings using +
in a loop (Mike Drob) (stack: rev a6fd48ba12e0f82b3ea937227845a63e5c1f8bf7)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
-
Key: HBASE-11499
URL: https://issues.apache.org/jira/browse/HBASE-11499
Project: HBase
Issue Type: Bug
Components: Client
Reporter: Mike Drob
Assignee: Mike Drob
Priority: Trivial
Labels: findbugs
Fix For: 2.0.0
Attachments: HBASE-11499.patch.txt, HBASE-11499.v2.patch.txt
The method is building a string using lots of concatenation, including in a
loop, which will be {{O(n^2)}} because a new array will be allocated each
time. Would be more efficient to use a StringBuilder for this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
[
https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057962#comment-14057962
]
Hadoop QA commented on HBASE-11499:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12655074/HBASE-11499.patch.txt
against trunk revision .
ATTACHMENT ID: 12655074
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10023//console
This message is automatically generated.
AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
-
Key: HBASE-11499
URL: https://issues.apache.org/jira/browse/HBASE-11499
Project: HBase
Issue Type: Bug
Components: Client
Reporter: Mike Drob
Priority: Trivial
Labels: findbugs
Attachments: HBASE-11499.patch.txt
The method is building a string using lots of concatenation, including in a
loop, which will be {{O(n^2)}} because a new array will be allocated each
time. Would be more efficient to use a StringBuilder for this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
[
https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057983#comment-14057983
]
Mike Drob commented on HBASE-11499:
---
It looks like HadoopQA is applying the patches with -p1 now? Which would mean
that the docs at
http://hbase.apache.org/book/submitting.patches.html#submitting.patches.create
need to be updated to not suggest using {{--no-prefix}}. Can somebody verify?
AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
-
Key: HBASE-11499
URL: https://issues.apache.org/jira/browse/HBASE-11499
Project: HBase
Issue Type: Bug
Components: Client
Reporter: Mike Drob
Priority: Trivial
Labels: findbugs
Attachments: HBASE-11499.patch.txt
The method is building a string using lots of concatenation, including in a
loop, which will be {{O(n^2)}} because a new array will be allocated each
time. Would be more efficient to use a StringBuilder for this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11499) AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
[
https://issues.apache.org/jira/browse/HBASE-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14058044#comment-14058044
]
Hadoop QA commented on HBASE-11499:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12655086/HBASE-11499.v2.patch.txt
against trunk revision .
ATTACHMENT ID: 12655086
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestCacheConfig
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10026//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10026//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10026//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10026//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10026//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10026//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10026//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10026//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10026//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10026//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10026//console
This message is automatically generated.
AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop
-
Key: HBASE-11499
URL: https://issues.apache.org/jira/browse/HBASE-11499
Project: HBase
Issue Type: Bug
Components: Client
Reporter: Mike Drob
Priority: Trivial
Labels: findbugs
Attachments: HBASE-11499.patch.txt, HBASE-11499.v2.patch.txt
The method is building a string using lots of concatenation, including in a
loop, which will be {{O(n^2)}} because a new array will be allocated each
time. Would be more efficient to use a StringBuilder for this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
