[jira] [Commented] (HBASE-14800) Expose checkAndMutate via Thrift2
[ https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071782#comment-15071782 ] Josh Elser commented on HBASE-14800: bq. However, patch cannot be applied to branch-1 since the thrift2 generated files carry a different date: I'll get a patch for branch-1 up here. Thanks for applying, Ted. > Expose checkAndMutate via Thrift2 > - > > Key: HBASE-14800 > URL: https://issues.apache.org/jira/browse/HBASE-14800 > Project: HBase > Issue Type: Improvement > Components: Thrift >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14800.001.patch, HBASE-14800.002.patch, > HBASE-14800.003.patch > > > Had a user ask why checkAndMutate wasn't exposed via Thrift2. > I see no good reason (since checkAndPut and checkAndDelete are already > there), so let's add it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14800) Expose checkAndMutate via Thrift2
[ https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071803#comment-15071803 ] Hudson commented on HBASE-14800: FAILURE: Integrated in HBase-1.3-IT #408 (See [https://builds.apache.org/job/HBase-1.3-IT/408/]) HBASE-14800 Expose checkAndMutate via Thrift2 (Josh Elser) (tedyu: rev 3cc6880904261429d64f3b7472bbd82a46c7cd8d) * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TServerName.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumn.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THRegionInfo.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THRegionLocation.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TColumn.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIOError.java * hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAppend.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAuthorization.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIllegalArgument.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TTimeRange.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnIncrement.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TCellVisibility.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TRowMutations.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TAppend.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TCompareOp.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnValue.java * hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java > Expose checkAndMutate via Thrift2 > - > > Key: HBASE-14800 > URL: https://issues.apache.org/jira/browse/HBASE-14800 > Project: HBase > Issue Type: Improvement > Components: Thrift >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14800-branch-1.003.patch, HBASE-14800.001.patch, > HBASE-14800.002.patch, HBASE-14800.003.patch > > > Had a user ask why checkAndMutate wasn't exposed via Thrift2. > I see no good reason (since checkAndPut and checkAndDelete are already > there), so let's add it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14800) Expose checkAndMutate via Thrift2
[
https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071773#comment-15071773
]
Hadoop QA commented on HBASE-14800:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12777382/HBASE-14800.003.patch
against master branch at commit 1c7e9ec124ab19d3c727d8294a8022d7b936bbfc.
ATTACHMENT ID: 12777382
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not generate new
checkstyle errors.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ checkAndMutate_call method_call = new checkAndMutate_call(table,
row, family, qualifier, compareOp, value, rowMutations, resultHandler, this,
___protocolFactory, ___transport);
+ result.success = iface.checkAndMutate(args.table, args.row,
args.family, args.qualifier, args.compareOp, args.value, args.rowMutations);
+ public AsyncMethodCallback getResultHandler(final
AsyncFrameBuffer fb, final int seqid) {
+iface.checkAndMutate(args.table, args.row, args.family,
args.qualifier, args.compareOp, args.value, args.rowMutations,resultHandler);
+private static final Map schemes
= new HashMap();
+/** The set of fields this struct contains, along with convenience methods
for finding and manipulating them. */
+if (fields == null) throw new IllegalArgumentException("Field " +
fieldId + " doesn't exist!");
+ this.table = table == null ? (ByteBuffer)null :
ByteBuffer.wrap(Arrays.copyOf(table, table.length));
+ this.family = family == null ? (ByteBuffer)null :
ByteBuffer.wrap(Arrays.copyOf(family, family.length));
+ this.qualifier = qualifier == null ? (ByteBuffer)null :
ByteBuffer.wrap(Arrays.copyOf(qualifier, qualifier.length));
{color:green}+1 site{color}. The mvn post-site goal succeeds with this
patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:green}+1 zombies{color}. No zombie tests found running at the end of
the build.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/17033//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/17033//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/17033//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/17033//console
This message is automatically generated.
> Expose checkAndMutate via Thrift2
> -
>
> Key: HBASE-14800
> URL: https://issues.apache.org/jira/browse/HBASE-14800
> Project: HBase
> Issue Type: Improvement
> Components: Thrift
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14800.001.patch, HBASE-14800.002.patch,
> HBASE-14800.003.patch
>
>
> Had a user ask why checkAndMutate wasn't exposed via Thrift2.
> I see no good reason (since checkAndPut and checkAndDelete are already
> there), so let's add it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14800) Expose checkAndMutate via Thrift2
[
https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071781#comment-15071781
]
Ted Yu commented on HBASE-14800:
Integrated to master branch.
However, patch cannot be applied to branch-1 since the thrift2 generated files
carry a different date:
{code}
@Generated(value = "Autogenerated by Thrift Compiler (0.9.3)", date =
"2015-11-22")
{code}
> Expose checkAndMutate via Thrift2
> -
>
> Key: HBASE-14800
> URL: https://issues.apache.org/jira/browse/HBASE-14800
> Project: HBase
> Issue Type: Improvement
> Components: Thrift
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14800.001.patch, HBASE-14800.002.patch,
> HBASE-14800.003.patch
>
>
> Had a user ask why checkAndMutate wasn't exposed via Thrift2.
> I see no good reason (since checkAndPut and checkAndDelete are already
> there), so let's add it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14800) Expose checkAndMutate via Thrift2
[ https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071829#comment-15071829 ] Hudson commented on HBASE-14800: FAILURE: Integrated in HBase-1.3 #472 (See [https://builds.apache.org/job/HBase-1.3/472/]) HBASE-14800 Expose checkAndMutate via Thrift2 (Josh Elser) (tedyu: rev 3cc6880904261429d64f3b7472bbd82a46c7cd8d) * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TRowMutations.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnValue.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumn.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TAppend.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TCompareOp.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAuthorization.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIllegalArgument.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TServerName.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAppend.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TColumn.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THRegionLocation.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java * hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnIncrement.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TTimeRange.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java * hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TCellVisibility.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIOError.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THRegionInfo.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java > Expose checkAndMutate via Thrift2 > - > > Key: HBASE-14800 > URL: https://issues.apache.org/jira/browse/HBASE-14800 > Project: HBase > Issue Type: Improvement > Components: Thrift >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14800-branch-1.003.patch, HBASE-14800.001.patch, > HBASE-14800.002.patch, HBASE-14800.003.patch > > > Had a user ask why checkAndMutate wasn't exposed via Thrift2. > I see no good reason (since checkAndPut and checkAndDelete are already > there), so let's add it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14800) Expose checkAndMutate via Thrift2
[ https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071831#comment-15071831 ] Hudson commented on HBASE-14800: SUCCESS: Integrated in HBase-Trunk_matrix #589 (See [https://builds.apache.org/job/HBase-Trunk_matrix/589/]) HBASE-14800 Expose checkAndMutate via Thrift2 (Josh Elser) (tedyu: rev b8e2e4a1e7c275752177baf64d6bf01e0da8228c) * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TAppend.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THRegionInfo.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAuthorization.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TServerName.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnIncrement.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAppend.java * hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnValue.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TColumn.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THRegionLocation.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumn.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java * hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TRowMutations.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIllegalArgument.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TCellVisibility.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TTimeRange.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIOError.java HBASE-14800 TCompareOp which was missing from initial checkin (tedyu: rev 5eefe1317336714b409500daaebe003f65fd87b6) * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TCompareOp.java > Expose checkAndMutate via Thrift2 > - > > Key: HBASE-14800 > URL: https://issues.apache.org/jira/browse/HBASE-14800 > Project: HBase > Issue Type: Improvement > Components: Thrift >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14800-branch-1.003.patch, HBASE-14800.001.patch, > HBASE-14800.002.patch, HBASE-14800.003.patch > > > Had a user ask why checkAndMutate wasn't exposed via Thrift2. > I see no good reason (since checkAndPut and checkAndDelete are already > there), so let's add it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14800) Expose checkAndMutate via Thrift2
[
https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071790#comment-15071790
]
Hadoop QA commented on HBASE-14800:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12779534/HBASE-14800-branch-1.003.patch
against branch-1.0 branch at commit b8e2e4a1e7c275752177baf64d6bf01e0da8228c.
ATTACHMENT ID: 12779534
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/17034//console
This message is automatically generated.
> Expose checkAndMutate via Thrift2
> -
>
> Key: HBASE-14800
> URL: https://issues.apache.org/jira/browse/HBASE-14800
> Project: HBase
> Issue Type: Improvement
> Components: Thrift
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14800-branch-1.003.patch, HBASE-14800.001.patch,
> HBASE-14800.002.patch, HBASE-14800.003.patch
>
>
> Had a user ask why checkAndMutate wasn't exposed via Thrift2.
> I see no good reason (since checkAndPut and checkAndDelete are already
> there), so let's add it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14800) Expose checkAndMutate via Thrift2
[ https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004779#comment-15004779 ] Andrew Purtell commented on HBASE-14800: lgtm Tiny spelling nit: test is named "testeCheckAndMutate", should be "testCheckAndMutate" I think. > Expose checkAndMutate via Thrift2 > - > > Key: HBASE-14800 > URL: https://issues.apache.org/jira/browse/HBASE-14800 > Project: HBase > Issue Type: Improvement > Components: Thrift >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-14800.001.patch > > > Had a user ask why checkAndMutate wasn't exposed via Thrift2. > I see no good reason (since checkAndPut and checkAndDelete are already > there), so let's add it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14800) Expose checkAndMutate via Thrift2
[ https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005068#comment-15005068 ] Josh Elser commented on HBASE-14800: Thanks for the review, [~apurtell]. The fingers have a mind of their own sometime. Will post a new patch shortly. > Expose checkAndMutate via Thrift2 > - > > Key: HBASE-14800 > URL: https://issues.apache.org/jira/browse/HBASE-14800 > Project: HBase > Issue Type: Improvement > Components: Thrift >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-14800.001.patch > > > Had a user ask why checkAndMutate wasn't exposed via Thrift2. > I see no good reason (since checkAndPut and checkAndDelete are already > there), so let's add it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14800) Expose checkAndMutate via Thrift2
[ https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005075#comment-15005075 ] Andrew Purtell commented on HBASE-14800: Oh, don't worry about, I'm more than happy to fix minor nits like that upon commit as long as you acknowledge the change. You have, so I will. No need for a new patch. No problem if you want to provide a new one, either. > Expose checkAndMutate via Thrift2 > - > > Key: HBASE-14800 > URL: https://issues.apache.org/jira/browse/HBASE-14800 > Project: HBase > Issue Type: Improvement > Components: Thrift >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0 > > Attachments: HBASE-14800.001.patch > > > Had a user ask why checkAndMutate wasn't exposed via Thrift2. > I see no good reason (since checkAndPut and checkAndDelete are already > there), so let's add it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14800) Expose checkAndMutate via Thrift2
[
https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005171#comment-15005171
]
Hadoop QA commented on HBASE-14800:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12772341/HBASE-14800.002.patch
against master branch at commit 789f8a5a70242c16ce10bc95401c51c7d04debfa.
ATTACHMENT ID: 12772341
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1729 checkstyle errors (more than the master's current 1727 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+lastComparison =
Boolean.valueOf(isSetBloomFilterType()).compareTo(other.isSetBloomFilterType());
+lastComparison =
Boolean.valueOf(isSetBloomFilterVectorSize()).compareTo(other.isSetBloomFilterVectorSize());
+lastComparison =
Boolean.valueOf(isSetBloomFilterNbHashes()).compareTo(other.isSetBloomFilterNbHashes());
+lastComparison =
Boolean.valueOf(isSetBlockCacheEnabled()).compareTo(other.isSetBlockCacheEnabled());
+ public AsyncMethodCallback getResultHandler(final AsyncFrameBuffer
fb, final int seqid) {
+ public AsyncMethodCallback getResultHandler(final AsyncFrameBuffer
fb, final int seqid) {
+ public AsyncMethodCallback getResultHandler(final
AsyncFrameBuffer fb, final int seqid) {
+ public AsyncMethodCallback getResultHandler(final AsyncFrameBuffer
fb, final int seqid) {
+ public AsyncMethodCallback getResultHandler(final AsyncFrameBuffer
fb, final int seqid) {
+ public AsyncMethodCallback getResultHandler(final
AsyncFrameBuffer fb, final int seqid) {
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.snapshot.TestMobExportSnapshot
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16516//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16516//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16516//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16516//console
This message is automatically generated.
> Expose checkAndMutate via Thrift2
> -
>
> Key: HBASE-14800
> URL: https://issues.apache.org/jira/browse/HBASE-14800
> Project: HBase
> Issue Type: Improvement
> Components: Thrift
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: 2.0.0
>
> Attachments: HBASE-14800.001.patch, HBASE-14800.002.patch
>
>
> Had a user ask why checkAndMutate wasn't exposed via Thrift2.
> I see no good reason (since checkAndPut and checkAndDelete are already
> there), so let's add it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14800) Expose checkAndMutate via Thrift2
[
https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003278#comment-15003278
]
Hadoop QA commented on HBASE-14800:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12772050/HBASE-14800.001.patch
against master branch at commit 789f8a5a70242c16ce10bc95401c51c7d04debfa.
ATTACHMENT ID: 12772050
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1729 checkstyle errors (more than the master's current 1727 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+lastComparison =
Boolean.valueOf(isSetBloomFilterType()).compareTo(other.isSetBloomFilterType());
+lastComparison =
Boolean.valueOf(isSetBloomFilterVectorSize()).compareTo(other.isSetBloomFilterVectorSize());
+lastComparison =
Boolean.valueOf(isSetBloomFilterNbHashes()).compareTo(other.isSetBloomFilterNbHashes());
+lastComparison =
Boolean.valueOf(isSetBlockCacheEnabled()).compareTo(other.isSetBlockCacheEnabled());
+ public AsyncMethodCallback getResultHandler(final AsyncFrameBuffer
fb, final int seqid) {
+ public AsyncMethodCallback getResultHandler(final AsyncFrameBuffer
fb, final int seqid) {
+ public AsyncMethodCallback getResultHandler(final
AsyncFrameBuffer fb, final int seqid) {
+ public AsyncMethodCallback getResultHandler(final AsyncFrameBuffer
fb, final int seqid) {
+ public AsyncMethodCallback getResultHandler(final AsyncFrameBuffer
fb, final int seqid) {
+ public AsyncMethodCallback getResultHandler(final
AsyncFrameBuffer fb, final int seqid) {
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16500//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16500//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16500//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16500//console
This message is automatically generated.
> Expose checkAndMutate via Thrift2
> -
>
> Key: HBASE-14800
> URL: https://issues.apache.org/jira/browse/HBASE-14800
> Project: HBase
> Issue Type: Improvement
> Components: Thrift
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: 2.0.0
>
> Attachments: HBASE-14800.001.patch
>
>
> Had a user ask why checkAndMutate wasn't exposed via Thrift2.
> I see no good reason (since checkAndPut and checkAndDelete are already
> there), so let's add it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
