[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219066#comment-16219066
]
Hudson commented on HBASE-18160:
FAILURE: Integrated in Jenkins build HBase-2.0 #748 (See
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218759#comment-16218759
]
Hudson commented on HBASE-18160:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3948 (See
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198105#comment-16198105
]
Hudson commented on HBASE-18160:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3859 (See
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198089#comment-16198089
]
Hudson commented on HBASE-18160:
FAILURE: Integrated in Jenkins build HBase-2.0 #658 (See
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195087#comment-16195087
]
Hudson commented on HBASE-18160:
Results for branch HBASE-18467, done in 4 hr 24 min and counting
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186810#comment-16186810
]
Ted Yu commented on HBASE-18160:
Enjoy the holiday, Zheng and Duo.
> Fix incorrect logic in
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186797#comment-16186797
]
Duo Zhang commented on HBASE-18160:
---
The National Day of China is coming. We will have a long holiday
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186685#comment-16186685
]
Ted Yu commented on HBASE-18160:
Running with branch-1.3 patch, I got:
{code}
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184459#comment-16184459
]
Nick Dimiduk commented on HBASE-18160:
--
For a patch to hit 1.1, it must first pass muster on all
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182391#comment-16182391
]
Anoop Sam John commented on HBASE-18160:
Should go into branch-1
> Fix incorrect logic in
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182321#comment-16182321
]
Zheng Hu commented on HBASE-18160:
--
bq. U mean branch-1.0 ? If so, no. It is already EOL.
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182312#comment-16182312
]
Anoop Sam John commented on HBASE-18160:
bq.Should this patch go in branch-1
U mean branch-1.0 ?
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182304#comment-16182304
]
Zheng Hu commented on HBASE-18160:
--
[~busbey] , [~mantonov] Should this patch go in branch-1 &
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182273#comment-16182273
]
Duo Zhang commented on HBASE-18160:
---
Oh, no patch for branch-1? Should I use the patch for master?
>
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182271#comment-16182271
]
Duo Zhang commented on HBASE-18160:
---
Anyway let me commit the patch for branch-1.x...
> Fix incorrect
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180811#comment-16180811
]
Zheng Hu commented on HBASE-18160:
--
UT works fine under my local host, but always failed under Hadoop QA
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180466#comment-16180466
]
Hadoop QA commented on HBASE-18160:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180453#comment-16180453
]
Hudson commented on HBASE-18160:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3781 (See
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180432#comment-16180432
]
Hudson commented on HBASE-18160:
FAILURE: Integrated in Jenkins build HBase-2.0 #580 (See
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180190#comment-16180190
]
Duo Zhang commented on HBASE-18160:
---
Pushed to master and branch-2.
Wait for the pre commit result for
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179738#comment-16179738
]
Hadoop QA commented on HBASE-18160:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179399#comment-16179399
]
Hadoop QA commented on HBASE-18160:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178994#comment-16178994
]
Zheng Hu commented on HBASE-18160:
--
[~Apache9], [~anoop.hbase] Patches for branch-1.3 & branch-1.4 &
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178966#comment-16178966
]
Duo Zhang commented on HBASE-18160:
---
Seems [~anoopsamjohn] has already accepted the patch on RB. Will
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177974#comment-16177974
]
Hadoop QA commented on HBASE-18160:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174350#comment-16174350
]
Hadoop QA commented on HBASE-18160:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169593#comment-16169593
]
Hadoop QA commented on HBASE-18160:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165806#comment-16165806
]
Hadoop QA commented on HBASE-18160:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164585#comment-16164585
]
Hadoop QA commented on HBASE-18160:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164430#comment-16164430
]
Zheng Hu commented on HBASE-18160:
--
Previously, I'm a bit busy. Sorry for my delay .
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164418#comment-16164418
]
Zheng Hu commented on HBASE-18160:
--
Patch v4
1. optimize the filter list with MUST_PASS_ONE
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123479#comment-16123479
]
Zheng Hu commented on HBASE-18160:
--
Attached a localcode to returncode map for filter list with or:
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099755#comment-16099755
]
Zheng Hu commented on HBASE-18160:
--
Fine , Let me have a try. Thanks.
> Fix incorrect logic in
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099750#comment-16099750
]
Anoop Sam John commented on HBASE-18160:
Ya in that case it should be INCLUDE.
My point is make
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099725#comment-16099725
]
Zheng Hu commented on HBASE-18160:
--
bq. What if SKIP being other filter's return? We need to return
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099598#comment-16099598
]
Anoop Sam John commented on HBASE-18160:
Thanks for fixing the comments and sorry for the delay.
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099400#comment-16099400
]
Zheng Hu commented on HBASE-18160:
--
[~anoop.hbase] , [~allan163], Could you help to review the patch v3
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093450#comment-16093450
]
Hadoop QA commented on HBASE-18160:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093447#comment-16093447
]
Hadoop QA commented on HBASE-18160:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093143#comment-16093143
]
Zheng Hu commented on HBASE-18160:
--
[~anoop.hbase] I uploaded patch v3 for your suggestion.
> Fix
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093038#comment-16093038
]
Zheng Hu commented on HBASE-18160:
--
bq. I'm thinking of another optimization for filterlist with
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058805#comment-16058805
]
Anoop Sam John commented on HBASE-18160:
Another side note. Again not related but we should try
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058801#comment-16058801
]
Anoop Sam John commented on HBASE-18160:
Quick question
{code}
if (operator ==
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058782#comment-16058782
]
Allan Yang commented on HBASE-18160:
I'm thinking of another optimization for filterlist with
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058764#comment-16058764
]
Anoop Sam John commented on HBASE-18160:
Sorry for the delay. Checking it now.
> Fix incorrect
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056941#comment-16056941
]
Ted Yu commented on HBASE-18160:
I already gave +1 above.
> Fix incorrect logic in
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056901#comment-16056901
]
Zheng Hu commented on HBASE-18160:
--
Ping [~anoop.hbase], [~tedyu] again.Thanks.
> Fix incorrect
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048670#comment-16048670
]
Zheng Hu commented on HBASE-18160:
--
[~anoop.hbase], [~tedyu], Any concerns for the patch ?
> Fix
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044092#comment-16044092
]
Hadoop QA commented on HBASE-18160:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044015#comment-16044015
]
Hadoop QA commented on HBASE-18160:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043880#comment-16043880
]
Ted Yu commented on HBASE-18160:
lgtm
> Fix incorrect logic in FilterList.filterKeyValue
>
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043867#comment-16043867
]
Zheng Hu commented on HBASE-18160:
--
The failed/timeout UTs are unrelated to the patch.
> Fix incorrect
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043844#comment-16043844
]
Zheng Hu commented on HBASE-18160:
--
[~anoop.hbase], Could you help to review the patch v2 ? Thanks.
[
https://issues.apache.org/jira/browse/HBASE-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042615#comment-16042615
]
Hadoop QA commented on HBASE-18160:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
54 matches
Mail list logo
