[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371572#comment-16371572
]
Mike Drob commented on HBASE-19920:
---
subtask is fair. thanks, stack
> TokenUtil.obtainToken
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367988#comment-16367988
]
Hudson commented on HBASE-19920:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4596 (See
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366540#comment-16366540
]
Francis Liu commented on HBASE-19920:
-
Test looks good. +1 post QA issues. Thanks [~mdrob].
>
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366210#comment-16366210
]
Hadoop QA commented on HBASE-19920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366044#comment-16366044
]
Sean Busbey commented on HBASE-19920:
-
+1 pending QA feedback.
{code}
---
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366019#comment-16366019
]
Mike Drob commented on HBASE-19920:
---
v9 to address Sean's comments
> TokenUtil.obtainToken
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365980#comment-16365980
]
Mike Drob commented on HBASE-19920:
---
bq. my intuition is telling me that the two ProtobufUtils should
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365830#comment-16365830
]
Sean Busbey commented on HBASE-19920:
-
I like the move to the singleton holder idiom. I don't have a
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365766#comment-16365766
]
Sean Busbey commented on HBASE-19920:
-
oh it grabbed the first patch instead of v8. let me figure out
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365720#comment-16365720
]
Sean Busbey commented on HBASE-19920:
-
hurm. lemme see what smart-apply-patch did.
>
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365692#comment-16365692
]
Mike Drob commented on HBASE-19920:
---
You were looking at the wrong patch, boss.
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365624#comment-16365624
]
Sean Busbey commented on HBASE-19920:
-
I don't want to go down a rabbit hole with a late review, so
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361587#comment-16361587
]
Mike Drob commented on HBASE-19920:
---
Looking for a review please
> TokenUtil.obtainToken unnecessarily
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359248#comment-16359248
]
Mike Drob commented on HBASE-19920:
---
Not sure why it couldn't comment...
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357768#comment-16357768
]
Hadoop QA commented on HBASE-19920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357650#comment-16357650
]
Mike Drob commented on HBASE-19920:
---
Ugh. v7, try again with checkstyle.
> TokenUtil.obtainToken
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357509#comment-16357509
]
Hadoop QA commented on HBASE-19920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357270#comment-16357270
]
Mike Drob commented on HBASE-19920:
---
v6: checkstyle
> TokenUtil.obtainToken unnecessarily creates a
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356339#comment-16356339
]
Hadoop QA commented on HBASE-19920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356194#comment-16356194
]
Mike Drob commented on HBASE-19920:
---
I'm not very happy with this test because we're still only testing
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355931#comment-16355931
]
Francis Liu commented on HBASE-19920:
-
Skimmed the patch, the approach looks better. Tho don't we
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354653#comment-16354653
]
Mike Drob commented on HBASE-19920:
---
hadoopcheck issues have been failing on other issues and don't
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354565#comment-16354565
]
Hadoop QA commented on HBASE-19920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354530#comment-16354530
]
Mike Drob commented on HBASE-19920:
---
While trying to write good tests, I realized there's a much more
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353185#comment-16353185
]
Hadoop QA commented on HBASE-19920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353157#comment-16353157
]
Ted Yu commented on HBASE-19920:
Looks good overall.
{code}
+ * @return IOException wrapped in
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353065#comment-16353065
]
Mike Drob commented on HBASE-19920:
---
v3:
* import order
* test classrule
> TokenUtil.obtainToken
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353049#comment-16353049
]
Hadoop QA commented on HBASE-19920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352961#comment-16352961
]
Mike Drob commented on HBASE-19920:
---
v2:
* checkstyle
* javadoc
* add a unit test
* added fault
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352813#comment-16352813
]
Francis Liu commented on HBASE-19920:
-
{quote}I think I'm in strong agreement with this now. Let's
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352811#comment-16352811
]
Francis Liu commented on HBASE-19920:
-
{quote}
That said, clients using ProtobufUtil::toException,
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352783#comment-16352783
]
Mike Drob commented on HBASE-19920:
---
bq. Having said that the approach you've currently taken sounds
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352775#comment-16352775
]
Mike Drob commented on HBASE-19920:
---
Ah, I think I misunderstood your question earlier. It's a good
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352758#comment-16352758
]
Francis Liu commented on HBASE-19920:
-
{quote}Sure, they compile against CP in maven parlance as a
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352705#comment-16352705
]
Mike Drob commented on HBASE-19920:
---
Sure, they compile against CP in maven parlance as a "provided"
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352700#comment-16352700
]
Francis Liu commented on HBASE-19920:
-
{quote}This was my initial assessment, but when I chatted with
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352684#comment-16352684
]
Mike Drob commented on HBASE-19920:
---
{quote}In any case, it sounds reasonable to assume that if a
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351992#comment-16351992
]
Francis Liu commented on HBASE-19920:
-
[~mdrob] Rohini and I were talking about this last friday. As
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351430#comment-16351430
]
Ted Yu commented on HBASE-19920:
{code}
34 * @return Exception wrapped in ServiceException or
35
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351423#comment-16351423
]
Attila Sasvari commented on HBASE-19920:
[~mdrob] we were using 1.2.0 (cdh5-1.2.0_5.13).
>
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351414#comment-16351414
]
Mike Drob commented on HBASE-19920:
---
[~rohini] - what version of HBase were you using, so that we know
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351221#comment-16351221
]
Hadoop QA commented on HBASE-19920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351039#comment-16351039
]
Mike Drob commented on HBASE-19920:
---
Attaching a patch that makes an attempt at this.
>
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351012#comment-16351012
]
Rohini Palaniswamy commented on HBASE-19920:
There was no failure because of this. We just
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351005#comment-16351005
]
Mike Drob commented on HBASE-19920:
---
[~rohini] - thanks for clarifying, yep that makes perfect sense
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350991#comment-16350991
]
Rohini Palaniswamy commented on HBASE-19920:
bq. Do you want to submit a patch ?
No
>From my
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350943#comment-16350943
]
Mike Drob commented on HBASE-19920:
---
It looks like there are a couple of subtle things going on here.
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350662#comment-16350662
]
Ted Yu commented on HBASE-19920:
Rohini:
Do you want to submit a patch ?
> TokenUtil.obtainToken
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350623#comment-16350623
]
Mike Drob commented on HBASE-19920:
---
Ah, ok a few lines up there is the mkdir
> TokenUtil.obtainToken
[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350569#comment-16350569
]
Mike Drob commented on HBASE-19920:
---
I don't see any directory creation code there, can you be more
50 matches
Mail list logo
