[jira] [Commented] (HBASE-19974) Decommissioned servers cannot be removed by remove_servers_rsgroup methods

2018-02-25 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376380#comment-16376380
 ] 

Hadoop QA commented on HBASE-19974:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
36s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
28s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
17s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 3s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
45s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git 
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply 
{color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
31s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
16m 49s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
24s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
11s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 36m 14s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db |
| JIRA Issue | HBASE-19974 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911980/HBASE-19974.branch-2.005.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 905ee398eca9 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | branch-2 / 10270e36c9 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC3 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11671/artifact/patchprocess/whitespace-eol.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11671/testReport/ |
| Max. process+thread count | 1842 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
|

[jira] [Commented] (HBASE-19974) Decommissioned servers cannot be removed by remove_servers_rsgroup methods

2018-02-25 Thread Guanghao Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376329#comment-16376329
 ] 

Guanghao Zhang commented on HBASE-19974:


You can upload the patch again to trigger HADOOP QA.

> Decommissioned servers cannot be removed by remove_servers_rsgroup methods
> --
>
> Key: HBASE-19974
> URL: https://issues.apache.org/jira/browse/HBASE-19974
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-19974.branch-2.001.patch, 
> HBASE-19974.branch-2.002.patch, HBASE-19974.branch-2.003.patch, 
> HBASE-19974.branch-2.004.patch
>
>
> When remove servers from a rsgroup, it will check the server is not online or 
> dead. But when we decommision a server, the server will be both in online 
> list and drainning list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-19974) Decommissioned servers cannot be removed by remove_servers_rsgroup methods

2018-02-23 Thread Xiaolin Ha (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375183#comment-16375183
 ] 

Xiaolin Ha commented on HBASE-19974:


[~hadoopqa] timeout is chance, please run once more.

> Decommissioned servers cannot be removed by remove_servers_rsgroup methods
> --
>
> Key: HBASE-19974
> URL: https://issues.apache.org/jira/browse/HBASE-19974
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-19974.branch-2.001.patch, 
> HBASE-19974.branch-2.002.patch, HBASE-19974.branch-2.003.patch, 
> HBASE-19974.branch-2.004.patch
>
>
> When remove servers from a rsgroup, it will check the server is not online or 
> dead. But when we decommision a server, the server will be both in online 
> list and drainning list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-19974) Decommissioned servers cannot be removed by remove_servers_rsgroup methods

2018-02-23 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374276#comment-16374276
 ] 

Hadoop QA commented on HBASE-19974:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 6s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
20s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
59s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 1s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
14m 55s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 14s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
19s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 47m 14s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestRSGroups |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db |
| JIRA Issue | HBASE-19974 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12911707/HBASE-19974.branch-2.004.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 54454be2addb 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | branch-2 / 4ddfdaffdc |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11635/artifact/patchprocess/patch-unit-hbase-rsgroup.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11635/testReport/ |
| Max. process+thread count | 2727 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11635/console |
| Powered by | Apache Yetus 0.7.0

[jira] [Commented] (HBASE-19974) Decommissioned servers cannot be removed by remove_servers_rsgroup methods

2018-02-23 Thread Xiaolin Ha (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374224#comment-16374224
 ] 

Xiaolin Ha commented on HBASE-19974:


Fixed older UT error. And made some change in the added UT codes.

> Decommissioned servers cannot be removed by remove_servers_rsgroup methods
> --
>
> Key: HBASE-19974
> URL: https://issues.apache.org/jira/browse/HBASE-19974
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-19974.branch-2.001.patch, 
> HBASE-19974.branch-2.002.patch, HBASE-19974.branch-2.003.patch, 
> HBASE-19974.branch-2.004.patch
>
>
> When remove servers from a rsgroup, it will check the server is not online or 
> dead. But when we decommision a server, the server will be both in online 
> list and drainning list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-19974) Decommissioned servers cannot be removed by remove_servers_rsgroup methods

2018-02-23 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374180#comment-16374180
 ] 

Ted Yu commented on HBASE-19974:


Looks good overall.
{code}
+  // Only online but not decommissioned servers is real online
{code}
servers is real online -> servers are really online
{code}
+List toDecommissionServers = new ArrayList<>();
{code}
toDecommissionServers -> serversToDecommission

See if there is better way than sleeping for a second (probably not).

> Decommissioned servers cannot be removed by remove_servers_rsgroup methods
> --
>
> Key: HBASE-19974
> URL: https://issues.apache.org/jira/browse/HBASE-19974
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-19974.branch-2.001.patch, 
> HBASE-19974.branch-2.002.patch, HBASE-19974.branch-2.003.patch
>
>
> When remove servers from a rsgroup, it will check the server is not online or 
> dead. But when we decommision a server, the server will be both in online 
> list and drainning list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)