[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643424#comment-16643424 ] Hudson commented on HBASE-20764: Results for branch master [build #533 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/533/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/533//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/533//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/533//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.1, 2.0.3 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > This issue happens if somebody has {{log.showsignature=true}} in their local > gitconfig. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643215#comment-16643215 ] Hudson commented on HBASE-20764: Results for branch branch-2.1 [build #437 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/437/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/437//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/437//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/437//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.1, 2.0.3 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > This issue happens if somebody has {{log.showsignature=true}} in their local > gitconfig. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643166#comment-16643166 ] Hudson commented on HBASE-20764: Results for branch branch-2 [build #1361 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1361/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1361//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1361//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1361//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.1, 2.0.3 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > This issue happens if somebody has {{log.showsignature=true}} in their local > gitconfig. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643117#comment-16643117 ] Hudson commented on HBASE-20764: Results for branch branch-2.0 [build #924 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/924/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/924//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/924//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/924//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.1, 2.0.3 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > This issue happens if somebody has {{log.showsignature=true}} in their local > gitconfig. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643104#comment-16643104 ] Hudson commented on HBASE-20764: Results for branch branch-1 [build #497 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/497/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/497//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/497//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/497//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.1, 2.0.3 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > This issue happens if somebody has {{log.showsignature=true}} in their local > gitconfig. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642654#comment-16642654 ] Mike Drob commented on HBASE-20764: --- Nobody is actively maintaining our python code, so I'm sure suboptimal styles have crept in over the years. Thanks for reviewing, pushed to branch-1, branch-2* and master > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Critical > Fix For: 3.0.0, 1.5.0, 2.2.0, 2.1.1, 2.0.3 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > This issue happens if somebody has {{log.showsignature=true}} in their local > gitconfig. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642530#comment-16642530 ] Andrew Purtell commented on HBASE-20764: +1 The pylint warnings are not due to this change but does something need to be updated? > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Critical > Fix For: 3.0.0 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > This issue happens if somebody has {{log.showsignature=true}} in their local > gitconfig. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640412#comment-16640412 ] Hadoop QA commented on HBASE-20764: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 32s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 0s{color} | {color:blue} Shelldocs was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 22s{color} | {color:blue} Maven dependency ordering for branch {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} pylint {color} | {color:red} 0m 5s{color} | {color:red} The patch generated 17 new + 8 unchanged - 17 fixed = 25 total (was 25) {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 0s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 38s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 3m 7s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-20764 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12928777/HBASE-20764.master.002.patch | | Optional Tests | dupname asflicense pylint shellcheck shelldocs | | uname | Linux 4d9fb122de29 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10 07:31:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / e42741e085 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | shellcheck | v0.4.4 | | pylint | v1.6.5 | | pylint | https://builds.apache.org/job/PreCommit-HBASE-Build/14582/artifact/patchprocess/diff-patch-pylint.txt | | Max. process+thread count | 52 (vs. ulimit of 1) | | modules | C: hbase-common . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/14582/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Critical > Fix For: 3.0.0 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > This issue happens if somebody has {{log.showsignature=true}} in their local > gitconfig. > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR]
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640364#comment-16640364 ] Mike Drob commented on HBASE-20764: --- [~apurtell], since you're pushing signed commits now, can you take a look? > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Critical > Fix For: 3.0.0 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > I broke the build by digitally signing a commit: > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535319#comment-16535319 ] Mike Drob commented on HBASE-20764: --- second request for reviews, please. > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Critical > Fix For: 3.0.0 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > I broke the build by digitally signing a commit: > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527069#comment-16527069 ] Mike Drob commented on HBASE-20764: --- anybody able to do reviews here? > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Critical > Fix For: 3.0.0 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > I broke the build by digitally signing a commit: > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520642#comment-16520642 ] Mike Drob commented on HBASE-20764: --- pylint issues are because the same lines got moved up, so the line numbers don't match. Not a result of this patch. > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > I broke the build by digitally signing a commit: > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520465#comment-16520465 ] Hadoop QA commented on HBASE-20764: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 9s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 2s{color} | {color:blue} Shelldocs was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for branch {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} pylint {color} | {color:red} 0m 4s{color} | {color:red} The patch generated 17 new + 8 unchanged - 17 fixed = 25 total (was 25) {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 2s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 1m 10s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-20764 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12928777/HBASE-20764.master.002.patch | | Optional Tests | asflicense pylint shellcheck shelldocs | | uname | Linux 2dfddbe7644e 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 14087cc919 | | maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) | | shellcheck | v0.4.4 | | pylint | v1.6.5 | | pylint | https://builds.apache.org/job/PreCommit-HBASE-Build/13351/artifact/patchprocess/diff-patch-pylint.txt | | Max. process+thread count | 44 (vs. ulimit of 1) | | modules | C: hbase-common . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/13351/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > I broke the build by digitally signing a commit: > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/tar
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520460#comment-16520460 ] Mike Drob commented on HBASE-20764: --- v3: fix one more RB related issue > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HBASE-20764.master.001.patch, > HBASE-20764.master.002.patch, HBASE-20764.patch > > > I broke the build by digitally signing a commit: > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519004#comment-16519004 ] Hadoop QA commented on HBASE-20764: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 4s{color} | {color:blue} Shelldocs was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 23s{color} | {color:blue} Maven dependency ordering for branch {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} pylint {color} | {color:red} 0m 6s{color} | {color:red} The patch generated 17 new + 8 unchanged - 17 fixed = 25 total (was 25) {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 0s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 21s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 1m 32s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-20764 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12928583/HBASE-20764.master.001.patch | | Optional Tests | asflicense pylint shellcheck shelldocs | | uname | Linux cc36d3620d48 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | master / 72784c2d83 | | maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) | | shellcheck | v0.4.4 | | pylint | v1.6.5 | | pylint | https://builds.apache.org/job/PreCommit-HBASE-Build/13327/artifact/patchprocess/diff-patch-pylint.txt | | Max. process+thread count | 45 (vs. ulimit of 1) | | modules | C: hbase-common . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/13327/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HBASE-20764.master.001.patch, HBASE-20764.patch > > > I broke the build by digitally signing a commit: > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518714#comment-16518714 ] Mike Drob commented on HBASE-20764: --- Realized that this _might_ be due to my gitconfig including: {noformat} [log] showSignature = true {noformat} > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HBASE-20764.patch > > > I broke the build by digitally signing a commit: > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518678#comment-16518678 ] Mike Drob commented on HBASE-20764: --- bq. so to test this I'll need the change and a signed commit, anything else? You could do something like {{curl https://issues.apache.org/jira/secure/attachment/12928542/HBASE-20764.patch | git am -S --signoff}} and that should let you test it. > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HBASE-20764.patch > > > I broke the build by digitally signing a commit: > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518677#comment-16518677 ] Mike Drob commented on HBASE-20764: --- submit-patch is also broken in a similar way, may fix it here or file a follow on > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HBASE-20764.patch > > > I broke the build by digitally signing a commit: > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20764) build broken when latest commit is gpg signed
[ https://issues.apache.org/jira/browse/HBASE-20764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518675#comment-16518675 ] Sean Busbey commented on HBASE-20764: - so to test this I'll need the change and a signed commit, anything else? > build broken when latest commit is gpg signed > - > > Key: HBASE-20764 > URL: https://issues.apache.org/jira/browse/HBASE-20764 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HBASE-20764.patch > > > I broke the build by digitally signing a commit: > {noformat} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile > (default-compile) on project hbase-common: Compilation failure: Compilation > failure: > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[11,41] > unclosed string literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,4] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,30] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[12,35] > malformed floating point literal > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,4] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,20] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,25] > expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,76] > illegal start of type > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[13,85] > ';' expected > [ERROR] > /Users/mdrob/IdeaProjects/hbase/hbase-common/target/generated-sources/java/org/apache/hadoop/hbase/Version.java:[14,41] > unclosed string literal > {noformat} > Which complains because: > {code} > public static final String revision = "gpg: Signature made Wed Jun 20 > 09:42:38 2018 PDT > gpg:using RSA key 86EDB9C33B8517228E88A8F93E48C0C6EF362B9E > gpg: Good signature from "Mike Drob (CODE SIGNING KEY) " > [ultimate] > d1cad1a25432ffcd75cd654e9bf68233ca7e1957"; > {code} > And this comes from {{src/saveVersion.sh}} where it does: > {noformat} > revision=`git log -1 --pretty=format:"%H"` > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)