[jira] [Commented] (HBASE-5903) Detect the test classes without categories
[ https://issues.apache.org/jira/browse/HBASE-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13264974#comment-13264974 ] Hadoop QA commented on HBASE-5903: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525071/5903.v3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestAssignmentManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1691//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1691//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1691//console This message is automatically generated. Detect the test classes without categories -- Key: HBASE-5903 URL: https://issues.apache.org/jira/browse/HBASE-5903 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Minor Fix For: 0.96.0 Attachments: 5903.v3.patch The tests are executed by category. When a test does not have a category, it's not run on prebuild nor central build. This new test checks the test classess and list the ones without category. It fails if it finds one. As it's a small test it will be executed on the developper machine and will fail immediately on the central builds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5903) Detect the test classes without categories
[ https://issues.apache.org/jira/browse/HBASE-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13264978#comment-13264978 ] nkeywal commented on HBASE-5903: Considering the actual patch, we can just consider TestAssignmentManager as a little bit flaky ;-) Detect the test classes without categories -- Key: HBASE-5903 URL: https://issues.apache.org/jira/browse/HBASE-5903 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Minor Fix For: 0.96.0 Attachments: 5903.v3.patch The tests are executed by category. When a test does not have a category, it's not run on prebuild nor central build. This new test checks the test classess and list the ones without category. It fails if it finds one. As it's a small test it will be executed on the developper machine and will fail immediately on the central builds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5903) Detect the test classes without categories
[
https://issues.apache.org/jira/browse/HBASE-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13264988#comment-13264988
]
Zhihong Yu commented on HBASE-5903:
---
Minor comments:
{code}
+/**
+ * Copyright 2012 The Apache Software Foundation
{code}
Year is not needed.
{code}
+ListClass? badClasses = new java.util.ArrayListClass?();
{code}
ArrayList is imported already.
{code}
+ private boolean existCategoryAnnotation(Class? c) {
{code}
Should the above method be named 'hasCategoryAnnotation()' ?
Detect the test classes without categories
--
Key: HBASE-5903
URL: https://issues.apache.org/jira/browse/HBASE-5903
Project: HBase
Issue Type: Improvement
Components: build, test
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
Fix For: 0.96.0
Attachments: 5903.v3.patch
The tests are executed by category. When a test does not have a category,
it's not run on prebuild nor central build.
This new test checks the test classess and list the ones without category. It
fails if it finds one. As it's a small test it will be executed on the
developper machine and will fail immediately on the central builds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5903) Detect the test classes without categories
[ https://issues.apache.org/jira/browse/HBASE-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13264991#comment-13264991 ] Hadoop QA commented on HBASE-5903: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525075/5903v4.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1692//console This message is automatically generated. Detect the test classes without categories -- Key: HBASE-5903 URL: https://issues.apache.org/jira/browse/HBASE-5903 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Minor Fix For: 0.96.0 Attachments: 5903.v3.patch, 5903v4.txt The tests are executed by category. When a test does not have a category, it's not run on prebuild nor central build. This new test checks the test classess and list the ones without category. It fails if it finds one. As it's a small test it will be executed on the developper machine and will fail immediately on the central builds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5903) Detect the test classes without categories
[ https://issues.apache.org/jira/browse/HBASE-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13265023#comment-13265023 ] Hudson commented on HBASE-5903: --- Integrated in HBase-TRUNK #2826 (See [https://builds.apache.org/job/HBase-TRUNK/2826/]) HBASE-5903 Detect the test classes without categories (Revision 1332260) Result = SUCCESS stack : Files : * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java Detect the test classes without categories -- Key: HBASE-5903 URL: https://issues.apache.org/jira/browse/HBASE-5903 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Minor Fix For: 0.96.0 Attachments: 5903.v3.patch, 5903v4.txt The tests are executed by category. When a test does not have a category, it's not run on prebuild nor central build. This new test checks the test classess and list the ones without category. It fails if it finds one. As it's a small test it will be executed on the developper machine and will fail immediately on the central builds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5903) Detect the test classes without categories
[ https://issues.apache.org/jira/browse/HBASE-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13265670#comment-13265670 ] Hudson commented on HBASE-5903: --- Integrated in HBase-TRUNK-security #188 (See [https://builds.apache.org/job/HBase-TRUNK-security/188/]) HBASE-5903 Detect the test classes without categories (Revision 1332260) Result = FAILURE stack : Files : * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java Detect the test classes without categories -- Key: HBASE-5903 URL: https://issues.apache.org/jira/browse/HBASE-5903 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.96.0 Reporter: nkeywal Assignee: nkeywal Priority: Minor Fix For: 0.96.0 Attachments: 5903.v3.patch, 5903v4.txt The tests are executed by category. When a test does not have a category, it's not run on prebuild nor central build. This new test checks the test classess and list the ones without category. It fails if it finds one. As it's a small test it will be executed on the developper machine and will fail immediately on the central builds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
