[GitHub] [hbase] ndimiduk commented on pull request #3349: HBASE-25966 Fix typo in NOTICE.vm

2021-06-23 Thread GitBox
ndimiduk commented on pull request #3349: URL: https://github.com/apache/hbase/pull/3349#issuecomment-866978311 > Let's get this in? @ndimiduk Yes, I suppose this doesn't make things worse. It sounds like we need further fixes in this area, and some kind of test that the notice

[GitHub] [hbase] ndimiduk commented on pull request #3349: HBASE-25966 Fix typo in NOTICE.vm

2021-06-04 Thread GitBox
ndimiduk commented on pull request #3349: URL: https://github.com/apache/hbase/pull/3349#issuecomment-853413908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [hbase] ndimiduk commented on pull request #3349: HBASE-25966 Fix typo in NOTICE.vm

2021-06-02 Thread GitBox
ndimiduk commented on pull request #3349: URL: https://github.com/apache/hbase/pull/3349#issuecomment-853416924 Trying to interpret this output. I think our build is configured such that the only module that bundles bootstrap is hbase-server. However, I think we also bundle it in

[GitHub] [hbase] ndimiduk commented on pull request #3349: HBASE-25966 Fix typo in NOTICE.vm

2021-06-02 Thread GitBox
ndimiduk commented on pull request #3349: URL: https://github.com/apache/hbase/pull/3349#issuecomment-853413908 Perhaps one of you can suggest how to verify that the license content is being included in the appropriate places after this change -- what those places are and whether it