[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-05-06 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r421202699 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/OffPeakHours.java ## @@ -87,6 +87,7 @@ private static boolean

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-05-06 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r420827744 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/CompactionThroughputControllerFactory.java ## @@ -47,24 +53,35 @@

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-05-02 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r418959287 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/CompactionThroughputControllerFactory.java ## @@ -33,10 +36,16 @@

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-30 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r417789507 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java ## @@ -742,12 +744,27 @@ public void

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415518856 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415508930 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415509197 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415508804 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415508804 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415508930 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -998,24 +998,6 @@ possible configurations would overwhelm and obscure the

[GitHub] [hbase] ystaticy commented on a change in pull request #1588: HBASE-24262 Improvement update_config for PressureAwareCompactionThroughputController

2020-04-26 Thread GitBox
ystaticy commented on a change in pull request #1588: URL: https://github.com/apache/hbase/pull/1588#discussion_r415497027 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/throttle/TestDynamicConfWithThroughputController.java ## @@ -0,0 +1,233 @@