[GitHub] [hbase-filesystem] wchevreuil commented on a change in pull request #9: HBASE-23099 - [HBOSS] Raise hadoop dependency version to 3.2.1
wchevreuil commented on a change in pull request #9: HBASE-23099 - [HBOSS]
Raise hadoop dependency version to 3.2.1
URL: https://github.com/apache/hbase-filesystem/pull/9#discussion_r330048363
##
File path:
hbase-oss/src/test/java/org/apache/hadoop/hbase/oss/contract/TestHBOSSContractOpen.java
##
@@ -31,6 +33,14 @@ protected Configuration createConfiguration() {
@Override
protected AbstractFSContract createContract(Configuration conf) {
-return new HBOSSContract(conf);
+HBOSSContract contract = new HBOSSContract(conf);
+try {
+ TestUtils.getFileSystem(conf);
+} catch (Exception e) {
+ e.printStackTrace();
Review comment:
Removed within the overall refactoring, but noticed this is spread around
other points in hboss tests. Might need an additional jira for cleaning this
out.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-filesystem] wchevreuil commented on a change in pull request #9: HBASE-23099 - [HBOSS] Raise hadoop dependency version to 3.2.1
wchevreuil commented on a change in pull request #9: HBASE-23099 - [HBOSS]
Raise hadoop dependency version to 3.2.1
URL: https://github.com/apache/hbase-filesystem/pull/9#discussion_r330047897
##
File path:
hbase-oss/src/test/java/org/apache/hadoop/hbase/oss/contract/TestHBOSSContractRootDirectory.java
##
@@ -34,6 +36,14 @@ protected Configuration createConfiguration() {
@Override
protected AbstractFSContract createContract(Configuration conf) {
-return new HBOSSContract(conf);
+HBOSSContract contract = new HBOSSContract(conf);
+try {
+ TestUtils.getFileSystem(conf);
+} catch (Exception e) {
+ e.printStackTrace();
+ fail("Exception configuring FS: " + e);
Review comment:
Right, moved this logic to a new method in TestUtils that's then called on
S3A specific contract tests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-filesystem] wchevreuil commented on a change in pull request #9: HBASE-23099 - [HBOSS] Raise hadoop dependency version to 3.2.1
wchevreuil commented on a change in pull request #9: HBASE-23099 - [HBOSS]
Raise hadoop dependency version to 3.2.1
URL: https://github.com/apache/hbase-filesystem/pull/9#discussion_r330006697
##
File path:
hbase-oss/src/test/java/org/apache/hadoop/hbase/oss/contract/TestHBOSSContractRootDirectory.java
##
@@ -34,6 +36,14 @@ protected Configuration createConfiguration() {
@Override
protected AbstractFSContract createContract(Configuration conf) {
-return new HBOSSContract(conf);
+HBOSSContract contract = new HBOSSContract(conf);
+try {
+ TestUtils.getFileSystem(conf);
+} catch (Exception e) {
+ e.printStackTrace();
+ fail("Exception configuring FS: " + e);
Review comment:
Maybe make _TestUtils.getFileSystem(conf)_ throw _AssertionError_, since
it's a basic test requirement? That would simplify this check for the subset of
tests requiring it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-filesystem] wchevreuil commented on a change in pull request #9: HBASE-23099 - [HBOSS] Raise hadoop dependency version to 3.2.1
wchevreuil commented on a change in pull request #9: HBASE-23099 - [HBOSS]
Raise hadoop dependency version to 3.2.1
URL: https://github.com/apache/hbase-filesystem/pull/9#discussion_r330006697
##
File path:
hbase-oss/src/test/java/org/apache/hadoop/hbase/oss/contract/TestHBOSSContractRootDirectory.java
##
@@ -34,6 +36,14 @@ protected Configuration createConfiguration() {
@Override
protected AbstractFSContract createContract(Configuration conf) {
-return new HBOSSContract(conf);
+HBOSSContract contract = new HBOSSContract(conf);
+try {
+ TestUtils.getFileSystem(conf);
+} catch (Exception e) {
+ e.printStackTrace();
+ fail("Exception configuring FS: " + e);
Review comment:
Maybe make _TestUtils.getFileSystem(conf);_ throw _AssertionError_, since
it's a basic test requirement? That would simplify this check for the subset of
tests requiring it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
