Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2116939444 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2116873570 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

apurtell merged PR #5545: URL: https://github.com/apache/hbase/pull/5545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2116540777 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1604284847 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileWriter.java: ## @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2116510269 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

virajjasani commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1604229161 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileWriter.java: ## @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

virajjasani commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1604229161 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileWriter.java: ## @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2115317652 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2115235512 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2115125977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114510060 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114088475 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114088119 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114088089 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114087829 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1602580409 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java: ## @@ -50,15 +50,15 @@ public interface StoreFileManager { */

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965661 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965652 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965649 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2113965547 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1602564157 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java: ## @@ -50,15 +50,15 @@ public interface StoreFileManager { */

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1602560727 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -48,17 +52,38 @@ class DefaultStoreFileManager implements

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1601087841 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -48,17 +52,38 @@ class DefaultStoreFileManager implements

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

apurtell commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2111577285 @Apache9 I think there was only one issue considered a blocker and @kadirozde has addressed it. There are three failing tests in the precommit but all are related to quotas so are

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2088988994 @Apache9, would you please review the latest commit and let me know if you have more comments for this PR? I also updated the design doc to reflect the changes based on your review

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2075973876 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2075919947 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2075904068 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2075520201 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2074180292 > There is only one blocker, about the concurrency control. We'd better still hold the consistent view while getting storefile list. > > The other is not a blocker but still better

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2074177990 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2074177955 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2074177958 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2074177864 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1577321980 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -86,13 +111,20 @@ public Collection getCompactedfiles() { }

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1577320047 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java: ## @@ -50,15 +50,15 @@ public interface StoreFileManager { */

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1577104587 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java: ## @@ -50,15 +50,15 @@ public interface StoreFileManager { */

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1577103908 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -86,13 +111,20 @@ public Collection getCompactedfiles() { }

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2073830963 Ah, sorry, forgot this one... Will take a look soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

bbeaudreault commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2073825447 @Apache9 Can you respond here? I think we should move towards merging this, @kadirozde has been very accommodating. I also want to make sure you're happy with it, since your

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2067815560 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2067813556 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2067809359 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2067761930 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1559993483 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -86,13 +111,20 @@ public Collection getCompactedfiles() { }

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2048360084 > For me the only big problem is how to deal with the updating of store file list. Please check my response on this. If you still want me to add a lock to protect the store file

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1559993483 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -86,13 +111,20 @@ public Collection getCompactedfiles() { }

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1559993483 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -86,13 +111,20 @@ public Collection getCompactedfiles() { }

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1558971974 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -256,156 +234,571 @@ public void appendMobMetadata(SetMultimap mobRefSet)

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1558965605 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -256,156 +234,571 @@ public void appendMobMetadata(SetMultimap mobRefSet)

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1558961072 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -181,7 +197,10 @@ public long getPos() throws IOException { */

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1558933042 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreFile.java: ## @@ -138,6 +140,12 @@ public class HStoreFile implements StoreFile { //

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1558933426 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java: ## @@ -50,15 +50,15 @@ public interface StoreFileManager { */

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1558932155 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -86,13 +111,20 @@ public Collection getCompactedfiles() { }

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1558928060 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java: ## @@ -464,7 +464,6 @@ protected boolean performCompaction(FileDetails fd,

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2045810903 @Apache9, @bbeaudreault, @virajjasani, @apurtell, please let me know if there is any review item left to be addressed. From my perspective, I have addressed all review comments. Thanks!

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545925927 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -247,7 +222,10 @@ public void appendMetadata(final long maxSequenceId,

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545925927 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -247,7 +222,10 @@ public void appendMetadata(final long maxSequenceId,

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2028948735 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2028942924 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2028937969 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

bbeaudreault commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545796726 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -86,13 +111,20 @@ public Collection getCompactedfiles() {

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

bbeaudreault commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545798434 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -247,7 +222,10 @@ public void appendMetadata(final long

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

bbeaudreault commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545796726 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -86,13 +111,20 @@ public Collection getCompactedfiles() {

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2028883478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 34s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545770119 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -247,7 +222,10 @@ public void appendMetadata(final long maxSequenceId,

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545755759 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -256,156 +234,571 @@ public void appendMobMetadata(SetMultimap

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545755759 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -256,156 +234,571 @@ public void appendMobMetadata(SetMultimap

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545554451 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -105,72 +132,44 @@ public class StoreFileWriter implements CellSink,

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545554196 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -247,7 +222,10 @@ public void appendMetadata(final long maxSequenceId,

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2028493399 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2028489821 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2028486055 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2028445194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545470519 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -256,156 +234,571 @@ public void appendMobMetadata(SetMultimap

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545469228 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -256,156 +234,571 @@ public void appendMobMetadata(SetMultimap

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545467925 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -247,7 +222,10 @@ public void appendMetadata(final long maxSequenceId,

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545467547 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -235,10 +210,10 @@ private byte[]

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545467119 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -105,72 +132,44 @@ public class StoreFileWriter implements CellSink,

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545464762 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreFile.java: ## @@ -138,6 +140,12 @@ public class HStoreFile implements StoreFile { //

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545462036 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java: ## @@ -86,13 +111,20 @@ public Collection getCompactedfiles() { }

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache9 commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1545362732 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java: ## @@ -105,72 +132,44 @@ public class StoreFileWriter implements CellSink,

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2001897341 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2001894215 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2001888007 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2001502697 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2001352366 Added tests for new version behavior and found a bug in HBase and create the [jira](https://issues.apache.org/jira/browse/HBASE-28442) for that. One of the tests fails because of this

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2000699516 > @kadirozde i just verified with HBase 2.6 (branch-2) that the flush writes only maxVersions versions to the new HFile. Hence, if the max version is 1, and if we write 2 versions of the

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

virajjasani commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2000651680 > i just verified with HBase 2.6 (branch-2) that the flush writes only maxVersions versions to the new HFile. Btw this also means that raw scan (that reads all versions) can have

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

virajjasani commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2000634670 > @Apache9, @virajjasani, @bbeaudreault , This PR is not done yet. I just realized that I need to add testing for newVersionBehavior. > > Also, I need to discuss the following

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2000602763 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2000584582 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

virajjasani commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2000579921 > Assume that for a given cell, two versions inserted and max versions is set to 1. If memory compaction is not enabled then I expect that both versions will be written to a new hfile

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2000576912 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2000437590 @Apache9, @virajjasani, @bbeaudreault , This PR is not done yet. I just realized that I need to add testing for newVersionBehavior. Also, I need to discuss the following case:

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2000243609 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2000166912 @bbeaudreault, @virajjasani, I updated the PR such that the historical files will be generated only with default store engine and default compactor. In other cases, historical files will

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

virajjasani commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-213796 I can also re-review the PR since my last review is now stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-209812 > @Apache9 @kadirozde How close is this to ready? I think I'm reading to cut the first RC0 of 2.6.0 on Monday, but this might be a nice addition to the release. We've delayed 2.6.0 for a

  1   2   >