[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993583#comment-13993583
]
Ted Yu commented on HBASE-10965:
w.r.t. complexity, patch v7 creates FilterUtil class for
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996838#comment-13996838
]
Ted Yu commented on HBASE-10965:
From Filter.java in 0.96 :
{code}
* Interface for row
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996049#comment-13996049
]
ramkrishna.s.vasudevan commented on HBASE-10965:
{code}
+ Class?
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996106#comment-13996106
]
Lars Hofhansl commented on HBASE-10965:
---
-0 on this change. Just seems to add
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996265#comment-13996265
]
Anoop Sam John commented on HBASE-10965:
My concern also same. We have to rely on
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996819#comment-13996819
]
Ted Yu commented on HBASE-10965:
In 0.94, Filter is an interface.
This means user filters
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989175#comment-13989175
]
Hadoop QA commented on HBASE-10965:
---
{color:green}+1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988837#comment-13988837
]
Ted Yu commented on HBASE-10965:
I ran test suite on Linux. There were 3 test failures:
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988406#comment-13988406
]
Ted Yu commented on HBASE-10965:
From
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13985161#comment-13985161
]
Ted Yu commented on HBASE-10965:
Toward the tail of HBASE-11093, Anoop makes a case that
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13971541#comment-13971541
]
stack commented on HBASE-10965:
---
bq. Accommodating brokenly implemented filters is already
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13971563#comment-13971563
]
Ted Yu commented on HBASE-10965:
bq. file a bug with pheonix that they've failed to
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969266#comment-13969266
]
Anoop Sam John commented on HBASE-10965:
In initial time of 94 , I remember that
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969457#comment-13969457
]
ramkrishna.s.vasudevan commented on HBASE-10965:
bq.This will be
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969760#comment-13969760
]
Ted Yu commented on HBASE-10965:
bq. You would change how we run filters to accommodate
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969773#comment-13969773
]
Ted Yu commented on HBASE-10965:
Another downside to purely depending on hasFilterRow()
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968349#comment-13968349
]
Anoop Sam John commented on HBASE-10965:
{code}
+if (hasFilterRow == null) {
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967425#comment-13967425
]
ramkrishna.s.vasudevan commented on HBASE-10965:
Will check this later so
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967579#comment-13967579
]
Hadoop QA commented on HBASE-10965:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967677#comment-13967677
]
stack commented on HBASE-10965:
---
bq. There is potential inconsistency between the return
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967692#comment-13967692
]
Hadoop QA commented on HBASE-10965:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967693#comment-13967693
]
Lars Hofhansl commented on HBASE-10965:
---
Is this right?
{code}
- if
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967201#comment-13967201
]
Ted Yu commented on HBASE-10965:
For Phoenix, I did the following:
apply patch to 0.98
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967306#comment-13967306
]
Ted Yu commented on HBASE-10965:
TestMultiParallel fails on QA bot.
But it doesn't use
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967315#comment-13967315
]
Hadoop QA commented on HBASE-10965:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967380#comment-13967380
]
Anoop Sam John commented on HBASE-10965:
We need similar change here also.
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967387#comment-13967387
]
Ted Yu commented on HBASE-10965:
The filter referenced in above code is of FilterWrapper
[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967398#comment-13967398
]
Hadoop QA commented on HBASE-10965:
---
{color:red}-1 overall{color}. Here are the
28 matches
Mail list logo
