[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common module
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244056#comment-14244056 ] Gaurav Menghani commented on HBASE-12650: - [~tedyu] Awesome! Can you please apply this on the feature branch as well? Move ServerName to hbase-common module -- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Ted Yu Priority: Blocker Fix For: 2.0.0 Attachments: 12650-v1.txt, 12650-v2.txt, 12650-v3.txt, 12650-v4.txt The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common module
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244160#comment-14244160 ] Ted Yu commented on HBASE-12650: Am in Beijing now where access to internet is slow. Let me try. Move ServerName to hbase-common module -- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Ted Yu Priority: Blocker Fix For: 2.0.0 Attachments: 12650-v1.txt, 12650-v2.txt, 12650-v3.txt, 12650-v4.txt The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common module
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237940#comment-14237940 ] Hudson commented on HBASE-12650: FAILURE: Integrated in HBase-TRUNK #5885 (See [https://builds.apache.org/job/HBase-TRUNK/5885/]) HBASE-12650 Move ServerName to hbase-common module (tedyu: rev 11864c60c721400bfca260143e9c92273893bd3b) * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufMagic.java * hbase-common/src/main/java/org/apache/hadoop/hbase/ServerName.java * hbase-common/src/main/java/org/apache/hadoop/hbase/exceptions/HBaseException.java * hbase-common/src/main/java/org/apache/hadoop/hbase/exceptions/DeserializationException.java HBASE-12650 Move ServerName to hbase-common module - remove files (tedyu: rev e930510c65fcda1251ffaf509f4e41f188361a9e) * hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/HBaseException.java * hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/DeserializationException.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java Move ServerName to hbase-common module -- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Ted Yu Priority: Blocker Fix For: 2.0.0 Attachments: 12650-v1.txt, 12650-v2.txt, 12650-v3.txt, 12650-v4.txt The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common module
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238057#comment-14238057 ] Hudson commented on HBASE-12650: SUCCESS: Integrated in HBase-TRUNK #5886 (See [https://builds.apache.org/job/HBase-TRUNK/5886/]) HBASE-12650 Move ServerName to hbase-common module - check in changed files (tedyu: rev 9e9be97af735a27769f4b348b72f065acaa1380c) * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java * hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaTableUtil.java * hbase-common/pom.xml Move ServerName to hbase-common module -- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Ted Yu Priority: Blocker Fix For: 2.0.0 Attachments: 12650-v1.txt, 12650-v2.txt, 12650-v3.txt, 12650-v4.txt The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common module
[
https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237260#comment-14237260
]
Hadoop QA commented on HBASE-12650:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685623/12650-v4.txt
against master branch at commit bb15fd5fe0a89e647cd9cefa0ceae342578f0833.
ATTACHMENT ID: 12685623
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
2092 checkstyle errors (more than the master's current 2089 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * codelt;hostname '{@link #SERVERNAME_SEPARATOR}' lt;port '{@link
#SERVERNAME_SEPARATOR}' lt;startcode/code.
+@edu.umd.cs.findbugs.annotations.SuppressWarnings(value=DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//console
This message is automatically generated.
Move ServerName to hbase-common module
--
Key: HBASE-12650
URL: https://issues.apache.org/jira/browse/HBASE-12650
Project: HBase
Issue Type: Improvement
Affects Versions: 2.0.0
Reporter: Gaurav Menghani
Assignee: Ted Yu
Priority: Blocker
Fix For: 2.0.0
Attachments: 12650-v1.txt, 12650-v2.txt, 12650-v3.txt, 12650-v4.txt
The idea is to move ServerName to hbase-common, so that other modules like
hbase-consensus which (would) depend on ServerName, but can't depend on
hbase-client, since hbase-client would depend on them. Moreover, it looks
logical that ServerName not be a part of the client module. It is a shared
class between multiple modules, so it should be in hbase-common.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236821#comment-14236821 ] Gaurav Menghani commented on HBASE-12650: - I will make this change only for trunk and branch-2, and the hydrabase feature branch, if everyone is okay with it. Move ServerName to hbase-common --- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Gaurav Menghani Priority: Blocker Fix For: 2.0.0 The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236825#comment-14236825 ] Ted Yu commented on HBASE-12650: +1 bq. and branch-2 Did you mean branch-1 ? [~enis]: What do you think ? Move ServerName to hbase-common --- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Gaurav Menghani Priority: Blocker Fix For: 2.0.0 The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236853#comment-14236853 ] Gaurav Menghani commented on HBASE-12650: - Is there is a branch for 2.0.0 (where hydrabase will land, I presume)? If yes, that's what I meant. Otherwise, I will just land it on trunk and the hydrabase feature branch. Move ServerName to hbase-common --- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Gaurav Menghani Priority: Blocker Fix For: 2.0.0 The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236855#comment-14236855 ] Ted Yu commented on HBASE-12650: There is currently no branch for 2.0.0 Master branch would become branch-2 Move ServerName to hbase-common --- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Gaurav Menghani Priority: Blocker Fix For: 2.0.0 The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236873#comment-14236873 ] stack commented on HBASE-12650: --- ServerName depends on hbase-protocol I think some one of us should do this work for you since you lot have your hands full bringing in consensus. If no volunteers, I'll have a go at it. Move ServerName to hbase-common --- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Gaurav Menghani Priority: Blocker Fix For: 2.0.0 The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236883#comment-14236883 ] Gaurav Menghani commented on HBASE-12650: - [~stack] Yes, you are right. ServerName.parseFrom(byte[]) has at least hbase-client dependencies. So this is a non-trivial-ish refactor. If anyone is taking this up, that would be great. It is not exactly blocking us completely, but we need to get this done as a part of HBASE-12510 some time in the future. Thanks :) Move ServerName to hbase-common --- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Gaurav Menghani Priority: Blocker Fix For: 2.0.0 The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common module
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236900#comment-14236900 ] Ted Yu commented on HBASE-12650: Review request: https://reviews.apache.org/r/28784/ Move ServerName to hbase-common module -- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Gaurav Menghani Priority: Blocker Fix For: 2.0.0 Attachments: 12650-v1.txt The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common module
[
https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236936#comment-14236936
]
Hadoop QA commented on HBASE-12650:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685558/12650-v1.txt
against master branch at commit b7d1790411a379a27c59514c806f48c91e7186c8.
ATTACHMENT ID: 12685558
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 5
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
2091 checkstyle errors (more than the master's current 2088 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * codelt;hostname '{@link #SERVERNAME_SEPARATOR}' lt;port '{@link
#SERVERNAME_SEPARATOR}' lt;startcode/code.
+@edu.umd.cs.findbugs.annotations.SuppressWarnings(value=DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11973//console
This message is automatically generated.
Move ServerName to hbase-common module
--
Key: HBASE-12650
URL: https://issues.apache.org/jira/browse/HBASE-12650
Project: HBase
Issue Type: Improvement
Affects Versions: 2.0.0
Reporter: Gaurav Menghani
Assignee: Gaurav Menghani
Priority: Blocker
Fix For: 2.0.0
Attachments: 12650-v1.txt
The idea is to move ServerName to hbase-common, so that other modules like
hbase-consensus which (would) depend on ServerName, but can't depend on
hbase-client, since hbase-client would depend on them. Moreover, it looks
logical that ServerName not be a part of the client module. It is a shared
class between multiple modules, so it should be in hbase-common.
--
This message was
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common module
[
https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237020#comment-14237020
]
Hadoop QA commented on HBASE-12650:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685572/12650-v3.txt
against master branch at commit b7d1790411a379a27c59514c806f48c91e7186c8.
ATTACHMENT ID: 12685572
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
2091 checkstyle errors (more than the master's current 2088 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * codelt;hostname '{@link #SERVERNAME_SEPARATOR}' lt;port '{@link
#SERVERNAME_SEPARATOR}' lt;startcode/code.
+@edu.umd.cs.findbugs.annotations.SuppressWarnings(value=DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11977//console
This message is automatically generated.
Move ServerName to hbase-common module
--
Key: HBASE-12650
URL: https://issues.apache.org/jira/browse/HBASE-12650
Project: HBase
Issue Type: Improvement
Affects Versions: 2.0.0
Reporter: Gaurav Menghani
Assignee: Gaurav Menghani
Priority: Blocker
Fix For: 2.0.0
Attachments: 12650-v1.txt, 12650-v2.txt, 12650-v3.txt
The idea is to move ServerName to hbase-common, so that other modules like
hbase-consensus which (would) depend on ServerName, but can't depend on
hbase-client, since hbase-client would depend on them. Moreover, it looks
logical that ServerName not be a part of the client module. It is a shared
class between multiple modules, so it should be in hbase-common.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
