[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071676#comment-15071676
]
Hudson commented on HBASE-14940:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1151 (See
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071674#comment-15071674
]
Hudson commented on HBASE-14940:
FAILURE: Integrated in HBase-0.98-matrix #278 (See
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071359#comment-15071359
]
Lars Hofhansl commented on HBASE-14940:
---
TestFromClientSide passes. If anything was wrong this, I
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071260#comment-15071260
]
Lars Hofhansl commented on HBASE-14940:
---
Should we replace
{source}
unaligned = (Boolean)
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071360#comment-15071360
]
Lars Hofhansl commented on HBASE-14940:
---
And looks right in the debugger.
> Make our unsafe based
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071259#comment-15071259
]
Lars Hofhansl commented on HBASE-14940:
---
Must have to do with compileSource being 1.6 in 0.98, and
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071358#comment-15071358
]
Lars Hofhansl commented on HBASE-14940:
---
+1 on addendum. I'm going to commit that to 0.98.
(It
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071309#comment-15071309
]
Anoop Sam John commented on HBASE-14940:
Yes only at the load time of UnsafeAccess, we do make
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071256#comment-15071256
]
Lars Hofhansl commented on HBASE-14940:
---
Looks like this break compilation in 0.98 now:
{code}
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071311#comment-15071311
]
stack commented on HBASE-14940:
---
Sound good [~lhofhansl] if it works sir
> Make our unsafe based ops more
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071128#comment-15071128
]
stack commented on HBASE-14940:
---
It looks like below only called on instantiation of UnsafeAccess...
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071135#comment-15071135
]
Hudson commented on HBASE-14940:
FAILURE: Integrated in HBase-1.0 #1127 (See
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070747#comment-15070747
]
Hudson commented on HBASE-14940:
FAILURE: Integrated in HBase-Trunk_matrix #583 (See
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070949#comment-15070949
]
Hudson commented on HBASE-14940:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1150 (See
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070967#comment-15070967
]
Hudson commented on HBASE-14940:
FAILURE: Integrated in HBase-0.98-matrix #277 (See
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070525#comment-15070525
]
Hudson commented on HBASE-14940:
SUCCESS: Integrated in HBase-1.3-IT #402 (See
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070501#comment-15070501
]
Anoop Sam John commented on HBASE-14940:
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070555#comment-15070555
]
Hudson commented on HBASE-14940:
SUCCESS: Integrated in HBase-1.2-IT #362 (See
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070099#comment-15070099
]
Hadoop QA commented on HBASE-14940:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070650#comment-15070650
]
Hudson commented on HBASE-14940:
FAILURE: Integrated in HBase-1.3 #466 (See
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070629#comment-15070629
]
Hudson commented on HBASE-14940:
SUCCESS: Integrated in HBase-1.2 #470 (See
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070683#comment-15070683
]
Hudson commented on HBASE-14940:
FAILURE: Integrated in HBase-1.1-JDK8 #1715 (See
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070712#comment-15070712
]
Hudson commented on HBASE-14940:
FAILURE: Integrated in HBase-1.1-JDK7 #1628 (See
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069037#comment-15069037
]
Ted Yu commented on HBASE-14940:
+1 on v2
> Make our unsafe based ops more safe
>
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069143#comment-15069143
]
Hadoop QA commented on HBASE-14940:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067728#comment-15067728
]
Hiroshi Ikeda commented on HBASE-14940:
---
That is a license issue, not a compatibility issue.
The
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066844#comment-15066844
]
stack commented on HBASE-14940:
---
bq. This part should be rewritten using reflection due to copyright.
What
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067501#comment-15067501
]
Anoop Sam John commented on HBASE-14940:
The required code is in Bits.java#unaligned() which is
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066558#comment-15066558
]
Ted Yu commented on HBASE-14940:
The code for checking unalignedness was copied from Java.
This part
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065310#comment-15065310
]
stack commented on HBASE-14940:
---
Not from me.
> Make our unsafe based ops more safe
>
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063828#comment-15063828
]
Hadoop QA commented on HBASE-14940:
---
{color:red}-1 overall{color}.
Test results:
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064385#comment-15064385
]
stack commented on HBASE-14940:
---
I filed HBASE-15009. Some commit to test-patch on branch broke the build
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064246#comment-15064246
]
stack commented on HBASE-14940:
---
Is this shortened format your doing [~busbey] ? If not, I'll dig in.
Let
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064335#comment-15064335
]
Sean Busbey commented on HBASE-14940:
-
the short format isn't from me, but that's how it's been
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064632#comment-15064632
]
Hadoop QA commented on HBASE-14940:
---
{color:red}-1 overall{color}.
Test results:
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065211#comment-15065211
]
Hadoop QA commented on HBASE-14940:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065229#comment-15065229
]
Anoop Sam John commented on HBASE-14940:
Same branch-1 patch applies to 0.98+ versions.. I think
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061602#comment-15061602
]
Anoop Sam John commented on HBASE-14940:
bq.There are risks (from the beginning)
We are adding
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050224#comment-15050224
]
ramkrishna.s.vasudevan commented on HBASE-14940:
Regarding the COPY_THRESHOLD thing that
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049943#comment-15049943
]
Hiroshi Ikeda commented on HBASE-14940:
---
There are risks (from the beginning) and if I were I might
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048990#comment-15048990
]
stack commented on HBASE-14940:
---
I'm +1 on the patch.
What you think [~ikeda]? Commit this and then file
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048132#comment-15048132
]
stack commented on HBASE-14940:
---
bq, if (UnsafeAccess.unaligned() == false) {
The above readst wrong but
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048180#comment-15048180
]
Anoop Sam John commented on HBASE-14940:
bq.In unsafeCopy if len > UNSAFE_COPY_THRESHOLD we will
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045113#comment-15045113
]
Hadoop QA commented on HBASE-14940:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046191#comment-15046191
]
Hiroshi Ikeda commented on HBASE-14940:
---
If there is not unaligned capability, when the starting
[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046323#comment-15046323
]
Anoop Sam John commented on HBASE-14940:
{quote}
Comparison to true/false in {{if}} conditions is
46 matches
Mail list logo
