[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827321#comment-16827321 ] Nate Edel commented on HBASE-14964: --- I haven't been active on here in a long time; [~eclark] may have some context on whether this ever got followed up on. > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Priority: Minor > Fix For: 1.5.0 > > Attachments: HBASE-14964-branch-1.1.patch, > HBASE-14964.1.branch-1.patch, HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815614#comment-16815614 ] Andrew Purtell commented on HBASE-14964: Any progress here? Or unschedule it? Or close it? > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 1.5.0 > > Attachments: HBASE-14964-branch-1.1.patch, > HBASE-14964.1.branch-1.patch, HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[
https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758622#comment-16758622
]
Hadoop QA commented on HBASE-14964:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 8s{color}
| {color:red} HBASE-14964 does not apply to branch-1. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.8.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-14964 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12778270/HBASE-14964.1.branch-1.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/15843/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage
> encryption keys
> ---
>
> Key: HBASE-14964
> URL: https://issues.apache.org/jira/browse/HBASE-14964
> Project: HBase
> Issue Type: Improvement
> Components: encryption
>Reporter: Nate Edel
>Assignee: Nate Edel
>Priority: Minor
> Fix For: 1.5.1
>
> Attachments: HBASE-14964-branch-1.1.patch,
> HBASE-14964.1.branch-1.patch, HBASE-14964.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> There is duplicated code from MobUtils.createEncryptionContext in HStore, and
> there is a subset of that code in HFileReaderImpl.
> Refactored key selection
> Moved both to EncryptionUtil.java
> Can't figure out how to write a unit test for this, but there's no new code
> just refactoring.
> A lot of the Mob stuff hasn't been backported, so this is a very small patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[
https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242913#comment-16242913
]
Hadoop QA commented on HBASE-14964:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 21m
30s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
3s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} branch-1 passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
47s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
19s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
0s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} branch-1 passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
29s{color} | {color:red} hbase-client: The patch generated 7 new + 5 unchanged
- 3 fixed = 12 total (was 8) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
17s{color} | {color:red} hbase-server: The patch generated 5 new + 61 unchanged
- 0 fixed = 66 total (was 61) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
33s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3.
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed with JDK v1.8.0_141 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
15s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 24m 0s{color}
| {color:red}
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[
https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337512#comment-15337512
]
Hadoop QA commented on HBASE-14964:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
59s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 22s
{color} | {color:green} branch-1 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 59s
{color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
29s {color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 1s
{color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 1s
{color} | {color:green} branch-1 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 16s
{color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 45s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 45s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 14s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 14s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
37s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 17s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
51s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 13s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 42s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 95m 48s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 141m 37s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12778270/HBASE-14964.1.branch-1.patch
|
| JIRA Issue | HBASE-14964 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[
https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062705#comment-15062705
]
Hadoop QA commented on HBASE-14964:
---
{color:green}+1 overall{color}.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16907//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16907//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16907//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16907//console
This message is automatically generated.
> Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage
> encryption keys
> ---
>
> Key: HBASE-14964
> URL: https://issues.apache.org/jira/browse/HBASE-14964
> Project: HBase
> Issue Type: Improvement
> Components: encryption
>Reporter: Nate Edel
>Assignee: Nate Edel
>Priority: Minor
> Fix For: 1.3.0
>
> Attachments: HBASE-14964-branch-1.1.patch,
> HBASE-14964.1.branch-1.patch, HBASE-14964.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> There is duplicated code from MobUtils.createEncryptionContext in HStore, and
> there is a subset of that code in HFileReaderImpl.
> Refactored key selection
> Moved both to EncryptionUtil.java
> Can't figure out how to write a unit test for this, but there's no new code
> just refactoring.
> A lot of the Mob stuff hasn't been backported, so this is a very small patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062732#comment-15062732 ] Sean Busbey commented on HBASE-14964: - The unit tests pass. | Vote | Subsystem | Runtime | Comment | 0 | reexec | 0m 0s | Docker mode activated. | +1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | +1 |@author | 0m 0s | The patch does not contain any @author | | || tags. | +1 | test4tests | 0m 0s | The patch appears to include 1 new or | | || modified test files. | +1 | mvninstall | 3m 58s| branch-1 passed | +1 |compile | 0m 46s| branch-1 passed with JDK v1.8.0_66 | +1 |compile | 0m 49s| branch-1 passed with JDK v1.7.0_91 | +1 | checkstyle | 0m 30s| branch-1 passed | +1 | mvneclipse | 0m 33s| branch-1 passed | -1 | findbugs | 0m 58s| hbase-client in branch-1 has 17 extant | | || Findbugs warnings. | -1 | findbugs | 1m 55s| hbase-server in branch-1 has 92 extant | | || Findbugs warnings. | -1 |javadoc | 0m 18s| hbase-client in branch-1 failed with | | || JDK v1.8.0_66. | -1 |javadoc | 0m 27s| hbase-server in branch-1 failed with | | || JDK v1.8.0_66. | +1 |javadoc | 0m 51s| branch-1 passed with JDK v1.7.0_91 | +1 | mvninstall | 1m 0s | the patch passed | +1 |compile | 0m 45s| the patch passed with JDK v1.8.0_66 | +1 | javac | 0m 45s| the patch passed | +1 |compile | 0m 49s| the patch passed with JDK v1.7.0_91 | +1 | javac | 0m 49s| the patch passed | -1 | checkstyle | 0m 10s| Patch generated 2 new checkstyle issues | | || in hbase-client (total was 1, now 2). | -1 | checkstyle | 0m 14s| Patch generated 5 new checkstyle issues | | || in hbase-server (total was 11, now 16). | +1 | mvneclipse | 0m 26s| the patch passed | +1 | whitespace | 0m 0s | Patch has no whitespace issues. | +1 |hadoopcheck | 4m 6s | Patch does not cause any errors with | | || Hadoop 2.4.1 2.5.2 2.6.0. | +1 | findbugs | 3m 2s | the patch passed | -1 |javadoc | 0m 15s| hbase-client in the patch failed with | | || JDK v1.8.0_66. | -1 |javadoc | 0m 23s| hbase-server in the patch failed with | | || JDK v1.8.0_66. | +1 |javadoc | 0m 50s| the patch passed with JDK v1.7.0_91 | +1 | unit | 1m 23s| hbase-client in the patch passed with | | || JDK v1.8.0_66. | +1 | unit | 78m 7s| hbase-server in the patch passed with | | || JDK v1.8.0_66. | +1 | unit | 1m 40s| hbase-client in the patch passed with | | || JDK v1.7.0_91. | +1 | unit | 82m 46s | hbase-server in the patch passed with | | || JDK v1.7.0_91. | +1 | asflicense | 0m 29s| Patch does not generate ASF License | | || warnings. | | | 188m 9s | || Subsystem || Report/Notes || | Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2015-12-17 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12778270/HBASE-14964.1.branch-1.patch | | JIRA Issue | HBASE-14964 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 43836f439275 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-1 / 6ec9228 | | findbugs | v3.0.0 | | findbugs | /testptch/patchprocess/branch-findbugs-hbase-client-warnings.html | | findbugs | /testptch/patchprocess/branch-findbugs-hbase-server-warnings.html | | javadoc | /testptch/patchprocess/branch-javadoc-hbase-client-jdk1.8.0_66.txt | | javadoc | /testptch/patchprocess/branch-javadoc-hbase-server-jdk1.8.0_66.txt | | checkstyle | /testptch/patchprocess/diff-checkstyle-hbase-client.txt | | checkstyle | /testptch/patchprocess/diff-checkstyle-hbase-server.txt | | javadoc |
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060682#comment-15060682 ] Sean Busbey commented on HBASE-14964: - I'm testing this locally since hte build bot exploded. > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 1.2.0, 1.3.0 > > Attachments: HBASE-14964-branch-1.1.patch, HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060731#comment-15060731 ] Sean Busbey commented on HBASE-14964: - (note that the buildbot should have said -1 because the build failed due to a flakey that I'm pretty sure is unrelated) > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 1.2.0, 1.3.0 > > Attachments: HBASE-14964-branch-1.1.patch, HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[
https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060452#comment-15060452
]
Hadoop QA commented on HBASE-14964:
---
{color:green}+1 overall{color}.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16877//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16877//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16877//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16877//console
This message is automatically generated.
> Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage
> encryption keys
> ---
>
> Key: HBASE-14964
> URL: https://issues.apache.org/jira/browse/HBASE-14964
> Project: HBase
> Issue Type: Improvement
> Components: encryption
>Reporter: Nate Edel
>Assignee: Nate Edel
>Priority: Minor
> Fix For: 1.2.0, 1.3.0
>
> Attachments: HBASE-14964-branch-1.1.patch, HBASE-14964.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> There is duplicated code from MobUtils.createEncryptionContext in HStore, and
> there is a subset of that code in HFileReaderImpl.
> Refactored key selection
> Moved both to EncryptionUtil.java
> Can't figure out how to write a unit test for this, but there's no new code
> just refactoring.
> A lot of the Mob stuff hasn't been backported, so this is a very small patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[
https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060920#comment-15060920
]
Sean Busbey commented on HBASE-14964:
-
running through things locally claims new checkstyle errors:
{code}
| Vote | Subsystem | Runtime | Comment
| +1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns.
| +1 |@author | 0m 0s | The patch does not contain any @author
| | || tags.
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or
| | || modified test files.
| +1 | mvninstall | 4m 28s| branch-1 passed
| +1 | checkstyle | 0m 36s| branch-1 passed
| +1 | mvneclipse | 0m 39s| branch-1 passed
| 0 | findbugs | 1m 15s| findbugs executables are not available.
| +1 | mvninstall | 1m 13s| the patch passed
| -1 | checkstyle | 0m 13s| Patch generated 2 new checkstyle issues
| | || in hbase-client (total was 1, now 2).
| -1 | checkstyle | 0m 20s| Patch generated 5 new checkstyle issues
| | || in hbase-server (total was 11, now 16).
| +1 | mvneclipse | 0m 30s| the patch passed
| +1 | whitespace | 0m 0s | Patch has no whitespace issues.
| +1 |hadoopcheck | 5m 24s| Patch does not cause any errors with
| | || Hadoop 2.4.1 2.5.2 2.6.0.
| +1 | asflicense | 0m 19s| Patch does not generate ASF License
| | || warnings.
| | | 13m 44s |
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12778014/HBASE-14964-branch-1.1.patch
|
| JIRA Issue | HBASE-14964 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux busbey.vpc.cloudera.com 3.10.0-229.11.1.el7.x86_64 #1 SMP Wed
Jul 22 12:06:11 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/busbey/yetus/yetus-0.1.0/lib/precommit/personality/hbase.sh |
| git revision | branch-1 / d2fb7e6 |
| checkstyle | /tmp/yetus-21889.12586/diff-checkstyle-hbase-client.txt |
| checkstyle | /tmp/yetus-21889.12586/diff-checkstyle-hbase-server.txt |
| modules | C: hbase-client hbase-server U: . |
| Max memory used | 135MB |
| Powered by | Apache Yetus 0.1.0 http://yetus.apache.org |
{code}
contents of {{/tmp/yetus-21889.12586/diff-checkstyle-hbase-client.txt}}
{code}
./hbase-client/src/main/java/org/apache/hadoop/hbase/security/EncryptionUtil.java:37:1:
Duplicate import to line 32 - org.apache.hadoop.conf.Configuration.
./hbase-client/src/main/java/org/apache/hadoop/hbase/security/EncryptionUtil.java:38:1:
Duplicate import to line 34 - org.apache.hadoop.hbase.HConstants.
{code}
contents of {{/tmp/yetus-21889.12586/diff-checkstyle-hbase-server.txt}}
{code}
./hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV3.java:22:8:
Unused import - java.security.KeyException.
./hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV3.java:40:8:
Unused import - org.apache.hadoop.hbase.security.User.
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:24:8:
Unused import - java.security.Key.
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:25:8:
Unused import - java.security.KeyException.
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:67:8:
Unused import - org.apache.hadoop.hbase.io.crypto.Cipher.
{code}
it looks like the unit tests didn't fire, so I'm going to see if I can figure
out why before moving this out of patch available.
> Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage
> encryption keys
> ---
>
> Key: HBASE-14964
> URL: https://issues.apache.org/jira/browse/HBASE-14964
> Project: HBase
> Issue Type: Improvement
> Components: encryption
>Reporter: Nate Edel
>Assignee: Nate Edel
>Priority: Minor
> Fix For: 1.2.0, 1.3.0
>
> Attachments: HBASE-14964-branch-1.1.patch, HBASE-14964.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> There is duplicated code from MobUtils.createEncryptionContext in HStore, and
> there is a subset of that code in HFileReaderImpl.
> Refactored key selection
> Moved both to EncryptionUtil.java
> Can't figure out how to write a unit test for this, but there's no
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060927#comment-15060927 ] Sean Busbey commented on HBASE-14964: - okay, rerunning so that tests will run this time. > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 1.2.0, 1.3.0 > > Attachments: HBASE-14964-branch-1.1.patch, HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060948#comment-15060948 ] Nate Edel commented on HBASE-14964: --- Thanks for fixing my patch name and kicking off the tests, [~busbey]]! I'll wait for the tests to come back, and assuming those are clean, clean up the imports to fix the checkstyle. > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 1.2.0, 1.3.0 > > Attachments: HBASE-14964-branch-1.1.patch, HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060095#comment-15060095 ] Sean Busbey commented on HBASE-14964: - started a manual precommit test run: https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-HBASE-Build/16876/ > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 1.2.0, 1.3.0 > > Attachments: HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
[ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060097#comment-15060097 ] Sean Busbey commented on HBASE-14964: - now that I look closer, that test run is almost certainly going to fail. aborting it. > Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage > encryption keys > --- > > Key: HBASE-14964 > URL: https://issues.apache.org/jira/browse/HBASE-14964 > Project: HBase > Issue Type: Improvement > Components: encryption >Reporter: Nate Edel >Assignee: Nate Edel >Priority: Minor > Fix For: 1.2.0, 1.3.0 > > Attachments: HBASE-14964.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > There is duplicated code from MobUtils.createEncryptionContext in HStore, and > there is a subset of that code in HFileReaderImpl. > Refactored key selection > Moved both to EncryptionUtil.java > Can't figure out how to write a unit test for this, but there's no new code > just refactoring. > A lot of the Mob stuff hasn't been backported, so this is a very small patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
