[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030600#comment-16030600
]
Phil Yang commented on HBASE-15302:
---
Agree, let's close this issue and file a new one if needed(not
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028119#comment-16028119
]
Hadoop QA commented on HBASE-15302:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028048#comment-16028048
]
Sean Busbey commented on HBASE-15302:
-
we have commits for this issue on master and branch-1 from
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885148#comment-15885148
]
Hadoop QA commented on HBASE-15302:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588623#comment-15588623
]
Hadoop QA commented on HBASE-15302:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588436#comment-15588436
]
Phil Yang commented on HBASE-15302:
---
TestAssignmentManager are also missed in branch-1/1.3.
>
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588315#comment-15588315
]
Phil Yang commented on HBASE-15302:
---
Seems in branch-1.1 it is also failed. I run the test in Intellij
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588288#comment-15588288
]
Phil Yang commented on HBASE-15302:
---
I run TestMasterFailoverWithProcedures locally in branch-1 and
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587546#comment-15587546
]
Phil Yang commented on HBASE-15302:
---
What about TestWALSplitCompressed, will you also pull it back?
>
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587538#comment-15587538
]
Gary Helmling commented on HBASE-15302:
---
Thanks, but please exclude TestWALSplit. I'm pulling that
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587527#comment-15587527
]
Phil Yang commented on HBASE-15302:
---
Oh, I missed the reverting. Let me put these three tests back.
>
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586024#comment-15586024
]
Hadoop QA commented on HBASE-15302:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15585974#comment-15585974
]
Gary Helmling commented on HBASE-15302:
---
What's the status of this? It's still showing as
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328916#comment-15328916
]
Hadoop QA commented on HBASE-15302:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201427#comment-15201427
]
Ted Yu commented on HBASE-15302:
Please look at checkstyle warnings in WALSplitter.java which is modified
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201685#comment-15201685
]
Ted Yu commented on HBASE-15302:
Based on the result from
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201701#comment-15201701
]
Ted Yu commented on HBASE-15302:
Pushed to branch-1, first.
> Reenable the other tests disabled by
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200892#comment-15200892
]
Phil Yang commented on HBASE-15302:
---
We should push this patch to branch 1.x before HBASE-15325 because
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201193#comment-15201193
]
Hadoop QA commented on HBASE-15302:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201588#comment-15201588
]
Hadoop QA commented on HBASE-15302:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202654#comment-15202654
]
Hudson commented on HBASE-15302:
FAILURE: Integrated in HBase-1.4 #32 (See
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202626#comment-15202626
]
Hudson commented on HBASE-15302:
SUCCESS: Integrated in HBase-1.3-IT #565 (See
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202463#comment-15202463
]
Hudson commented on HBASE-15302:
SUCCESS: Integrated in HBase-1.3-IT #564 (See
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202540#comment-15202540
]
Ted Yu commented on HBASE-15302:
{code}
Fetching
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201435#comment-15201435
]
Phil Yang commented on HBASE-15302:
---
There are many warnings and they seems not caused by this patch.
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202507#comment-15202507
]
Hudson commented on HBASE-15302:
FAILURE: Integrated in HBase-1.4 #31 (See
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169125#comment-15169125
]
Phil Yang commented on HBASE-15302:
---
This patch only adds tests and changes an interface, no logic
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167551#comment-15167551
]
stack commented on HBASE-15302:
---
Same set of tests failed for jdk8 and 7. Related to patch?
> Reenable the
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166731#comment-15166731
]
Hadoop QA commented on HBASE-15302:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163601#comment-15163601
]
Hudson commented on HBASE-15302:
FAILURE: Integrated in HBase-Trunk_matrix #734 (See
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163169#comment-15163169
]
stack commented on HBASE-15302:
---
I pushed patch to master branch. Leaving issue open for now waiting to see
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163167#comment-15163167
]
stack commented on HBASE-15302:
---
[~yangzhe1991] You might skip adding TestAssignmentManager back on
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15162922#comment-15162922
]
Phil Yang commented on HBASE-15302:
---
I port the patch to branch-1, but TestAssignmentManager failed
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157937#comment-15157937
]
Hadoop QA commented on HBASE-15302:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157901#comment-15157901
]
Duo Zhang commented on HBASE-15302:
---
+1 if it pass pre commit again.
> Reenable the other tests
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156789#comment-15156789
]
Hadoop QA commented on HBASE-15302:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156560#comment-15156560
]
Phil Yang commented on HBASE-15302:
---
I find no test set it to false, and I use a temp file name to be
[
https://issues.apache.org/jira/browse/HBASE-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156550#comment-15156550
]
Duo Zhang commented on HBASE-15302:
---
{{fileBeingSplit}} used to be {{isCreate}}, and after HBASE-14949
38 matches
Mail list logo