[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903055#comment-15903055 ] Hudson commented on HBASE-15941: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #122 (See [https://builds.apache.org/job/HBase-1.3-JDK7/122/]) HBASE-15941 HBCK repair should not unsplit healthy splitted region (esteban: rev 0f011a9d928999186ad371f6cd02b94f49a5c631) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/hbck/TableIntegrityErrorHandler.java > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.6 > > Attachments: HBASE-15941.branch-1.001.patch, > HBASE-15941.master.001.patch, HBASE-15941.master.001.patch, > HBASE-15941.master.002.patch > > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903046#comment-15903046 ] Hudson commented on HBASE-15941: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2640 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2640/]) HBASE-15941 HBCK repair should not unsplit healthy splitted region (esteban: rev 1160315e2f666fd5c51505f55f77399e302885f2) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/hbck/TableIntegrityErrorHandler.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckReplicas.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckTwoRS.java > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.6 > > Attachments: HBASE-15941.branch-1.001.patch, > HBASE-15941.master.001.patch, HBASE-15941.master.001.patch, > HBASE-15941.master.002.patch > > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902983#comment-15902983 ] Hudson commented on HBASE-15941: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #133 (See [https://builds.apache.org/job/HBase-1.3-JDK8/133/]) HBASE-15941 HBCK repair should not unsplit healthy splitted region (esteban: rev 0f011a9d928999186ad371f6cd02b94f49a5c631) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/hbck/TableIntegrityErrorHandler.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.6 > > Attachments: HBASE-15941.branch-1.001.patch, > HBASE-15941.master.001.patch, HBASE-15941.master.001.patch, > HBASE-15941.master.002.patch > > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902949#comment-15902949 ] Hudson commented on HBASE-15941: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #114 (See [https://builds.apache.org/job/HBase-1.2-JDK7/114/]) HBASE-15941 HBCK repair should not unsplit healthy splitted region (esteban: rev c368c8587a85261ac9eefe56a2d5f30ee8fe3f33) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/hbck/TableIntegrityErrorHandler.java > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.6 > > Attachments: HBASE-15941.branch-1.001.patch, > HBASE-15941.master.001.patch, HBASE-15941.master.001.patch, > HBASE-15941.master.002.patch > > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902937#comment-15902937 ] Hudson commented on HBASE-15941: SUCCESS: Integrated in Jenkins build HBase-1.4 #662 (See [https://builds.apache.org/job/HBase-1.4/662/]) HBASE-15941 HBCK repair should not unsplit healthy splitted region (esteban: rev c70769ea891bbac7c65b191faec53a81a6af654c) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/hbck/TableIntegrityErrorHandler.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.6 > > Attachments: HBASE-15941.branch-1.001.patch, > HBASE-15941.master.001.patch, HBASE-15941.master.001.patch, > HBASE-15941.master.002.patch > > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902919#comment-15902919 ] Hudson commented on HBASE-15941: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #109 (See [https://builds.apache.org/job/HBase-1.2-JDK8/109/]) HBASE-15941 HBCK repair should not unsplit healthy splitted region (esteban: rev c368c8587a85261ac9eefe56a2d5f30ee8fe3f33) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/hbck/TableIntegrityErrorHandler.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.6 > > Attachments: HBASE-15941.branch-1.001.patch, > HBASE-15941.master.001.patch, HBASE-15941.master.001.patch, > HBASE-15941.master.002.patch > > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902701#comment-15902701 ] Hudson commented on HBASE-15941: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #5 (See [https://builds.apache.org/job/HBase-1.3-IT/5/]) HBASE-15941 HBCK repair should not unsplit healthy splitted region (esteban: rev 0f011a9d928999186ad371f6cd02b94f49a5c631) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/hbck/TableIntegrityErrorHandler.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.6 > > Attachments: HBASE-15941.branch-1.001.patch, > HBASE-15941.master.001.patch, HBASE-15941.master.001.patch, > HBASE-15941.master.002.patch > > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902700#comment-15902700 ] Hudson commented on HBASE-15941: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #847 (See [https://builds.apache.org/job/HBase-1.2-IT/847/]) HBASE-15941 HBCK repair should not unsplit healthy splitted region (esteban: rev c368c8587a85261ac9eefe56a2d5f30ee8fe3f33) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/hbck/TableIntegrityErrorHandler.java > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.6 > > Attachments: HBASE-15941.branch-1.001.patch, > HBASE-15941.master.001.patch, HBASE-15941.master.001.patch, > HBASE-15941.master.002.patch > > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[
https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902613#comment-15902613
]
Stephen Yuan Jiang commented on HBASE-15941:
{noformat}
out.println(" -fixSplitParents Try to force offline split
parents to be online.");
out.println(" -removeParentsTry to offline and sideline
lingering parents and keep daughter regions.");
{noformat}
We are getting too many options now. I just wonder whether we should have this
new option or put logic in other options. For example, maybe merge with
-fixSplitParents option to either force offline parent online or sideline
lingering parents. (I am not sure about this, as I have not take a close look
at this fixSplitParents code path. I just feel HBCK already has too many
options today; my experience with customer is that they sometimes miss the
right option or sometimes they just simply use -repair to apply all options.)
> HBCK repair should not unsplit healthy splitted region
> --
>
> Key: HBASE-15941
> URL: https://issues.apache.org/jira/browse/HBASE-15941
> Project: HBase
> Issue Type: Improvement
> Components: hbck
>Affects Versions: 1.0.0
>Reporter: Stephen Yuan Jiang
>Assignee: Esteban Gutierrez
> Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.6
>
> Attachments: HBASE-15941.branch-1.001.patch,
> HBASE-15941.master.001.patch, HBASE-15941.master.001.patch,
> HBASE-15941.master.002.patch
>
>
> Currently HBCK design in branch-1 has a flaw when repair option (the
> -fixHdfsOverlaps option specifically) is specified: it would wrongly merge
> split region (by looking at HDFS, it thinks that there exists overlapped
> regions - parent region and daughter regions covers the same key range, of
> course). See HBASE-15940 for details.
> This JIRA tracks the improvement not-to-merge split region in HBCK repair.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902433#comment-15902433 ] Esteban Gutierrez commented on HBASE-15941: --- Last test failure also is not related to this change. Unless there is any additional comment I will go ahead and commit this shortly. > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > Attachments: HBASE-15941.master.001.patch, > HBASE-15941.master.001.patch, HBASE-15941.master.002.patch > > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[
https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902333#comment-15902333
]
Hadoop QA commented on HBASE-15941:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
6s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
42s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 21s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
57s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 95m 17s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 136m 56s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12856898/HBASE-15941.master.002.patch
|
| JIRA Issue | HBASE-15941 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux caeadfad722e 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24
10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 1b5afc3 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/6019/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/6019/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/6019/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> HBCK repair should not unsplit healthy splitted region
> --
>
> Key: HBASE-15941
> URL: https://issues.apache.org/jira/browse/HBASE-15941
> Project: HBase
> Issue Type: Improvement
> Components: hbck
>Affects Versions: 1.0.0
>Reporter:
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902150#comment-15902150 ] Esteban Gutierrez commented on HBASE-15941: --- Failed test not related. Uploading new patch with additional test and addressing finbug report. > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > Attachments: HBASE-15941.master.001.patch, > HBASE-15941.master.001.patch > > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[
https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902085#comment-15902085
]
Hadoop QA commented on HBASE-15941:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
0s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
43s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
42s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 13s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 52s
{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed = 1
total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 100m 50s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 140m 27s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | Dead store to meta in
org.apache.hadoop.hbase.util.HBaseFsckRepair.removeParentInMeta(Configuration,
HRegionInfo) At
HBaseFsckRepair.java:org.apache.hadoop.hbase.util.HBaseFsckRepair.removeParentInMeta(Configuration,
HRegionInfo) At HBaseFsckRepair.java:[line 206] |
| Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
|
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12856860/HBASE-15941.master.001.patch
|
| JIRA Issue | HBASE-15941 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 9db6563670c2 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6
15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 1b5afc3 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/6011/artifact/patchprocess/new-findbugs-hbase-server.html
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/6011/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit test logs |
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901891#comment-15901891 ] stack commented on HBASE-15941: --- Went over this w/ [~esteban] Needs a good release note on when this new option would be used. Otherwise +1. > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > Attachments: HBASE-15941.master.001.patch > > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900235#comment-15900235 ] Esteban Gutierrez commented on HBASE-15941: --- Hi [~syuanjiang], can you take a look to this approach? Basically if we are 100% sure that there is parent is present and the splits are valid daughters then we remove the parent and sideline the parent. Otherwise we fallback to the current approach. Thanks! > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > Attachments: HBASE-15941.master.001.patch > > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848507#comment-15848507 ] Esteban Gutierrez commented on HBASE-15941: --- Thanks [~syuanjiang]! > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Esteban Gutierrez > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848067#comment-15848067 ] Stephen Yuan Jiang commented on HBASE-15941: [~esteban], please go ahead and take it. Thanks > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Stephen Yuan Jiang > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-15941) HBCK repair should not unsplit healthy splitted region
[ https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847849#comment-15847849 ] Esteban Gutierrez commented on HBASE-15941: --- Do you mind if I work on this [~syuanjiang]? I got a patch for this on the works. > HBCK repair should not unsplit healthy splitted region > -- > > Key: HBASE-15941 > URL: https://issues.apache.org/jira/browse/HBASE-15941 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 1.0.0 >Reporter: Stephen Yuan Jiang >Assignee: Stephen Yuan Jiang > > Currently HBCK design in branch-1 has a flaw when repair option (the > -fixHdfsOverlaps option specifically) is specified: it would wrongly merge > split region (by looking at HDFS, it thinks that there exists overlapped > regions - parent region and daughter regions covers the same key range, of > course). See HBASE-15940 for details. > This JIRA tracks the improvement not-to-merge split region in HBCK repair. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
