[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533855#comment-15533855
]
stack commented on HBASE-16264:
---
Pushed a dev branch HBASE-16264
Added a jenkins job HBASE-16264
> Figure
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533774#comment-15533774
]
stack commented on HBASE-16264:
---
Hmmm... I can't attach my patch. It is too big for JIRA. 21MB. Let me fix.
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533292#comment-15533292
]
stack commented on HBASE-16264:
---
New patch adds a hbase-endpoint module and moves all the bundled CPEPs to
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509295#comment-15509295
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508333#comment-15508333
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508116#comment-15508116
]
stack commented on HBASE-16264:
---
Tried a branch-1.x client against a master server with this patch in place
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507553#comment-15507553
]
stack commented on HBASE-16264:
---
Chatting w/ Sean, the whitespace complaints against generated code cannot
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505681#comment-15505681
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505165#comment-15505165
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504749#comment-15504749
]
stack commented on HBASE-16264:
---
Patch is just 2MB when I strip the generated content. Updated rb:
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504716#comment-15504716
]
stack commented on HBASE-16264:
---
Good idea for getting patch up on rb. Thanks.
> Figure how to deal with
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504524#comment-15504524
]
Matteo Bertozzi commented on HBASE-16264:
-
remove the generated *Protos.java from the patch you
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504507#comment-15504507
]
stack commented on HBASE-16264:
---
Back up to 14.5MB. Won't go up on RB. Lets see how this run does. Will
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503863#comment-15503863
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502631#comment-15502631
]
stack commented on HBASE-16264:
---
I cut it by .8MB but still too big. More to do. New patch is mostly remove
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502156#comment-15502156
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15501981#comment-15501981
]
stack commented on HBASE-16264:
---
Having trouble uploading 14.5MB patch to RB. Will work on this.
> Figure
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15501953#comment-15501953
]
stack commented on HBASE-16264:
---
Tactic #4 seems to work: i.e. a copy of hbase-protocol relocated as
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451276#comment-15451276
]
stack commented on HBASE-16264:
---
Digging in more, the above NoClassDefFoundError is a linkage time error
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15449905#comment-15449905
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448281#comment-15448281
]
stack commented on HBASE-16264:
---
Took a while, but Tactic #2 where I define my own system classloader,
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438171#comment-15438171
]
stack commented on HBASE-16264:
---
Interesting. For true exterior endpoints, the are packaged in an endpoint
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437738#comment-15437738
]
stack commented on HBASE-16264:
---
More fun. Tests fail because we are not using CoprocessorClassLoader for
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435971#comment-15435971
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435931#comment-15435931
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435617#comment-15435617
]
stack commented on HBASE-16264:
---
The build is failing unable to find the relocated protobuf. Works locally
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435498#comment-15435498
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434627#comment-15434627
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434235#comment-15434235
]
stack commented on HBASE-16264:
---
Last patch fixes findbugs, unrelated to this patch. First batch of
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434148#comment-15434148
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433760#comment-15433760
]
Hadoop QA commented on HBASE-16264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431919#comment-15431919
]
stack commented on HBASE-16264:
---
Posted first version. 9MB.
> Figure how to deal with endpoints and shaded
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431914#comment-15431914
]
stack commented on HBASE-16264:
---
I added doc in parent issue on approach with downsides. Loading up a patch
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411910#comment-15411910
]
stack commented on HBASE-16264:
---
Sorry, copies.. So a CPEP is standalone, doesn't depend on importing hbase
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411393#comment-15411393
]
ramkrishna.s.vasudevan commented on HBASE-16264:
bq.At the moment having copies of base
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411335#comment-15411335
]
Anoop Sam John commented on HBASE-16264:
So we will need hbase.proto , cell.proto etc for the
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410671#comment-15410671
]
stack commented on HBASE-16264:
---
At the moment having copies of base HBase Protos so corps are standalone
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410500#comment-15410500
]
stack commented on HBASE-16264:
---
Learnings:
# We have a few Coprocessor Endpoints (CPEP) in the codebase
[
https://issues.apache.org/jira/browse/HBASE-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398495#comment-15398495
]
stack commented on HBASE-16264:
---
See [~ghelmling] comment up in the parent issue:
39 matches
Mail list logo