[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520744#comment-15520744 ] Hudson commented on HBASE-16665: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #1670 (See

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-24 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519903#comment-15519903 ] Heng Chen commented on HBASE-16665: --- will commit it if no other concerns. > Check whether

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-23 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518113#comment-15518113 ] Heng Chen commented on HBASE-16665: --- hadoop.hbase.client.TestBlockEvictionFromClient failed w/ or w/o

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516609#comment-15516609 ] Hadoop QA commented on HBASE-16665: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516099#comment-15516099 ] Anoop Sam John commented on HBASE-16665: +1 > Check whether KeyValueUtil.createXXX could be

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-23 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516028#comment-15516028 ] Heng Chen commented on HBASE-16665: --- Sounds reasonable. Empty byte[] will be better. > Check whether

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516021#comment-15516021 ] Anoop Sam John commented on HBASE-16665: bq. family, 0, family == null ? 0 : (byte)family.length,

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-23 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516005#comment-15516005 ] Heng Chen commented on HBASE-16665: --- v2 Fix failed testcase > Check whether KeyValueUtil.createXXX

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-22 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512832#comment-15512832 ] Anoop Sam John commented on HBASE-16665: bq.CellUtil.createFirstOnRow(CellUtil.cloneRow(kvs[0]),

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-22 Thread binlijin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512810#comment-15512810 ] binlijin commented on HBASE-16665: -- [~chenheng] the failures caused by this patch. > Check whether

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512787#comment-15512787 ] Hadoop QA commented on HBASE-16665: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-22 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512417#comment-15512417 ] Heng Chen commented on HBASE-16665: --- Will open another issue for cleanup, keep this issue small and

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-22 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512356#comment-15512356 ] Anoop Sam John commented on HBASE-16665: +1. createXXX method should go away from KVUtil.. We

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-22 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512330#comment-15512330 ] Heng Chen commented on HBASE-16665: --- Another thoughts about KeyValueUtil and CellUtil, we'd better to

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-22 Thread binlijin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512319#comment-15512319 ] binlijin commented on HBASE-16665: -- +1 > Check whether KeyValueUtil.createXXX could be replaced by

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-21 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509572#comment-15509572 ] Anoop Sam John commented on HBASE-16665: AbstractMemStore#updateColumnValue change seems not

[jira] [Commented] (HBASE-16665) Check whether KeyValueUtil.createXXX could be replaced by CellUtil without copy

2016-09-21 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509251#comment-15509251 ] Heng Chen commented on HBASE-16665: --- Not sure for the two place whether KeyValueUtil.createFirstOnRow