[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-20 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763969#comment-15763969 ] Hudson commented on HBASE-17333: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2165 (See

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763317#comment-15763317 ] ramkrishna.s.vasudevan commented on HBASE-17333: Pushed to master. Thanks for the

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763303#comment-15763303 ] ramkrishna.s.vasudevan commented on HBASE-17333: So I will go ahead and commit this

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763186#comment-15763186 ] Anoop Sam John commented on HBASE-17333: DD As Stack said.. IMO also we should do BASIC as the

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762253#comment-15762253 ] stack commented on HBASE-17333: --- [~anastas] Yes. You do. Turning it off for now and then filing an issue

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread Anastasia Braginsky (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762229#comment-15762229 ] Anastasia Braginsky commented on HBASE-17333: - I am not sure what is the final suggestion

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762167#comment-15762167 ] stack commented on HBASE-17333: --- [~devaraj] BASIC was default. Suggest you ask question about perf to get

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread Devaraj Das (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762082#comment-15762082 ] Devaraj Das commented on HBASE-17333: - Guys, wondering if we have perf tests that prove BASIC is

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761992#comment-15761992 ] stack commented on HBASE-17333: --- +1 on patch and +1 on [~anoop.hbase] suggestion above. Thanks

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761921#comment-15761921 ] Anoop Sam John commented on HBASE-17333: +1 Pls raise another issue to change the default to be

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761896#comment-15761896 ] ramkrishna.s.vasudevan commented on HBASE-17333: Ok fine. Will change it accordingly

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761868#comment-15761868 ] stack commented on HBASE-17333: --- All reasonable. Can we just set the default to NONE? > HBASE-17294

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761854#comment-15761854 ] ramkrishna.s.vasudevan commented on HBASE-17333: See my description. I was actually not

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761708#comment-15761708 ] Anoop Sam John commented on HBASE-17333: HBASE-17294 was about external configs for compacting

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761697#comment-15761697 ] stack commented on HBASE-17333: --- Lads, we want inmemory compaction as default unless it broken or causes

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760650#comment-15760650 ] Hadoop QA commented on HBASE-17333: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760565#comment-15760565 ] Hadoop QA commented on HBASE-17333: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-18 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760421#comment-15760421 ] ramkrishna.s.vasudevan commented on HBASE-17333: bq.The way to enable compacting Memstore

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-18 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760402#comment-15760402 ] Anoop Sam John commented on HBASE-17333: bq.COMPACTING_MEMSTORE_ENABLED =

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-18 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760366#comment-15760366 ] Anoop Sam John commented on HBASE-17333: Same.. Ya when HCD level is null, we go with conf read

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-18 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760357#comment-15760357 ] ramkrishna.s.vasudevan commented on HBASE-17333: Oh I got the problem with the patch. Am

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-18 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760348#comment-15760348 ] Anoop Sam John commented on HBASE-17333: When at conf level we have say Basic and CF level we

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-18 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760346#comment-15760346 ] ramkrishna.s.vasudevan commented on HBASE-17333: And my other suggestion would be to

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-18 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760339#comment-15760339 ] ramkrishna.s.vasudevan commented on HBASE-17333: bq.The issue is this. When read from

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-18 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760303#comment-15760303 ] Anoop Sam John commented on HBASE-17333: {code} if (inMemoryCompaction != null) { 246

[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default

2016-12-18 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760273#comment-15760273 ] Anoop Sam John commented on HBASE-17333: Should not be.. +1 to change it so as to ake DefaultMS