[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995881#comment-15995881
]
Enis Soztutar commented on HBASE-17576:
---
Doing these kind of aliases is not good in a header file.
[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995789#comment-15995789
]
Enis Soztutar commented on HBASE-17576:
---
Thanks Sudeep.
- Remove this:
+
[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987868#comment-15987868
]
Enis Soztutar commented on HBASE-17576:
---
- From a coding practice, this is not how we check
[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986736#comment-15986736
]
Sudeep Sunthankar commented on HBASE-17576:
---
Hi [~enis],
Based on the feedback I have uploaded
[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962608#comment-15962608
]
Enis Soztutar commented on HBASE-17576:
---
bq. I believe we should take this approach instead of
[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962530#comment-15962530
]
Sudeep Sunthankar commented on HBASE-17576:
---
Hi [~enis]
We require {code} std::mutex
[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951894#comment-15951894
]
Enis Soztutar commented on HBASE-17576:
---
- Here, ActionsByServer is already a hash map, but you are
[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951716#comment-15951716
]
Enis Soztutar commented on HBASE-17576:
---
- This should be ordered reverse?
{code}
+ return
[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933661#comment-15933661
]
Enis Soztutar commented on HBASE-17576:
---
- You should not stop the cpu executor when Batch caller
[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898352#comment-15898352
]
Enis Soztutar commented on HBASE-17576:
---
- Some of these should be {{int32_t}} or {{size_t}}:
[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867141#comment-15867141
]
Enis Soztutar commented on HBASE-17576:
---
- This does not look correct:
{code}
+
[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867110#comment-15867110
]
Enis Soztutar commented on HBASE-17576:
---
Thanks Sudeep for the patches.
In v2 patch, you don't
12 matches
Mail list logo
