[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164902#comment-16164902 ] Hudson commented on HBASE-17823: FAILURE: Integrated in Jenkins build HBase-2.0 #508 (See [https://builds.apache.org/job/HBase-2.0/508/]) HBASE-17823 Migrate to Apache Yetus Audience Annotations (busbey: rev d576e5a32db930f99beb3e9fc33649b660e907f9) * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedString.java * (edit) hbase-common/src/saveVersion.sh * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/EncryptionUtil.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawBytes.java * (edit) hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/ColumnAggregationEndpoint.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SkipFilter.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/RegionException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaExceededException.java * (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/util/vint/UVIntTool.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/UnknownProtocolException.java * (edit) hbase-examples/pom.xml * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/Coprocessor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Cancellable.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawBytesFixedLength.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapred/TableRecordReader.java * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/exceptions/IllegalArgumentIOException.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultStatsUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/RestoreTool.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/CryptoCipherProvider.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCoprocessorRpcChannelImpl.java * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsHeapMemoryManagerSourceImpl.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/FailedSanityCheckException.java * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableHistogram.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionLocateType.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferWriter.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/DelayingRunner.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/util/AbstractHBaseToolTest.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/ExtendedCell.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RemoteWithExtrasException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/CryptoAESUnwrapHandler.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/metrics/ServerSideScanMetrics.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcController.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Row.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterFilesystemSourceImpl.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableRegionLocatorImpl.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/util/LoadTestKVGenerator.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReflectionUtils.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZooKeeperRegistry.java * (edit)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164748#comment-16164748 ] stack commented on HBASE-17823: --- [~busbey] Follow-on. Thanks for getting this in. > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch, > HBASE-17823.2.patch, HBASE-17823.3.patch, HBASE-17823-branch-2.v3.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[
https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164678#comment-16164678
]
Hadoop QA commented on HBASE-17823:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
53s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 195 new or modified
test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
51s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
56s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m
23s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
33s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 8m
47s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly
hbase-shaded . hbase-archetypes {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 14m
5s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
33s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 6m
24s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
19s{color} | {color:red} hbase-thrift in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
12s{color} | {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
13s{color} | {color:red} hbase-shell in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
12s{color} | {color:red} hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
14s{color} | {color:red} hbase-it in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
14s{color} | {color:red} hbase-examples in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
13s{color} | {color:red} hbase-rest in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
36s{color} | {color:red} hbase-spark in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
12s{color} | {color:red} hbase-spark-it in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
27s{color} | {color:red} hbase-archetypes in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 12m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 12m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 8m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} pylint {color} | {color:green} 0m
6s{color} | {color:green} There were no new pylint issues. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
5s{color} | {color:green} There were no new shellcheck issues. {color} |
|
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164508#comment-16164508 ] Sean Busbey commented on HBASE-17823: - pushed to branch-2. bq. Does it mean we can have errorprone in hbase2? We'd have to do a bit more work it seems since you have the bare minimum of hbase-build-configuration module. no errorprone in branch-2. I purposefully didn't include those changes. If we wanted it we'd still need to cherry-pick that full patch that introduced the build-configuration module in master. bq. The new hbase-build-configuration/pom.xml depends on hbase-annotations test. It needs it? I left the test dependency on hbase-annotations test since it was in the master hbase-build-configuration. I figured it was there so modules with java code could annotation tests as Small/Medium/Large. It occurs to me that several modules declare that dependency themselves so maybe neither branch actually needs it. follow on work? > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch, > HBASE-17823.2.patch, HBASE-17823.3.patch, HBASE-17823-branch-2.v3.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164295#comment-16164295 ] stack commented on HBASE-17823: --- Does it mean we can have errorprone in hbase2? We'd have to do a bit more work it seems since you have the bare minimum of hbase-build-configuration module. We are in a bit of limbo at the mo with this patch in master but not in hbase2... and it touches everything so all patches from here on on out are not going to cherry-pick easy. For that reason we should just commit this to branch-2 (smile). Other reasons to commit to branch-2 are the nice code removals and removal of hbase-annotations from a few poms. I skimmed the 1.8 megs of one line changes... seems fine (again -- smile). The new hbase-build-configuration/pom.xml depends on hbase-annotations test. It needs it? Thanks for the changes that allow us remove this hackery of mine: 4 // @InterfaceAudience.Private 55 // This class has NO InterfaceAudience. It is commented out. We do not want to import 56 // InterfaceAudience. This would be only class in this module with the IA import and we do not want 57 // to have this module depend annotations module just for one class. 58 // NO InterfaceAudience defaults to mean InterfaceAudience.Private! 55 @InterfaceAudience.Private I think its fine [~busbey] Even in branch-2 we'll be wanting to build out hbase-build-configuration facility. +1 > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch, > HBASE-17823.2.patch, HBASE-17823.3.patch, HBASE-17823-branch-2.v3.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164199#comment-16164199 ] Hudson commented on HBASE-17823: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3707 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3707/]) HBASE-17823 Migrate to Apache Yetus Audience Annotations (busbey: rev 4b124913f0d816c5ba81e45f7aab1864520924bc) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/AvlUtil.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java * (edit) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestSystemTableSnapshot.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedBlob.java * (delete) hbase-annotations/src/main/java/org/apache/hadoop/hbase/classification/tools/IncludePublicAnnotationsStandardDoclet.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapred/GroupingTableMap.java * (delete) hbase-annotations/src/main/java/org/apache/hadoop/hbase/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/MemoryCompactionPolicy.java * (edit) hbase-metrics/pom.xml * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/ShadedAccessControlUtil.java * (edit) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/Meter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/MobCompactPartitionPolicy.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/master/RegionState.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/NoTagsByteBufferKeyValue.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/IdentityTableReducer.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/regionserver/WrongRegionException.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellScanner.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/DoNotRetryRegionException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/UserPermission.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyOnlyKeyValue.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Decryptor.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/LRUDictionary.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawLong.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/RegionTooBusyException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFuture.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java * (edit) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistries.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Batch.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClient.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java * (edit) hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/package-info.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/ExceptionUtil.java * (edit) hbase-prefix-tree/pom.xml * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/exceptions/UnexpectedStateException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerAbortedException.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/aes/AESDecryptor.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/IndividualBytesFieldCellBuilder.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableBuilder.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/Addressing.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexCodecV1.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/OperationWithAttributes.java * (edit)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164066#comment-16164066 ] Sean Busbey commented on HBASE-17823: - pushed to master after rebasing again. working on branch-2 now. will post both patches as pushed here when done. > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch, > HBASE-17823.2.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161820#comment-16161820 ] Misty Stanley-Jones commented on HBASE-17823: - v2 LGTM! Docs are more clear. Thank you! > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch, > HBASE-17823.2.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[
https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161539#comment-16161539
]
Hadoop QA commented on HBASE-17823:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
48s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
1s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 197 new or modified
test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
0s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 9m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
27s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-build-configuration hbase-shaded . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 17m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 10m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 6m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
20s{color} | {color:red} hbase-thrift in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
13s{color} | {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
12s{color} | {color:red} hbase-shell in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
12s{color} | {color:red} hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
13s{color} | {color:red} hbase-it in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
14s{color} | {color:red} hbase-rest in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
35s{color} | {color:red} hbase-spark in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 10m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 7m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} pylint {color} | {color:green} 0m
10s{color} | {color:green} There were no new pylint issues. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
6s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
23s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green}
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159699#comment-16159699 ] Sean Busbey commented on HBASE-17823: - okay, let me get [~misty]'s docs feedback from the PR in place. > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159689#comment-16159689 ] stack commented on HBASE-17823: --- +1 for hbase2 at least. > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149147#comment-16149147 ] Sean Busbey commented on HBASE-17823: - yeah the annotations are just a change of package name. My concern is that I haven't checked that e.g. JACC will handle "filter by this annotation in the 1st version and this other filter in the 2nd version". > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148457#comment-16148457 ] stack commented on HBASE-17823: --- bq. stack do I need to figure out how to do a comparison between HBase 1 w/ HBase annotations and HBase 2 after we're on Yetus annotations before I push this? I presume the vocabulary similar; i.e. hbase Private has a Yetus equiv and so on? If so, go ahead. No need to figure how to diff. > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148213#comment-16148213 ] Sean Busbey commented on HBASE-17823: - [~stack] do I need to figure out how to do a comparison between HBase 1 w/ HBase annotations and HBase 2 after we're on Yetus annotations before I push this? Anyone have opinions on maybe bringing this change back into branch-1? > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[
https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145971#comment-16145971
]
Hadoop QA commented on HBASE-17823:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
35s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 203 new or modified
test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 6m
57s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-build-configuration . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 13m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 5m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 11m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 11m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 7m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} pylint {color} | {color:green} 0m
7s{color} | {color:green} There were no new pylint issues. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
4s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
21s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 31s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-annotations hbase-build-configuration . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 18m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 10m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 6m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
9s{color} | {color:green} hbase-annotations in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
8s{color} | {color:green} hbase-build-configuration in
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145682#comment-16145682 ] Sean Busbey commented on HBASE-17823: - could have them get fixed as we modify files in the future. or I could install an IDE that will do an automatic sort of imports, but I presume that will catch more than just these instances. > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[
https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145545#comment-16145545
]
Josh Elser commented on HBASE-17823:
Nit: I can see your {{sed}} magic at work, but that also messed up the import
sort-order (common case is an {{o.a.yetus}} import in the middle of the
{{o.a.hadoop.hbase}} section). I'm not sure of an easy way to fix that across
hundreds of files however...
> Migrate to Apache Yetus Audience Annotations
>
>
> Key: HBASE-17823
> URL: https://issues.apache.org/jira/browse/HBASE-17823
> Project: HBase
> Issue Type: Improvement
> Components: API
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
> Fix For: 2.0.0
>
> Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch
>
>
> Migrate from our own audience annotation handling to apache yetus'
> implementation.
> [discussion thread on
> dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[
https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145546#comment-16145546
]
Josh Elser commented on HBASE-17823:
Nit: I can see your {{sed}} magic at work, but that also messed up the import
sort-order (common case is an {{o.a.yetus}} import in the middle of the
{{o.a.hadoop.hbase}} section). I'm not sure of an easy way to fix that across
hundreds of files however...
> Migrate to Apache Yetus Audience Annotations
>
>
> Key: HBASE-17823
> URL: https://issues.apache.org/jira/browse/HBASE-17823
> Project: HBase
> Issue Type: Improvement
> Components: API
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
> Fix For: 2.0.0
>
> Attachments: HBASE-17823.0.patch, HBASE-17823.1.patch
>
>
> Migrate from our own audience annotation handling to apache yetus'
> implementation.
> [discussion thread on
> dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134526#comment-16134526 ] Misty Stanley-Jones commented on HBASE-17823: - That would work, or just keep the doc changes in a separate commit during PR review (you can review each commit separately) and then squash them before push. > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > Attachments: HBASE-17823.0.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134207#comment-16134207 ] Sean Busbey commented on HBASE-17823: - want me to do that as a follow-on so that the change set in the github PR is smaller? > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > Attachments: HBASE-17823.0.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134205#comment-16134205 ] Misty Stanley-Jones commented on HBASE-17823: - It builds and I don't see any problems. If you'd like to work together on the doc changes, can you just open a Github PR and tag me there so I can commit into it? > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > Attachments: HBASE-17823.0.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134195#comment-16134195 ] Sean Busbey commented on HBASE-17823: - excellent catch. I'll post a new patch with that section updated later tonight. > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > Attachments: HBASE-17823.0.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134190#comment-16134190 ] Misty Stanley-Jones commented on HBASE-17823: - Please have a look at http://hbase.apache.org/book.html#hbase.client.api.surface and make sure nothing needs changing due to this. > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > Attachments: HBASE-17823.0.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134125#comment-16134125 ] Sean Busbey commented on HBASE-17823: - ran through TestInterfaceAudienceAnnotations, which worked. Also ran through maven site and checked that generated javadocs still properly handle split between public and non-public classes. > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > Attachments: HBASE-17823.0.patch > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069924#comment-16069924 ] Sean Busbey commented on HBASE-17823: - I can put up a patch shortly. > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069113#comment-16069113 ] stack commented on HBASE-17823: --- All subtasks complete. Can we resolve this parent issue [~busbey] > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17823) Migrate to Apache Yetus Audience Annotations
[ https://issues.apache.org/jira/browse/HBASE-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938668#comment-15938668 ] Sean Busbey commented on HBASE-17823: - linking our recent changes to the annotations module to make sure those same things aren't needed over in yetus. > Migrate to Apache Yetus Audience Annotations > > > Key: HBASE-17823 > URL: https://issues.apache.org/jira/browse/HBASE-17823 > Project: HBase > Issue Type: Improvement > Components: API >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 2.0.0 > > > Migrate from our own audience annotation handling to apache yetus' > implementation. > [discussion thread on > dev@hbase|https://lists.apache.org/thread.html/5a83d37c9c763b3fc4114231489a073167ac69dbade9774af5ca4fb4@%3Cdev.hbase.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.3.15#6346)
