[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999269#comment-15999269
]
Hudson commented on HBASE-17862:
FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #223 (See
[https://builds.apache.org/job/HBase-HBASE-14614/223/])
HBASE-17862 Fix a condition that always returns true (chia7712: rev
c0f265384f09d5b36e2065083922ba428edef798)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Assignee: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993706#comment-15993706
]
Hudson commented on HBASE-17862:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2938 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/2938/])
HBASE-17862 Fix a condition that always returns true (chia7712: rev
c0f265384f09d5b36e2065083922ba428edef798)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Assignee: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993568#comment-15993568
]
Hudson commented on HBASE-17862:
SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #155 (See
[https://builds.apache.org/job/HBase-1.3-JDK7/155/])
HBASE-17862 Fix a condition that always returns true (chia7712: rev
8bfef58a4690abed1a201558282380b63efc708c)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Assignee: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993570#comment-15993570
]
Hudson commented on HBASE-17862:
SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #169 (See
[https://builds.apache.org/job/HBase-1.3-JDK8/169/])
HBASE-17862 Fix a condition that always returns true (chia7712: rev
8bfef58a4690abed1a201558282380b63efc708c)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Assignee: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993544#comment-15993544
]
Hudson commented on HBASE-17862:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #129 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/129/])
HBASE-17862 Fix a condition that always returns true (chia7712: rev
dfd07710c53c5488d24ccdb3e67f82c6969f78f4)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Assignee: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993519#comment-15993519
]
Hudson commented on HBASE-17862:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #125 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/125/])
HBASE-17862 Fix a condition that always returns true (chia7712: rev
dfd07710c53c5488d24ccdb3e67f82c6969f78f4)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Assignee: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993513#comment-15993513
]
Hudson commented on HBASE-17862:
SUCCESS: Integrated in Jenkins build HBase-1.1-JDK8 #1948 (See
[https://builds.apache.org/job/HBase-1.1-JDK8/1948/])
HBASE-17862 Fix a condition that always returns true (chia7712: rev
3f8636056150f1c50ad4e4eb2b0c239c6d89026d)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Assignee: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993504#comment-15993504
]
Hudson commented on HBASE-17862:
FAILURE: Integrated in Jenkins build HBase-1.4 #715 (See
[https://builds.apache.org/job/HBase-1.4/715/])
HBASE-17862 Fix a condition that always returns true (chia7712: rev
3a3cb48e2bd804388cea13f2145eef0d40894ac6)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Assignee: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993501#comment-15993501
]
Hudson commented on HBASE-17862:
SUCCESS: Integrated in Jenkins build HBase-1.1-JDK7 #1865 (See
[https://builds.apache.org/job/HBase-1.1-JDK7/1865/])
HBASE-17862 Fix a condition that always returns true (chia7712: rev
3f8636056150f1c50ad4e4eb2b0c239c6d89026d)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Assignee: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993292#comment-15993292
]
Hudson commented on HBASE-17862:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #36 (See
[https://builds.apache.org/job/HBase-1.3-IT/36/])
HBASE-17862 Fix a condition that always returns true (chia7712: rev
8bfef58a4690abed1a201558282380b63efc708c)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Assignee: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993267#comment-15993267
]
Hudson commented on HBASE-17862:
SUCCESS: Integrated in Jenkins build HBase-1.2-IT #864 (See
[https://builds.apache.org/job/HBase-1.2-IT/864/])
HBASE-17862 Fix a condition that always returns true (chia7712: rev
dfd07710c53c5488d24ccdb3e67f82c6969f78f4)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Assignee: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993243#comment-15993243
]
Chia-Ping Tsai commented on HBASE-17862:
[~lifove] Would you please close the pull request in Github? Thanks.
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Assignee: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992690#comment-15992690
]
Chia-Ping Tsai commented on HBASE-17862:
Will commit it tomorrow if no complaint.
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992594#comment-15992594
]
Hadoop QA commented on HBASE-17862:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
29s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
51s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
9s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 40s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 32s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 8s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12865866/0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
|
| JIRA Issue | HBASE-17862 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 2f937bc86656 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20
09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c8a7e80 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/6660/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/6660/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Priority:
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992285#comment-15992285
]
Chia-Ping Tsai commented on HBASE-17862:
LGTM. +1 if QA is fine.
[~busbey] Could you assign this issue to [~lifove] ? Thanks.
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Priority: Trivial
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992280#comment-15992280
]
JC commented on HBASE-17862:
I've just attached the patch. (This is the first time to submit a patch in this
way. I have no idea if I submitted correctly here.) Thanks!
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Priority: Trivial
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992013#comment-15992013
]
Chia-Ping Tsai commented on HBASE-17862:
ping [~lifove].
Would you please submit a patch here?
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Priority: Trivial
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989098#comment-15989098
]
Yi Liang commented on HBASE-17862:
--
Hi JC,
we usually provide a patch and attach it under this JIRA instead of create a
pull request.
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Priority: Trivial
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951903#comment-15951903
]
JC commented on HBASE-17862:
Thanks for the comment. I've create a pull request:
https://github.com/apache/hbase/pull/47
Thanks!
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Priority: Trivial
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17862) Condition that always returns true
[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951883#comment-15951883
]
Sean Busbey commented on HBASE-17862:
-
looks like a legit bug. Are you interested in putting together a patch to fix
it?
> Condition that always returns true
> --
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: JC
>Priority: Trivial
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
