[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576337#comment-16576337
]
Hudson commented on HBASE-18201:
Results for branch master
[build #424 on
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576124#comment-16576124
]
Hudson commented on HBASE-18201:
Results for branch branch-2
[build #1088 on
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576111#comment-16576111
]
Hudson commented on HBASE-18201:
Results for branch branch-2.1
[build #166 on
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575728#comment-16575728
]
Kuan-Po Tseng commented on HBASE-18201:
---
[~reidchan] OK, I will find a day to backport this to
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575725#comment-16575725
]
Reid Chan commented on HBASE-18201:
---
I just tried cherry-pick to branch-1, it may need some more
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575724#comment-16575724
]
Chia-Ping Tsai commented on HBASE-18201:
+1 Nice patch [~brandboat]!
> add UT and docs for
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575723#comment-16575723
]
Reid Chan commented on HBASE-18201:
---
Thanks for contribution, [~brandboat]
> add UT and docs for
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575722#comment-16575722
]
Reid Chan commented on HBASE-18201:
---
Pushed to master, branch-2 and branch-2.1.
> add UT and docs for
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574896#comment-16574896
]
Duo Zhang commented on HBASE-18201:
---
+1 for branch-2.1.
> add UT and docs for DataBlockEncodingTool
>
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574234#comment-16574234
]
Kuan-Po Tseng commented on HBASE-18201:
---
[~reidchan] No problem.
> add UT and docs for
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574222#comment-16574222
]
Reid Chan commented on HBASE-18201:
---
ping [~brandboat], Can you provide a patch for branch-1 also?
>
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574217#comment-16574217
]
Reid Chan commented on HBASE-18201:
---
Will commit it late this day if no further comments.
ping
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572656#comment-16572656
]
Reid Chan commented on HBASE-18201:
---
Any comment? [~chia7712]
> add UT and docs for
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571845#comment-16571845
]
Hadoop QA commented on HBASE-18201:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571423#comment-16571423
]
Reid Chan commented on HBASE-18201:
---
Failed tests are due to timeout, not related.
|(/)
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571411#comment-16571411
]
Hadoop QA commented on HBASE-18201:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570122#comment-16570122
]
Kuan-Po Tseng commented on HBASE-18201:
---
[~reidchan] Thanks for your review.
{quote} Is
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570040#comment-16570040
]
Reid Chan commented on HBASE-18201:
---
{quote}2. Can check other available Compression.Algorithm as
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569932#comment-16569932
]
Reid Chan commented on HBASE-18201:
---
I think we need one more vote to let this go, since i'm not
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569931#comment-16569931
]
Reid Chan commented on HBASE-18201:
---
lgtm, overall.
You may need rebase again, i tried {{git apply}}
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569728#comment-16569728
]
Kuan-Po Tseng commented on HBASE-18201:
---
[~reidchan] Could you take a look ?
> add UT and docs
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546187#comment-16546187
]
Hadoop QA commented on HBASE-18201:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545465#comment-16545465
]
Hadoop QA commented on HBASE-18201:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545111#comment-16545111
]
Kuan-Po Tseng commented on HBASE-18201:
---
It seems fail test isn't relate to this patch, resummit
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545068#comment-16545068
]
Hadoop QA commented on HBASE-18201:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544881#comment-16544881
]
Kuan-Po Tseng commented on HBASE-18201:
---
patch 005
- delete useless code.
- fix checkstyle issues.
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544586#comment-16544586
]
Hadoop QA commented on HBASE-18201:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544557#comment-16544557
]
Kuan-Po Tseng commented on HBASE-18201:
---
Patch 004
Bugs
* When HFile includeTags is true, it
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529364#comment-16529364
]
Kuan-Po Tseng commented on HBASE-18201:
---
No problem, I will add comments for every bug fixes,
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529362#comment-16529362
]
Reid Chan commented on HBASE-18201:
---
Dug deeper, and got your concern.
Would you mind adding some
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529358#comment-16529358
]
Reid Chan commented on HBASE-18201:
---
Got your point.
But still we can avoid this if branch: {{return
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529342#comment-16529342
]
Kuan-Po Tseng commented on HBASE-18201:
---
Sorry, I gave the wrong explain. The probolm is in
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527469#comment-16527469
]
Reid Chan commented on HBASE-18201:
---
bq. but still writes integer called unencodedDataSizeWritten
It
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527455#comment-16527455
]
Kuan-Po Tseng commented on HBASE-18201:
---
{quote}BufferedDataBlockEncoder should work as well?
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527290#comment-16527290
]
Reid Chan commented on HBASE-18201:
---
{{BufferedDataBlockEncoder}} should work as well? Those encoders
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527252#comment-16527252
]
Kuan-Po Tseng commented on HBASE-18201:
---
Thanks for reviewing, Reid Chan.
{quote}I think adjust
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527184#comment-16527184
]
Reid Chan commented on HBASE-18201:
---
Not sure if it is matter.
> add UT and docs for
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527174#comment-16527174
]
Reid Chan commented on HBASE-18201:
---
{code:title=DataBlockEncodingTool#checkStatistics}
rawKVs =
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527156#comment-16527156
]
Reid Chan commented on HBASE-18201:
---
{quote}
Encoder ROW_INDEX_V1 throw error, things go wrong in
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527115#comment-16527115
]
Kuan-Po Tseng commented on HBASE-18201:
---
[~chia7712] OK, will submit next patch soon, thanks for
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527110#comment-16527110
]
Chia-Ping Tsai commented on HBASE-18201:
We will get the useTag from the hfile rather than
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527099#comment-16527099
]
Kuan-Po Tseng commented on HBASE-18201:
---
Yes, I think the way to check if hfile use tag by getting
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527095#comment-16527095
]
Chia-Ping Tsai commented on HBASE-18201:
{quote}Could we replace the way checking *_useTag_*
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526485#comment-16526485
]
Kuan-Po Tseng commented on HBASE-18201:
---
Could we replace the way checking *_useTag_* with this
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526037#comment-16526037
]
Chia-Ping Tsai commented on HBASE-18201:
{quote}We need to go through all KVs and check if there
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526030#comment-16526030
]
Kuan-Po Tseng commented on HBASE-18201:
---
Yeah, that would be wrong, > 0 should be >=0. Will fix in
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526024#comment-16526024
]
Chia-Ping Tsai commented on HBASE-18201:
{quote} The reason useTag only checks the last KV is
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526008#comment-16526008
]
Kuan-Po Tseng commented on HBASE-18201:
---
[~chia7712] The reason useTag only checks the last KV is
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524687#comment-16524687
]
Kuan-Po Tseng commented on HBASE-18201:
---
[~chia7712] patch003 is as follows,
Bugs(4)
- Encoder
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524677#comment-16524677
]
Kuan-Po Tseng commented on HBASE-18201:
---
[~chia7712] Me too, I will correct it in the next patch.
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524622#comment-16524622
]
Chia-Ping Tsai commented on HBASE-18201:
I feel that is a bug also. The useTag is false only if
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524566#comment-16524566
]
Kuan-Po Tseng commented on HBASE-18201:
---
[~chia7712] I wasn't change the logic of the code, what I
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524547#comment-16524547
]
Chia-Ping Tsai commented on HBASE-18201:
{code:java}
+boolean useTag =
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524535#comment-16524535
]
Chia-Ping Tsai commented on HBASE-18201:
[~brandboat] Thanks for making this stale tool
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522639#comment-16522639
]
Hadoop QA commented on HBASE-18201:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521968#comment-16521968
]
Hadoop QA commented on HBASE-18201:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521802#comment-16521802
]
Chia-Ping Tsai commented on HBASE-18201:
retry
> add UT and docs for DataBlockEncodingTool
>
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516567#comment-16516567
]
Kuan-Po Tseng commented on HBASE-18201:
---
reattach patch to trigger testing.
> add UT and docs for
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513480#comment-16513480
]
Kuan-Po Tseng commented on HBASE-18201:
---
Hi [~chia7712] ! I am not sure if I meet all the needs.
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165908#comment-16165908
]
Chia-Ping Tsai commented on HBASE-18201:
sure
> add UT and docs for DataBlockEncodingTool
>
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165905#comment-16165905
]
Kuan-Po Tseng commented on HBASE-18201:
---
[~chia7712] May I take over this issue ?
> add UT and
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044662#comment-16044662
]
Chia-Ping Tsai commented on HBASE-18201:
I'm tring to eliminate the KeyValue references, but the
[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044605#comment-16044605
]
stack commented on HBASE-18201:
---
I like the suggestion that we just remove it but I don't think we can.
63 matches
Mail list logo
