[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525701#comment-16525701
]
Hudson commented on HBASE-19164:
Results for branch branch-2
[build #915 on
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525216#comment-16525216
]
Sahil Aggarwal commented on HBASE-19164:
Thanks a lot [~mdrob] for prompt reviews.
> Avoid
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524953#comment-16524953
]
Hadoop QA commented on HBASE-19164:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524747#comment-16524747
]
Hadoop QA commented on HBASE-19164:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523910#comment-16523910
]
Mike Drob commented on HBASE-19164:
---
Patch looks mostly fine, a few checkstyle issues that should be
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523339#comment-16523339
]
Hadoop QA commented on HBASE-19164:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523336#comment-16523336
]
Hadoop QA commented on HBASE-19164:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523153#comment-16523153
]
Sahil Aggarwal commented on HBASE-19164:
Rebased the patch.
> Avoid UUID.randomUUID in tests
>
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324537#comment-16324537
]
Mike Drob commented on HBASE-19164:
---
Attempted to rerun the precommit, patch probably needs a rebase...
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324535#comment-16324535
]
Hadoop QA commented on HBASE-19164:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248817#comment-16248817
]
Sahil Aggarwal commented on HBASE-19164:
These tests are passing on my local but timing out on
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247269#comment-16247269
]
Hadoop QA commented on HBASE-19164:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247008#comment-16247008
]
Hadoop QA commented on HBASE-19164:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246996#comment-16246996
]
Mike Drob commented on HBASE-19164:
---
bq. Shall i do "Submit Patch" to trigger the QA?
Yes, please.
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246986#comment-16246986
]
Sahil Aggarwal commented on HBASE-19164:
Attached the patch.
Have added helper method in
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242161#comment-16242161
]
Mike Drob commented on HBASE-19164:
---
Yea, that's probably sufficient.
Maybe make a helper method in
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241483#comment-16241483
]
Sahil Aggarwal commented on HBASE-19164:
I see multiple tests using ```UUID.randomUUID()```, do
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236667#comment-16236667
]
Mike Drob commented on HBASE-19164:
---
[~apurtell]'s suggestion on HBASE-19150
{quote}
Generally I think
[
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1623#comment-1623
]
Mike Drob commented on HBASE-19164:
---
It's probably sufficient to use something like {{Random.nextLong}}
19 matches
Mail list logo
