[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390086#comment-16390086
]
Josh Elser commented on HBASE-20108:
Thanks, sir.
Pushing to those two branches now. Adding my omitted Signed-Off-By on those
branches (forgot it on Master, sorry Mike).
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch, HBASE-20108.003.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390048#comment-16390048
]
stack commented on HBASE-20108:
---
+1 on commit to branch-2 and branch-2.0. Thanks [~elserj]
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch, HBASE-20108.003.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390038#comment-16390038
]
Josh Elser commented on HBASE-20108:
[~stack], in case you're keeping a list, would like to land this one for 2.0.0
when permitted. Thanks.
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch, HBASE-20108.003.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387185#comment-16387185
]
Hudson commented on HBASE-20108:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4697 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4697/])
HBASE-20108 Remove jline exclusion from ZooKeeper (elserj: rev
2402f1fd43fbe04ecce8bac67d31931251bcac6c)
* (edit) hbase-assembly/pom.xml
* (edit) hbase-assembly/src/main/assembly/hadoop-two-compat.xml
* (edit) bin/hbase
* (edit) pom.xml
* (edit) bin/hbase.cmd
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch, HBASE-20108.003.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386706#comment-16386706
]
Josh Elser commented on HBASE-20108:
Thanks, Mike!
FYI [~stack], this would be a good one if you re-roll another beta2 RC.
Otherwise, I'll wait for your all-clear to commit to branch-2.
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch, HBASE-20108.003.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386686#comment-16386686
]
Mike Drob commented on HBASE-20108:
---
+1
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch, HBASE-20108.003.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382834#comment-16382834
]
Hadoop QA commented on HBASE-20108:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
28s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
4s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
47s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
29s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
17s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
32s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
2s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
0s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
14m 50s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}195m
41s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
46s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}244m 15s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db |
| JIRA Issue | HBASE-20108 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12912632/HBASE-20108.003.branch-2.patch
|
| Optional Tests | asflicense shellcheck shelldocs javac javadoc unit
shadedjars hadoopcheck xml compile |
| uname | Linux 286648c07dd8 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-2 / 4547edbfe0 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| shellcheck | v0.4.4 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11747/testReport/ |
| Max. process+thread count | 4535 (vs. ulimit of 1) |
| modules | C: hbase-assembly . U: . |
| Console output |
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382546#comment-16382546
]
Hadoop QA commented on HBASE-20108:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
10s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
39s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
13s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
4s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
26s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
4s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
1s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
14m 36s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}155m
19s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
47s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}194m 21s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db |
| JIRA Issue | HBASE-20108 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12912620/HBASE-20108.002.branch-2.patch
|
| Optional Tests | asflicense shellcheck shelldocs javac javadoc unit
shadedjars hadoopcheck xml compile |
| uname | Linux cd19cb9e4677 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-2 / a08ade9f1a |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| shellcheck | v0.4.4 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11745/testReport/ |
| Max. process+thread count | 4607 (vs. ulimit of 1) |
| modules | C: hbase-assembly . U: . |
| Console output |
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382468#comment-16382468
]
Josh Elser commented on HBASE-20108:
{quote}Testing against h2 and h3? I suspect there's no difference, and don't
need it before commit, but a statement on what you've done would be good.
{quote}
Yup, just tested H3. No issues (as expected).
{quote}Do we need to update hbase.cmd? Maybe a follow on issue for discussing
the level of support that it needs?
{quote}
Looks like it, but I don't know how to test that one. Since Stack has asked for
silence on branch-2, I'll put up a new patch with some copy-paste from
elsewhere in hbase.cmd which I think will work.
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch, HBASE-20108.003.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382440#comment-16382440
]
Mike Drob commented on HBASE-20108:
---
Do we need to update hbase.cmd? Maybe a follow on issue for discussing the
level of support that it needs?
Testing against h2 and h3? I suspect there's no difference, and don't need it
before commit, but a statement on what you've done would be good.
Needs RN.
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382424#comment-16382424
]
Josh Elser commented on HBASE-20108:
{quote}After {{mvn package}} you can run {{bin/hbase}} directly.
{quote}
Ahh, thanks. Yes, this also works.
{quote}looks like jline shows up in the shaded-client/mapreduce modules now.
the rest of the approach looks really good, though!
{quote}
Pinged Mike offline and he confirmed that he was looking at v1. v2 doesn't have
this.
+1 from you folks after QA?
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382362#comment-16382362
]
Mike Drob commented on HBASE-20108:
---
bq. How do you run out of the dev tree
After {{mvn package}} you can run {{bin/hbase}} directly.
We generate some classpaths at
https://github.com/apache/hbase/blob/master/hbase-assembly/pom.xml#L109 and
then dev-tree classpaths are built in
https://github.com/apache/hbase/blob/master/bin/hbase#L321
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382348#comment-16382348
]
Josh Elser commented on HBASE-20108:
{quote}looks like jline shows up in the shaded-client/mapreduce modules now.
the rest of the approach looks really good, though!
{quote}
Blargh. Thanks for catching!
{quote}I assume this works both in dev tree and out of a bin tarball?
{quote}
Tested a local bin-tarball. How do you run out of the dev tree? I always end up
building a tarball if I want to launch something.
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382345#comment-16382345
]
Sean Busbey commented on HBASE-20108:
-
exactly the approach I was thinking
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382327#comment-16382327
]
Mike Drob commented on HBASE-20108:
---
looks like jline shows up in the shaded-client/mapreduce modules now. the rest
of the approach looks really good, though!
I assume this works both in dev tree and out of a bin tarball?
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382258#comment-16382258
]
Josh Elser commented on HBASE-20108:
.002 (re) introduces jline in {{lib/zkcli}} and then adds all JAR files from
{{lib/zkcli}} to the {{CLASSPATH}} when {{hbase zkcli}} is invoked.
Something like what you were thinking, [~busbey]?
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20108.001.branch-2.patch,
> HBASE-20108.002.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381380#comment-16381380
]
Hadoop QA commented on HBASE-20108:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
3s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
3s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 13m
3s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
24s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 3m
56s{color} | {color:red} patch has 13 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
14m 19s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}172m
20s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}211m 49s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db |
| JIRA Issue | HBASE-20108 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12912495/HBASE-20108.001.branch-2.patch
|
| Optional Tests | asflicense javac javadoc unit shadedjars hadoopcheck
xml compile |
| uname | Linux 4f79089cb915 3.13.0-137-generic #186-Ubuntu SMP Mon Dec 4
19:09:19 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-2 / 313464f007 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11730/testReport/ |
| Max. process+thread count | 4384 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11730/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments:
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381116#comment-16381116
]
Josh Elser commented on HBASE-20108:
bq. could we only include jline when zkcli is invoked? hate to add another
runtime dependency that's only used in one place.
Can try to do that!
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20108.001.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381104#comment-16381104
]
Sean Busbey commented on HBASE-20108:
-
could we only include jline when zkcli is invoked? hate to add another runtime
dependency that's only used in one place.
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20108.001.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20108) `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
[
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381101#comment-16381101
]
Josh Elser commented on HBASE-20108:
We exclude jline from the zookeeper dependency. I think we just need to undo
that..
> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> ---
>
> Key: HBASE-20108
> URL: https://issues.apache.org/jira/browse/HBASE-20108
> Project: HBase
> Issue Type: Bug
> Components: Usability
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20108.001.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling
> a version of jline to make sure that {{hbase zkcli}} actually works. As long
> as we're expecting {{zkcli}} to be there, we should provide jline on the
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
