[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-05-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479647#comment-16479647
 ] 

Hudson commented on HBASE-20500:


Results for branch branch-1.4
[build #324 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/324/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/324//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/324//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/324//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.4.5
>
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch, 
> HBASE-20500-master.v5.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-05-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478864#comment-16478864
 ] 

Hudson commented on HBASE-20500:


Results for branch branch-1
[build #318 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/318/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/318//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/318//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/318//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Fix For: 3.0.0, 2.1.0, 1.5.0, 1.4.5
>
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch, 
> HBASE-20500-master.v5.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-05-16 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478158#comment-16478158
 ] 

Andrew Purtell commented on HBASE-20500:


This needs to go into branch-1 as well. I will take care of it. 

See HBASE-20595 for further followup.

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch, 
> HBASE-20500-master.v5.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-05-15 Thread Andrew Purtell (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476570#comment-16476570
 ] 

Andrew Purtell commented on HBASE-20500:


Does this affect RSgroups in branch-1 too?

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch, 
> HBASE-20500-master.v5.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-05-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468766#comment-16468766
 ] 

Hudson commented on HBASE-20500:


Results for branch master
[build #325 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/325/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/325//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/325//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/325//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch, 
> HBASE-20500-master.v5.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-05-08 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468085#comment-16468085
 ] 

Hudson commented on HBASE-20500:


Results for branch branch-2
[build #711 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/711/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/711//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/711//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/711//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch, 
> HBASE-20500-master.v5.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-05-08 Thread Yechao Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467565#comment-16467565
 ] 

Yechao Chen commented on HBASE-20500:
-

what about branch-2 ,sir ? 

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch, 
> HBASE-20500-master.v5.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-05-08 Thread Yechao Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467563#comment-16467563
 ] 

Yechao Chen commented on HBASE-20500:
-

yes sir, i mean subject of the patch .

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch, 
> HBASE-20500-master.v5.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-05-08 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467560#comment-16467560
 ] 

Ted Yu commented on HBASE-20500:


JIRA in filename is already correct.
I was talking about the JIRA name in subject of the patch.


> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch, 
> HBASE-20500-master.v5.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-05-08 Thread Yechao Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467551#comment-16467551
 ] 

Yechao Chen commented on HBASE-20500:
-

thanks,

need i attach a new file named HBASE-20500-master.v6.patch to correct the Jira 
NAME ?

 

and  would it be merged to branch-2 ?

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch, 
> HBASE-20500-master.v5.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-05-08 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467000#comment-16467000
 ] 

Hadoop QA commented on HBASE-20500:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
19s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
20s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
12m 58s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
14s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 37m 15s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20500 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12922403/HBASE-20500-master.v5.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 7e08bf315e50 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 1825af45b3 |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12743/testReport/ |
| Max. process+thread count | 2681 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12743/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> [rsgroup] should keep at 

[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-05-08 Thread Yechao Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466941#comment-16466941
 ] 

Yechao Chen commented on HBASE-20500:
-

sorry for reply later,

thank you for your review and suggestion,[~yuzhih...@gmail.com]

change the code by your suggestion,

TestShellRSGroups   has passed locally.

 

submit v5 and retry qa

 

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch, 
> HBASE-20500-master.v5.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457864#comment-16457864
 ] 

Ted Yu commented on HBASE-20500:


I know long holiday is coming (May 1st).

Please take some rest - there is no hurry.

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1645#comment-1645
 ] 

Ted Yu commented on HBASE-20500:


Please also run TestShellRSGroups locally. It is in hbase-shell module which QA 
bot doesn't cover.

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457710#comment-16457710
 ] 

Ted Yu commented on HBASE-20500:


Please address the following in your next patch (on top of my suggestion above):
{code}
Caused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException: 
org.apache.hadoop.hbase.constraint.ConstraintException: RSGroup foo has 1 
servers; you must remove these servers from the RSGroup beforethe RSGroup can 
be removed.
at 
org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.removeRSGroup(RSGroupAdminServer.java:469)
at 
org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.removeRSGroup(RSGroupAdminEndpoint.java:252)
{code}

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457709#comment-16457709
 ] 

Ted Yu commented on HBASE-20500:


This was the error from first test failure (patch v1):
{code}
[ERROR] 
org.apache.hadoop.hbase.rsgroup.TestRSGroups.testMoveServersFromDefaultGroup(org.apache.hadoop.hbase.rsgroup.TestRSGroups)
[ERROR]   Run 1: 
TestRSGroups>TestRSGroupsBase.testMoveServersFromDefaultGroup:358
{code}
This was the failed assertion:
{code}
+  String exp = "should keep at least one server in 'default' RSGroup.";
+  assertTrue(ex.getMessage().contains(exp));
{code}
If you look at the spelling of the sentence in the test and spelling in 
RSGroupAdminServer.java, you would see why the test failed.

A better way of checking exception message:
{code}
+  throw new ConstraintException("should keep at least one server in 
'default' RSGroup.");
{code}
is to declare a (package private) String constant in RSGroupAdminServer and 
reference the constant in the test.

This way, even if the exception message is modified by anyone in the future, 
the test would still pass.

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457708#comment-16457708
 ] 

Hadoop QA commented on HBASE-20500:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
23s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
19s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
12m 53s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  5m 35s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 27s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestRSGroups |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20500 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12921150/HBASE-20500-master.v4.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux abda1bd48d6b 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11 
12:16:42 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / a136303833 |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12687/artifact/patchprocess/patch-unit-hbase-rsgroup.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12687/testReport/ |
| Max. process+thread count | 2695 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 

[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457700#comment-16457700
 ] 

Ted Yu commented on HBASE-20500:


https://builds.apache.org/job/PreCommit-HBASE-Build/12686/artifact/patchprocess/patch-unit-hbase-rsgroup.txt
 (most recent test run) gave me 404

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457697#comment-16457697
 ] 

Ted Yu commented on HBASE-20500:


It seems there is no material difference between v3 and v4.

In this case, you can attach v3 again which would be run by QA bot.
Naming new patch v4 may give people impression that something has changed while 
that is not the case.

TestRSGroups may be flaky - investigation should be carried out to find the 
cause.

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Yechao Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457691#comment-16457691
 ] 

Yechao Chen commented on HBASE-20500:
-

it seems v3 test failed and jenkins result is not my commit...

so submit v4 and retry qa

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch, HBASE-20500-master.v4.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457671#comment-16457671
 ] 

Hadoop QA commented on HBASE-20500:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
35s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
21s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
17m 50s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m  
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  3m 46s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m  3s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestRSGroups |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20500 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12921149/HBASE-20500-master.v3.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux e1d273ff891d 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / a136303833 |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12686/artifact/patchprocess/patch-unit-hbase-rsgroup.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12686/testReport/ |
| Max. process+thread count | 2647 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 

[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457644#comment-16457644
 ] 

Ted Yu commented on HBASE-20500:


Thanks for the quick turnaround.

Will wait for QA to report back.

Have a nice weekend, Yechao.

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Yechao Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457640#comment-16457640
 ] 

Yechao Chen commented on HBASE-20500:
-

[~yuzhih...@gmail.com]  thanks for review and submit patch v3  

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch, 
> HBASE-20500-master.v3.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457585#comment-16457585
 ] 

Ted Yu commented on HBASE-20500:


For the new test, please add the following at the end of the method:
{code}
LOG.info("Remove group "+fooGroup.getName());
rsGroupAdmin.removeRSGroup(fooGroup.getName());
{code}
Otherwise the foo group would stay, potentially interfering with subsequent 
tests since we have no control over the order of subtests.
{code}
   if (RSGroupInfo.DEFAULT_GROUP.equals(srcGrp.getName())) {
 checkOnlineServersOnly(servers);
   }
+
+  if (RSGroupInfo.DEFAULT_GROUP.equals(srcGrp.getName()) && 
srcGrp.getServers().size() <=
+  servers.size()) {
{code}
As you can see, the new condition can actually be moved to under the condition 
directly above it.
It would be easier to read.

I ran TestRSGroups with patch v2 locally and it passed.

Once the above comments are addressed, I will integrate.

Thanks

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457444#comment-16457444
 ] 

Hadoop QA commented on HBASE-20500:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
52s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
49s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
14m 22s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
10s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 51s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20500 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12921120/HBASE-20500-master.v2.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux a9a2d6546082 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 59f6ecd6b2 |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12684/testReport/ |
| Max. process+thread count | 2654 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12684/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> [rsgroup] should keep 

[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Yechao Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457431#comment-16457431
 ] 

Yechao Chen commented on HBASE-20500:
-

retry qa for master-v2

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch, HBASE-20500-master.v2.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457415#comment-16457415
 ] 

Hadoop QA commented on HBASE-20500:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
18s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
20s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
13m  6s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  5m  3s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
10s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 26s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestRSGroups |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20500 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12921109/HBASE-20500-master.v1.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 3c09501dfccd 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11 
12:16:42 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 59f6ecd6b2 |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12683/artifact/patchprocess/patch-unit-hbase-rsgroup.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12683/testReport/ |
| Max. process+thread count | 2735 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 

[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-28 Thread Yechao Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457388#comment-16457388
 ] 

Yechao Chen commented on HBASE-20500:
-

try qa

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch, 
> HBASE-20500-master.v1.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-27 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456533#comment-16456533
 ] 

Ted Yu commented on HBASE-20500:


Once patch for master is accepted, it would be merged to branch-2.

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-27 Thread Yechao Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456159#comment-16456159
 ] 

Yechao Chen commented on HBASE-20500:
-

[~yuzhih...@gmail.com] yes sir ,submit a patch

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-27 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456158#comment-16456158
 ] 

Ted Yu commented on HBASE-20500:


Can you generate patch for master branch ?

Also, can you add a test ?

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-20500-branch-2.v1.patch
>
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-27 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456151#comment-16456151
 ] 

Ted Yu commented on HBASE-20500:


There seems to be some typo in the error above.
Here is related code:
{code}
  throw new ConstraintException("Target RSGroup must have at least one 
server.");
{code}
Do you want to attach a patch ?

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
>
> we move all the servers from default group
> the default group will has  no servers,
> then we create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-20500) [rsgroup] should keep at least one server in default group

2018-04-27 Thread Yechao Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-20500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456150#comment-16456150
 ] 

Yechao Chen commented on HBASE-20500:
-

!create_table_with_empty_default_group.png!

> [rsgroup] should keep at least one server in default group
> --
>
> Key: HBASE-20500
> URL: https://issues.apache.org/jira/browse/HBASE-20500
> Project: HBase
>  Issue Type: Bug
>  Components: rsgroup
>Affects Versions: 2.0.0-beta-2
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
>
> we move all the servers from default group
> the default group will has  no servers,
> then we will create a  new table ,
> it will failed case of the default group has no servers
> eorr info is :
> EROOR: ConstraintException:Target RSGroup must have at lease on server
>  
> we should keep at least one server in 'default' RSGroup
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)