[jira] [Commented] (HBASE-20693) Refactor rest and thrift jsp's and extract header and footer
[ https://issues.apache.org/jira/browse/HBASE-20693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797440#comment-17797440 ] Duo Zhang commented on HBASE-20693: --- Any updates here [~nihaljain.cs]? Mind putting up a PR, as per [~ndimiduk] said? Thanks. > Refactor rest and thrift jsp's and extract header and footer > > > Key: HBASE-20693 > URL: https://issues.apache.org/jira/browse/HBASE-20693 > Project: HBase > Issue Type: Improvement >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Fix For: 3.0.0-beta-1 > > Attachments: HBASE-20693.master.001.patch, rest_home_after_patch.png, > thrift_home_after_patch.png, thrift_log_level_after_patch.png, > thrift_log_level_before_patch.png > > > Log Level page design was changed to include header and footers in > HBASE-20577. Since, thrift and rest do not have header and footer jsp's, the > log level page will be as it were before HBASE-20577 i.e without the > navigation bar. This JIRA will refactor rest and thrift and extract > 'header.jsp' and 'footer.jsp' from them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-20693) Refactor rest and thrift jsp's and extract header and footer
[ https://issues.apache.org/jira/browse/HBASE-20693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762656#comment-17762656 ] Nick Dimiduk commented on HBASE-20693: -- Heya [~nihaljain.cs] you have a +1 but do you mind putting this up as a PR on github? Thanks. > Refactor rest and thrift jsp's and extract header and footer > > > Key: HBASE-20693 > URL: https://issues.apache.org/jira/browse/HBASE-20693 > Project: HBase > Issue Type: Improvement >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Fix For: 3.0.0-beta-1 > > Attachments: HBASE-20693.master.001.patch, rest_home_after_patch.png, > thrift_home_after_patch.png, thrift_log_level_after_patch.png, > thrift_log_level_before_patch.png > > > Log Level page design was changed to include header and footers in > HBASE-20577. Since, thrift and rest do not have header and footer jsp's, the > log level page will be as it were before HBASE-20577 i.e without the > navigation bar. This JIRA will refactor rest and thrift and extract > 'header.jsp' and 'footer.jsp' from them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-20693) Refactor rest and thrift jsp's and extract header and footer
[ https://issues.apache.org/jira/browse/HBASE-20693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718916#comment-17718916 ] Nihal Jain commented on HBASE-20693: The REST part of this Jira is handled in HBASE-27814 > Refactor rest and thrift jsp's and extract header and footer > > > Key: HBASE-20693 > URL: https://issues.apache.org/jira/browse/HBASE-20693 > Project: HBase > Issue Type: Improvement >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Fix For: 3.0.0-alpha-4 > > Attachments: HBASE-20693.master.001.patch, rest_home_after_patch.png, > thrift_home_after_patch.png, thrift_log_level_after_patch.png, > thrift_log_level_before_patch.png > > > Log Level page design was changed to include header and footers in > HBASE-20577. Since, thrift and rest do not have header and footer jsp's, the > log level page will be as it were before HBASE-20577 i.e without the > navigation bar. This JIRA will refactor rest and thrift and extract > 'header.jsp' and 'footer.jsp' from them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-20693) Refactor rest and thrift jsp's and extract header and footer
[
https://issues.apache.org/jira/browse/HBASE-20693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757680#comment-16757680
]
Hadoop QA commented on HBASE-20693:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
19s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
24s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 21s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-20693 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12957160/HBASE-20693.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit |
| uname | Linux d92a9450bd1a 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct
5 08:56:16 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c5f4e84106 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/15819/testReport/ |
| Max. process+thread count | 2071 (vs. ulimit of 1) |
| modules | C: hbase-thrift hbase-rest U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/15819/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Refactor rest and thrift jsp's and extract header and footer
>
>
> Key: HBASE-20693
> URL: https://issues.apache.org/jira/browse/HBASE-20693
> Project: HBase
> Issue Type: Improvement
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20693.master.001.patch, rest_home_after_patch.png,
> thrift_home_after_patch.png, thrift_log_level_after_patch.png,
> thrift_log_level_before_patch.png
>
>
> Log Level page design was changed to include header and footers in
> HBASE-20577. Since, thrift and rest do not have header and footer jsp's, the
> log level page will be as it were before HBASE-20577 i.e without the
> navigation bar. This JIRA will refactor rest and thrift and extract
> 'header.jsp' and 'footer.jsp' from them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20693) Refactor rest and thrift jsp's and extract header and footer
[
https://issues.apache.org/jira/browse/HBASE-20693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757660#comment-16757660
]
Nihal Jain commented on HBASE-20693:
Attached [^HBASE-20693.master.001.patch] which refactors {{rest.jsp}} and
{{thrift.jsp}} and extracts header and footer out of them. Also, fixed
following typo in thrift.jsp.
{code:java}
- <%= VersionInfo.getVersion() %>, r<%= VersionInfo.getRevision() %>
+ <%= VersionInfo.getVersion() %>, revision=<%= VersionInfo.getRevision()
%>
{code}
Please review. Ping [~tianjingyun], [~zghaobac], [~stack].
> Refactor rest and thrift jsp's and extract header and footer
>
>
> Key: HBASE-20693
> URL: https://issues.apache.org/jira/browse/HBASE-20693
> Project: HBase
> Issue Type: Improvement
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20693.master.001.patch, rest_home_after_patch.png,
> thrift_home_after_patch.png, thrift_log_level_after_patch.png,
> thrift_log_level_before_patch.png
>
>
> Log Level page design was changed to include header and footers in
> HBASE-20577. Since, thrift and rest do not have header and footer jsp's, the
> log level page will be as it were before HBASE-20577 i.e without the
> navigation bar. This JIRA will refactor rest and thrift and extract
> 'header.jsp' and 'footer.jsp' from them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20693) Refactor rest and thrift jsp's and extract header and footer
[ https://issues.apache.org/jira/browse/HBASE-20693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503904#comment-16503904 ] Nihal Jain commented on HBASE-20693: Hi I have removed the patch and moved it to HBASE-20577 as addendum. In this JIRA I will refactor the jsp's of rest and thrift. > Refactor rest and thrift jsp's and extract header and footer > > > Key: HBASE-20693 > URL: https://issues.apache.org/jira/browse/HBASE-20693 > Project: HBase > Issue Type: Bug >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > > Log Level page design was changed to include header and footers in > HBASE-20577. Since, thrift and rest do not have header and footer jsp's, the > log level page will be as it were before HBASE-20577 i.e without the > navigation bar. This JIRA will refactor rest and thrift and extract > 'header.jsp' and 'footer.jsp' form them. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
