[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815971#comment-16815971 ] Hudson commented on HBASE-21129: Results for branch branch-2.0 [build #1512 on

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815956#comment-16815956 ] Hudson commented on HBASE-21129: Results for branch branch-2.1 [build #1046 on

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607275#comment-16607275 ] Hudson commented on HBASE-21129: Results for branch master [build #478 on

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605890#comment-16605890 ] Reid Chan commented on HBASE-21129: --- Thanks for sean's report and ted's addendum. > Clean up

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602916#comment-16602916 ] Hudson commented on HBASE-21129: Results for branch branch-2 [build #1198 on

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602790#comment-16602790 ] Hudson commented on HBASE-21129: Results for branch master [build #472 on

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602575#comment-16602575 ] Reid Chan commented on HBASE-21129: --- Thanks Ted, pushed to master branch and branch-2. > Clean up

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602561#comment-16602561 ] Ted Yu commented on HBASE-21129: Failed test doesn't involve Filter. Go ahead with commit. > Clean up

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602559#comment-16602559 ] Reid Chan commented on HBASE-21129: --- Any more comments, Ted? > Clean up duplicate codes in #equals

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602044#comment-16602044 ] Reid Chan commented on HBASE-21129: --- Unrelated failed test. > Clean up duplicate codes in #equals and

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602012#comment-16602012 ] Hadoop QA commented on HBASE-21129: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601821#comment-16601821 ] Hadoop QA commented on HBASE-21129: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599236#comment-16599236 ] Hadoop QA commented on HBASE-21129: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598961#comment-16598961 ] Hadoop QA commented on HBASE-21129: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598720#comment-16598720 ] Reid Chan commented on HBASE-21129: --- v5 fixed this warning: {{ColumnPaginationFilter.java:[243,19]

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598695#comment-16598695 ] Hadoop QA commented on HBASE-21129: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598498#comment-16598498 ] Ted Yu commented on HBASE-21129: Test failures were not related. After addressing FindBugs warning,

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598380#comment-16598380 ] Hadoop QA commented on HBASE-21129: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598196#comment-16598196 ] Hadoop QA commented on HBASE-21129: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598155#comment-16598155 ] Reid Chan commented on HBASE-21129: --- Thanks Ted. > Clean up duplicate codes in #equals and #hashCode

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598152#comment-16598152 ] Ted Yu commented on HBASE-21129: QA is back. Triggered a QA run. > Clean up duplicate codes in #equals

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597317#comment-16597317 ] Reid Chan commented on HBASE-21129: --- QA doesn't work...? > Clean up duplicate codes in #equals and

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596634#comment-16596634 ] Ted Yu commented on HBASE-21129: Thanks for the quick turn around. lgtm, pending QA. > Clean up

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596631#comment-16596631 ] Reid Chan commented on HBASE-21129: --- master.v2 adds hashCode() for {{FirstKeyOnlyFilter}} > Clean up

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596620#comment-16596620 ] Ted Yu commented on HBASE-21129: For FirstKeyOnlyFilter, can you use foundKV ? I don't have suggestion

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596615#comment-16596615 ] Reid Chan commented on HBASE-21129: --- bq. hashCode is dropped. This is because we are using

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596463#comment-16596463 ] Ted Yu commented on HBASE-21129: For FamilyFilter.java, hashCode is dropped. This is because we are

[jira] [Commented] (HBASE-21129) Clean up duplicate codes in #equals and #hashCode methods of Filter

[ https://issues.apache.org/jira/browse/HBASE-21129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596170#comment-16596170 ] Reid Chan commented on HBASE-21129: --- cc [~tedyu] > Clean up duplicate codes in #equals and #hashCode