[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2021-12-05 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17453769#comment-17453769 ] Yu Li commented on HBASE-24640: --- Just a note here, that please use

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239232#comment-17239232 ] Hudson commented on HBASE-24640: Results for branch branch-2 [build #112 on

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239216#comment-17239216 ] Hudson commented on HBASE-24640: Results for branch master [build #138 on

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239072#comment-17239072 ] Hudson commented on HBASE-24640: Results for branch branch-1 [build #59 on

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239026#comment-17239026 ] Duo Zhang commented on HBASE-24640: --- My point is that this is a common thing in java world so if we do

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239013#comment-17239013 ] Andrew Kyle Purtell commented on HBASE-24640: - VisibleForTesting binds us to Guava for no

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239010#comment-17239010 ] Duo Zhang commented on HBASE-24640: --- I would say that on a IA.Private class it is fine to add

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-23 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237672#comment-17237672 ] Andrew Kyle Purtell commented on HBASE-24640: - [~reidchan] This looks like something I can

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-23 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237667#comment-17237667 ] Andrew Kyle Purtell commented on HBASE-24640: - Here is what I plan to do: * Find all

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-23 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237663#comment-17237663 ] Andrew Kyle Purtell commented on HBASE-24640: - Copying from the thread discussion, the full

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-11-23 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237661#comment-17237661 ] Andrew Kyle Purtell commented on HBASE-24640: - I encountered issues with VisibleForTesting

[jira] [Commented] (HBASE-24640) Purge use of VisibleForTesting

2020-08-10 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174407#comment-17174407 ] Wellington Chevreuil commented on HBASE-24640: -- +1 for the proposal on the comment