[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251623#comment-17251623
]
Hudson commented on HBASE-25246:
Results for branch branch-2.4
[build #10 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/10/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/10/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/10/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/10/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/10/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251273#comment-17251273
]
Hudson commented on HBASE-25246:
Results for branch branch-2.2
[build #137 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/137/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/137//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/137//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/137//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/137//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251266#comment-17251266
]
Hudson commented on HBASE-25246:
Results for branch branch-2
[build #130 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/130/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/130/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/130/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/130/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/130/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251241#comment-17251241 ] Rushabh Shah commented on HBASE-25246: -- Thank you [~vjasani] for the review and commit. Thank you [~anoop.hbase] for the idea and the review. > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 3.0.0-alpha-1, 1.7.0, 2.2.7, 2.3.4, 2.5.0, 2.4.1 > > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251239#comment-17251239
]
Hudson commented on HBASE-25246:
Results for branch branch-2.3
[build #125 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/125/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/125/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/125/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/125/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/125/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251168#comment-17251168
]
Hudson commented on HBASE-25246:
Results for branch branch-1
[build #65 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/65/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/65//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/65//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/65//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251074#comment-17251074
]
Hudson commented on HBASE-25246:
Results for branch master
[build #159 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/159/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/159/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/159/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/159/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250856#comment-17250856 ] Viraj Jasani commented on HBASE-25246: -- Agree with [~anoop.hbase] 's comment and also this is backward compatible with existing patch releases, I don't see any issue there so let me include this in branch-2.3 and branch-2.4. > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 3.0.0-alpha-1, 1.7.0, 2.2.7, 2.3.4, 2.5.0, 2.4.1 > > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250416#comment-17250416 ] Anoop Sam John commented on HBASE-25246: IMO its a bug fix only and so should go to all active patch branches. > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.4.1 > > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250331#comment-17250331 ] Viraj Jasani commented on HBASE-25246: -- Thanks for this nice work [~shahrs87], the patch is committed to master, branch-2 and branch-1 as of now. Thanks [~anoop.hbase] for all your valuable inputs. Although some of the core (de)serialization of Cell in ProtobufUtil is modified, the current patch on branch-2 as is seem compatible with 2.3.3 and 2.4.0 releases. IMHO this would be a great addition to 2.3.4 and 2.4.1 releases. However, given the timeline, if we are not expecting such patch to land on branch-2.3 as of now, at least we can target branch-2.4 now and evaluate for 2.3.5 later. Any specific preference? [~apurtell] [~ndimiduk] [~huaxiangsun] > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0 > > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244192#comment-17244192
]
Hudson commented on HBASE-25246:
Results for branch branch-2
[build #120 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/120/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/120/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/120/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/120/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/120/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244154#comment-17244154
]
Hudson commented on HBASE-25246:
Results for branch branch-2.3
[build #119 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/119/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/119/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/119/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/119/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/119/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243988#comment-17243988
]
Hudson commented on HBASE-25246:
Results for branch master
[build #148 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/148/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/148/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/148/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/148/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243446#comment-17243446
]
Nick Dimiduk commented on HBASE-25246:
--
{quote}
This may need to wait until 2.5. Is it in-line with our compatibility
guidelines to introduce a feature on a patch release? Is this something that
rises to the level of a new feature? Not sure. Anyway I moved the fix version
to 2.5.0 for now.
{quote}
No, we do not add new features on a patch release. However, the definition of
"new feature" has some room for interpretation. For example, in this case, it
could be argued that "backup/restore" is the "feature" and omission of cell
tags was a "bug". Under that way of thinking, so long as backups created with a
2.3.x version before this patch can be restored by a 2.3.x after this patch,
and so long as backups created with a 2.3.x version after this patch can be
restored by a 2.3.x before this patch, it would be permissible.
In general, I try to be as flexible as possible for adding changes that provide
user-facing conveniences as "enhancements" while draconian strict on changes to
core runtime components. I consider {{ProtobufUtil}} to be a core runtime
component, so I would demand a high level of testing before accepting this into
branch-2.3.
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243443#comment-17243443
]
Hudson commented on HBASE-25246:
Results for branch branch-2.2
[build #132 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/132/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/132//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/132//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/132//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243426#comment-17243426
]
Hudson commented on HBASE-25246:
Results for branch branch-2
[build #119 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/119/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/119/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/119/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/119/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/119/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243414#comment-17243414 ] Andrew Kyle Purtell commented on HBASE-25246: - [~shahrs87] No need to apologize! If it's not 100% yet it's important to revert and improve. > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0 > > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243394#comment-17243394 ] Rushabh Shah commented on HBASE-25246: -- > This may need to wait until 2.5. [~apurtell] Sounds good. Apologies that you have to spin a new RC due to revert of this jira. > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0 > > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243392#comment-17243392 ] Andrew Kyle Purtell commented on HBASE-25246: - The way the RC process works we already have commits and tags for RC0, so I'm just going to move on and start a RC1. Thanks for the heads up. > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0 > > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243390#comment-17243390 ] Andrew Kyle Purtell commented on HBASE-25246: - This may need to wait until 2.5. Is it in-line with our compatibility guidelines to introduce a feature on a patch release? Is this something that rises to the level of a new feature? Not sure. Anyway I moved the fix version to 2.5.0 for now. > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 3.0.0-alpha-1, 2.2.7, 2.3.4, 2.5.0, 2.4.1 > > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243389#comment-17243389
]
Hudson commented on HBASE-25246:
Results for branch branch-2.3
[build #118 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/118/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/118/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/118/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/118/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/118/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243312#comment-17243312
]
Viraj Jasani commented on HBASE-25246:
--
RSRpcServices has this logic:
{code:java}
if (clientCellBlockSupported) {
for (Result res : results) {
builder.addCellsPerResult(res.size());
builder.addPartialFlagPerResult(res.mayHaveMoreCellsInRow());
}
controller.setCellScanner(CellUtil.createCellScanner(results));
} else {
for (Result res : results) {
ClientProtos.Result pbr = ProtobufUtil.toResult(res);
builder.addResults(pbr);
}
}
{code}
Hence, if client doesn't have cellBlock supported, we go to
ProtobufUtil.toResult(final Result result), which internally calls
ProtobufUtil.toCell(final Cell kv) and hence, kvbuilder.setTags() (as per PR
#2706) is executed.
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243294#comment-17243294 ] Viraj Jasani commented on HBASE-25246: -- Apologies for this last minute work. [~apurtell] I have updated fixed version to 2.4.1, and reverting the commit. > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 3.0.0-alpha-1, 2.2.7, 2.3.4, 2.4.1 > > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243291#comment-17243291 ] Viraj Jasani commented on HBASE-25246: -- [~anoop.hbase] I just tried to test client without codec scenario by running test TestScannersFromClientSide.testScanRawDeleteFamilyVersion() and indeed when we override *hbase.client.rpc.codec* and *hbase.client.default.rpc.codec* both with empty string, code path that we are concerned about i.e both ProtobufUtil.toCell() methods that are modified with this Jira are executed as part of proto conversion. [~shahrs87] you can try running above test to debug further. Let me revert commits in the meanwhile. > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.4 > > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243181#comment-17243181 ] Viraj Jasani commented on HBASE-25246: -- [~anoop.hbase] has raised some concerns for client side cellblock support. After this change, even though client which does not support codec (e.g either non-Java client or client with disabled codec), we will still return tags. [~shahrs87] can you once try to validate this usecase in simple Get/Scan APIs from client side? I know you have already used "-Dhbase.client.rpc.codec=org.apache.hadoop.hbase.codec.KeyValueCodecWithTags" for Export tests, however a couple of client side tests confirming these two use-cases will be really helpful. # With KeyValueCodecWithTags, we return all tags in response # With default KeyValueCodec, we don't return any tag in response If we still have slight doubt, let me revert commits from branch-2.4 at least so as to unblock 2.4.0 RC. Sorry [~apurtell] if you have to sink RC0 for this reason (I think there is one more obstacle HBASE-25352 for RC it seems, I am yet to look into it). > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.4 > > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243169#comment-17243169
]
Hudson commented on HBASE-25246:
Results for branch master
[build #147 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/147/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/147/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/147/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/147/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.4
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242615#comment-17242615
]
Hudson commented on HBASE-25246:
Results for branch branch-2.2
[build #131 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/131/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/131//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/131//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/131//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backuprestore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.4
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242568#comment-17242568 ] Andrew Kyle Purtell commented on HBASE-25246: - Yes please file a backport issue to track a branch-1 backport, this is now resolved. > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242469#comment-17242469 ] Viraj Jasani commented on HBASE-25246: -- [~shahrs87] The patch is committed to trunk and all active branch-2's. Can you also create branch-1 PR? Thanks > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226365#comment-17226365 ] Andrew Kyle Purtell commented on HBASE-25246: - Cell tags are persisted in store files. A snapshot based backup/restore foundation will capture tags. To the extent that meets your needs, at least you have that. Agreed, to extract tags along with the rest of the cell data into some other format requires a tooling improvement. Makes sense. > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226311#comment-17226311 ] Rushabh Shah commented on HBASE-25246: -- Cc [~andrew.purt...@gmail.com] [~gjacoby] > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backuprestore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
