[jira] [Commented] (HBASE-25792) Filter out o.a.hadoop.thirdparty building shaded jars
[ https://issues.apache.org/jira/browse/HBASE-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454776#comment-17454776 ] Bryan Beaudreault commented on HBASE-25792: --- Actually [~stack] , I decided to just submit this to a new issue since this one is closed. If you don't mind, let's continue this discussion in HBASE-26546 > Filter out o.a.hadoop.thirdparty building shaded jars > - > > Key: HBASE-25792 > URL: https://issues.apache.org/jira/browse/HBASE-25792 > Project: HBase > Issue Type: Bug > Components: shading >Affects Versions: 3.0.0-alpha-1, 2.5.0, 2.4.3 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3 > > > Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips > the check in our shading that tries to exclude hadoop bits from the fat jars > we build. > For the issue to trigger, need to build against tip of hadoop branch-3.3. You > then get this complaint: > {code} > [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ > hbase-shaded-check-invariants --- > [ERROR] Found artifact with unexpected contents: > '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar' > Please check the following and either correct the build or update > the allowed list with reasoning. > org/apache/hadoop/thirdparty/ > org/apache/hadoop/thirdparty/com/ > org/apache/hadoop/thirdparty/com/google/ > org/apache/hadoop/thirdparty/com/google/common/ > org/apache/hadoop/thirdparty/com/google/common/annotations/ > org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class > org/apache/hadoop/thirdparty/com/google/common/base/ > org/apache/hadoop/thirdparty/com/google/common/base/Absent.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class > org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class > > {code} -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-25792) Filter out o.a.hadoop.thirdparty building shaded jars
[ https://issues.apache.org/jira/browse/HBASE-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454729#comment-17454729 ] Bryan Beaudreault commented on HBASE-25792: --- [~stack] I just stumbled across this and I think it may not be the correct solution. I wonder if you can give more context around the decision. I think it may have been more appropriate to add these classes to the allow list. Here's my reasoning: I tried creating a downstream project which depends on {{{}hbase-shaded-client{}}}. I'd expect this to Just Work, but I get the following error when constructing a Configuration object: {{Caused by: java.lang.NoClassDefFoundError: org/apache/hadoop/thirdparty/com/google/common/base/Preconditions }}{{ at org.apache.hadoop.conf.Configuration$DeprecationDelta.(Configuration.java:430) }}{{ at org.apache.hadoop.conf.Configuration$DeprecationDelta.(Configuration.java:443) }}{{ at org.apache.hadoop.conf.Configuration.(Configuration.java:525)}} Looking at the {{hbase-shaded-client}} output fat jar, it does indeed include {{org/apache/hadoop/conf/Configuration}} as I'd expect. If you decompile that Configuration, you'll see that it imports {{{}org.apache.hadoop.thirdparty.com.google.common.base.Preconditions{}}}. But due to this JIRA, we do not include that Preconditions class in the fat jar. One way to work around this on the client side is to explicitly add a dependency on hadoop-shaded-guava, but that is problematic because it requires the end user to keep track of the appropriate version to include over time. It also only solves for guava, when there is also protobuf and potentially other thirdparty artifacts that might cause issues over time. Thoughts on reverting this and instead adding to the allow list? If you agree I can create a new Jira to track. > Filter out o.a.hadoop.thirdparty building shaded jars > - > > Key: HBASE-25792 > URL: https://issues.apache.org/jira/browse/HBASE-25792 > Project: HBase > Issue Type: Bug > Components: shading >Affects Versions: 3.0.0-alpha-1, 2.5.0, 2.4.3 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3 > > > Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips > the check in our shading that tries to exclude hadoop bits from the fat jars > we build. > For the issue to trigger, need to build against tip of hadoop branch-3.3. You > then get this complaint: > {code} > [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ > hbase-shaded-check-invariants --- > [ERROR] Found artifact with unexpected contents: > '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar' > Please check the following and either correct the build or update > the allowed list with reasoning. > org/apache/hadoop/thirdparty/ > org/apache/hadoop/thirdparty/com/ > org/apache/hadoop/thirdparty/com/google/ > org/apache/hadoop/thirdparty/com/google/common/ > org/apache/hadoop/thirdparty/com/google/common/annotations/ > org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class > org/apache/hadoop/thirdparty/com/google/common/base/ > org/apache/hadoop/thirdparty/com/google/common/base/Absent.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class > org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class > > {code} -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-25792) Filter out o.a.hadoop.thirdparty building shaded jars
[ https://issues.apache.org/jira/browse/HBASE-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386427#comment-17386427 ] Hudson commented on HBASE-25792: Results for branch branch-2.3 [build #260 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/260/]: (/) *{color:green}+1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/260/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/260/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/260/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/260/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Filter out o.a.hadoop.thirdparty building shaded jars > - > > Key: HBASE-25792 > URL: https://issues.apache.org/jira/browse/HBASE-25792 > Project: HBase > Issue Type: Bug > Components: shading >Affects Versions: 3.0.0-alpha-1, 2.5.0, 2.4.3 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3 > > > Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips > the check in our shading that tries to exclude hadoop bits from the fat jars > we build. > For the issue to trigger, need to build against tip of hadoop branch-3.3. You > then get this complaint: > {code} > [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ > hbase-shaded-check-invariants --- > [ERROR] Found artifact with unexpected contents: > '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar' > Please check the following and either correct the build or update > the allowed list with reasoning. > org/apache/hadoop/thirdparty/ > org/apache/hadoop/thirdparty/com/ > org/apache/hadoop/thirdparty/com/google/ > org/apache/hadoop/thirdparty/com/google/common/ > org/apache/hadoop/thirdparty/com/google/common/annotations/ > org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class > org/apache/hadoop/thirdparty/com/google/common/base/ > org/apache/hadoop/thirdparty/com/google/common/base/Absent.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class > org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class > > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25792) Filter out o.a.hadoop.thirdparty building shaded jars
[ https://issues.apache.org/jira/browse/HBASE-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385947#comment-17385947 ] Michael Stack commented on HBASE-25792: --- The revert was not complete... This bit was left over. I just reverted the below to complete the revert from branch-2.3. {code:java} commit 1832418ca7b78739c8443a4a1f3de587e847a41a (HEAD -> 2.3, origin/branch-2.3) Author: stack Date: Thu Jul 22 22:25:36 2021 -0700Revert "HBASE-25792 Filter out o.a.hadoop.thirdparty building shaded jars"This reverts commit 59a67c6dfbae00bbf9c7994224b66406260e8f50.diff --git a/hbase-shaded/pom.xml b/hbase-shaded/pom.xml index 27e6d3cfd3..615bdb2a99 100644 --- a/hbase-shaded/pom.xml +++ b/hbase-shaded/pom.xml @@ -541,13 +541,6 @@ keytab.txt - - -*:* - - org/apache/hadoop/thirdparty/**/* - - {code} > Filter out o.a.hadoop.thirdparty building shaded jars > - > > Key: HBASE-25792 > URL: https://issues.apache.org/jira/browse/HBASE-25792 > Project: HBase > Issue Type: Bug > Components: shading >Affects Versions: 3.0.0-alpha-1, 2.5.0, 2.4.3 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3 > > > Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips > the check in our shading that tries to exclude hadoop bits from the fat jars > we build. > For the issue to trigger, need to build against tip of hadoop branch-3.3. You > then get this complaint: > {code} > [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ > hbase-shaded-check-invariants --- > [ERROR] Found artifact with unexpected contents: > '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar' > Please check the following and either correct the build or update > the allowed list with reasoning. > org/apache/hadoop/thirdparty/ > org/apache/hadoop/thirdparty/com/ > org/apache/hadoop/thirdparty/com/google/ > org/apache/hadoop/thirdparty/com/google/common/ > org/apache/hadoop/thirdparty/com/google/common/annotations/ > org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class > org/apache/hadoop/thirdparty/com/google/common/base/ > org/apache/hadoop/thirdparty/com/google/common/base/Absent.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class > org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class > > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25792) Filter out o.a.hadoop.thirdparty building shaded jars
[ https://issues.apache.org/jira/browse/HBASE-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355358#comment-17355358 ] Michael Stack commented on HBASE-25792: --- [~ndimiduk] bq. Accidental push to branch-2.3 ? Yes. Reverting. Thanks. > Filter out o.a.hadoop.thirdparty building shaded jars > - > > Key: HBASE-25792 > URL: https://issues.apache.org/jira/browse/HBASE-25792 > Project: HBase > Issue Type: Bug > Components: shading >Affects Versions: 3.0.0-alpha-1, 2.5.0, 2.4.3 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3 > > > Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips > the check in our shading that tries to exclude hadoop bits from the fat jars > we build. > For the issue to trigger, need to build against tip of hadoop branch-3.3. You > then get this complaint: > {code} > [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ > hbase-shaded-check-invariants --- > [ERROR] Found artifact with unexpected contents: > '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar' > Please check the following and either correct the build or update > the allowed list with reasoning. > org/apache/hadoop/thirdparty/ > org/apache/hadoop/thirdparty/com/ > org/apache/hadoop/thirdparty/com/google/ > org/apache/hadoop/thirdparty/com/google/common/ > org/apache/hadoop/thirdparty/com/google/common/annotations/ > org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class > org/apache/hadoop/thirdparty/com/google/common/base/ > org/apache/hadoop/thirdparty/com/google/common/base/Absent.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class > org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class > > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25792) Filter out o.a.hadoop.thirdparty building shaded jars
[ https://issues.apache.org/jira/browse/HBASE-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355354#comment-17355354 ] Nick Dimiduk commented on HBASE-25792: -- [~stack] Accidental push to branch-2.3 ? > Filter out o.a.hadoop.thirdparty building shaded jars > - > > Key: HBASE-25792 > URL: https://issues.apache.org/jira/browse/HBASE-25792 > Project: HBase > Issue Type: Bug > Components: shading >Affects Versions: 3.0.0-alpha-1, 2.5.0, 2.4.3 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3 > > > Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips > the check in our shading that tries to exclude hadoop bits from the fat jars > we build. > For the issue to trigger, need to build against tip of hadoop branch-3.3. You > then get this complaint: > {code} > [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ > hbase-shaded-check-invariants --- > [ERROR] Found artifact with unexpected contents: > '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar' > Please check the following and either correct the build or update > the allowed list with reasoning. > org/apache/hadoop/thirdparty/ > org/apache/hadoop/thirdparty/com/ > org/apache/hadoop/thirdparty/com/google/ > org/apache/hadoop/thirdparty/com/google/common/ > org/apache/hadoop/thirdparty/com/google/common/annotations/ > org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class > org/apache/hadoop/thirdparty/com/google/common/base/ > org/apache/hadoop/thirdparty/com/google/common/base/Absent.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class > org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class > > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25792) Filter out o.a.hadoop.thirdparty building shaded jars
[ https://issues.apache.org/jira/browse/HBASE-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354353#comment-17354353 ] Hudson commented on HBASE-25792: Results for branch branch-2.3 [build #228 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/228/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/228/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/228/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/228/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/228/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 source release artifact{color} -- See build output for details. (x) {color:red}-1 client integration test{color} -- Something went wrong with this stage, [check relevant console output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/228//console]. > Filter out o.a.hadoop.thirdparty building shaded jars > - > > Key: HBASE-25792 > URL: https://issues.apache.org/jira/browse/HBASE-25792 > Project: HBase > Issue Type: Bug > Components: shading >Affects Versions: 3.0.0-alpha-1, 2.5.0, 2.4.3 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3 > > > Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips > the check in our shading that tries to exclude hadoop bits from the fat jars > we build. > For the issue to trigger, need to build against tip of hadoop branch-3.3. You > then get this complaint: > {code} > [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ > hbase-shaded-check-invariants --- > [ERROR] Found artifact with unexpected contents: > '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar' > Please check the following and either correct the build or update > the allowed list with reasoning. > org/apache/hadoop/thirdparty/ > org/apache/hadoop/thirdparty/com/ > org/apache/hadoop/thirdparty/com/google/ > org/apache/hadoop/thirdparty/com/google/common/ > org/apache/hadoop/thirdparty/com/google/common/annotations/ > org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class > org/apache/hadoop/thirdparty/com/google/common/base/ > org/apache/hadoop/thirdparty/com/google/common/base/Absent.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class > org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class > > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25792) Filter out o.a.hadoop.thirdparty building shaded jars
[ https://issues.apache.org/jira/browse/HBASE-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334914#comment-17334914 ] Hudson commented on HBASE-25792: Results for branch branch-2 [build #237 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/237/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/237/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/237/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/237/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/237/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Filter out o.a.hadoop.thirdparty building shaded jars > - > > Key: HBASE-25792 > URL: https://issues.apache.org/jira/browse/HBASE-25792 > Project: HBase > Issue Type: Bug > Components: shading >Affects Versions: 3.0.0-alpha-1, 2.5.0, 2.4.3 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3 > > > Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips > the check in our shading that tries to exclude hadoop bits from the fat jars > we build. > For the issue to trigger, need to build against tip of hadoop branch-3.3. You > then get this complaint: > {code} > [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ > hbase-shaded-check-invariants --- > [ERROR] Found artifact with unexpected contents: > '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar' > Please check the following and either correct the build or update > the allowed list with reasoning. > org/apache/hadoop/thirdparty/ > org/apache/hadoop/thirdparty/com/ > org/apache/hadoop/thirdparty/com/google/ > org/apache/hadoop/thirdparty/com/google/common/ > org/apache/hadoop/thirdparty/com/google/common/annotations/ > org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class > org/apache/hadoop/thirdparty/com/google/common/base/ > org/apache/hadoop/thirdparty/com/google/common/base/Absent.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class > org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class > > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25792) Filter out o.a.hadoop.thirdparty building shaded jars
[ https://issues.apache.org/jira/browse/HBASE-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334698#comment-17334698 ] Hudson commented on HBASE-25792: Results for branch master [build #277 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/277/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/277/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/277/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/277/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Filter out o.a.hadoop.thirdparty building shaded jars > - > > Key: HBASE-25792 > URL: https://issues.apache.org/jira/browse/HBASE-25792 > Project: HBase > Issue Type: Bug > Components: shading >Affects Versions: 3.0.0-alpha-1, 2.5.0, 2.4.3 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3 > > > Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips > the check in our shading that tries to exclude hadoop bits from the fat jars > we build. > For the issue to trigger, need to build against tip of hadoop branch-3.3. You > then get this complaint: > {code} > [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ > hbase-shaded-check-invariants --- > [ERROR] Found artifact with unexpected contents: > '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar' > Please check the following and either correct the build or update > the allowed list with reasoning. > org/apache/hadoop/thirdparty/ > org/apache/hadoop/thirdparty/com/ > org/apache/hadoop/thirdparty/com/google/ > org/apache/hadoop/thirdparty/com/google/common/ > org/apache/hadoop/thirdparty/com/google/common/annotations/ > org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class > org/apache/hadoop/thirdparty/com/google/common/base/ > org/apache/hadoop/thirdparty/com/google/common/base/Absent.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class > org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class > > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25792) Filter out o.a.hadoop.thirdparty building shaded jars
[ https://issues.apache.org/jira/browse/HBASE-25792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334406#comment-17334406 ] Hudson commented on HBASE-25792: Results for branch branch-2.4 [build #106 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/106/]: (/) *{color:green}+1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/106/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/106/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/106/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/106/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Filter out o.a.hadoop.thirdparty building shaded jars > - > > Key: HBASE-25792 > URL: https://issues.apache.org/jira/browse/HBASE-25792 > Project: HBase > Issue Type: Bug > Components: shading >Affects Versions: 3.0.0-alpha-1, 2.5.0, 2.4.3 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.3 > > > Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips > the check in our shading that tries to exclude hadoop bits from the fat jars > we build. > For the issue to trigger, need to build against tip of hadoop branch-3.3. You > then get this complaint: > {code} > [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ > hbase-shaded-check-invariants --- > [ERROR] Found artifact with unexpected contents: > '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar' > Please check the following and either correct the build or update > the allowed list with reasoning. > org/apache/hadoop/thirdparty/ > org/apache/hadoop/thirdparty/com/ > org/apache/hadoop/thirdparty/com/google/ > org/apache/hadoop/thirdparty/com/google/common/ > org/apache/hadoop/thirdparty/com/google/common/annotations/ > org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class > > org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class > org/apache/hadoop/thirdparty/com/google/common/base/ > org/apache/hadoop/thirdparty/com/google/common/base/Absent.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class > > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class > org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class > org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class > org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class > > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)