[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2012-06-14 Thread Xing Shi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295432#comment-13295432 ] Xing Shi commented on HBASE-4487: - But now there is no code for hlog sync in Increment and

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2012-06-14 Thread dhruba borthakur (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294912#comment-13294912 ] dhruba borthakur commented on HBASE-4487: - If the hlog sync failed, you can invoke

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2012-06-13 Thread Xing Shi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294282#comment-13294282 ] Xing Shi commented on HBASE-4487: - @[~yuzhih...@gmail.com] or @[~dhruba] I have a questio

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2012-04-18 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257272#comment-13257272 ] Hudson commented on HBASE-4487: --- Integrated in HBase-TRUNK-security #175 (See [https://buil

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2012-04-18 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257006#comment-13257006 ] Hudson commented on HBASE-4487: --- Integrated in HBase-0.94 #129 (See [https://builds.apache.

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2012-04-18 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256995#comment-13256995 ] Hudson commented on HBASE-4487: --- Integrated in HBase-TRUNK #2783 (See [https://builds.apach

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2012-04-18 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256980#comment-13256980 ] Hudson commented on HBASE-4487: --- Integrated in HBase-0.94-security #15 (See [https://builds

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-10-01 Thread dhruba borthakur (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118967#comment-13118967 ] dhruba borthakur commented on HBASE-4487: - Hi Lars, this is a performance fix, so

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-10-01 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118960#comment-13118960 ] Lars Hofhansl commented on HBASE-4487: -- Is this too risky for 0.92? I guess we have t

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118630#comment-13118630 ] Hudson commented on HBASE-4487: --- Integrated in HBase-TRUNK #2274 (See [https://builds.apach

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118394#comment-13118394 ] Ted Yu commented on HBASE-4487: --- Integrated patch v7 to TRUNK. Thanks for the nice feature

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread Jonathan Gray (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118311#comment-13118311 ] Jonathan Gray commented on HBASE-4487: -- +1 as well. And agree with your assessment a

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118308#comment-13118308 ] stack commented on HBASE-4487: -- +1 on v7 (IIUC, Ram and Lars close issue is addressed by the

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread dhruba borthakur (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118291#comment-13118291 ] dhruba borthakur commented on HBASE-4487: - v7 looks good to me, thanks for doing i

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread ramkrishna.s.vasudevan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118260#comment-13118260 ] ramkrishna.s.vasudevan commented on HBASE-4487: --- @Dhruba I was happy with v6

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread ramkrishna.s.vasudevan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118236#comment-13118236 ] ramkrishna.s.vasudevan commented on HBASE-4487: --- I feel that check will be h

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118222#comment-13118222 ] Lars Hofhansl commented on HBASE-4487: -- @ramkrishna and @dhruba. I agree with ramkris

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread Andrew Purtell (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118214#comment-13118214 ] Andrew Purtell commented on HBASE-4487: --- bq. Even prior to this patch, individual in

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118203#comment-13118203 ] Todd Lipcon commented on HBASE-4487: looking over the patch, I think I agree with Dhru

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread dhruba borthakur (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118201#comment-13118201 ] dhruba borthakur commented on HBASE-4487: - > one cannot guarantee that any individ

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread Andrew Purtell (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118193#comment-13118193 ] Andrew Purtell commented on HBASE-4487: --- My comment lines up with Stack's on the cod

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread Andrew Purtell (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118189#comment-13118189 ] Andrew Purtell commented on HBASE-4487: --- bq. I could not find the place where to mar

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread dhruba borthakur (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118186#comment-13118186 ] dhruba borthakur commented on HBASE-4487: - > I'd mark this an 'incompatible change

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread dhruba borthakur (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118183#comment-13118183 ] dhruba borthakur commented on HBASE-4487: - Hi Ramakrishna, from my understanding,

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread ramkrishna.s.vasudevan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118177#comment-13118177 ] ramkrishna.s.vasudevan commented on HBASE-4487: --- {code} -synchronized (t

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-29 Thread dhruba borthakur (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117889#comment-13117889 ] dhruba borthakur commented on HBASE-4487: - > This is like a group commit in HLog.

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-29 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117885#comment-13117885 ] jirapos...@reviews.apache.org commented on HBASE-4487: --

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117839#comment-13117839 ] Lars Hofhansl commented on HBASE-4487: -- How does that relate to the logic in HLog.syn

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-29 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117780#comment-13117780 ] jirapos...@reviews.apache.org commented on HBASE-4487: -- bq. On 201

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-29 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117677#comment-13117677 ] jirapos...@reviews.apache.org commented on HBASE-4487: --

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-29 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117651#comment-13117651 ] jirapos...@reviews.apache.org commented on HBASE-4487: --

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-29 Thread dhruba borthakur (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117557#comment-13117557 ] dhruba borthakur commented on HBASE-4487: - Review board: https://reviews.apache.or

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-29 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117556#comment-13117556 ] jirapos...@reviews.apache.org commented on HBASE-4487: --

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-29 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117298#comment-13117298 ] Ted Yu commented on HBASE-4487: --- I got the following from test suite run: {code} testAppend(

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-29 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117074#comment-13117074 ] Ted Yu commented on HBASE-4487: --- Wow, this is the quickest turnaround for code review I have

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-28 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117047#comment-13117047 ] Ted Yu commented on HBASE-4487: --- Nice feature. {code} + System.err.println("Version Mis