[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425084#comment-13425084
]
Andrew Purtell commented on HBASE-6427:
---
bq. There is no deterministic order in
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425086#comment-13425086
]
Andrew Purtell commented on HBASE-6427:
---
@Lars, lgtm.
Pluggable
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425109#comment-13425109
]
Zhihong Ted Yu commented on HBASE-6427:
---
From
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425120#comment-13425120
]
Zhihong Ted Yu commented on HBASE-6427:
---
For RegionObserver.preFlushScannerOpen(),
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425124#comment-13425124
]
Andrew Purtell commented on HBASE-6427:
---
bq. This means there still might be
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425127#comment-13425127
]
Zhihong Ted Yu commented on HBASE-6427:
---
I don't have further design level comments.
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425142#comment-13425142
]
Hadoop QA commented on HBASE-6427:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13425228#comment-13425228
]
Lars Hofhansl commented on HBASE-6427:
--
Thanks Ted and Andy, and thanks for the
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424622#comment-13424622
]
Zhihong Ted Yu commented on HBASE-6427:
---
Review board doesn't show correct
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424655#comment-13424655
]
Lars Hofhansl commented on HBASE-6427:
--
Thinking on this more... I think the
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424657#comment-13424657
]
Zhihong Ted Yu commented on HBASE-6427:
---
bq. to correctly deal with chained scanners
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424658#comment-13424658
]
Lars Hofhansl commented on HBASE-6427:
--
It's used rarely, because coprocessors are
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424663#comment-13424663
]
Andrew Purtell commented on HBASE-6427:
---
bq. I personally haven't seen chained
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424664#comment-13424664
]
Andrew Purtell commented on HBASE-6427:
---
[~lhofhansl] A follow up JIRA to discuss
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424665#comment-13424665
]
Andrew Purtell commented on HBASE-6427:
---
And a follow up note to my above comment:
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424667#comment-13424667
]
Zhihong Ted Yu commented on HBASE-6427:
---
I understand the goal for this JIRA and am
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424669#comment-13424669
]
Andrew Purtell commented on HBASE-6427:
---
bq. I understand the goal for this JIRA and
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424671#comment-13424671
]
Zhihong Ted Yu commented on HBASE-6427:
---
There is no intersection between memstore
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424672#comment-13424672
]
Lars Hofhansl commented on HBASE-6427:
--
bq. This illustrates the intricacies of
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424673#comment-13424673
]
Lars Hofhansl commented on HBASE-6427:
--
Also another thought: I wonder how hard it is
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424674#comment-13424674
]
Lars Hofhansl commented on HBASE-6427:
--
Re: Ted's last comment. So you want to
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424676#comment-13424676
]
Zhihong Ted Yu commented on HBASE-6427:
---
bq. If that is not desired an implementer
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424680#comment-13424680
]
Lars Hofhansl commented on HBASE-6427:
--
Ted, you are trying to redesign the overall
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424690#comment-13424690
]
Zhihong Ted Yu commented on HBASE-6427:
---
For preCompactScannerOpen() /
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424697#comment-13424697
]
Lars Hofhansl commented on HBASE-6427:
--
I see your point.
But then you
# need a
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424281#comment-13424281
]
Hadoop QA commented on HBASE-6427:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424367#comment-13424367
]
Zhihong Ted Yu commented on HBASE-6427:
---
{code}
+ scanner =
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424416#comment-13424416
]
Zhihong Ted Yu commented on HBASE-6427:
---
Looking at the changes to
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424425#comment-13424425
]
Lars Hofhansl commented on HBASE-6427:
--
I think we should what the current
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424433#comment-13424433
]
Andrew Purtell commented on HBASE-6427:
---
Agree that scanners should be passed along.
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424449#comment-13424449
]
Lars Hofhansl commented on HBASE-6427:
--
Interestingly I would like to have the
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424451#comment-13424451
]
Andrew Purtell commented on HBASE-6427:
---
Then you want to restore this behavior:
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424453#comment-13424453
]
Zhihong Ted Yu commented on HBASE-6427:
---
bq. null means create the default scanner
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424458#comment-13424458
]
Lars Hofhansl commented on HBASE-6427:
--
After reviewing all the use cases I have this
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424463#comment-13424463
]
Hadoop QA commented on HBASE-6427:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424464#comment-13424464
]
Lars Hofhansl commented on HBASE-6427:
--
bq. I'd not be opposed to adding additional
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424466#comment-13424466
]
Andrew Purtell commented on HBASE-6427:
---
It's fine. I like how you made the new APIs
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423694#comment-13423694
]
Hadoop QA commented on HBASE-6427:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424270#comment-13424270
]
Zhihong Ted Yu commented on HBASE-6427:
---
Some new files need license header.
{code}
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424273#comment-13424273
]
Lars Hofhansl commented on HBASE-6427:
--
Thanks Ted. You are right on all counts. Need
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424275#comment-13424275
]
Lars Hofhansl commented on HBASE-6427:
--
The current preCompact/preScannerOpen/other
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423305#comment-13423305
]
Andrew Purtell commented on HBASE-6427:
---
Or use polymorphism?
{noformat}
+ public
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423325#comment-13423325
]
Lars Hofhansl commented on HBASE-6427:
--
Uh... I like that.
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423365#comment-13423365
]
Lars Hofhansl commented on HBASE-6427:
--
The part I still have think through is how to
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423367#comment-13423367
]
Andrew Purtell commented on HBASE-6427:
---
BaseRegionObserver should reimplement the
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423368#comment-13423368
]
Andrew Purtell commented on HBASE-6427:
---
Or, better yet, BaseRegionObserver calls
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423372#comment-13423372
]
Lars Hofhansl commented on HBASE-6427:
--
Hmm... The default behavior is followed when
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423374#comment-13423374
]
Andrew Purtell commented on HBASE-6427:
---
bq. The default behavior is followed when
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423384#comment-13423384
]
Lars Hofhansl commented on HBASE-6427:
--
Of course this has to be compared to simply
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423387#comment-13423387
]
Andrew Purtell commented on HBASE-6427:
---
bq. The coprocessor approach is nice,
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423469#comment-13423469
]
Andrew Purtell commented on HBASE-6427:
---
lgtm, good tests
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423501#comment-13423501
]
Hadoop QA commented on HBASE-6427:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423548#comment-13423548
]
Lars Hofhansl commented on HBASE-6427:
--
I ran the failing tests locally, and they all
53 matches
Mail list logo
