[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-05-13 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655788#comment-13655788 ] Anoop Sam John commented on HBASE-8218: --- [~yuzhih...@gmail.com] In the patch there

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-05-13 Thread cuijianwei (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655801#comment-13655801 ] cuijianwei commented on HBASE-8218: --- [anoopsamjohn~], thanks for your hint。I think

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-05-13 Thread cuijianwei (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655803#comment-13655803 ] cuijianwei commented on HBASE-8218: --- [~anoopsamjohn], thanks for your hint。I think

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-05-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655533#comment-13655533 ] Ted Yu commented on HBASE-8218: --- [~cuijianwei]: What do you think about Anoop's patch ?

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-05-12 Thread cuijianwei (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655740#comment-13655740 ] cuijianwei commented on HBASE-8218: --- [~Ted Yu] and [~Anoop Sam John], sorry for reply

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-05-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655755#comment-13655755 ] Ted Yu commented on HBASE-8218: --- [~anoopsamjohn]: Do you want to change the title of this

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-05-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655264#comment-13655264 ] Ted Yu commented on HBASE-8218: --- The intention of this JIRA is to allow client reusing

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-05-11 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655470#comment-13655470 ] Anoop Sam John commented on HBASE-8218: --- Yes. The HTable instance should be created

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-05-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13654563#comment-13654563 ] Ted Yu commented on HBASE-8218: --- Passing HTable object to AggegationClient API should be

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-24 Thread cuijianwei (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13641286#comment-13641286 ] cuijianwei commented on HBASE-8218: --- @Anoop, thanks for your idear, users have to call

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-22 Thread cuijianwei (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637800#comment-13637800 ] cuijianwei commented on HBASE-8218: --- I try to find 'Findbugs' errors from

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637848#comment-13637848 ] Ted Yu commented on HBASE-8218: --- Can you re-attach latest patch for QA run ? Thanks

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-22 Thread cuijianwei (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637852#comment-13637852 ] cuijianwei commented on HBASE-8218: --- Ok, I re-attached the patch. Pass

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637894#comment-13637894 ] Hadoop QA commented on HBASE-8218: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638439#comment-13638439 ] Ted Yu commented on HBASE-8218: --- For TestAggregateProtocol.java, do you want to add

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-22 Thread cuijianwei (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638753#comment-13638753 ] cuijianwei commented on HBASE-8218: --- Yes, in the new patch '8218-trunk-v3-rerun', I

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-22 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638779#comment-13638779 ] Anoop Sam John commented on HBASE-8218: --- Why we have not tried with overloaded APIs?

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-20 Thread cuijianwei (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637164#comment-13637164 ] cuijianwei commented on HBASE-8218: --- Thanks for your review, sorry for reply late. The

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637187#comment-13637187 ] Hadoop QA commented on HBASE-8218: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-15 Thread cuijianwei (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631702#comment-13631702 ] cuijianwei commented on HBASE-8218: --- Thanks for your concern. I make a

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631740#comment-13631740 ] Ted Yu commented on HBASE-8218: --- What do you think of my earlier comment ?

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-15 Thread cuijianwei (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631796#comment-13631796 ] cuijianwei commented on HBASE-8218: --- Thanks for your concern, I rename the patch. Do you

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631924#comment-13631924 ] Hadoop QA commented on HBASE-8218: -- {color:green}+1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient

2013-04-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630379#comment-13630379 ] Ted Yu commented on HBASE-8218: --- {code} + protected HConnection getConnection() throws