[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-14 Thread Jieshan Bean (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631453#comment-13631453
 ] 

Jieshan Bean commented on HBASE-8251:
-

Yes, we can.

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch, HBASE-8251-94-v2.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-14 Thread Jieshan Bean (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631455#comment-13631455
 ] 

Jieshan Bean commented on HBASE-8251:
-

Sorry, it should be duplicated:(. I linked this issue to HBASE-7824.

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch, HBASE-8251-94-v2.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-13 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631072#comment-13631072
 ] 

Ted Yu commented on HBASE-8251:
---

HBASE-7824 has been resolved.
Can we close this JIRA ?

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch, HBASE-8251-94-v2.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-09 Thread Jieshan Bean (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627367#comment-13627367
 ] 

Jieshan Bean commented on HBASE-8251:
-

[~jeffreyz] [~zjushch]
Do you have further comments? Thank you.

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch, HBASE-8251-94-v2.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-09 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627374#comment-13627374
 ] 

Hadoop QA commented on HBASE-8251:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12577450/HBASE-8251-94-v2.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5237//console

This message is automatically generated.

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch, HBASE-8251-94-v2.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-09 Thread Jieshan Bean (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627380#comment-13627380
 ] 

Jieshan Bean commented on HBASE-8251:
-

It seems this approach conflicts with the patch in HBASE-7824.

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch, HBASE-8251-94-v2.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-09 Thread chunhui shen (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627389#comment-13627389
 ] 

chunhui shen commented on HBASE-8251:
-

I think HBASE-7824 has covered this issue?

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch, HBASE-8251-94-v2.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-09 Thread Jieshan Bean (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627448#comment-13627448
 ] 

Jieshan Bean commented on HBASE-8251:
-

Yes. I'm reviewing that patch. Seems I missed a wonderful discussion:)

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch, HBASE-8251-94-v2.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-08 Thread Jieshan Bean (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625234#comment-13625234
 ] 

Jieshan Bean commented on HBASE-8251:
-

bq.I'm not sure if it's a good modification for scenario that a Meta location 
is pointing to an offline server or a wrong server.

The key point is whether this offline server or wrong server is a 
registered server on this master. If already rigistered, SSH will be triggered. 
This patch can avoid race. Otherwise, SSH would not happen.

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch, HBASE-8251-94-v2.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-07 Thread Jieshan Bean (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624848#comment-13624848
 ] 

Jieshan Bean commented on HBASE-8251:
-

Yes, one corner case is META RS is killed just before new assignment 
happening(Killing happens either during calling 
processRegionInTransitionAndBlockUntilAssigned or verifyMetaRegionLocation), so 
rit is false and metaRegionLocation is false(Only under this scenario may 
trigger a new assignment).
It may cause data-loss and double assignment.
Thanks, Chunhui, Rama and Jeffrey.
I'm thinking about adding a check(check for whether currentMetaServer is a 
online server or a processing dead server, need to change something in 
ServerManager) before calling assignMeta.


 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-07 Thread Jeffrey Zhong (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624971#comment-13624971
 ] 

Jeffrey Zhong commented on HBASE-8251:
--

[~jeason] The changes still not guarantee the possible double meta assignment. 
For example, right after {code}boolean needToAssign = !(currentMetaServer != 
null  
this.serverManager.isOnlineOrProcessingDeadServer(currentMetaServer));{code}, 
currentMetaServer is marked dead by master. Then we still have two possible 
places to assign meta. 

In addition, I thought about enableSSH globally idea before. A concern is that 
once SSH is enabled and meta assignment could be delayed by other dead servers 
log splitting work from SSHs so master starts up will slower than before. It's 
not ideal otherwise the existing code could have skipped 
assignmentManager.assignMeta(); right after expireServer.

The above are just IMHO. Thanks.

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch, HBASE-8251-94-v2.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-07 Thread Jieshan Bean (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625064#comment-13625064
 ] 

Jieshan Bean commented on HBASE-8251:
-

bq.*, currentMetaServer is marked dead by master. Then we still have two 
possible places to assign meta. 
This RS should belong to the set of ServerManager#onlineServers just before 
marking it as dead(See the related code of ServerManager#onlineServers and 
DeadServer#processingDeadServers.
). So the below check returns true:
{code}
this.serverManager
  .isOnlineOrProcessingDeadServer(currentMetaServer).
{code}
So needToAssign is false. No new assign would happen under this scenario.
Correct me if I misunderstood you:). Thank you.

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch, HBASE-8251-94-v2.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-07 Thread Jeffrey Zhong (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625095#comment-13625095
 ] 

Jeffrey Zhong commented on HBASE-8251:
--

Oh, I c. You changed the existing logic. For example, the above check is within 
the {code}if (!rit  !metaRegionLocation) {{code}
Old logic will offline the meta server if it's online and re-assign meta while 
the patch skips meta assignment. I'm not sure if it's a good modification for 
scenario that a Meta location is pointing to an offline server or a wrong 
server.





 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch, HBASE-8251-94-v2.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-05 Thread Jeffrey Zhong (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624095#comment-13624095
 ] 

Jeffrey Zhong commented on HBASE-8251:
--

[~rajesh23] brought me attention to this JIRA. Basically I saw similar issue 
during test against the patch for bhase-7824. The solution I'm using for the 
issue is that

2) Assign ROOT
3) Enable SSH for ROOT only not others
4) Assign META
5) Enable SSH globally

The above solution is less intrusive. The existing patch for the JIRA might 
also have double assignment issue because meta assignment could happen in both 
places: master initialization and META SSH.

Please let me know what you think.

Thanks,
-Jeffrey

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-05 Thread chunhui shen (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624287#comment-13624287
 ] 

chunhui shen commented on HBASE-8251:
-

bq.3) Enable SSH for ROOT only not others
How about if ROOT and META are on the same regionserver?

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-05 Thread Jeffrey Zhong (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624304#comment-13624304
 ] 

Jeffrey Zhong commented on HBASE-8251:
--

[~zjushch] Thanks for the very good question!

{quote}
How about if ROOT and META are on the same regionserver?
{quote}

I handled this in MetaSSH, you can check details in the patch of hbase-7828(I 
pasted the related code below). It basically wait for master meta assignment 
done then handle a deadButNotExpired Meta RS.

{code}
+  if(!this.services.isServerShutdownHandlerEnabled()) {
+// resubmit in case we're in master initialization and SSH hasn't been 
enabled yet.
+this.services.getExecutorService().submit(this);
+this.deadServers.add(serverName);
+  }
{code}

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-03 Thread rajeshbabu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620701#comment-13620701
 ] 

rajeshbabu commented on HBASE-8251:
---

[~jeason]
As part of HBASE-5875 we fixed this.After enabling SSH only we are wating for 
META(before 4th step).
{code}
  assignmentManager.assignMeta();
  enableSSHandWaitForMeta();
{code}
{code}
  private void enableSSHandWaitForMeta() throws IOException,
  InterruptedException {
enableServerShutdownHandler();
this.catalogTracker.waitForMeta();
// Above check waits for general meta availability but this does not
// guarantee that the transition has completed
this.assignmentManager
.waitForAssignment(HRegionInfo.FIRST_META_REGIONINFO);
  }
{code}

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean

 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-03 Thread Jieshan Bean (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620703#comment-13620703
 ] 

Jieshan Bean commented on HBASE-8251:
-

[~rajesh23]I don't think so, Master was blocked at 
AM#processRegionInTransitionAndBlockUntilAssigned:
{code}
// Work on meta region
status.setStatus(Assigning META region);
rit = this.assignmentManager.
  
processRegionInTransitionAndBlockUntilAssigned(HRegionInfo.FIRST_META_REGIONINFO);
boolean metaRegionLocation = 
this.catalogTracker.verifyMetaRegionLocation(timeout);
{code}


 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean

 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-03 Thread rajeshbabu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621117#comment-13621117
 ] 

rajeshbabu commented on HBASE-8251:
---

[~jeason]
Correct, If a meta region in transition during master startup, then not 
enabling SSH until META assigned.

Patch looks good. Nice test.

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-03 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621130#comment-13621130
 ] 

Ted Yu commented on HBASE-8251:
---

@Jieshan:

TestMasterStartup.java is not in trunk.
Can you come up with patch for trunk with TestMasterStartup ?

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-03 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621372#comment-13621372
 ] 

Ted Yu commented on HBASE-8251:
---

Please use dos2unix to convert the line endings in your patch.

Thanks

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-03 Thread Jieshan Bean (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621535#comment-13621535
 ] 

Jieshan Bean commented on HBASE-8251:
-

[~ted_yu] Sorry, we will be on vacation before April 7th. So I can only submit 
the new patch on 7th:).

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-03 Thread chunhui shen (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621689#comment-13621689
 ] 

chunhui shen commented on HBASE-8251:
-

[~jeason]
Good catch, but move enabling SSH before assign META would cause another META 
data loss case:
1. Assign ROOT.
2. Block until ROOT be opened.
3. Enable SSH
4. Assign META.
5. Block until META be opened.

if META RS is killed between step 3 and step 4, SSH will start handling it 
(including split logs),
step 4 will assign the META, it means META region would loss the data from the 
hlog.

In order to fix related cases, two other things should also be noticed:
1.The concurrency of SSH#process and HMaster#splitLogAndExpireIfOnline
2.Before completing assignRootAndMeta, A dead META RS will be handled by 
ServerShutdownHandler, not MetaServerShutdownHandler, see 
AssignmentManager#isCarryingMeta

Since we have dropped ROOT in trunk, I think there is no related trouble in 
trunk.

IMHO, aborting master may be a compromise choice if encounter this case.



 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-8251) enable SSH before assign META on Master startup

2013-04-03 Thread ramkrishna.s.vasudevan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621713#comment-13621713
 ] 

ramkrishna.s.vasudevan commented on HBASE-8251:
---

Nice review Chunhui.  I remember we tried with different JIRAs to tackle this 
problem of ROOT and META going down on master initialization along with SSH.

 enable SSH before assign META on Master startup
 ---

 Key: HBASE-8251
 URL: https://issues.apache.org/jira/browse/HBASE-8251
 Project: HBase
  Issue Type: Bug
  Components: master, Region Assignment
Affects Versions: 0.94.6
Reporter: Jieshan Bean
Assignee: Jieshan Bean
 Attachments: HBASE-8251-94.patch


 I think HBASE-5918 could not fix this issue. In HMaster#assignRootAndMeta:
 1. Assign ROOT.
 2. Block until ROOT be opened.
 3. Assign META.
 4. Block until META be opened.
 SSH is enabled after step 4. So if the RS who host ROOT dies before step 4, 
 master will be blocked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira