[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14548127#comment-14548127
]
Reuben Kuhnert commented on HIVE-10190:
---
If everything looks good here, do you mind
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538207#comment-14538207
]
Laljo John Pullokkaran commented on HIVE-10190:
---
+1
CBO: AST mode checks
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537239#comment-14537239
]
Hive QA commented on HIVE-10190:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536030#comment-14536030
]
Hive QA commented on HIVE-10190:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533546#comment-14533546
]
Laljo John Pullokkaran commented on HIVE-10190:
---
[~sircodesalot] Looks good,
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528909#comment-14528909
]
Hive QA commented on HIVE-10190:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526936#comment-14526936
]
Hive QA commented on HIVE-10190:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527101#comment-14527101
]
Hive QA commented on HIVE-10190:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527688#comment-14527688
]
Hive QA commented on HIVE-10190:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527167#comment-14527167
]
Reuben Kuhnert commented on HIVE-10190:
---
I just tried running some tests locally:
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527253#comment-14527253
]
Laljo John Pullokkaran commented on HIVE-10190:
---
[~sircodesalot] Try running
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511602#comment-14511602
]
Reuben Kuhnert commented on HIVE-10190:
---
Going to review the tests and then submit
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499153#comment-14499153
]
Hive QA commented on HIVE-10190:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493924#comment-14493924
]
Reuben Kuhnert commented on HIVE-10190:
---
Okay, I think this patch clears both
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494368#comment-14494368
]
Hive QA commented on HIVE-10190:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494510#comment-14494510
]
Reuben Kuhnert commented on HIVE-10190:
---
I'm not sure if my patches are causing
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494247#comment-14494247
]
Hive QA commented on HIVE-10190:
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492903#comment-14492903
]
Reuben Kuhnert commented on HIVE-10190:
---
Actually, I just found a simple solution to
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490465#comment-14490465
]
Laljo John Pullokkaran commented on HIVE-10190:
---
[~ sircodesalot] How does
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488081#comment-14488081
]
Laljo John Pullokkaran commented on HIVE-10190:
---
Submit your patch, i am
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487266#comment-14487266
]
Reuben commented on HIVE-10190:
---
Right, which is is why in my code, I was using the
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487276#comment-14487276
]
Reuben commented on HIVE-10190:
---
One other thing, it looks like {{ArrayListT.remove}} has a
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488076#comment-14488076
]
Laljo John Pullokkaran commented on HIVE-10190:
---
[~Reuben] No need for
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488144#comment-14488144
]
Reuben commented on HIVE-10190:
---
Okay, I think it's up. I really appreciate the help!
CBO:
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486058#comment-14486058
]
Pengcheng Xiong commented on HIVE-10190:
I would prefer a BFS rather than a DFS.
[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14485983#comment-14485983
]
Reuben commented on HIVE-10190:
---
I think I maybe have a solution for this, but not sure how
26 matches
Mail list logo