[
https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487276#comment-14487276
]
Reuben commented on HIVE-10190:
-------------------------------
One other thing, it looks like {{ArrayList<T>.remove}} has a runtime of O(N)
(http://infotechgems.blogspot.com/2011/11/java-collections-performance-time.html).
If we don't want to use a {{Queue<T>}}, maybe a {{LinkedList<T>}} instead?
> CBO: AST mode checks for TABLESAMPLE with
> AST.toString().contains("TOK_TABLESPLITSAMPLE")
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-10190
> URL: https://issues.apache.org/jira/browse/HIVE-10190
> Project: Hive
> Issue Type: Bug
> Components: CBO
> Affects Versions: 1.2.0
> Reporter: Gopal V
> Assignee: Pengcheng Xiong
> Priority: Trivial
> Labels: perfomance
> Attachments: HIVE-10190-querygen.py, HIVE-10190.01.patch
>
>
> {code}
> public static boolean validateASTForUnsupportedTokens(ASTNode ast) {
> String astTree = ast.toStringTree();
> // if any of following tokens are present in AST, bail out
> String[] tokens = { "TOK_CHARSETLITERAL", "TOK_TABLESPLITSAMPLE" };
> for (String token : tokens) {
> if (astTree.contains(token)) {
> return false;
> }
> }
> return true;
> }
> {code}
> This is an issue for a SQL query which is bigger in AST form than in text
> (~700kb).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
