[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-09 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139142#comment-15139142 ] Aihua Xu commented on HIVE-12987: - +1 on the new patch. Of course we need to wait for the new build, but

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-09 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139870#comment-15139870 ] Hive QA commented on HIVE-12987: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-09 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139315#comment-15139315 ] Jimmy Xiang commented on HIVE-12987: Thanks a lot for the review. Yeah we need to wait for the new

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137420#comment-15137420 ] Hive QA commented on HIVE-12987: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-07 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136234#comment-15136234 ] Aihua Xu commented on HIVE-12987: - I see. Thanks for explanation. > Add metrics for HS2 active users

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-07 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136395#comment-15136395 ] Jimmy Xiang commented on HIVE-12987: Sure, I can make Operation::setMetrics private and use

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-06 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136130#comment-15136130 ] Jimmy Xiang commented on HIVE-12987: [~aihuaxu], the map is not redundant. It is different from that

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-06 Thread Szehon Ho (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136157#comment-15136157 ] Szehon Ho commented on HIVE-12987: -- Thanks Jimmy and Aihua for also taking a look.. i see now about the

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-06 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135679#comment-15135679 ] Hive QA commented on HIVE-12987: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-05 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135034#comment-15135034 ] Aihua Xu commented on HIVE-12987: - I'm wondering why we need to keep track of the counts in Metrics and

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-05 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134851#comment-15134851 ] Aihua Xu commented on HIVE-12987: - Sure. I will take a look. > Add metrics for HS2 active users and SQL

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-05 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135580#comment-15135580 ] Jimmy Xiang commented on HIVE-12987: Do you mean the user queries map? It is used to track active

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-04 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132003#comment-15132003 ] Hive QA commented on HIVE-12987: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-03 Thread Szehon Ho (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131178#comment-15131178 ] Szehon Ho commented on HIVE-12987: -- Thanks for the patch.. I had some comments. 1. The overriding of

[jira] [Commented] (HIVE-12987) Add metrics for HS2 active users and SQL operations

2016-02-03 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131286#comment-15131286 ] Jimmy Xiang commented on HIVE-12987: Sure. Thanks a lot for reviewing it. bq. 1. The overriding of